namespace kernel {
namespace actor {
+void SimcallObserver::serialize(std::stringstream& stream) const
+{
+ stream << (short)mc::Transition::Type::UNKNOWN;
+}
bool SimcallObserver::depends(SimcallObserver* other)
{
THROW_UNIMPLEMENTED;
{
return get_issuer() == other->get_issuer();
}
+void RandomSimcall::serialize(std::stringstream& stream) const
+{
+ stream << (short)mc::Transition::Type::RANDOM << ' ';
+ stream << min_ << ' ' << max_;
+}
+
bool MutexSimcall::depends(SimcallObserver* other)
{
if (dynamic_cast<RandomSimcall*>(other) != nullptr)
return true; // Depend on things we don't know for sure that they are independent
}
-/*
-std::string SimcallObserver::to_string(int) const
-{
- return simgrid::xbt::string_printf("[(%ld)%s (%s)] ", issuer_->get_pid(), issuer_->get_host()->get_cname(),
- issuer_->get_cname());
-}*/
-
-std::string SimcallObserver::dot_label(int /*times_considered*/) const
-{
- if (issuer_->get_host())
- return xbt::string_printf("[(%ld)%s] ", issuer_->get_pid(), issuer_->get_host()->get_cname());
- return xbt::string_printf("[(%ld)] ", issuer_->get_pid());
-}
-
-std::string RandomSimcall::dot_label(int times_considered) const
-{
- return SimcallObserver::dot_label(times_considered) + "MC_RANDOM(" + std::to_string(next_value_) + ")";
-}
-
void RandomSimcall::prepare(int times_considered)
{
next_value_ = min_ + times_considered;
XBT_DEBUG("MC_RANDOM(%d, %d) will return %d after %d times", min_, max_, next_value_, times_considered);
}
-int RandomSimcall::get_max_consider() const
+int RandomSimcall::get_max_consider()
{
return max_ - min_ + 1;
}
-std::string MutexUnlockSimcall::dot_label(int times_considered) const
-{
- return SimcallObserver::dot_label(times_considered) + "Mutex UNLOCK";
-}
-
/*
std::string MutexLockSimcall::to_string(int times_considered) const
{
return res;
}*/
-std::string MutexLockSimcall::dot_label(int times_considered) const
-{
- return SimcallObserver::dot_label(times_considered) + (blocking_ ? "Mutex LOCK" : "Mutex TRYLOCK");
-}
-
-bool MutexLockSimcall::is_enabled() const
+bool MutexLockSimcall::is_enabled()
{
return not blocking_ || get_mutex()->get_owner() == nullptr || get_mutex()->get_owner() == get_issuer();
}
-std::string ConditionWaitSimcall::dot_label(int times_considered) const
-{
- return SimcallObserver::dot_label(times_considered) + "Condition WAIT";
-}
-
-bool ConditionWaitSimcall::is_enabled() const
+bool ConditionWaitSimcall::is_enabled()
{
static bool warned = false;
if (not warned) {
return true;
}
-std::string SemAcquireSimcall::dot_label(int times_considered) const
-{
- return SimcallObserver::dot_label(times_considered) + "Sem ACQUIRE";
-}
-
-bool SemAcquireSimcall::is_enabled() const
+bool SemAcquireSimcall::is_enabled()
{
static bool warned = false;
if (not warned) {
return true;
}
-int ActivityTestanySimcall::get_max_consider() const
-{
- // Only Comms are of interest to MC for now. When all types of activities can be consider, this function can simply
- // return the size of activities_.
- int count = 0;
- for (const auto& act : activities_)
- if (dynamic_cast<activity::CommImpl*>(act) != nullptr)
- count++;
- return count;
-}
-
-void ActivityTestanySimcall::prepare(int times_considered)
+ActivityTestanySimcall::ActivityTestanySimcall(ActorImpl* actor, const std::vector<activity::ActivityImpl*>& activities)
+ : ResultingSimcall(actor, -1), activities_(activities)
{
- next_value_ = times_considered;
}
-/*
-std::string ActivityTestanySimcall::to_string(int times_considered) const
+int ActivityTestanySimcall::get_max_consider()
{
- std::string res = SimcallObserver::to_string(times_considered);
- if (times_considered == -1) {
- res += "TestAny FALSE(-)";
- } else {
- res += "TestAny(" + xbt::string_printf("(%d of %zu)", times_considered + 1, activities_.size());
- }
-
- return res;
-}*/
-
-std::string ActivityTestanySimcall::dot_label(int times_considered) const
-{
- std::string res = SimcallObserver::dot_label(times_considered) + "TestAny ";
- if (times_considered == -1) {
- res += "FALSE";
- } else {
- res += xbt::string_printf("TRUE [%d of %zu]", times_considered + 1, activities_.size());
- }
- return res;
+ indexes_.clear();
+ // list all the activities that are ready
+ for (unsigned i = 0; i < activities_.size(); i++)
+ if (activities_[i]->test(get_issuer()))
+ indexes_.push_back(i);
+ return indexes_.size() + 1;
}
-bool ActivityTestSimcall::depends(SimcallObserver* other)
+void ActivityTestanySimcall::prepare(int times_considered)
{
- if (get_issuer() == other->get_issuer())
- return false;
-
- if (dynamic_cast<ActivityTestSimcall*>(other))
- return true;
-
- const auto* comm1 = dynamic_cast<activity::CommImpl*>(activity_);
- if (comm1 == nullptr)
- return false;
-
- if (dynamic_cast<ActivityWaitSimcall*>(other) != nullptr &&
- (comm1->src_actor_.get() == nullptr || comm1->dst_actor_.get() == nullptr))
- return false;
-
- if (comm1->src_buff_ == nullptr || comm1->dst_buff_ == nullptr)
- return false;
-
- if (const auto* test = dynamic_cast<ActivityTestSimcall*>(other)) {
- const auto* comm2 = dynamic_cast<activity::CommImpl*>(test->get_activity());
- if (comm2 == nullptr)
- return false;
- else if (comm2->src_buff_ == nullptr || comm2->dst_buff_ == nullptr)
- return false;
- }
-
- if (auto* wait = dynamic_cast<ActivityWaitSimcall*>(other)) {
- auto* comm2 = dynamic_cast<activity::CommImpl*>(wait->get_activity());
- if (comm2 == nullptr)
- return false;
- if (comm1->src_buff_ == comm2->src_buff_ && comm1->dst_buff_ == comm2->dst_buff_)
- return false;
- if (comm1->src_buff_ != nullptr && comm1->dst_buff_ != nullptr && comm2->src_buff_ != nullptr &&
- comm2->dst_buff_ != nullptr && comm1->dst_buff_ != comm2->src_buff_ && comm1->dst_buff_ != comm2->dst_buff_ &&
- comm2->dst_buff_ != comm1->src_buff_)
- return false;
- }
-
- return true;
+ if (times_considered < static_cast<int>(indexes_.size()))
+ next_value_ = indexes_.at(times_considered);
+ else
+ next_value_ = -1;
}
-void ActivityWaitSimcall::serialize(Simcall& type, char* buffer)
+static void serialize_activity_test(const activity::ActivityImpl* act, std::stringstream& stream)
{
- std::stringstream stream;
- if (auto* comm = dynamic_cast<activity::CommImpl*>(activity_)) {
- type = Simcall::COMM_WAIT;
- stream << timeout_ << ' ' << comm;
+ if (auto* comm = dynamic_cast<activity::CommImpl const*>(act)) {
+ stream << " " << (short)mc::Transition::Type::COMM_TEST;
+ stream << ' ' << (uintptr_t)comm;
stream << ' ' << (comm->src_actor_ != nullptr ? comm->src_actor_->get_pid() : -1);
stream << ' ' << (comm->dst_actor_ != nullptr ? comm->dst_actor_->get_pid() : -1);
- stream << ' ' << (comm->get_mailbox() != nullptr ? comm->get_mailbox()->get_id() : 666);
- stream << ' ' << (void*)comm->src_buff_ << ' ' << (void*)comm->dst_buff_ << ' ' << comm->src_buff_size_;
- strcpy(buffer, stream.str().c_str());
+ stream << ' ' << comm->get_mailbox_id();
+ stream << ' ' << (uintptr_t)comm->src_buff_ << ' ' << (uintptr_t)comm->dst_buff_ << ' ' << comm->src_buff_size_;
} else {
- type = Simcall::UNKNOWN;
- strcpy(buffer, stream.str().c_str());
+ stream << (short)mc::Transition::Type::UNKNOWN;
}
}
-
-/*
-std::string ActivityTestSimcall::to_string(int times_considered) const
-{
- std::string res = SimcallObserver::to_string(times_considered) + "Test ";
- if (const auto* comm = dynamic_cast<activity::CommImpl*>(activity_)) {
- if (comm->src_actor_.get() == nullptr || comm->dst_actor_.get() == nullptr) {
- res += "FALSE(comm=";
- res += XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf("%p)", comm)
- : "(verbose only))";
- } else {
- res += "TRUE(comm=";
-
- auto src = comm->src_actor_;
- auto dst = comm->dst_actor_;
- res +=
- XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf("%p", comm) : "(verbose only) ";
- res += xbt::string_printf("[(%ld)%s (%s) ", src->get_pid(), src->get_host()->get_cname(), src->get_cname()) +
- "-> " +
- xbt::string_printf("(%ld)%s (%s)])", dst->get_pid(), dst->get_host()->get_cname(), dst->get_cname());
- }
- } else
- xbt_die("Only Comms are supported here for now");
- return res;
-}*/
-
-std::string ActivityTestSimcall::dot_label(int times_considered) const
+void ActivityTestanySimcall::serialize(std::stringstream& stream) const
{
- std::string res = SimcallObserver::dot_label(times_considered) + "Test ";
- const auto* comm = dynamic_cast<activity::CommImpl*>(activity_);
- if (comm && (comm->src_actor_.get() == nullptr || comm->dst_actor_.get() == nullptr)) {
- res += "FALSE";
- } else {
- res += "TRUE";
+ stream << (short)mc::Transition::Type::TESTANY << ' ' << activities_.size() << ' ';
+ for (auto const& act : activities_) {
+ serialize_activity_test(act, stream);
+ stream << ' ';
}
- return res;
}
-
-bool ActivityWaitSimcall::is_enabled() const
+void ActivityTestSimcall::serialize(std::stringstream& stream) const
{
- /* FIXME: check also that src and dst processes are not suspended */
- const auto* comm = dynamic_cast<activity::CommImpl*>(activity_);
- if (comm == nullptr)
- xbt_die("Only Comms are supported here for now");
-
- if (comm->src_timeout_ || comm->dst_timeout_) {
- /* If it has a timeout it will be always be enabled (regardless of who declared the timeout),
- * because even if the communication is not ready, it can timeout and won't block. */
- if (_sg_mc_timeout == 1)
- return true;
- }
- /* On the other hand if it hasn't a timeout, check if the comm is ready.*/
- else if (comm->detached() && comm->src_actor_ == nullptr && comm->get_state() == activity::State::READY)
- return (comm->dst_actor_ != nullptr);
- return (comm->src_actor_ && comm->dst_actor_);
+ serialize_activity_test(activity_, stream);
}
-
-bool ActivityWaitSimcall::depends(SimcallObserver* other)
+static void serialize_activity_wait(const activity::ActivityImpl* act, bool timeout, std::stringstream& stream)
{
- if (get_issuer() == other->get_issuer())
- return false;
-
- if (auto* isend = dynamic_cast<CommIsendSimcall*>(other))
- return isend->depends(this);
-
- if (auto* irecv = dynamic_cast<CommIrecvSimcall*>(other))
- return irecv->depends(this);
-
- /* Timeouts in wait transitions are not considered by the independence theorem, thus assumed dependent */
- if (const auto* wait = dynamic_cast<ActivityWaitSimcall*>(other)) {
- if (timeout_ > 0 || wait->get_timeout() > 0)
- return true;
- const auto* comm1 = dynamic_cast<activity::CommImpl*>(activity_);
- const auto* comm2 = dynamic_cast<activity::CommImpl*>(wait->get_activity());
-
- if (comm1 == nullptr || comm2 == nullptr) // One wait at least in not on a Comm
- return true;
+ if (auto* comm = dynamic_cast<activity::CommImpl const*>(act)) {
+ stream << (short)mc::Transition::Type::COMM_WAIT << ' ';
+ stream << timeout << ' ' << (uintptr_t)comm;
- if (comm1->src_buff_ == comm2->src_buff_ && comm1->dst_buff_ == comm2->dst_buff_)
- return false;
- if (comm1->src_buff_ != nullptr && comm1->dst_buff_ != nullptr && comm2->src_buff_ != nullptr &&
- comm2->dst_buff_ != nullptr && comm1->dst_buff_ != comm2->src_buff_ && comm1->dst_buff_ != comm2->dst_buff_ &&
- comm2->dst_buff_ != comm1->src_buff_)
- return false;
+ stream << ' ' << (comm->src_actor_ != nullptr ? comm->src_actor_->get_pid() : -1);
+ stream << ' ' << (comm->dst_actor_ != nullptr ? comm->dst_actor_->get_pid() : -1);
+ stream << ' ' << comm->get_mailbox_id();
+ stream << ' ' << (uintptr_t)comm->src_buff_ << ' ' << (uintptr_t)comm->dst_buff_ << ' ' << comm->src_buff_size_;
+ } else {
+ stream << (short)mc::Transition::Type::UNKNOWN;
}
-
- return true;
-}
-
-std::string ActivityWaitSimcall::dot_label(int times_considered) const
-{
- std::string res = SimcallObserver::dot_label(times_considered);
- res += (times_considered == -1) ? "WaitTimeout " : "Wait ";
-
- const auto* comm = dynamic_cast<activity::CommImpl*>(activity_);
- if (comm) {
- auto src = comm->src_actor_;
- auto dst = comm->dst_actor_;
- res += " [(" + std::to_string(src ? src->get_pid() : 0) + ")";
- res += "->(" + std::to_string(dst ? dst->get_pid() : 0) + ")]";
- } else
- xbt_die("Only Comms are supported here for now");
- return res;
}
-std::string ActivityWaitanySimcall::dot_label(int times_considered) const
+void ActivityWaitSimcall::serialize(std::stringstream& stream) const
{
- return SimcallObserver::dot_label(times_considered) +
- xbt::string_printf("WaitAny [%d of %zu]", times_considered + 1, activities_.size());
+ serialize_activity_wait(activity_, timeout_ > 0, stream);
}
-
-bool ActivityWaitanySimcall::is_enabled() const
+void ActivityWaitanySimcall::serialize(std::stringstream& stream) const
{
- // FIXME: deal with other kind of activities (Exec and I/Os)
- // FIXME: Can be factored with ActivityWaitSimcall::is_enabled()
- const auto* comm = dynamic_cast<activity::CommImpl*>(activities_[next_value_]);
- if (comm == nullptr)
- xbt_die("Only Comms are supported here for now");
- if (comm->src_timeout_ || comm->dst_timeout_) {
- /* If it has a timeout it will be always be enabled (regardless of who declared the timeout),
- * because even if the communication is not ready, it can timeout and won't block. */
- if (_sg_mc_timeout == 1)
- return true;
+ stream << (short)mc::Transition::Type::WAITANY << ' ' << activities_.size() << ' ';
+ for (auto const& act : activities_) {
+ serialize_activity_wait(act, timeout_ > 0, stream);
+ stream << ' ';
}
- /* On the other hand if it hasn't a timeout, check if the comm is ready.*/
- else if (comm->detached() && comm->src_actor_ == nullptr && comm->get_state() == activity::State::READY)
- return (comm->dst_actor_ != nullptr);
- return (comm->src_actor_ && comm->dst_actor_);
}
-
-int ActivityWaitanySimcall::get_max_consider() const
+ActivityWaitanySimcall::ActivityWaitanySimcall(ActorImpl* actor, const std::vector<activity::ActivityImpl*>& activities,
+ double timeout)
+ : ResultingSimcall(actor, -1), activities_(activities), timeout_(timeout)
{
- return static_cast<int>(activities_.size());
}
-void ActivityWaitanySimcall::prepare(int times_considered)
+bool ActivityWaitSimcall::is_enabled()
{
- next_value_ = times_considered;
+ // FIXME: if _sg_mc_timeout == 1 and if we have either a sender or receiver timeout, the transition is enabled
+ // because even if the communication is not ready, it can timeout and won't block.
+
+ return activity_->test(get_issuer());
}
-bool CommIsendSimcall::depends(SimcallObserver* other)
+bool ActivityWaitanySimcall::is_enabled()
{
- if (get_issuer() == other->get_issuer())
- return false;
+ // list all the activities that are ready
+ indexes_.clear();
+ for (unsigned i = 0; i < activities_.size(); i++)
+ if (activities_[i]->test(get_issuer()))
+ indexes_.push_back(i);
- if (const auto* other_isend = dynamic_cast<CommIsendSimcall*>(other))
- return mbox_ == other_isend->get_mailbox();
+ // if (_sg_mc_timeout && timeout_) FIXME: deal with the potential timeout of the WaitAny
- // FIXME: Not in the former dependency check because of the ordering but seems logical to add it
- if (dynamic_cast<CommIrecvSimcall*>(other) != nullptr)
- return false;
-
-#if SIMGRID_HAVE_MC // FIXME needed to access mbox_cpy
- if (const auto* wait = dynamic_cast<ActivityWaitSimcall*>(other)) {
- if (const auto* comm2 = dynamic_cast<activity::CommImpl*>(wait->get_activity())) { // this is a Comm::wait_for
- const auto* mbox1 = mbox_;
- const auto* mbox2 = comm2->mbox_cpy;
+ // FIXME: even if the WaitAny has no timeout, some of the activities may still have one.
+ // we should iterate over the vector searching for them
+ return not indexes_.empty();
+}
- if (mbox1 != mbox2 && wait->get_timeout() <= 0)
- return false;
+int ActivityWaitanySimcall::get_max_consider()
+{
+ // list all the activities that are ready
+ indexes_.clear();
+ for (unsigned i = 0; i < activities_.size(); i++)
+ if (activities_[i]->test(get_issuer()))
+ indexes_.push_back(i);
- if ((get_issuer() != comm2->src_actor_.get()) && (get_issuer() != comm2->dst_actor_.get()) &&
- wait->get_timeout() <= 0)
- return false;
+ int res = indexes_.size();
+ // if (_sg_mc_timeout && timeout_)
+ // res++;
- if (comm2->type_ == activity::CommImpl::Type::SEND && comm2->src_buff_ != src_buff_ && wait->get_timeout() <= 0)
- return false;
- }
- }
-#endif
- /* FIXME: the following rule assumes that the result of the isend/irecv call is not stored in a buffer used in the
- * test call. */
-#if 0
- if (dynamic_cast<ActivityTestSimcall*>(other))
- return false;
-#endif
-
- return true;
-}
-void CommIsendSimcall::serialize(Simcall& type, char* buffer)
-{
- type = Simcall::ISEND;
- std::stringstream stream;
- stream << mbox_->get_id() << ' ' << (void*)src_buff_ << ' ' << src_buff_size_;
- strcpy(buffer, stream.str().c_str());
+ return res;
}
-void CommIrecvSimcall::serialize(Simcall& type, char* buffer)
+void ActivityWaitanySimcall::prepare(int times_considered)
{
- type = Simcall::IRECV;
- std::stringstream stream;
- stream << mbox_->get_id() << dst_buff_;
- strcpy(buffer, stream.str().c_str());
+ if (times_considered < static_cast<int>(indexes_.size()))
+ next_value_ = indexes_.at(times_considered);
+ else
+ next_value_ = -1;
}
-bool CommIrecvSimcall::depends(SimcallObserver* other)
+void CommIsendSimcall::serialize(std::stringstream& stream) const
{
- if (get_issuer() == other->get_issuer())
- return false;
-
- if (const auto* other_irecv = dynamic_cast<CommIrecvSimcall*>(other))
- return mbox_ == other_irecv->get_mailbox();
-
- if (auto* isend = dynamic_cast<CommIsendSimcall*>(other))
- return isend->depends(this);
-
-#if SIMGRID_HAVE_MC // FIXME needed to access mbox_cpy
- if (auto* wait = dynamic_cast<ActivityWaitSimcall*>(other)) {
- if (auto* comm2 = dynamic_cast<activity::CommImpl*>(wait->get_activity())) { // this is a Comm::wait_for
- const auto* mbox1 = mbox_;
- const auto* mbox2 = comm2->mbox_cpy;
-
- if (mbox1 != mbox2 && wait->get_timeout() <= 0)
- return false;
-
- if ((get_issuer() != comm2->src_actor_.get()) && (get_issuer() != comm2->dst_actor_.get()) &&
- wait->get_timeout() <= 0)
- return false;
-
- if (comm2->type_ == activity::CommImpl::Type::RECEIVE && comm2->dst_buff_ != dst_buff_ &&
- wait->get_timeout() <= 0)
- return false;
- }
- }
-#endif
- /* FIXME: the following rule assumes that the result of the isend/irecv call is not stored in a buffer used in the
- * test call. */
-#if 0
- if (dynamic_cast<ActivityTestSimcall*>(other))
- return false;
-#endif
-
- return true;
+ stream << (short)mc::Transition::Type::COMM_SEND << ' ';
+ stream << (uintptr_t)comm_ << ' ' << mbox_->get_id() << ' ' << (uintptr_t)src_buff_ << ' ' << src_buff_size_;
+ XBT_DEBUG("SendObserver comm:%p mbox:%u buff:%p size:%zu", comm_, mbox_->get_id(), src_buff_, src_buff_size_);
}
-/*
-std::string CommIrecvSimcall::to_string(int times_considered) const
+void CommIrecvSimcall::serialize(std::stringstream& stream) const
{
- std::string res = SimcallObserver::to_string(times_considered) + "iRecv(";
- res += xbt::string_printf("dst=(%ld)%s (%s)", get_issuer()->get_pid(), get_issuer()->get_host()->get_cname(),
- get_issuer()->get_cname());
- res += ", buff=" + (XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf("%p", dst_buff_)
- : "(verbose only)");
- res += ", size=" + (XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? std::to_string(*dst_buff_size_)
- : "(verbose only)");
- res += ")";
- return res;
+ stream << (short)mc::Transition::Type::COMM_RECV << ' ';
+ stream << (uintptr_t)comm_ << ' ' << mbox_->get_id() << ' ' << (uintptr_t)dst_buff_;
+ XBT_DEBUG("RecvObserver comm:%p mbox:%u buff:%p", comm_, mbox_->get_id(), dst_buff_);
}
-*/
} // namespace actor
} // namespace kernel
