namespace xbt {
namespace random {
-bool Random::read_state(std::string filename)
+bool Random::read_state(const std::string& filename)
{
std::ifstream file(filename);
- if (file) {
- file >> mt19937_gen;
- return true;
- } else {
- XBT_WARN("Could not open %s and thus not save the RNG state.", filename.c_str());
- return false;
- }
+ file >> mt19937_gen;
+ file.close();
+ if (file.fail())
+ XBT_WARN("Could not save the RNG state to file %s.", filename.c_str());
+ return not file.fail();
}
-bool Random::write_state(std::string filename)
+bool Random::write_state(const std::string& filename) const
{
std::ofstream file(filename);
- if (file) {
- file << mt19937_gen;
- return false;
- } else {
- XBT_WARN("Could not open %s and thus not read the RNG state.", filename.c_str());
- return false;
- }
+ file << mt19937_gen;
+ file.close();
+ if (file.fail())
+ XBT_WARN("Could not read the RNG state from file %s.", filename.c_str());
+ return not file.fail();
}
int StdRandom::uniform_int(int min, int max)
do {
value = mt19937_gen();
} while (value >= decltype(mt19937_gen)::max() - decltype(mt19937_gen)::max() % range);
- return value % range + min;
+ return static_cast<int>(value % range + min);
}
double XbtRandom::uniform_real(double min, double max)
do {
numerator = mt19937_gen() - decltype(mt19937_gen)::min();
} while (numerator == divisor);
- return min + (max - min) * numerator / divisor;
+ return min + (max - min) * static_cast<double>(numerator) / divisor;
}
double XbtRandom::exponential(double lambda)
return z0 * sd + mean;
}
-static std::unique_ptr<Random> default_random(new XbtRandom);
+static std::unique_ptr<Random> default_random = std::make_unique<XbtRandom>();
void set_implem_xbt()
{
- default_random.reset(new XbtRandom);
+ default_random = std::make_unique<XbtRandom>();
}
void set_implem_std()
{
- default_random.reset(new StdRandom);
+ default_random = std::make_unique<StdRandom>();
}
void set_mersenne_seed(int seed)
default_random->set_seed(seed);
}
-bool read_mersenne_state(std::string filename)
+bool read_mersenne_state(const std::string& filename)
{
return default_random->read_state(filename);
}
-bool write_mersenne_state(std::string filename)
+bool write_mersenne_state(const std::string& filename)
{
return default_random->write_state(filename);
}