static int surf_parse_models_setup_already_called = 0;
-/** The current AS in the parsing */
+/** The current NetZone in the parsing */
static simgrid::kernel::routing::NetZoneImpl* current_routing = nullptr;
static simgrid::kernel::routing::NetZoneImpl* routing_get_current()
{
surf_parse_lex_destroy();
}
-/** @brief Add a host to the current AS */
+/** @brief Add a host to the current NetZone */
void sg_platf_new_host(const simgrid::kernel::routing::HostCreationArgs* args)
{
simgrid::s4u::Host* host = routing_get_current()->create_host(args->id, args->speed_per_pstate, args->core_amount);
host->pimpl_->set_disks(args->disks, host);
/* Change from the defaults */
- if (args->state_trace)
- host->set_state_profile(args->state_trace);
- if (args->speed_trace)
- host->set_speed_profile(args->speed_trace);
+ host->set_state_profile(args->state_trace)->set_speed_profile(args->speed_trace);
+
if (not args->coord.empty())
new simgrid::kernel::routing::vivaldi::Coords(host->get_netpoint(), args->coord);
static void sg_platf_new_link(const simgrid::kernel::routing::LinkCreationArgs* args, const std::string& link_name)
{
simgrid::s4u::Link* link = routing_get_current()->create_link(link_name, args->bandwidths, args->policy);
- if (args->policy != simgrid::s4u::Link::SharingPolicy::WIFI)
- link->get_impl()->set_latency(args->latency);
-
if (args->properties)
link->set_properties(*args->properties);
- simgrid::kernel::resource::LinkImpl* l = link->get_impl();
- if (args->latency_trace)
- l->set_latency_profile(args->latency_trace);
- if (args->bandwidth_trace)
- l->set_bandwidth_profile(args->bandwidth_trace);
- if (args->state_trace)
- l->set_state_profile(args->state_trace);
-
- link->seal();
+ link->get_impl() // this call to get_impl saves some simcalls but can be removed
+ ->set_state_profile(args->state_trace)
+ ->set_latency_profile(args->latency_trace)
+ ->set_bandwidth_profile(args->bandwidth_trace)
+ ->set_latency(args->latency)
+ ->seal();
}
void sg_platf_new_link(const simgrid::kernel::routing::LinkCreationArgs* link)
int rankId = 0;
- // What an inventive way of initializing the AS that I have as ancestor :-(
+ // What an inventive way of initializing the NetZone that I have as ancestor :-(
simgrid::kernel::routing::ZoneCreationArgs zone;
zone.id = cluster->id;
switch (cluster->topology) {
break;
}
sg_platf_new_Zone_begin(&zone);
- auto* current_as = static_cast<ClusterZone*>(routing_get_current());
- current_as->parse_specific_arguments(cluster);
+ auto* current_zone = static_cast<ClusterZone*>(routing_get_current());
+ current_zone->parse_specific_arguments(cluster);
if (cluster->properties != nullptr)
for (auto const& elm : *cluster->properties)
- current_as->get_iface()->set_property(elm.first, elm.second);
+ current_zone->get_iface()->set_property(elm.first, elm.second);
if (cluster->loopback_bw > 0 || cluster->loopback_lat > 0) {
- current_as->num_links_per_node_++;
- current_as->has_loopback_ = true;
+ current_zone->set_loopback();
}
if (cluster->limiter_link > 0) {
- current_as->num_links_per_node_++;
- current_as->has_limiter_ = true;
+ current_zone->set_limiter();
}
for (int const& i : *cluster->radicals) {
linkUp = simgrid::s4u::Link::by_name_or_null(tmp_link);
linkDown = simgrid::s4u::Link::by_name_or_null(tmp_link);
- ClusterZone* as_cluster = current_as;
- as_cluster->private_links_.insert({as_cluster->node_pos(rankId), {linkUp->get_impl(), linkDown->get_impl()}});
+ current_zone->add_private_link_at(current_zone->node_pos(rankId), {linkUp->get_impl(), linkDown->get_impl()});
}
// add a limiter link (shared link to account for maximal bandwidth of the node)
sg_platf_new_link(&link);
linkDown = simgrid::s4u::Link::by_name_or_null(tmp_link);
linkUp = linkDown;
- current_as->private_links_.insert(
- {current_as->node_pos_with_loopback(rankId), {linkUp->get_impl(), linkDown->get_impl()}});
+ current_zone->add_private_link_at(current_zone->node_pos_with_loopback(rankId),
+ {linkUp->get_impl(), linkDown->get_impl()});
}
// call the cluster function that adds the others links
if (cluster->topology == simgrid::kernel::routing::ClusterTopology::FAT_TREE) {
- static_cast<FatTreeZone*>(current_as)->add_processing_node(i);
+ static_cast<FatTreeZone*>(current_zone)->add_processing_node(i);
} else {
- current_as->create_links_for_node(cluster, i, rankId, current_as->node_pos_with_loopback_limiter(rankId));
+ current_zone->create_links_for_node(cluster, i, rankId, current_zone->node_pos_with_loopback_limiter(rankId));
}
rankId++;
}
XBT_DEBUG("<router id=\"%s\"/>", cluster->router_id.c_str());
if (cluster->router_id.empty())
cluster->router_id = std::string(cluster->prefix) + cluster->id + "_router" + cluster->suffix;
- current_as->router_ = sg_platf_new_router(cluster->router_id, nullptr);
+ current_zone->set_router(sg_platf_new_router(cluster->router_id, nullptr));
// Make the backbone
if ((cluster->bb_bw > 0) || (cluster->bb_lat > 0)) {
routing_cluster_add_backbone(simgrid::s4u::Link::by_name(link.id)->get_impl());
}
- XBT_DEBUG("</AS>");
+ XBT_DEBUG("</zone>");
sg_platf_new_Zone_seal();
simgrid::kernel::routing::on_cluster_creation(*cluster);
auto* cluster = dynamic_cast<simgrid::kernel::routing::ClusterZone*>(current_routing);
xbt_assert(cluster, "Only hosts from Cluster can get a backbone.");
- xbt_assert(nullptr == cluster->backbone_, "Cluster %s already has a backbone link!", cluster->get_cname());
+ xbt_assert(not cluster->has_backbone(), "Cluster %s already has a backbone link!", cluster->get_cname());
- cluster->backbone_ = bb;
- XBT_DEBUG("Add a backbone to AS '%s'", current_routing->get_cname());
+ cluster->set_backbone(bb);
+ XBT_DEBUG("Add a backbone to zone '%s'", current_routing->get_cname());
}
void sg_platf_new_cabinet(const simgrid::kernel::routing::CabinetCreationArgs* cabinet)
void sg_platf_new_peer(const simgrid::kernel::routing::PeerCreationArgs* peer)
{
- auto* as = dynamic_cast<simgrid::kernel::routing::VivaldiZone*>(current_routing);
- xbt_assert(as, "<peer> tag can only be used in Vivaldi netzones.");
+ auto* zone = dynamic_cast<simgrid::kernel::routing::VivaldiZone*>(current_routing);
+ xbt_assert(zone, "<peer> tag can only be used in Vivaldi netzones.");
std::vector<double> speed_per_pstate;
speed_per_pstate.push_back(peer->speed);
- simgrid::s4u::Host* host = as->create_host(peer->id, speed_per_pstate, 1);
+ simgrid::s4u::Host* host = zone->create_host(peer->id, speed_per_pstate, 1);
- as->set_peer_link(host->get_netpoint(), peer->bw_in, peer->bw_out, peer->coord);
+ zone->set_peer_link(host->get_netpoint(), peer->bw_in, peer->bw_out, peer->coord);
/* Change from the defaults */
if (peer->state_trace)
surf_host_model_description[host_id].model_init_preparse();
XBT_DEBUG("Call vm_model_init");
- surf_vm_model_init_HL13();
+ /* ideally we should get back the pointer to CpuModel from model_init_preparse(), but this
+ * requires changing the declaration of surf_cpu_model_description.
+ * To be reviewed in the future */
+ surf_vm_model_init_HL13(
+ simgrid::s4u::Engine::get_instance()->get_netzone_root()->get_impl()->get_cpu_pm_model().get());
XBT_DEBUG("Call disk_model_init");
int disk_id = find_model_description(surf_disk_model_description, disk_model_name);
if (current_routing->hierarchy_ == simgrid::kernel::routing::NetZoneImpl::RoutingMode::unset)
current_routing->hierarchy_ = simgrid::kernel::routing::NetZoneImpl::RoutingMode::recursive;
/* add to the sons dictionary */
- current_routing->get_children()->push_back(new_zone);
+ current_routing->add_child(new_zone);
/* set models from parent netzone */
new_zone->set_network_model(current_routing->get_network_model());
new_zone->set_cpu_pm_model(current_routing->get_cpu_pm_model());
xbt_assert(current_routing, "Cannot seal the current Zone: zone under construction");
current_routing->seal();
simgrid::s4u::NetZone::on_seal(*current_routing->get_iface());
- current_routing = current_routing->get_father();
+ current_routing = current_routing->get_parent();
}
/** @brief Add a link connecting a host to the rest of its Zone (which must be cluster or vivaldi) */
xbt_assert(linkUp, "Link '%s' not found!", hostlink->link_up.c_str());
xbt_assert(linkDown, "Link '%s' not found!", hostlink->link_down.c_str());
- auto* as_cluster = static_cast<simgrid::kernel::routing::ClusterZone*>(current_routing);
+ auto* cluster_zone = static_cast<simgrid::kernel::routing::ClusterZone*>(current_routing);
- if (as_cluster->private_links_.find(netpoint->id()) != as_cluster->private_links_.end())
+ if (cluster_zone->private_link_exists_at(netpoint->id()))
surf_parse_error(std::string("Host_link for '") + hostlink->id.c_str() + "' is already defined!");
XBT_DEBUG("Push Host_link for host '%s' to position %u", netpoint->get_cname(), netpoint->id());
- as_cluster->private_links_.insert({netpoint->id(), {linkUp->get_impl(), linkDown->get_impl()}});
+ cluster_zone->add_private_link_at(netpoint->id(), {linkUp->get_impl(), linkDown->get_impl()});
}
void sg_platf_new_trace(simgrid::kernel::routing::ProfileCreationArgs* profile)