Minor sonar issues.

[simgrid.git] / src / surf / xml / surfxml_sax_cb.cpp

diff --git a/src/surf/xml/surfxml_sax_cb.cpp b/src/surf/xml/surfxml_sax_cb.cpp
index 43d1dbeafbddf0932ce4c6a2402a57ed75a4879a..c486699284867979184710d412fa480ff1932009 100644 (file)
--- a/src/surf/xml/surfxml_sax_cb.cpp
+++ b/src/surf/xml/surfxml_sax_cb.cpp
@@ -97,7 +97,7 @@ int surf_parse_get_int(const std::string& s)
 /* Turn something like "1-4,6,9-11" into the vector {1,2,3,4,6,9,10,11} */
 static std::vector<int>* explodesRadical(const std::string& radicals)
 {
-  std::vector<int>* exploded = new std::vector<int>();
+  auto* exploded = new std::vector<int>();
 
   // Make all hosts
   std::vector<std::string> radical_elements;
@@ -182,8 +182,9 @@ void ETag_surfxml_storage___type()
   storage_type.content = A_surfxml_storage___type_content;
   storage_type.id      = A_surfxml_storage___type_id;
   storage_type.model   = A_surfxml_storage___type_model;
-  storage_type.size    = surf_parse_get_size(surf_parsed_filename, surf_parse_lineno, A_surfxml_storage___type_size,
-                                          "size of storage type", storage_type.id.c_str());
+  storage_type.size =
+      static_cast<sg_size_t>(surf_parse_get_size(surf_parsed_filename, surf_parse_lineno, A_surfxml_storage___type_size,
+                                                 "size of storage type", storage_type.id.c_str()));
   sg_platf_new_storage_type(&storage_type);
 }
 
@@ -734,7 +735,7 @@ void STag_surfxml_trace___connect()
 void STag_surfxml_AS()
 {
   AX_surfxml_zone_id = AX_surfxml_AS_id;
-  AX_surfxml_zone_routing = (AT_surfxml_zone_routing)AX_surfxml_AS_routing;
+  AX_surfxml_zone_routing = AX_surfxml_AS_routing;
   STag_surfxml_zone();
 }
 
@@ -748,7 +749,7 @@ void STag_surfxml_zone()
   property_sets.push_back(new std::unordered_map<std::string, std::string>());
   simgrid::kernel::routing::ZoneCreationArgs zone;
   zone.id      = A_surfxml_zone_id;
-  zone.routing = static_cast<int>(A_surfxml_zone_routing);
+  zone.routing = A_surfxml_zone_routing;
   sg_platf_new_Zone_begin(&zone);
 }
 
@@ -848,7 +849,7 @@ void ETag_surfxml_actor()
 }
 
 void STag_surfxml_argument(){
-  arguments.push_back(A_surfxml_argument_value);
+  arguments.emplace_back(A_surfxml_argument_value);
 }
 
 void STag_surfxml_model___prop(){