all_existing_models.push_back(this);
}
-LinkImpl* NetworkConstantModel::create_link(const std::string& name, std::vector<double> /*bandwidth*/,
+LinkImpl* NetworkConstantModel::create_link(const std::string& name, const std::vector<double>& /*bandwidth*/,
double /*latency*/, s4u::Link::SharingPolicy)
{
return nullptr;
}
-double NetworkConstantModel::next_occuring_event(double /*now*/)
+double NetworkConstantModel::next_occurring_event(double /*now*/)
{
double min = -1.0;
for (kernel::resource::Action const& action : *get_started_action_set()) {
- const NetworkConstantAction& net_action = static_cast<const NetworkConstantAction&>(action);
+ const auto& net_action = static_cast<const NetworkConstantAction&>(action);
if (net_action.latency_ > 0 && (min < 0 || net_action.latency_ < min))
min = net_action.latency_;
}
void NetworkConstantModel::update_actions_state(double /*now*/, double delta)
{
for (auto it = std::begin(*get_started_action_set()); it != std::end(*get_started_action_set());) {
- NetworkConstantAction& action = static_cast<NetworkConstantAction&>(*it);
+ auto& action = static_cast<NetworkConstantAction&>(*it);
++it; // increment iterator here since the following calls to action.finish() may invalidate it
if (action.latency_ > 0) {
if (action.latency_ > delta) {
Action* NetworkConstantModel::communicate(s4u::Host* src, s4u::Host* dst, double size, double)
{
- NetworkConstantAction* action = new NetworkConstantAction(this, size, sg_latency_factor);
+ auto* action = new NetworkConstantAction(this, size, sg_latency_factor);
s4u::Link::on_communicate(*action, src, dst);
return action;