Replace state copy with recipe: list of transition to replay a state

[simgrid.git] / src / mc / api / State.cpp

diff --git a/src/mc/api/State.cpp b/src/mc/api/State.cpp
index ce8daed..6c1d348 100644 (file)
--- a/src/mc/api/State.cpp
+++ b/src/mc/api/State.cpp
@@ -5,6 +5,7 @@
 
 #include "src/mc/api/State.hpp"
 #include "src/mc/api/guide/BasicGuide.hpp"
+#include "src/mc/api/guide/WaitGuide.hpp"
 #include "src/mc/explo/Exploration.hpp"
 #include "src/mc/mc_config.hpp"
 
@@ -16,9 +17,17 @@ namespace simgrid::mc {
 
 long State::expended_states_ = 0;
 
-State::State(RemoteApp& remote_app) : num_(++expended_states_), guide(std::make_unique<BasicGuide>())
+State::State(RemoteApp& remote_app) : num_(++expended_states_)
 {
-  remote_app.get_actors_status(guide->actors_to_run_);
+  XBT_VERB("Creating a guide for the state");
+  if (_sg_mc_guided == "none")
+    guide_ = std::make_shared<BasicGuide>();
+  if (_sg_mc_guided == "nb_wait")
+    guide_ = std::make_shared<WaitGuide>();
+
+  recipe_ = std::list<Transition*>();
+
+  remote_app.get_actors_status(guide_->actors_to_run_);
 
   /* Stateful model checking */
   if ((_sg_mc_checkpoint > 0 && (num_ % _sg_mc_checkpoint == 0)) || _sg_mc_termination)
@@ -26,10 +35,20 @@ State::State(RemoteApp& remote_app) : num_(++expended_states_), guide(std::make_
                                                             *remote_app.get_remote_process_memory());
 }
 
-State::State(RemoteApp& remote_app, const State* parent_state)
-    : num_(++expended_states_), parent_state_(parent_state), guide(std::make_unique<BasicGuide>())
+State::State(RemoteApp& remote_app, std::shared_ptr<State> parent_state)
+    : num_(++expended_states_), parent_state_(parent_state)
 {
-  remote_app.get_actors_status(guide->actors_to_run_);
+
+  if (_sg_mc_guided == "none")
+    guide_ = std::make_shared<BasicGuide>();
+  if (_sg_mc_guided == "nb_wait")
+    guide_ = std::make_shared<WaitGuide>();
+  *guide_ = *(parent_state->guide_);
+
+  recipe_ = std::list(parent_state_->get_recipe());
+  recipe_.push_back(parent_state_->get_transition());
+
+  remote_app.get_actors_status(guide_->actors_to_run_);
 
   /* Stateful model checking */
   if ((_sg_mc_checkpoint > 0 && (num_ % _sg_mc_checkpoint == 0)) || _sg_mc_termination)
@@ -44,10 +63,10 @@ State::State(RemoteApp& remote_app, const State* parent_state)
     for (auto& [aid, transition] : parent_state_->get_sleep_set()) {
       if (not parent_state_->get_transition()->depends(&transition)) {
         sleep_set_.try_emplace(aid, transition);
-        if (guide->actors_to_run_.count(aid) != 0) {
+        if (guide_->actors_to_run_.count(aid) != 0) {
           XBT_DEBUG("Actor %ld will not be explored, for it is in the sleep set", aid);
 
-          guide->actors_to_run_.at(aid).mark_done();
+          guide_->actors_to_run_.at(aid).mark_done();
         }
       } else
         XBT_DEBUG("Transition >>%s<< removed from the sleep set because it was dependent with >>%s<<",
@@ -58,7 +77,17 @@ State::State(RemoteApp& remote_app, const State* parent_state)
 
 std::size_t State::count_todo() const
 {
-  return boost::range::count_if(this->guide->actors_to_run_, [](auto& pair) { return pair.second.is_todo(); });
+  return boost::range::count_if(this->guide_->actors_to_run_, [](auto& pair) { return pair.second.is_todo(); });
+}
+
+std::size_t State::count_todo_multiples() const
+{
+  size_t count = 0;
+  for (auto& [_, actor] : guide_->actors_to_run_)
+    if (actor.is_todo())
+      count += actor.get_times_not_considered();
+
+  return count;
 }
 
 Transition* State::get_transition() const
@@ -68,8 +97,8 @@ Transition* State::get_transition() const
 
 aid_t State::next_transition() const
 {
-  XBT_DEBUG("Search for an actor to run. %zu actors to consider", guide->actors_to_run_.size());
-  for (auto const& [aid, actor] : guide->actors_to_run_) {
+  XBT_DEBUG("Search for an actor to run. %zu actors to consider", guide_->actors_to_run_.size());
+  for (auto const& [aid, actor] : guide_->actors_to_run_) {
     /* Only consider actors (1) marked as interleaving by the checker and (2) currently enabled in the application */
     if (not actor.is_todo() || not actor.is_enabled() || actor.is_done()) {
       if (not actor.is_todo())
@@ -91,17 +120,20 @@ aid_t State::next_transition() const
 
 std::pair<aid_t, double> State::next_transition_guided() const
 {
-  return guide->next_transition();
+  return guide_->next_transition();
 }
 
 // This should be done in GuidedState, or at least interact with it
 void State::execute_next(aid_t next, RemoteApp& app)
 {
+  // First, warn the guide, so it knows how to build a proper child state
+  guide_->execute_next(next, app);
+
   // This actor is ready to be executed. Execution involves three phases:
 
   // 1. Identify the appropriate ActorState to prepare for execution
   // when simcall_handle will be called on it
-  auto& actor_state                        = guide->actors_to_run_.at(next);
+  auto& actor_state                        = guide_->actors_to_run_.at(next);
   const unsigned times_considered          = actor_state.do_consider();
   const auto* expected_executed_transition = actor_state.get_transition(times_considered);
   xbt_assert(expected_executed_transition != nullptr,