namespace simgrid::kernel::actor {
ActivityTestanySimcall::ActivityTestanySimcall(ActorImpl* actor, const std::vector<activity::ActivityImpl*>& activities,
- std::string fun_call)
+ std::string_view fun_call)
: ResultingSimcall(actor, -1), activities_(activities), fun_call_(fun_call)
{
indexes_.clear();
else
next_value_ = -1;
}
-static void serialize_activity_test(const activity::ActivityImpl* act, std::stringstream& stream)
+static void serialize_activity_test(const activity::ActivityImpl* act, std::string const& call_location,
+ std::stringstream& stream)
{
if (const auto* comm = dynamic_cast<activity::CommImpl const*>(act)) {
stream << " " << (short)mc::Transition::Type::COMM_TEST;
- stream << ' ' << (uintptr_t)comm;
+ stream << ' ' << comm->get_id();
stream << ' ' << (comm->src_actor_ != nullptr ? comm->src_actor_->get_pid() : -1);
stream << ' ' << (comm->dst_actor_ != nullptr ? comm->dst_actor_->get_pid() : -1);
stream << ' ' << comm->get_mailbox_id();
- stream << ' ' << (uintptr_t)comm->src_buff_ << ' ' << (uintptr_t)comm->dst_buff_ << ' ' << comm->src_buff_size_;
+ stream << ' ' << call_location;
} else {
stream << (short)mc::Transition::Type::UNKNOWN;
+ XBT_CRITICAL("Unknown transition in a test any. Bad things may happen");
}
}
static std::string to_string_activity_test(const activity::ActivityImpl* act)
{
if (const auto* comm = dynamic_cast<activity::CommImpl const*>(act)) {
- const std::string src_buff_id = ptr_to_id<unsigned char>(comm->src_buff_);
- const std::string dst_buff_id = ptr_to_id<unsigned char>(comm->dst_buff_);
- return "CommTest(comm_id:" + ptr_to_id<activity::CommImpl const>(comm) +
+ return "CommTest(comm_id:" + std::to_string(comm->get_id()) +
" src:" + std::to_string(comm->src_actor_ != nullptr ? comm->src_actor_->get_pid() : -1) +
" dst:" + std::to_string(comm->dst_actor_ != nullptr ? comm->dst_actor_->get_pid() : -1) +
- " mbox:" + std::to_string(comm->get_mailbox_id()) + " srcbuf:" + src_buff_id + " dstbuf:" + dst_buff_id +
- " bufsize:" + std::to_string(comm->src_buff_size_);
+ " mbox:" + std::to_string(comm->get_mailbox_id()) + ")";
} else {
return "TestUnknownType()";
}
}
void ActivityTestanySimcall::serialize(std::stringstream& stream) const
{
+ XBT_DEBUG("Serialize %s", to_string().c_str());
stream << (short)mc::Transition::Type::TESTANY << ' ' << activities_.size() << ' ';
for (auto const* act : activities_) {
- serialize_activity_test(act, stream);
+ // fun_call of each activity embedded in the TestAny is not known, so let's use the location of the TestAny itself
+ serialize_activity_test(act, fun_call_, stream);
stream << ' ';
}
stream << fun_call_;
std::string ActivityTestanySimcall::to_string() const
{
std::stringstream buffer("TestAny(");
+ bool first = true;
for (auto const* act : activities_) {
+ if (first)
+ first = false;
+ else
+ buffer << " | ";
buffer << to_string_activity_test(act);
}
+ buffer << ")";
return buffer.str();
}
void ActivityTestSimcall::serialize(std::stringstream& stream) const
{
- serialize_activity_test(activity_, stream);
- stream << ' ' << fun_call_;
+ serialize_activity_test(activity_, fun_call_, stream);
}
std::string ActivityTestSimcall::to_string() const
{
return to_string_activity_test(activity_);
}
-static void serialize_activity_wait(const activity::ActivityImpl* act, bool timeout, std::stringstream& stream)
+static void serialize_activity_wait(const activity::ActivityImpl* act, bool timeout, std::string const& call_location,
+ std::stringstream& stream)
{
if (const auto* comm = dynamic_cast<activity::CommImpl const*>(act)) {
stream << (short)mc::Transition::Type::COMM_WAIT << ' ';
- stream << timeout << ' ' << (uintptr_t)comm;
+ stream << timeout << ' ' << comm->get_id();
stream << ' ' << (comm->src_actor_ != nullptr ? comm->src_actor_->get_pid() : -1);
stream << ' ' << (comm->dst_actor_ != nullptr ? comm->dst_actor_->get_pid() : -1);
stream << ' ' << comm->get_mailbox_id();
- stream << ' ' << (uintptr_t)comm->src_buff_ << ' ' << (uintptr_t)comm->dst_buff_ << ' ' << comm->src_buff_size_;
+ stream << ' ' << call_location;
} else {
stream << (short)mc::Transition::Type::UNKNOWN;
}
static std::string to_string_activity_wait(const activity::ActivityImpl* act)
{
if (const auto* comm = dynamic_cast<activity::CommImpl const*>(act)) {
- const std::string src_buff_id = ptr_to_id<unsigned char>(comm->src_buff_);
- const std::string dst_buff_id = ptr_to_id<unsigned char>(comm->dst_buff_);
- return "CommWait(comm_id:" + ptr_to_id<activity::CommImpl const>(comm) +
+ return "CommWait(comm_id:" + std::to_string(comm->get_id()) +
" src:" + std::to_string(comm->src_actor_ != nullptr ? comm->src_actor_->get_pid() : -1) +
" dst:" + std::to_string(comm->dst_actor_ != nullptr ? comm->dst_actor_->get_pid() : -1) +
" mbox:" + (comm->get_mailbox() == nullptr ? "-" : comm->get_mailbox()->get_name()) +
- "(id:" + std::to_string(comm->get_mailbox_id()) + ") srcbuf:" + src_buff_id + " dstbuf:" + dst_buff_id +
- " bufsize:" + std::to_string(comm->src_buff_size_) + ")";
+ "(id:" + std::to_string(comm->get_mailbox_id()) + "))";
} else {
return "WaitUnknownType()";
}
void ActivityWaitSimcall::serialize(std::stringstream& stream) const
{
- serialize_activity_wait(activity_, timeout_ > 0, stream);
- stream << ' ' << fun_call_;
+ serialize_activity_wait(activity_, timeout_ > 0, fun_call_, stream);
}
void ActivityWaitanySimcall::serialize(std::stringstream& stream) const
{
+ XBT_DEBUG("Serialize %s", to_string().c_str());
stream << (short)mc::Transition::Type::WAITANY << ' ' << activities_.size() << ' ';
for (auto const* act : activities_) {
- serialize_activity_wait(act, timeout_ > 0, stream);
+ // fun_call of each activity embedded in the WaitAny is not known, so let's use the location of the WaitAny itself
+ serialize_activity_wait(act, timeout_ > 0, fun_call_, stream);
stream << ' ';
}
stream << fun_call_;
std::string ActivityWaitanySimcall::to_string() const
{
std::stringstream buffer("WaitAny(");
+ bool first = true;
for (auto const* act : activities_) {
- buffer << to_string_activity_wait(act);
+ if (first)
+ first = false;
+ else
+ buffer << " | ";
+ buffer << to_string_activity_test(act);
}
+ buffer << ")";
return buffer.str();
}
ActivityWaitanySimcall::ActivityWaitanySimcall(ActorImpl* actor, const std::vector<activity::ActivityImpl*>& activities,
- double timeout, std::string fun_call)
+ double timeout, std::string_view fun_call)
: ResultingSimcall(actor, -1), activities_(activities), timeout_(timeout), fun_call_(fun_call)
{
// list all the activities that are ready
{
/* Note that the comm_ is 0 until after the execution of the simcall */
stream << (short)mc::Transition::Type::COMM_ASYNC_SEND << ' ';
- stream << (uintptr_t)comm_ << ' ' << mbox_->get_id() << ' ' << (uintptr_t)src_buff_ << ' ' << src_buff_size_ << ' '
- << tag_;
- XBT_DEBUG("SendObserver comm:%p mbox:%u buff:%p size:%zu tag:%d", comm_, mbox_->get_id(), src_buff_, src_buff_size_,
- tag_);
+ stream << (comm_ ? comm_->get_id() : 0) << ' ' << mbox_->get_id() << ' ' << tag_;
+ XBT_DEBUG("SendObserver comm:%p mbox:%u tag:%d", comm_, mbox_->get_id(), tag_);
stream << ' ' << fun_call_;
}
std::string CommIsendSimcall::to_string() const
{
- return "CommAsyncSend(comm_id: " + std::to_string((uintptr_t)comm_) + " mbox:" + std::to_string(mbox_->get_id()) +
- " srcbuf:" + ptr_to_id<unsigned char>(src_buff_) + " bufsize:" + std::to_string(src_buff_size_) +
+ return "CommAsyncSend(comm_id: " + std::to_string(comm_->get_id()) + " mbox:" + std::to_string(mbox_->get_id()) +
" tag: " + std::to_string(tag_) + ")";
}
{
/* Note that the comm_ is 0 until after the execution of the simcall */
stream << (short)mc::Transition::Type::COMM_ASYNC_RECV << ' ';
- stream << (uintptr_t)comm_ << ' ' << mbox_->get_id() << ' ' << (uintptr_t)dst_buff_ << ' ' << tag_;
- XBT_DEBUG("RecvObserver comm:%p mbox:%u buff:%p tag:%d", comm_, mbox_->get_id(), dst_buff_, tag_);
+ stream << (comm_ ? comm_->get_id() : 0) << ' ' << mbox_->get_id() << ' ' << tag_;
+ XBT_DEBUG("RecvObserver comm:%p mbox:%u tag:%d", comm_, mbox_->get_id(), tag_);
stream << ' ' << fun_call_;
}
std::string CommIrecvSimcall::to_string() const
{
- return "CommAsyncRecv(comm_id: " + ptr_to_id<activity::CommImpl const>(comm_) +
- " mbox:" + std::to_string(mbox_->get_id()) + " dstbuf:" + ptr_to_id<unsigned char>(dst_buff_) +
+ return "CommAsyncRecv(comm_id: " + std::to_string(comm_->get_id()) + " mbox:" + std::to_string(mbox_->get_id()) +
" tag: " + std::to_string(tag_) + ")";
}