-/* Copyright (c) 2007-2020. The SimGrid Team.
- * All rights reserved. */
+/* Copyright (c) 2007-2023. The SimGrid Team. All rights reserved. */
/* This program is free software; you can redistribute it and/or modify it
* under the terms of the license (GNU LGPL) which comes with this package. */
#ifndef SIMGRID_SIMIX_HPP
#define SIMGRID_SIMIX_HPP
-#include <simgrid/simix.h>
-#include <xbt/functional.hpp>
-#include <xbt/future.hpp>
+#include <simgrid/s4u/Actor.hpp>
+#include <xbt/promise.hpp>
#include <xbt/signal.hpp>
-#include <boost/heap/fibonacci_heap.hpp>
#include <string>
#include <unordered_map>
-XBT_PUBLIC void simcall_run_kernel(std::function<void()> const& code, simgrid::mc::SimcallInspector* t);
-XBT_PUBLIC void simcall_run_blocking(std::function<void()> const& code, simgrid::mc::SimcallInspector* t);
+XBT_PUBLIC void simcall_run_answered(std::function<void()> const& code,
+ simgrid::kernel::actor::SimcallObserver* observer);
+XBT_PUBLIC void simcall_run_blocking(std::function<void()> const& code,
+ simgrid::kernel::actor::SimcallObserver* observer);
+XBT_PUBLIC void simcall_run_object_access(std::function<void()> const& code,
+ simgrid::kernel::actor::ObjectAccessSimcallItem* item);
-namespace simgrid {
-namespace kernel {
-namespace actor {
+namespace simgrid::kernel::actor {
/** Execute some code in kernel context on behalf of the user code.
*
* Every modification of the environment must be protected this way: every setter, constructor and similar.
- * Getters don't have to be protected this way.
+ * Getters don't have to be protected this way, and setters may use the simcall_object_access() variant (see below).
*
* This allows deterministic parallel simulation without any locking, even if almost nobody uses parallel simulation in
* SimGrid. More interestingly it makes every modification of the simulated world observable by the model-checker,
* you may need to wait for that mutex to be unlocked by its current owner.
* Potentially blocking simcall must be issued using simcall_blocking(), right below in this file.
*/
-template <class F> typename std::result_of<F()>::type simcall(F&& code, mc::SimcallInspector* t = nullptr)
+template <class F> typename std::result_of_t<F()> simcall_answered(F&& code, SimcallObserver* observer = nullptr)
{
// If we are in the maestro, we take the fast path and execute the
// code directly without simcall marshalling/unmarshalling/dispatch:
- if (SIMIX_is_maestro())
+ if (s4u::Actor::is_maestro())
return std::forward<F>(code)();
// If we are in the application, pass the code to the maestro which
// executes it for us and reports the result. We use a std::future which
// conveniently handles the success/failure value for us.
- typedef typename std::result_of<F()>::type R;
+ using R = typename std::result_of_t<F()>;
simgrid::xbt::Result<R> result;
- simcall_run_kernel([&result, &code] { simgrid::xbt::fulfill_promise(result, std::forward<F>(code)); }, t);
+ simcall_run_answered([&result, &code] { simgrid::xbt::fulfill_promise(result, std::forward<F>(code)); }, observer);
+ return result.get();
+}
+
+/** Use a setter on the `item` object. That's a simcall only if running in parallel or with MC activated.
+ *
+ * Simulation without MC and without parallelism (contexts/nthreads=1) will not pay the price of a simcall for an
+ * harmless setter. When running in parallel, you want your write access to be done in a mutual exclusion way, while the
+ * getters can still occur out of order.
+ *
+ * When running in MC, you want to make this access visible to the checker. Actually in this case, it's not visible from
+ * the checker (and thus still use a fast track) if the setter is called from the actor that created the object.
+ */
+template <class F> typename std::result_of_t<F()> simcall_object_access(ObjectAccessSimcallItem* item, F&& code)
+{
+ // If we are in the maestro, we take the fast path and execute the code directly
+ if (simgrid::s4u::Actor::is_maestro())
+ return std::forward<F>(code)();
+
+ // If called from another thread, do a real simcall. It will be short-cut on need
+ using R = typename std::result_of_t<F()>;
+ simgrid::xbt::Result<R> result;
+ simcall_run_object_access([&result, &code] { simgrid::xbt::fulfill_promise(result, std::forward<F>(code)); }, item);
+
return result.get();
}
/** Execute some code (that does not return immediately) in kernel context
*
- * This is very similar to simcall() right above, but the calling actor will not get rescheduled until
+ * This is very similar to simcall_answered() above, but the calling actor will not get rescheduled until
* actor->simcall_answer() is called explicitly.
*
- * Since the return value does not come from the lambda directly, its type cannot be guessed automatically and must
- * be provided as template parameter.
- *
* This is meant for blocking actions. For example, locking a mutex is a blocking simcall.
* First it's a simcall because that's obviously a modification of the world. Then, that's a blocking simcall because if
* the mutex happens not to be free, the actor is added to a queue of actors in the mutex. Every mutex->unlock() takes
* right away with actor->simcall_answer() once the mutex is marked as locked.
*
* If your code never calls actor->simcall_answer() itself, the actor will never return from its simcall.
+ *
+ * The return value is obtained from observer->get_result() if it exists. Otherwise void is returned.
*/
-template <class R, class F> R simcall_blocking(F&& code, mc::SimcallInspector* t = nullptr)
+template <class F> void simcall_blocking(F&& code, SimcallObserver* observer = nullptr)
{
- // If we are in the maestro, we take the fast path and execute the
- // code directly without simcall marshalling/unmarshalling/dispatch:
- if (SIMIX_is_maestro())
- return std::forward<F>(code)();
+ xbt_assert(not s4u::Actor::is_maestro(), "Cannot execute blocking call in kernel mode");
- // If we are in the application, pass the code to the maestro which
- // executes it for us and reports the result. We use a std::future which
+ // Pass the code to the maestro which executes it for us and reports the result. We use a std::future which
// conveniently handles the success/failure value for us.
- simgrid::xbt::Result<R> result;
- simcall_run_blocking([&result, &code] { simgrid::xbt::fulfill_promise(result, std::forward<F>(code)); }, t);
- return result.get();
+ simgrid::xbt::Result<void> result;
+ simcall_run_blocking([&result, &code] { simgrid::xbt::fulfill_promise(result, std::forward<F>(code)); }, observer);
+ result.get(); // rethrow stored exception if any
}
-} // namespace actor
-} // namespace kernel
-} // namespace simgrid
-namespace simgrid {
-namespace simix {
-
-
-typedef std::pair<double, Timer*> TimerQelt;
-static boost::heap::fibonacci_heap<TimerQelt, boost::heap::compare<xbt::HeapComparator<TimerQelt>>> simix_timers;
-
-/** @brief Timer datatype */
-class Timer {
- double date = 0.0;
-
-public:
- decltype(simix_timers)::handle_type handle_;
-
- Timer(double date, simgrid::xbt::Task<void()>&& callback) : date(date), callback(std::move(callback)) {}
-
- simgrid::xbt::Task<void()> callback;
- double get_date() { return date; }
- void remove();
-
- template <class F> static inline Timer* set(double date, F callback)
- {
- return set(date, simgrid::xbt::Task<void()>(std::move(callback)));
- }
-
- static Timer* set(double date, simgrid::xbt::Task<void()>&& callback);
- static double next() { return simix_timers.empty() ? -1.0 : simix_timers.top().first; }
-};
-
-} // namespace simix
-} // namespace simgrid
+template <class F, class Observer>
+auto simcall_blocking(F&& code, Observer* observer) -> decltype(observer->get_result())
+{
+ simcall_blocking(std::forward<F>(code), static_cast<SimcallObserver*>(observer));
+ return observer->get_result();
+}
+} // namespace simgrid::kernel::actor
#endif