#include "src/kernel/actor/SimcallObserver.hpp"
#include "simgrid/s4u/Host.hpp"
#include "src/kernel/activity/CommImpl.hpp"
+#include "src/kernel/activity/MailboxImpl.hpp"
#include "src/kernel/activity/MutexImpl.hpp"
#include "src/kernel/actor/ActorImpl.hpp"
#include "src/mc/mc_config.hpp"
+#include <sstream>
+
XBT_LOG_NEW_DEFAULT_SUBCATEGORY(mc_observer, mc, "Logging specific to MC simcall observation");
namespace simgrid {
{
return get_issuer() == other->get_issuer();
}
+void RandomSimcall::serialize(Simcall& type, std::stringstream& stream)
+{
+ type = Simcall::RANDOM;
+ stream << min_ << ' ' << max_;
+}
+
bool MutexSimcall::depends(SimcallObserver* other)
{
if (dynamic_cast<RandomSimcall*>(other) != nullptr)
return true; // Depend on things we don't know for sure that they are independent
}
-std::string SimcallObserver::to_string(int /*times_considered*/) const
+/*
+std::string SimcallObserver::to_string(int) const
{
return simgrid::xbt::string_printf("[(%ld)%s (%s)] ", issuer_->get_pid(), issuer_->get_host()->get_cname(),
issuer_->get_cname());
-}
+}*/
std::string SimcallObserver::dot_label(int /*times_considered*/) const
{
return xbt::string_printf("[(%ld)] ", issuer_->get_pid());
}
-std::string RandomSimcall::to_string(int times_considered) const
-{
- return SimcallObserver::to_string(times_considered) + "MC_RANDOM(" + std::to_string(times_considered) + ")";
-}
-
std::string RandomSimcall::dot_label(int times_considered) const
{
return SimcallObserver::dot_label(times_considered) + "MC_RANDOM(" + std::to_string(next_value_) + ")";
return max_ - min_ + 1;
}
-std::string MutexUnlockSimcall::to_string(int times_considered) const
-{
- return SimcallObserver::to_string(times_considered) + "Mutex UNLOCK";
-}
-
std::string MutexUnlockSimcall::dot_label(int times_considered) const
{
return SimcallObserver::dot_label(times_considered) + "Mutex UNLOCK";
}
+/*
std::string MutexLockSimcall::to_string(int times_considered) const
{
auto mutex = get_mutex();
res += ", owner = " + std::to_string(mutex->get_owner() ? mutex->get_owner()->get_pid() : -1);
res += ", sleeping = n/a)";
return res;
-}
+}*/
std::string MutexLockSimcall::dot_label(int times_considered) const
{
return not blocking_ || get_mutex()->get_owner() == nullptr || get_mutex()->get_owner() == get_issuer();
}
-std::string ConditionWaitSimcall::to_string(int times_considered) const
-{
- std::string res = SimcallObserver::to_string(times_considered) + "Condition WAIT";
- res += "(" + (timeout_ == -1.0 ? "" : std::to_string(timeout_)) + ")";
- return res;
-}
-
std::string ConditionWaitSimcall::dot_label(int times_considered) const
{
return SimcallObserver::dot_label(times_considered) + "Condition WAIT";
return true;
}
-std::string SemAcquireSimcall::to_string(int times_considered) const
-{
- std::string res = SimcallObserver::to_string(times_considered) + "Sem ACQUIRE";
- res += "(" + (timeout_ == -1.0 ? "" : std::to_string(timeout_)) + ")";
- return res;
-}
-
std::string SemAcquireSimcall::dot_label(int times_considered) const
{
return SimcallObserver::dot_label(times_considered) + "Sem ACQUIRE";
next_value_ = times_considered;
}
+/*
std::string ActivityTestanySimcall::to_string(int times_considered) const
{
std::string res = SimcallObserver::to_string(times_considered);
}
return res;
-}
+}*/
std::string ActivityTestanySimcall::dot_label(int times_considered) const
{
if (dynamic_cast<ActivityTestSimcall*>(other))
return true;
- auto* comm1 = dynamic_cast<activity::CommImpl*>(activity_);
+ const auto* comm1 = dynamic_cast<activity::CommImpl*>(activity_);
if (comm1 == nullptr)
return false;
if (comm1->src_buff_ == nullptr || comm1->dst_buff_ == nullptr)
return false;
- if (auto* test = dynamic_cast<ActivityTestSimcall*>(other)) {
- auto* comm2 = dynamic_cast<activity::CommImpl*>(test->get_activity());
+ if (const auto* test = dynamic_cast<ActivityTestSimcall*>(other)) {
+ const auto* comm2 = dynamic_cast<activity::CommImpl*>(test->get_activity());
if (comm2 == nullptr)
return false;
else if (comm2->src_buff_ == nullptr || comm2->dst_buff_ == nullptr)
return true;
}
+void ActivityWaitSimcall::serialize(Simcall& type, std::stringstream& stream)
+{
+ if (auto* comm = dynamic_cast<activity::CommImpl*>(activity_)) {
+ type = Simcall::COMM_WAIT;
+ stream << (timeout_ > 0) << ' ' << comm;
+ stream << ' ' << (comm->src_actor_ != nullptr ? comm->src_actor_->get_pid() : -1);
+ stream << ' ' << (comm->dst_actor_ != nullptr ? comm->dst_actor_->get_pid() : -1);
+ stream << ' ' << comm->get_mailbox_id();
+ stream << ' ' << (void*)comm->src_buff_ << ' ' << (void*)comm->dst_buff_ << ' ' << comm->src_buff_size_;
+ } else {
+ type = Simcall::UNKNOWN;
+ }
+}
+/*
std::string ActivityTestSimcall::to_string(int times_considered) const
{
std::string res = SimcallObserver::to_string(times_considered) + "Test ";
- auto* comm = dynamic_cast<activity::CommImpl*>(activity_);
- if (comm) {
+ if (const auto* comm = dynamic_cast<activity::CommImpl*>(activity_)) {
if (comm->src_actor_.get() == nullptr || comm->dst_actor_.get() == nullptr) {
res += "FALSE(comm=";
res += XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf("%p)", comm)
} else
xbt_die("Only Comms are supported here for now");
return res;
-}
+}*/
std::string ActivityTestSimcall::dot_label(int times_considered) const
{
- std::string res = SimcallObserver::dot_label(times_considered) + "Test ";
- auto* comm = dynamic_cast<activity::CommImpl*>(activity_);
+ std::string res = SimcallObserver::dot_label(times_considered) + "Test ";
+ const auto* comm = dynamic_cast<activity::CommImpl*>(activity_);
if (comm && (comm->src_actor_.get() == nullptr || comm->dst_actor_.get() == nullptr)) {
res += "FALSE";
} else {
return (comm->src_actor_ && comm->dst_actor_);
}
-bool ActivityWaitSimcall::depends(SimcallObserver* other)
-{
- if (get_issuer() == other->get_issuer())
- return false;
-
- /* Timeouts in wait transitions are not considered by the independence theorem, thus assumed dependent */
- if (auto* wait = dynamic_cast<ActivityWaitSimcall*>(other)) {
- if (timeout_ > 0 || wait->get_timeout() > 0)
- return true;
- auto* comm1 = dynamic_cast<activity::CommImpl*>(activity_);
- auto* comm2 = dynamic_cast<activity::CommImpl*>(wait->get_activity());
-
- if (comm1 == nullptr || comm2 == nullptr) // One wait at least in not on a Comm
- return true;
-
- if (comm1->src_buff_ == comm2->src_buff_ && comm1->dst_buff_ == comm2->dst_buff_)
- return false;
- if (comm1->src_buff_ != nullptr && comm1->dst_buff_ != nullptr && comm2->src_buff_ != nullptr &&
- comm2->dst_buff_ != nullptr && comm1->dst_buff_ != comm2->src_buff_ && comm1->dst_buff_ != comm2->dst_buff_ &&
- comm2->dst_buff_ != comm1->src_buff_)
- return false;
- }
-
- return true;
-}
-
-std::string ActivityWaitSimcall::to_string(int times_considered) const
-{
- std::string res = SimcallObserver::to_string(times_considered);
- auto* comm = dynamic_cast<activity::CommImpl*>(activity_);
- if (comm == nullptr)
- xbt_die("Only Comms are supported here for now");
-
- if (times_considered == -1) {
- res += "WaitTimeout(comm=" + (XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose)
- ? xbt::string_printf("%p)", comm)
- : "(verbose only))");
- } else {
- res += "Wait(comm=";
-
- auto src = comm->src_actor_;
- auto dst = comm->dst_actor_;
- res +=
- XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf("%p", comm) : "(verbose only) ";
- res += xbt::string_printf("[(%ld)%s (%s) ", src->get_pid(), src->get_host()->get_cname(), src->get_cname()) +
- "-> " + xbt::string_printf("(%ld)%s (%s)])", dst->get_pid(), dst->get_host()->get_cname(), dst->get_cname());
- }
- return res;
-}
-
std::string ActivityWaitSimcall::dot_label(int times_considered) const
{
std::string res = SimcallObserver::dot_label(times_considered);
res += (times_considered == -1) ? "WaitTimeout " : "Wait ";
- auto* comm = dynamic_cast<activity::CommImpl*>(activity_);
+ const auto* comm = dynamic_cast<activity::CommImpl*>(activity_);
if (comm) {
auto src = comm->src_actor_;
auto dst = comm->dst_actor_;
next_value_ = times_considered;
}
-std::string ActivityWaitanySimcall::to_string(int times_considered) const
-{
- std::string res = SimcallObserver::to_string(times_considered) + "WaitAny(";
- size_t count = activities_.size();
- if (count > 0) {
- if (auto* comm = dynamic_cast<kernel::activity::CommImpl*>(activities_[times_considered]))
- res += "comm=" +
- (XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf("%p", comm)
- : "(verbose only)") +
- xbt::string_printf("(%d of %zu))", times_considered + 1, count);
- else
- xbt_die("Only Comms are supported here for now");
- } else
- res += "comm at idx " + std::to_string(times_considered) + ")";
- return res;
-}
-
-bool CommIsendSimcall::depends(SimcallObserver* other)
-{
- if (get_issuer() == other->get_issuer())
- return false;
-
- if (auto* other_isend = dynamic_cast<CommIsendSimcall*>(other))
- return mbox_ == other_isend->get_mailbox();
-
- // FIXME: Not in the former dependency check because of the ordering but seems logical to add it
- if (dynamic_cast<CommIrecvSimcall*>(other) != nullptr)
- return false;
-
-#if SIMGRID_HAVE_MC // FIXME needed to access mbox_cpy
- if (auto* wait = dynamic_cast<ActivityWaitSimcall*>(other)) {
- if (auto* comm2 = dynamic_cast<activity::CommImpl*>(wait->get_activity())) { // this is a Comm::wait_for
- auto* mbox1 = mbox_;
- auto* mbox2 = comm2->mbox_cpy;
-
- if (mbox1 != mbox2 && wait->get_timeout() <= 0)
- return false;
-
- if ((get_issuer() != comm2->src_actor_.get()) && (get_issuer() != comm2->dst_actor_.get()) &&
- wait->get_timeout() <= 0)
- return false;
-
- if (comm2->type_ == activity::CommImpl::Type::SEND && comm2->src_buff_ != src_buff_ && wait->get_timeout() <= 0)
- return false;
- }
- }
-#endif
- /* FIXME: the following rule assumes that the result of the isend/irecv call is not stored in a buffer used in the
- * test call. */
-#if 0
- if (dynamic_cast<ActivityTestSimcall*>(other))
- return false;
-#endif
-
- return true;
-}
-
-std::string CommIsendSimcall::to_string(int times_considered) const
-{
- std::string res = SimcallObserver::to_string(times_considered) + "iSend(";
- res += xbt::string_printf("src=[(%ld)%s (%s)]", get_issuer()->get_pid(), get_issuer()->get_host()->get_cname(),
- get_issuer()->get_cname());
- res += XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf(", buff=%p", src_buff_)
- : "(verbose only)";
- res += ", size=" +
- (XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? std::to_string(src_buff_size_) : "(verbose only)");
- res += ")";
- return res;
-}
-
-bool CommIrecvSimcall::depends(SimcallObserver* other)
+void CommIsendSimcall::serialize(Simcall& type, std::stringstream& stream)
{
- if (get_issuer() == other->get_issuer())
- return false;
-
- if (auto* other_irecv = dynamic_cast<CommIrecvSimcall*>(other))
- return mbox_ == other_irecv->get_mailbox();
-
- if (dynamic_cast<CommIsendSimcall*>(other) != nullptr)
- return false;
-
-#if SIMGRID_HAVE_MC // FIXME needed to access mbox_cpy
- if (auto* wait = dynamic_cast<ActivityWaitSimcall*>(other)) {
- if (auto* comm2 = dynamic_cast<activity::CommImpl*>(wait->get_activity())) { // this is a Comm::wait_for
- auto* mbox1 = mbox_;
- auto* mbox2 = comm2->mbox_cpy;
-
- if (mbox1 != mbox2 && wait->get_timeout() <= 0)
- return false;
-
- if ((get_issuer() != comm2->src_actor_.get()) && (get_issuer() != comm2->dst_actor_.get()) &&
- wait->get_timeout() <= 0)
- return false;
-
- if (comm2->type_ == activity::CommImpl::Type::RECEIVE && comm2->dst_buff_ != dst_buff_ &&
- wait->get_timeout() <= 0)
- return false;
- }
- }
-#endif
- /* FIXME: the following rule assumes that the result of the isend/irecv call is not stored in a buffer used in the
- * test call. */
-#if 0
- if (dynamic_cast<ActivityTestSimcall*>(other))
- return false;
-#endif
-
- return true;
+ type = Simcall::ISEND;
+ stream << mbox_->get_id() << ' ' << (void*)src_buff_ << ' ' << src_buff_size_;
+ XBT_DEBUG("SendObserver mbox:%u buff:%p size:%zu", mbox_->get_id(), src_buff_, src_buff_size_);
}
-std::string CommIrecvSimcall::to_string(int times_considered) const
+void CommIrecvSimcall::serialize(Simcall& type, std::stringstream& stream)
{
- std::string res = SimcallObserver::to_string(times_considered) + "iRecv(";
- res += xbt::string_printf("dst=[(%ld)%s (%s)]", get_issuer()->get_pid(), get_issuer()->get_host()->get_cname(),
- get_issuer()->get_cname());
- res += XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf(", buff=%p", dst_buff_)
- : "(verbose only)";
- res += ", size=" + (XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? std::to_string(*dst_buff_size_)
- : "(verbose only)");
- res += ")";
- return res;
+ type = Simcall::IRECV;
+ stream << mbox_->get_id() << dst_buff_;
}
} // namespace actor