Replace todo direct access with consider methods; guided or not

[simgrid.git] / include / xbt / config.hpp

diff --git a/include/xbt/config.hpp b/include/xbt/config.hpp
index 494d89c..8071dbd 100644 (file)
--- a/include/xbt/config.hpp
+++ b/include/xbt/config.hpp
@@ -1,4 +1,4 @@
-/* Copyright (c) 2016-2022. The SimGrid Team. All rights reserved.          */
+/* Copyright (c) 2016-2023. The SimGrid Team. All rights reserved.          */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
@@ -20,6 +20,7 @@
 
 #include <xbt/base.h>
 #include <xbt/sysdep.h>
+#include <xbt/utility.hpp>
 
 namespace simgrid {
 namespace config {
@@ -76,6 +77,10 @@ extern template XBT_PUBLIC double const& get_value<double>(const std::string& na
 extern template XBT_PUBLIC bool const& get_value<bool>(const std::string& name);
 extern template XBT_PUBLIC std::string const& get_value<std::string>(const std::string& name);
 
+// ***** alias *****
+
+XBT_PUBLIC void alias(const char* realname, std::initializer_list<const char*> aliases);
+
 // Register:
 
 /** Register a configuration flag
@@ -88,6 +93,13 @@ extern template XBT_PUBLIC std::string const& get_value<std::string>(const std::
 template <class T>
 XBT_PUBLIC void declare_flag(const std::string& name, const std::string& description, T value,
                              std::function<void(const T&)> callback = std::function<void(const T&)>());
+template <class T>
+void declare_flag(const std::string& name, std::initializer_list<const char*> aliases, const std::string& description,
+                  T value, std::function<void(const T&)> callback = std::function<void(const T&)>())
+{
+  declare_flag(name, description, std::move(value), std::move(callback));
+  alias(name.c_str(), aliases);
+}
 
 extern template XBT_PUBLIC void declare_flag(const std::string& name, const std::string& description, int value,
                                              std::function<void(int const&)> callback);
@@ -98,10 +110,6 @@ extern template XBT_PUBLIC void declare_flag(const std::string& name, const std:
 extern template XBT_PUBLIC void declare_flag(const std::string& name, const std::string& description, std::string value,
                                              std::function<void(std::string const&)> callback);
 
-// ***** alias *****
-
-XBT_PUBLIC void alias(const char* realname, std::initializer_list<const char*> aliases);
-
 /** Bind a variable to configuration flag
  *
  *  @param value Bound variable
@@ -166,7 +174,7 @@ bind_flag(std::string& value, const char* name, const char* description,
                  if (val == "help")
                    mesg += std::string("Possible values for option ") + name + ":\n";
                  else
-                   mesg += std::string("Invalid value '") + val + "' for option " + name + ". Possible values:\n";
+                   mesg += "Invalid value '" + val + "' for option " + name + ". Possible values:\n";
                  for (auto const& kv : valid_values)
                    mesg += "  - '" + kv.first + "': " + kv.second + (kv.first == value ? "  <=== DEFAULT" : "") + "\n";
                  xbt_die("%s", mesg.c_str());
@@ -221,13 +229,13 @@ public:
    *  @param desc  Flag description
    *  @param value Flag initial/default value
    */
-  Flag(const char* name, const char* desc, T value) : value_(value), name_(name)
+  Flag(const char* name, const char* desc, xbt::type_identity_t<T> value) : value_(value), name_(name)
   {
     simgrid::config::bind_flag(value_, name, desc);
   }
 
   /** Constructor taking also an array of aliases for name */
-  Flag(const char* name, std::initializer_list<const char*> aliases, const char* desc, T value)
+  Flag(const char* name, std::initializer_list<const char*> aliases, const char* desc, xbt::type_identity_t<T> value)
       : value_(value), name_(name)
   {
     simgrid::config::bind_flag(value_, name, aliases, desc);
@@ -236,13 +244,15 @@ public:
   /* A constructor accepting a callback that will be passed the parameter.
    * It can either return a boolean (informing whether the parameter is valid), or returning void.
    */
-  template <class F> Flag(const char* name, const char* desc, T value, F callback) : value_(value), name_(name)
+  template <class F>
+  Flag(const char* name, const char* desc, xbt::type_identity_t<T> value, F callback) : value_(value), name_(name)
   {
     simgrid::config::bind_flag(value_, name, desc, std::move(callback));
   }
 
   template <class F>
-  Flag(const char* name, std::initializer_list<const char*> aliases, const char* desc, T value, F callback)
+  Flag(const char* name, std::initializer_list<const char*> aliases, const char* desc, xbt::type_identity_t<T> value,
+       F callback)
       : value_(value), name_(name)
   {
     simgrid::config::bind_flag(value_, name, aliases, desc, std::move(callback));
@@ -252,8 +262,8 @@ public:
    * and producing an informative error message when an invalid value is passed, or when help is passed as a value.
    */
   template <class F>
-  Flag(const char* name, const char* desc, T value, const std::map<std::string, std::string, std::less<>>& valid_values,
-       F callback)
+  Flag(const char* name, const char* desc, xbt::type_identity_t<T> value,
+       const std::map<std::string, std::string, std::less<>>& valid_values, F callback)
       : value_(value), name_(name)
   {
     simgrid::config::bind_flag(value_, name, desc, valid_values, std::move(callback));
@@ -261,7 +271,7 @@ public:
 
   /* A constructor with everything */
   template <class F>
-  Flag(const char* name, std::initializer_list<const char*> aliases, const char* desc, T value,
+  Flag(const char* name, std::initializer_list<const char*> aliases, const char* desc, xbt::type_identity_t<T> value,
        const std::map<std::string, std::string, std::less<>>& valid_values, F callback)
       : value_(value), name_(name)
   {
@@ -307,20 +317,4 @@ XBT_PUBLIC void help();
 } // namespace config
 } // namespace simgrid
 
-/******************************** Configuration of Simgrid **************************************/
-extern XBT_PUBLIC simgrid::config::Flag<int> _sg_context_stack_size;
-extern XBT_PUBLIC simgrid::config::Flag<int> _sg_context_guard_size;
-extern XBT_PUBLIC simgrid::config::Flag<int> _sg_context_nthreads;
-extern XBT_PUBLIC simgrid::config::Flag<std::string> _sg_context_synchro;
-
-extern XBT_PUBLIC simgrid::config::Flag<bool> _sg_cpu_maxmin_selective_update;
-
-extern XBT_PUBLIC simgrid::config::Flag<bool> _sg_bmf_selective_update;
-
-extern XBT_PUBLIC simgrid::config::Flag<double> _sg_network_loopback_bandwidth;
-extern XBT_PUBLIC simgrid::config::Flag<double> _sg_network_loopback_latency;
-extern XBT_PUBLIC simgrid::config::Flag<bool> _sg_network_maxmin_selective_update;
-
-extern XBT_PUBLIC simgrid::config::Flag<bool> _sg_execution_cutpath;
-
 #endif