better check for mpi_datatype_null

[simgrid.git] / src / s4u / s4u_Link.cpp

diff --git a/src/s4u/s4u_Link.cpp b/src/s4u/s4u_Link.cpp
index 41a19abdac10012dae9280d23078a8f791c0776e..1a5db6cde0cf10c248886579fd6a47bcd0db808e 100644 (file)
--- a/src/s4u/s4u_Link.cpp
+++ b/src/s4u/s4u_Link.cpp
@@ -73,7 +73,7 @@ Link* Link::set_latency(const std::string& value)
 {
   double d_value = 0.0;
   try {
-    d_value = xbt_parse_get_time("", 0, value.c_str(), nullptr, "");
+    d_value = xbt_parse_get_time("", 0, value, "");
   } catch (const simgrid::ParseError&) {
     throw std::invalid_argument(std::string("Impossible to set latency for link: ") + get_name() +
                                 std::string(". Invalid value: ") + value);
@@ -94,6 +94,10 @@ Link* Link::set_bandwidth(double value)
 
 Link* Link::set_sharing_policy(Link::SharingPolicy policy)
 {
+  if (policy == SharingPolicy::SPLITDUPLEX)
+    throw std::invalid_argument(std::string("Impossible to set split-duplex for the link: ") + get_name() +
+                                std::string(". You should create a link-up and link-down to emulate this behavior"));
+
   kernel::actor::simcall([this, policy] { pimpl_->set_sharing_policy(policy); });
   return this;
 }
@@ -260,7 +264,7 @@ void sg_link_data_set(sg_link_t link, void* data) // XBT_ATTRIB_DEPRECATED_v330
   sg_link_set_data(link, data);
 }
 
-int sg_link_count()
+size_t sg_link_count()
 {
   return simgrid::s4u::Engine::get_instance()->get_link_count();
 }
@@ -269,8 +273,8 @@ sg_link_t* sg_link_list()
 {
   std::vector<simgrid::s4u::Link*> links = simgrid::s4u::Engine::get_instance()->get_all_links();
 
-  sg_link_t* res = xbt_new(sg_link_t, links.size());
-  memcpy(res, links.data(), sizeof(sg_link_t) * links.size());
+  auto* res = xbt_new(sg_link_t, links.size());
+  std::copy(begin(links), end(links), res);
 
   return res;
 }