Better handling of test any

[simgrid.git] / src / smpi / colls / allreduce / allreduce-smp-rsag-lr.cpp

diff --git a/src/smpi/colls/allreduce/allreduce-smp-rsag-lr.cpp b/src/smpi/colls/allreduce/allreduce-smp-rsag-lr.cpp
index afc21e8ca1b34a2f198477599919744a8c0488a6..79692cb89fab6c2304f1ab61ac5c7841457504ac 100644 (file)
--- a/src/smpi/colls/allreduce/allreduce-smp-rsag-lr.cpp
+++ b/src/smpi/colls/allreduce/allreduce-smp-rsag-lr.cpp
@@ -1,27 +1,25 @@
-/* Copyright (c) 2013-2017. The SimGrid Team.
+/* Copyright (c) 2013-2023. The SimGrid Team.
  * All rights reserved.                                                     */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
 
-#include "../colls_private.h"
+#include "../colls_private.hpp"
 //#include <star-reduction.c>
 
 /*
-This fucntion performs all-reduce operation as follow.
+This function performs all-reduce operation as follow.
 1) binomial_tree reduce inside each SMP node
 2) reduce-scatter -inter between root of each SMP node
 3) allgather - inter between root of each SMP node
 4) binomial_tree bcast inside each SMP node
 */
-namespace simgrid{
-namespace smpi{
-int Coll_allreduce_smp_rsag_lr::allreduce(void *send_buf, void *recv_buf,
-                                          int count, MPI_Datatype dtype,
-                                          MPI_Op op, MPI_Comm comm)
+namespace simgrid::smpi {
+int allreduce__smp_rsag_lr(const void *send_buf, void *recv_buf,
+                           int count, MPI_Datatype dtype,
+                           MPI_Op op, MPI_Comm comm)
 {
   int comm_size, rank;
-  void *tmp_buf;
   int tag = COLL_TAG_ALLREDUCE;
   int mask, src, dst;
   MPI_Status status;
@@ -37,7 +35,7 @@ int Coll_allreduce_smp_rsag_lr::allreduce(void *send_buf, void *recv_buf,
      MPI_User_function * uop = MPIR_Op_table[op % 16 - 1];
      #else
      MPI_User_function *uop;
-     struct MPIR_OP *op_ptr;
+     MPIR_OP *op_ptr;
      op_ptr = MPIR_ToPointer(op);
      uop  = op_ptr->op;
      #endif
@@ -46,7 +44,7 @@ int Coll_allreduce_smp_rsag_lr::allreduce(void *send_buf, void *recv_buf,
   rank = comm->rank();
   MPI_Aint extent;
   extent = dtype->get_extent();
-  tmp_buf = (void *) smpi_get_tmp_sendbuffer(count * extent);
+  unsigned char* tmp_buf = smpi_get_tmp_sendbuffer(count * extent);
 
   int intra_rank, inter_rank;
   intra_rank = rank % num_core;
@@ -257,5 +255,4 @@ int Coll_allreduce_smp_rsag_lr::allreduce(void *send_buf, void *recv_buf,
   smpi_free_tmp_buffer(tmp_buf);
   return MPI_SUCCESS;
 }
-}
-}
+} // namespace simgrid::smpi