-/* Copyright (c) 2004-2014,2016. The SimGrid Team.
- * All rights reserved. */
+/* Copyright (c) 2004-2014,2016. The SimGrid Team. All rights reserved. */
+
+/* This program is free software; you can redistribute it and/or modify it
+ * under the terms of the license (GNU LGPL) which comes with this package. */
#include <stdio.h>
#include <typeinfo>
#include <type_traits>
+#include <xbt/ex.hpp>
#include <xbt/config.h>
#include <xbt/config.hpp>
#include "xbt/misc.h"
XBT_LOG_NEW_DEFAULT_SUBCATEGORY(xbt_cfg, xbt, "configuration support");
-XBT_EXPORT_NO_IMPORT(xbt_cfg_t) simgrid_config = NULL;
+XBT_EXPORT_NO_IMPORT(xbt_cfg_t) simgrid_config = nullptr;
+extern "C" {
+ XBT_PUBLIC(void) sg_config_finalize();
+}
namespace simgrid {
namespace config {
+missing_key_error::~missing_key_error() {}
+
class Config;
namespace {
for (const char* false_value : false_values)
if (std::strcmp(false_value, value) == 0)
return false;
- throw std::domain_error("not a boolean");
+ throw std::range_error("not a boolean");
}
static double parseDouble(const char* value)
name,
variable->getDescription().c_str(),
variable->getTypeName(), variable, this);
- xbt_dict_set(this->options, name, variable, NULL);
+ xbt_dict_set(this->options, name, variable, nullptr);
variable->update();
return variable;
}
Config::Config() :
options(xbt_dict_new_homogeneous(xbt_cfgelm_free)),
- aliases(xbt_dict_new_homogeneous(NULL))
+ aliases(xbt_dict_new_homogeneous(nullptr))
{}
Config::~Config()
{
xbt_dictelm_t elm = getDictElement(name);
if (elm == nullptr)
- throw std::invalid_argument(std::string("Bad config key, ") + name);
+ throw simgrid::config::missing_key_error(std::string("Bad config key, ") + name);
return *(ConfigurationElement*)elm->content;
}
xbt_assert(this->getDictElement(aliasname) == nullptr, "Alias '%s' already.", aliasname);
xbt_dictelm_t element = this->getDictElement(realname);
xbt_assert(element, "Cannot define an alias to the non-existing option '%s'.", realname);
- xbt_dict_set(this->aliases, aliasname, element, NULL);
+ xbt_dict_set(this->aliases, aliasname, element, nullptr);
}
/** @brief Dump a config set for debuging purpose
void Config::dump(const char *name, const char *indent)
{
xbt_dict_t dict = this->options;
- xbt_dict_cursor_t cursor = NULL;
- simgrid::config::ConfigurationElement* variable = NULL;
- char *key = NULL;
+ xbt_dict_cursor_t cursor = nullptr;
+ simgrid::config::ConfigurationElement* variable = nullptr;
+ char *key = nullptr;
if (name)
printf("%s>> Dumping of the config set '%s':\n", indent, name);
unsigned int dynar_cursor;
xbt_dictelm_t dictel;
char *name;
- xbt_dynar_t names = xbt_dynar_new(sizeof(char *), NULL);
+ xbt_dynar_t names = xbt_dynar_new(sizeof(char *), nullptr);
xbt_dict_foreach(this->aliases, dict_cursor, name, dictel)
xbt_dynar_push(names, &name);
unsigned int dynar_cursor;
simgrid::config::ConfigurationElement* variable;
char *name;
- xbt_dynar_t names = xbt_dynar_new(sizeof(char *), NULL);
+ xbt_dynar_t names = xbt_dynar_new(sizeof(char *), nullptr);
xbt_dict_foreach(this->options, dict_cursor, name, variable)
xbt_dynar_push(names, &name);
template XBT_PUBLIC(bool const&) getConfig<bool>(const char* name);
template XBT_PUBLIC(std::string const&) getConfig<std::string>(const char* name);
+// ***** alias *****
+
+void alias(const char* realname, const char* aliasname)
+{
+ simgrid_config->alias(realname, aliasname);
+}
+
// ***** declareFlag *****
template<class T>
XBT_PUBLIC(void) declareFlag(const char* name, const char* description,
T value, std::function<void(const T&)> callback)
{
- if (simgrid_config == NULL)
+ if (simgrid_config == nullptr) {
simgrid_config = xbt_cfg_new();
+ atexit(sg_config_finalize);
+ }
simgrid_config->registerOption<T>(
name, description, std::move(value), std::move(callback));
}
template XBT_PUBLIC(void) declareFlag(const char* name,
const char* description, std::string value, std::function<void(std::string const &)> callback);
-
}
}
// ***** C bindings *****
-xbt_cfg_t xbt_cfg_new(void) { return new simgrid::config::Config(); }
+xbt_cfg_t xbt_cfg_new() { return new simgrid::config::Config(); }
void xbt_cfg_free(xbt_cfg_t * cfg) { delete *cfg; }
void xbt_cfg_dump(const char *name, const char *indent, xbt_cfg_t cfg)
void xbt_cfg_register_double(const char *name, double default_value,
xbt_cfg_cb_t cb_set, const char *desc)
{
- if (simgrid_config == NULL)
+ if (simgrid_config == nullptr)
simgrid_config = xbt_cfg_new();
simgrid_config->registerOption<double>(name, desc, default_value, cb_set);
}
void xbt_cfg_register_int(const char *name, int default_value,xbt_cfg_cb_t cb_set, const char *desc)
{
- if (simgrid_config == NULL)
+ if (simgrid_config == nullptr) {
simgrid_config = xbt_cfg_new();
+ atexit(&sg_config_finalize);
+ }
simgrid_config->registerOption<int>(name, desc, default_value, cb_set);
}
void xbt_cfg_register_string(const char *name, const char *default_value, xbt_cfg_cb_t cb_set, const char *desc)
{
- if (simgrid_config == NULL)
+ if (simgrid_config == nullptr) {
simgrid_config = xbt_cfg_new();
+ atexit(sg_config_finalize);
+ }
simgrid_config->registerOption<std::string>(name, desc,
default_value ? default_value : "", cb_set);
}
void xbt_cfg_register_boolean(const char *name, const char*default_value,xbt_cfg_cb_t cb_set, const char *desc)
{
- if (simgrid_config == NULL)
+ if (simgrid_config == nullptr) {
simgrid_config = xbt_cfg_new();
+ atexit(sg_config_finalize);
+ }
simgrid_config->registerOption<bool>(name, desc, simgrid::config::parseBool(default_value), cb_set);
}
void xbt_cfg_register_alias(const char *realname, const char *aliasname)
{
- if (simgrid_config == NULL)
+ if (simgrid_config == nullptr) {
simgrid_config = xbt_cfg_new();
+ atexit(sg_config_finalize);
+ }
simgrid_config->alias(realname, aliasname);
}
-void xbt_cfg_aliases(void) { simgrid_config->showAliases(); }
-void xbt_cfg_help(void) { simgrid_config->help(); }
+void xbt_cfg_aliases() { simgrid_config->showAliases(); }
+void xbt_cfg_help() { simgrid_config->help(); }
/*----[ Setting ]---------------------------------------------------------*/
}
if (option - name == len) {
XBT_DEBUG("Boundary=EOL");
- option = NULL; /* don't do next iteration */
+ option = nullptr; /* don't do next iteration */
} else {
XBT_DEBUG("Boundary on '%c'. len=%d;option-name=%ld", *option, len, (long) (option - name));
/* Pass the following blank chars */
option++;
}
if (option - name == len - 1)
- option = NULL; /* don't do next iteration */
+ option = nullptr; /* don't do next iteration */
}
XBT_DEBUG("parse now:'%s'; parse later:'%s'", name, option);
try {
(*simgrid_config)[name].setStringValue(val);
}
+ catch (simgrid::config::missing_key_error& e) {
+ goto on_missing_key;
+ }
catch (...) {
- THROWF(not_found_error, 0, "Could not set the value %s for %s", val, name);
+ goto on_exception;
}
}
free(optionlist_cpy);
+ return;
+
+on_missing_key:
+ free(optionlist_cpy);
+ THROWF(not_found_error, 0, "Could not set variables %s", options);
+ return;
+on_exception:
+ free(optionlist_cpy);
+ THROWF(unknown_error, 0, "Could not set variables %s", options);
+ return;
}
+// Horrible mess to translate C++ exceptions to C exceptions:
+// Exit from the catch blog (and do the correct exceptio cleaning)
+// before attempting to THROWF.
+#define TRANSLATE_EXCEPTIONS(...) \
+ catch(simgrid::config::missing_key_error& e) { THROWF(not_found_error, 0, __VA_ARGS__); abort(); } \
+ catch(...) { THROWF(not_found_error, 0, __VA_ARGS__); abort(); }
+
/** @brief Set the value of a variable, using the string representation of that value
*
* @param key name of the variable to modify
{
try {
(*simgrid_config)[key].setStringValue(value);
+ return;
}
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
- }
+ TRANSLATE_EXCEPTIONS("Could not set variable %s as string %s", key, value);
}
/** @brief Set an integer value to \a name within \a cfg if it wasn't changed yet
* This is useful to change the default value of a variable while allowing
* users to override it with command line arguments
*/
-void xbt_cfg_setdefault_int(const char *name, int val)
+void xbt_cfg_setdefault_int(const char *key, int value)
{
try {
- (*simgrid_config)[name].setDefaultValue<int>(val);
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ (*simgrid_config)[key].setDefaultValue<int>(value);
+ return;
}
+ TRANSLATE_EXCEPTIONS("Could not set variable %s to default integer %i",
+ key, value);
}
/** @brief Set an integer value to \a name within \a cfg if it wasn't changed yet
* This is useful to change the default value of a variable while allowing
* users to override it with command line arguments
*/
-void xbt_cfg_setdefault_double(const char *name, double val)
+void xbt_cfg_setdefault_double(const char *key, double value)
{
try {
- (*simgrid_config)[name].setDefaultValue<double>(val);
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ (*simgrid_config)[key].setDefaultValue<double>(value);
+ return;
}
+ TRANSLATE_EXCEPTIONS("Could not set variable %s to default double %f",
+ key, value);
}
/** @brief Set a string value to \a name within \a cfg if it wasn't changed yet
* This is useful to change the default value of a variable while allowing
* users to override it with command line arguments
*/
-void xbt_cfg_setdefault_string(const char *name, const char *val)
+void xbt_cfg_setdefault_string(const char *key, const char *value)
{
try {
- (*simgrid_config)[name].setDefaultValue<std::string>(val ? val : "");
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ (*simgrid_config)[key].setDefaultValue<std::string>(value ? value : "");
+ return;
}
+ TRANSLATE_EXCEPTIONS("Could not set variable %s to default string %s",
+ key, value);
}
/** @brief Set an boolean value to \a name within \a cfg if it wasn't changed yet
* This is useful to change the default value of a variable while allowing
* users to override it with command line arguments
*/
-void xbt_cfg_setdefault_boolean(const char *name, const char *val)
+void xbt_cfg_setdefault_boolean(const char *key, const char *value)
{
try {
- (*simgrid_config)[name].setDefaultValue<bool>(simgrid::config::parseBool(val));
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ (*simgrid_config)[key].setDefaultValue<bool>(simgrid::config::parseBool(value));
+ return;
}
+ TRANSLATE_EXCEPTIONS("Could not set variable %s to default boolean %s",
+ key, value);
}
/** @brief Set an integer value to \a name within \a cfg
*
- * @param name the name of the variable
- * @param val the value of the variable
+ * @param key the name of the variable
+ * @param value the value of the variable
*/
-void xbt_cfg_set_int(const char *name, int val)
+void xbt_cfg_set_int(const char *key, int value)
{
try {
- (*simgrid_config)[name].setValue<int>(val);
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ (*simgrid_config)[key].setValue<int>(value);
+ return;
}
+ TRANSLATE_EXCEPTIONS("Could not set variable %s to integer %i",
+ key, value);
}
/** @brief Set or add a double value to \a name within \a cfg
*
- * @param name the name of the variable
- * @param val the double to set
+ * @param key the name of the variable
+ * @param value the double to set
*/
-void xbt_cfg_set_double(const char *name, double val)
+void xbt_cfg_set_double(const char *key, double value)
{
try {
- (*simgrid_config)[name].setValue<double>(val);
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ (*simgrid_config)[key].setValue<double>(value);
+ return;
}
+ TRANSLATE_EXCEPTIONS("Could not set variable %s to double %f",
+ key, value);
}
/** @brief Set or add a string value to \a name within \a cfg
*
- * @param cfg the config set
- * @param name the name of the variable
- * @param val the value to be added
+ * @param key the name of the variable
+ * @param value the value to be added
*
*/
-void xbt_cfg_set_string(const char *name, const char *val)
+void xbt_cfg_set_string(const char *key, const char *value)
{
try {
- (*simgrid_config)[name].setValue<std::string>(val ? val : "");
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ (*simgrid_config)[key].setValue<std::string>(value ? value : "");
+ return;
}
+ TRANSLATE_EXCEPTIONS("Could not set variable %s to string %s",
+ key, value);
}
/** @brief Set or add a boolean value to \a name within \a cfg
*
- * @param name the name of the variable
- * @param val the value of the variable
+ * @param key the name of the variable
+ * @param value the value of the variable
*/
-void xbt_cfg_set_boolean(const char *name, const char *val)
+void xbt_cfg_set_boolean(const char *key, const char *value)
{
try {
- (*simgrid_config)[name].setValue<bool>(simgrid::config::parseBool(val));
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ (*simgrid_config)[key].setValue<bool>(simgrid::config::parseBool(value));
+ return;
}
+ TRANSLATE_EXCEPTIONS("Could not set variable %s to boolean %s",
+ key, value);
}
/* Say if the value is the default value */
-int xbt_cfg_is_default_value(const char *name)
+int xbt_cfg_is_default_value(const char *key)
{
try {
- return (*simgrid_config)[name].isDefault() ? 1 : 0;
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ return (*simgrid_config)[key].isDefault() ? 1 : 0;
}
+ TRANSLATE_EXCEPTIONS("Could not get variable %s", key);
}
/*----[ Getting ]---------------------------------------------------------*/
/** @brief Retrieve an integer value of a variable (get a warning if not uniq)
*
- * @param name the name of the variable
+ * @param key the name of the variable
*
* Returns the first value from the config set under the given name.
*/
-int xbt_cfg_get_int(const char *name)
+int xbt_cfg_get_int(const char *key)
{
try {
- return (*simgrid_config)[name].getValue<int>();
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ return (*simgrid_config)[key].getValue<int>();
}
+ TRANSLATE_EXCEPTIONS("Could not get variable %s", key);
}
/** @brief Retrieve a double value of a variable (get a warning if not uniq)
*
- * @param cfg the config set
- * @param name the name of the variable
+ * @param key the name of the variable
*
* Returns the first value from the config set under the given name.
*/
-double xbt_cfg_get_double(const char *name)
+double xbt_cfg_get_double(const char *key)
{
try {
- return (*simgrid_config)[name].getValue<double>();
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ return (*simgrid_config)[key].getValue<double>();
}
+ TRANSLATE_EXCEPTIONS("Could not get variable %s", key);
}
/** @brief Retrieve a string value of a variable (get a warning if not uniq)
*
- * @param cfg the config set
- * @param name the name of the variable
+ * @param key the name of the variable
*
* Returns the first value from the config set under the given name.
* If there is more than one value, it will issue a warning.
- * Returns NULL if there is no value.
+ * Returns nullptr if there is no value.
*
* \warning the returned value is the actual content of the config set
*/
-char *xbt_cfg_get_string(const char *name)
+char *xbt_cfg_get_string(const char *key)
{
try {
- return (char*) (*simgrid_config)[name].getValue<std::string>().c_str();
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ return (char*) (*simgrid_config)[key].getValue<std::string>().c_str();
}
+ TRANSLATE_EXCEPTIONS("Could not get variable %s", key);
}
/** @brief Retrieve a boolean value of a variable (get a warning if not uniq)
*
- * @param cfg the config set
- * @param name the name of the variable
+ * @param key the name of the variable
*
* Returns the first value from the config set under the given name.
* If there is more than one value, it will issue a warning.
*/
-int xbt_cfg_get_boolean(const char *name)
+int xbt_cfg_get_boolean(const char *key)
{
try {
- return (*simgrid_config)[name].getValue<bool>() ? 1 : 0;
- }
- catch (std::exception const& e) {
- THROWF(unknown_error, 0, "%s", e.what());
+ return (*simgrid_config)[key].getValue<bool>() ? 1 : 0;
}
+ TRANSLATE_EXCEPTIONS("Could not get variable %s", key);
}
#ifdef SIMGRID_TEST
#include "xbt.h"
#include "xbt/ex.h"
+#include <xbt/ex.hpp>
#include <xbt/config.hpp>
static void make_set()
{
- simgrid_config = NULL;
+ simgrid_config = nullptr;
xbt_log_threshold_set(&_XBT_LOGV(xbt_cfg), xbt_log_priority_critical);
- xbt_cfg_register_int("speed", 0, NULL, "");
- xbt_cfg_register_string("peername", "", NULL, "");
- xbt_cfg_register_string("user", "", NULL, "");
+ xbt_cfg_register_int("speed", 0, nullptr, "");
+ xbt_cfg_register_string("peername", "", nullptr, "");
+ xbt_cfg_register_string("user", "", nullptr, "");
} /* end_of_make_set */
XBT_TEST_UNIT("memuse", test_config_memuse, "Alloc and free a config set")
xbt_test_add("Access to a non-existant entry");
{
- xbt_ex_t e;
-
- TRY {
+ try {
xbt_cfg_set_parse("color:blue");
- } CATCH(e) {
+ } catch(xbt_ex& e) {
if (e.category != not_found_error)
xbt_test_exception(e);
- xbt_ex_free(e);
}
}
xbt_cfg_free(&simgrid_config);