* under the terms of the license (GNU LGPL) which comes with this package. */
#include "src/kernel/lmm/bmf.hpp"
-#include <eigen3/Eigen/LU>
+#include <Eigen/LU>
#include <iostream>
#include <numeric>
#include <sstream>
return true;
}
- int n_resources = A_.rows();
+ auto n_resources = A_.rows();
size_t idx = 0;
while (idx < alloc_.size()) {
- alloc_[idx] = (++alloc_[idx]) % n_resources;
+ alloc_[idx] = (alloc_[idx] + 1) % n_resources;
if (alloc_[idx] == 0) {
idx++;
continue;
/*****************************************************************************/
-BmfSolver::BmfSolver(Eigen::MatrixXd A, Eigen::MatrixXd maxA, Eigen::VectorXd C, Eigen::VectorXd phi)
- : A_(std::move(A)), maxA_(std::move(maxA)), C_(std::move(C)), phi_(std::move(phi)), gen_(A_)
+BmfSolver::BmfSolver(Eigen::MatrixXd A, Eigen::MatrixXd maxA, Eigen::VectorXd C, std::vector<bool> shared,
+ Eigen::VectorXd phi)
+ : A_(std::move(A))
+ , maxA_(std::move(maxA))
+ , C_(std::move(C))
+ , C_shared_(std::move(shared))
+ , phi_(std::move(phi))
+ , gen_(A_)
{
xbt_assert(max_iteration_ > 0,
"Invalid number of iterations for BMF solver. Please check your \"bmf/max-iterations\" configuration.");
+ xbt_assert(A_.cols() == maxA_.cols(), "Invalid number of cols in matrix A (%td) or maxA (%td)", A_.cols(),
+ maxA_.cols());
+ xbt_assert(A_.cols() == phi_.size(), "Invalid size of phi vector (%td)", phi_.size());
+ xbt_assert(static_cast<long>(C_shared_.size()) == C_.size(), "Invalid size param shared (%zu)", C_shared_.size());
}
template <typename T> std::string BmfSolver::debug_eigen(const T& obj) const
double BmfSolver::get_resource_capacity(int resource, const std::vector<int>& bounded_players) const
{
double capacity = C_[resource];
+ if (not C_shared_[resource])
+ return capacity;
+
for (int p : bounded_players) {
capacity -= A_(resource, p) * phi_[p];
}
- return capacity;
+ return std::max(0.0, capacity);
}
std::vector<int> BmfSolver::alloc_map_to_vector(const allocation_map_t& alloc) const
{
std::vector<int> alloc_by_player(A_.cols(), -1);
- for (auto it : alloc) {
+ for (const auto& it : alloc) {
for (auto p : it.second) {
alloc_by_player[p] = it.first;
}
return alloc_by_player;
}
+std::vector<int> BmfSolver::get_bounded_players(const allocation_map_t& alloc) const
+{
+ std::vector<int> bounded_players;
+ for (const auto& e : alloc) {
+ if (e.first == NO_RESOURCE) {
+ bounded_players.insert(bounded_players.end(), e.second.begin(), e.second.end());
+ }
+ }
+ return bounded_players;
+}
+
Eigen::VectorXd BmfSolver::equilibrium(const allocation_map_t& alloc) const
{
- int n_players = A_.cols();
+ auto n_players = A_.cols();
Eigen::MatrixXd A_p = Eigen::MatrixXd::Zero(n_players, n_players); // square matrix with number of players
Eigen::VectorXd C_p = Eigen::VectorXd::Zero(n_players);
- // iterate over alloc to verify if 2 players have chosen the same resource
- // if so, they must have a fair sharing of this resource, adjust A_p and C_p accordingly
- int last_row = n_players - 1;
- int first_row = 0;
- std::vector<int> bounded_players;
+ int row = 0;
+ auto bounded_players = get_bounded_players(alloc);
for (const auto& e : alloc) {
// add one row for the resource with A[r,]
int cur_resource = e.first;
- if (cur_resource == NO_RESOURCE) {
- bounded_players.insert(bounded_players.end(), e.second.begin(), e.second.end());
+ /* bounded players, nothing to do */
+ if (cur_resource == NO_RESOURCE)
+ continue;
+ /* not shared resource, each player can receive the full capacity of the resource */
+ if (not C_shared_[cur_resource]) {
+ for (int i : e.second) {
+ C_p[row] = get_resource_capacity(cur_resource, bounded_players);
+ A_p(row, i) = A_(cur_resource, i);
+ row++;
+ }
continue;
}
- A_p.row(first_row) = A_.row(cur_resource);
- C_p[first_row] = get_resource_capacity(cur_resource, bounded_players);
- first_row++;
+
+ /* shared resource: fairly share it between players */
+ A_p.row(row) = A_.row(cur_resource);
+ C_p[row] = get_resource_capacity(cur_resource, bounded_players);
+ row++;
if (e.second.size() > 1) {
+ // if 2 players have chosen the same resource
+ // they must have a fair sharing of this resource, adjust A_p and C_p accordingly
auto it = e.second.begin();
int i = *it; // first player
/* for each other player sharing this resource */
for (++it; it != e.second.end(); ++it) {
/* player i and k on this resource j: so maxA_ji*rho_i - maxA_jk*rho_k = 0 */
- int k = *it;
- C_p[last_row] = 0;
- A_p(last_row, i) = maxA_(cur_resource, i);
- A_p(last_row, k) = -maxA_(cur_resource, k);
- last_row--;
+ int k = *it;
+ C_p[row] = 0;
+ A_p(row, i) = maxA_(cur_resource, i);
+ A_p(row, k) = -maxA_(cur_resource, k);
+ row++;
}
}
}
continue;
double share = fair_sharing[cnst_idx] / A_(cnst_idx, player_idx);
- if (min_share == -1 || double_positive(min_share - share, sg_maxmin_precision)) {
+ if (min_share == -1 || share < min_share) {
selected_resource = cnst_idx;
min_share = share;
}
return true;
std::vector<int> alloc_by_player = alloc_map_to_vector(alloc);
-#if 0
- std::vector<int> last_alloc_by_player = alloc_map_to_vector(last_alloc);
- if (not initial) {
- std::for_each(allocations_age_.begin(), allocations_age_.end(), [](int& n) { n++; });
- std::vector<int> age_idx(allocations_age_.size());
- std::iota(age_idx.begin(), age_idx.end(), 0);
- std::stable_sort(age_idx.begin(), age_idx.end(),
- [this](auto a, auto b) { return this->allocations_age_[a] > this->allocations_age_[b]; });
- for (int p : age_idx) {
- if (alloc_by_player[p] != last_alloc_by_player[p]) {
- alloc = last_alloc;
- alloc[last_alloc_by_player[p]].erase(p);
- if (alloc[last_alloc_by_player[p]].empty())
- alloc.erase(last_alloc_by_player[p]);
- alloc[alloc_by_player[p]].insert(p);
- allocations_age_[p] = 0;
- }
- }
- alloc_by_player = alloc_map_to_vector(alloc);
- }
-#endif
auto ret = allocations_.insert(alloc_by_player);
/* oops, allocation already tried, let's pertube it a bit */
if (not ret.second) {
void BmfSolver::set_fair_sharing(const allocation_map_t& alloc, const Eigen::VectorXd& rho,
Eigen::VectorXd& fair_sharing) const
{
+ std::vector<int> bounded_players = get_bounded_players(alloc);
+
for (int r = 0; r < fair_sharing.size(); r++) {
auto it = alloc.find(r);
if (it != alloc.end()) { // resource selected by some player, fair share depends on rho
double consumption_r = A_.row(r) * rho;
double_update(&consumption_r, C_[r], sg_maxmin_precision);
if (consumption_r > 0.0) {
- int n_players = std::count_if(A_.row(r).data(), A_.row(r).data() + A_.row(r).size(),
- [](double v) { return double_positive(v, sg_maxmin_precision); });
+ auto n_players = (A_.row(r).array() > 0).count();
fair_sharing[r] = C_[r] / n_players;
} else {
- fair_sharing[r] = C_[r];
+ fair_sharing[r] = get_resource_capacity(r, bounded_players);
}
}
}
bool bmf = true;
// 1) the capacity of all resources is respected
+ Eigen::VectorXd shared(C_shared_.size());
+ for (int j = 0; j < shared.size(); j++)
+ shared[j] = C_shared_[j] ? 1.0 : 0.0;
+
Eigen::VectorXd remaining = (A_ * rho) - C_;
+ remaining = remaining.array() * shared.array(); // ignore non shared resources
bmf = bmf && (not std::any_of(remaining.data(), remaining.data() + remaining.size(),
[](double v) { return double_positive(v, sg_maxmin_precision); }));
Eigen::MatrixXi player_max_share =
((usage.array().colwise() - max_share.array()).abs() <= sg_maxmin_precision).cast<int>();
// but only saturated resources must be considered
- Eigen::VectorXi saturated = ((remaining.array().abs() <= sg_maxmin_precision)).cast<int>();
+ Eigen::VectorXi saturated = (remaining.array().abs() <= sg_maxmin_precision).cast<int>();
XBT_DEBUG("Saturated_j resources:\n%s", debug_eigen(saturated).c_str());
player_max_share.array().colwise() *= saturated.array();
XBT_DEBUG("Player_ji usage of saturated resources:\n%s", debug_eigen(player_max_share).c_str());
// for all columns(players) it has to be the max at least in 1
- bmf = bmf && (player_max_share.colwise().sum().all() >= 1);
+ bmf = bmf && (player_max_share.colwise().sum().array() >= 1).all();
return bmf;
}
auto fair_sharing = C_;
/* BMF allocation for each player (current and last one) stop when are equal */
- allocation_map_t last_alloc, cur_alloc;
+ allocation_map_t last_alloc;
+ allocation_map_t cur_alloc;
Eigen::VectorXd rho;
while (it < max_iteration_ && not get_alloc(fair_sharing, last_alloc, cur_alloc, it == 0)) {
fprintf(stderr, "A:\n%s\n", debug_eigen(A_).c_str());
fprintf(stderr, "maxA:\n%s\n", debug_eigen(maxA_).c_str());
fprintf(stderr, "C:\n%s\n", debug_eigen(C_).c_str());
+ fprintf(stderr, "C_shared:\n%s\n", debug_vector(C_shared_).c_str());
+ fprintf(stderr, "phi:\n%s\n", debug_eigen(phi_).c_str());
fprintf(stderr, "rho:\n%s\n", debug_eigen(rho).c_str());
xbt_abort();
}
/*****************************************************************************/
-void BmfSystem::get_flows_data(Eigen::MatrixXd& A, Eigen::MatrixXd& maxA, Eigen::VectorXd& phi)
+void BmfSystem::get_flows_data(Eigen::Index number_cnsts, Eigen::MatrixXd& A, Eigen::MatrixXd& maxA,
+ Eigen::VectorXd& phi)
{
- A.resize(active_constraint_set.size(), variable_set.size());
+ A.resize(number_cnsts, variable_set.size());
A.setZero();
- maxA.resize(active_constraint_set.size(), variable_set.size());
+ maxA.resize(number_cnsts, variable_set.size());
maxA.setZero();
phi.resize(variable_set.size());
if (var.sharing_penalty_ <= 0)
continue;
bool active = false;
- var.value_ = 1; // assign something by default for tasks with 0 consumption
+ bool linked = false; // variable is linked to some constraint (specially for selective_update)
for (const Element& elem : var.cnsts_) {
+ const boost::intrusive::list_member_hook<>& cnst_hook = selective_update_active
+ ? elem.constraint->modified_constraint_set_hook_
+ : elem.constraint->active_constraint_set_hook_;
+ if (not cnst_hook.is_linked())
+ continue;
+ /* active and linked variable, lets check its consumption */
+ linked = true;
double consumption = elem.consumption_weight;
if (consumption > 0) {
- int cnst_idx = cnst2idx_[elem.constraint];
- A(cnst_idx, var_idx) = consumption;
- maxA(cnst_idx, var_idx) = elem.max_consumption_weight;
+ int cnst_idx = cnst2idx_[elem.constraint];
+ A(cnst_idx, var_idx) += consumption;
+ // a variable with double penalty must receive half share, so it max weight is greater
+ maxA(cnst_idx, var_idx) = std::max(maxA(cnst_idx, var_idx), elem.max_consumption_weight * var.sharing_penalty_);
active = true;
}
}
+ /* skip variables not linked to any modified or active constraint */
+ if (not linked)
+ continue;
if (active) {
- phi[var_idx] = var.get_bound();
+ phi[var_idx] = var.get_bound();
idx2Var_[var_idx] = &var;
var_idx++;
+ } else {
+ var.value_ = 1; // assign something by default for tasks with 0 consumption
}
}
// resize matrix to active variables only
phi.conservativeResize(var_idx);
}
-void BmfSystem::get_constraint_data(Eigen::VectorXd& C)
+template <class CnstList>
+void BmfSystem::get_constraint_data(const CnstList& cnst_list, Eigen::VectorXd& C, std::vector<bool>& shared)
{
- C.resize(active_constraint_set.size());
+ C.resize(cnst_list.size());
+ shared.resize(cnst_list.size());
cnst2idx_.clear();
int cnst_idx = 0;
- for (const Constraint& cnst : active_constraint_set) {
+ for (const Constraint& cnst : cnst_list) {
C(cnst_idx) = cnst.bound_;
+ if (cnst.get_sharing_policy() == Constraint::SharingPolicy::NONLINEAR && cnst.dyn_constraint_cb_) {
+ C(cnst_idx) = cnst.dyn_constraint_cb_(cnst.bound_, cnst.concurrency_current_);
+ if (not warned_nonlinear_) {
+ XBT_WARN("You are using dynamic constraint bound with parallel tasks and BMF model."
+ " The BMF solver assumes that all flows (and subflows) are always active and executing."
+ " This is quite pessimist, specially considering parallel tasks with small subflows."
+ " Analyze your results with caution.");
+ warned_nonlinear_ = true;
+ }
+ }
cnst2idx_[&cnst] = cnst_idx;
+ // FATPIPE links aren't really shared
+ shared[cnst_idx] = (cnst.sharing_policy_ != Constraint::SharingPolicy::FATPIPE);
cnst_idx++;
}
}
-void BmfSystem::bmf_solve()
+void BmfSystem::solve()
{
- if (not modified_)
- return;
+ if (modified_) {
+ if (selective_update_active)
+ bmf_solve(modified_constraint_set);
+ else
+ bmf_solve(active_constraint_set);
+ }
+}
+template <class CnstList> void BmfSystem::bmf_solve(const CnstList& cnst_list)
+{
/* initialize players' weight and constraint matrices */
idx2Var_.clear();
cnst2idx_.clear();
- Eigen::MatrixXd A, maxA;
- Eigen::VectorXd C, bounds;
- get_constraint_data(C);
- get_flows_data(A, maxA, bounds);
-
- auto solver = BmfSolver(A, maxA, C, bounds);
+ Eigen::MatrixXd A;
+ Eigen::MatrixXd maxA;
+ Eigen::VectorXd C;
+ Eigen::VectorXd bounds;
+ std::vector<bool> shared;
+ get_constraint_data(cnst_list, C, shared);
+ get_flows_data(C.size(), A, maxA, bounds);
+
+ auto solver = BmfSolver(std::move(A), std::move(maxA), std::move(C), std::move(shared), std::move(bounds));
auto rho = solver.solve();
if (rho.size() == 0)
} // namespace lmm
} // namespace kernel
-} // namespace simgrid
\ No newline at end of file
+} // namespace simgrid
