X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/08ddd90ede6ae87880ab6aefe213001b224de841..5e7d79b763a5f55d1afb579d2b5a8d30ccfe869c:/src/kernel/resource/Action.cpp

diff --git a/src/kernel/resource/Action.cpp b/src/kernel/resource/Action.cpp
index 8559cca8db..b21dbbade1 100644
--- a/src/kernel/resource/Action.cpp
+++ b/src/kernel/resource/Action.cpp
@@ -20,14 +20,14 @@ Action::Action(simgrid::kernel::resource::Model* model, double cost, bool failed
 }
 
 Action::Action(simgrid::kernel::resource::Model* model, double cost, bool failed, kernel::lmm::Variable* var)
-    : remains_(cost), start_(surf_get_clock()), cost_(cost), model_(model), variable_(var)
+    : remains_(cost), start_time_(surf_get_clock()), cost_(cost), model_(model), variable_(var)
 {
   if (failed)
-    stateSet_ = getModel()->getFailedActionSet();
+    state_set_ = get_model()->getFailedActionSet();
   else
-    stateSet_ = getModel()->getRunningActionSet();
+    state_set_ = get_model()->getRunningActionSet();
 
-  stateSet_->push_back(*this);
+  state_set_->push_back(*this);
 }
 
 Action::~Action()
@@ -37,64 +37,65 @@ Action::~Action()
 
 void Action::finish(Action::State state)
 {
-  finishTime_ = surf_get_clock();
-  setState(state);
+  finish_time_ = surf_get_clock();
+  set_state(state);
+  set_remains(0);
 }
 
-Action::State Action::getState() const
+Action::State Action::get_state() const
 {
-  if (stateSet_ == model_->getReadyActionSet())
+  if (state_set_ == model_->getReadyActionSet())
     return Action::State::ready;
-  if (stateSet_ == model_->getRunningActionSet())
+  if (state_set_ == model_->getRunningActionSet())
     return Action::State::running;
-  if (stateSet_ == model_->getFailedActionSet())
+  if (state_set_ == model_->getFailedActionSet())
     return Action::State::failed;
-  if (stateSet_ == model_->getDoneActionSet())
+  if (state_set_ == model_->getDoneActionSet())
     return Action::State::done;
   return Action::State::not_in_the_system;
 }
 
-void Action::setState(Action::State state)
+void Action::set_state(Action::State state)
 {
-  simgrid::xbt::intrusive_erase(*stateSet_, *this);
+  simgrid::xbt::intrusive_erase(*state_set_, *this);
   switch (state) {
     case Action::State::ready:
-      stateSet_ = model_->getReadyActionSet();
+      state_set_ = model_->getReadyActionSet();
       break;
     case Action::State::running:
-      stateSet_ = model_->getRunningActionSet();
+      state_set_ = model_->getRunningActionSet();
       break;
     case Action::State::failed:
-      stateSet_ = model_->getFailedActionSet();
+      state_set_ = model_->getFailedActionSet();
       break;
     case Action::State::done:
-      stateSet_ = model_->getDoneActionSet();
+      state_set_ = model_->getDoneActionSet();
       break;
     default:
-      stateSet_ = nullptr;
+      state_set_ = nullptr;
       break;
   }
-  if (stateSet_)
-    stateSet_->push_back(*this);
+  if (state_set_)
+    state_set_->push_back(*this);
 }
 
-double Action::getBound() const
+double Action::get_bound() const
 {
   return variable_ ? variable_->get_bound() : 0;
 }
 
-void Action::setBound(double bound)
+void Action::set_bound(double bound)
 {
   XBT_IN("(%p,%g)", this, bound);
   if (variable_)
-    getModel()->getMaxminSystem()->update_variable_bound(variable_, bound);
+    get_model()->getMaxminSystem()->update_variable_bound(variable_, bound);
 
-  if (getModel()->getUpdateMechanism() == UM_LAZY && getLastUpdate() != surf_get_clock())
-    heapRemove(getModel()->getActionHeap());
+  if (get_model()->getUpdateMechanism() == UM_LAZY && getLastUpdate() != surf_get_clock())
+    heapRemove(get_model()->getActionHeap());
   XBT_OUT();
 }
 
-void Action::setCategory(const char* category)
+void Action::set_category(const char* category)
 {
   category_ = xbt_strdup(category);
 }
@@ -104,31 +105,31 @@ void Action::ref()
   refcount_++;
 }
 
-void Action::setMaxDuration(double duration)
+void Action::set_max_duration(double duration)
 {
-  maxDuration_ = duration;
-  if (getModel()->getUpdateMechanism() == UM_LAZY) // remove action from the heap
-    heapRemove(getModel()->getActionHeap());
+  max_duration_ = duration;
+  if (get_model()->getUpdateMechanism() == UM_LAZY) // remove action from the heap
+    heapRemove(get_model()->getActionHeap());
 }
 
-void Action::setSharingWeight(double weight)
+void Action::set_priority(double weight)
 {
   XBT_IN("(%p,%g)", this, weight);
-  sharingWeight_ = weight;
-  getModel()->getMaxminSystem()->update_variable_weight(getVariable(), weight);
+  sharing_priority_ = weight;
+  get_model()->getMaxminSystem()->update_variable_weight(getVariable(), weight);
 
-  if (getModel()->getUpdateMechanism() == UM_LAZY)
-    heapRemove(getModel()->getActionHeap());
+  if (get_model()->getUpdateMechanism() == UM_LAZY)
+    heapRemove(get_model()->getActionHeap());
   XBT_OUT();
 }
 
 void Action::cancel()
 {
-  setState(Action::State::failed);
-  if (getModel()->getUpdateMechanism() == UM_LAZY) {
-    if (modifiedSetHook_.is_linked())
-      simgrid::xbt::intrusive_erase(*getModel()->getModifiedSet(), *this);
-    heapRemove(getModel()->getActionHeap());
+  set_state(Action::State::failed);
+  if (get_model()->getUpdateMechanism() == UM_LAZY) {
+    if (modified_set_hook_.is_linked())
+      simgrid::xbt::intrusive_erase(*get_model()->getModifiedSet(), *this);
+    heapRemove(get_model()->getActionHeap());
   }
 }
 
@@ -136,15 +137,15 @@ int Action::unref()
 {
   refcount_--;
   if (not refcount_) {
-    if (stateSetHook_.is_linked())
-      simgrid::xbt::intrusive_erase(*stateSet_, *this);
+    if (state_set_hook_.is_linked())
+      simgrid::xbt::intrusive_erase(*state_set_, *this);
     if (getVariable())
-      getModel()->getMaxminSystem()->variable_free(getVariable());
-    if (getModel()->getUpdateMechanism() == UM_LAZY) {
+      get_model()->getMaxminSystem()->variable_free(getVariable());
+    if (get_model()->getUpdateMechanism() == UM_LAZY) {
       /* remove from heap */
-      heapRemove(getModel()->getActionHeap());
-      if (modifiedSetHook_.is_linked())
-        simgrid::xbt::intrusive_erase(*getModel()->getModifiedSet(), *this);
+      heapRemove(get_model()->getActionHeap());
+      if (modified_set_hook_.is_linked())
+        simgrid::xbt::intrusive_erase(*get_model()->getModifiedSet(), *this);
     }
     delete this;
     return 1;
@@ -156,11 +157,11 @@ void Action::suspend()
 {
   XBT_IN("(%p)", this);
   if (suspended_ != SuspendStates::sleeping) {
-    getModel()->getMaxminSystem()->update_variable_weight(getVariable(), 0.0);
-    if (getModel()->getUpdateMechanism() == UM_LAZY) {
-      heapRemove(getModel()->getActionHeap());
-      if (getModel()->getUpdateMechanism() == UM_LAZY && stateSet_ == getModel()->getRunningActionSet() &&
-          sharingWeight_ > 0) {
+    get_model()->getMaxminSystem()->update_variable_weight(getVariable(), 0.0);
+    if (get_model()->getUpdateMechanism() == UM_LAZY) {
+      heapRemove(get_model()->getActionHeap());
+      if (get_model()->getUpdateMechanism() == UM_LAZY && state_set_ == get_model()->getRunningActionSet() &&
+          sharing_priority_ > 0) {
         // If we have a lazy model, we need to update the remaining value accordingly
         updateRemainingLazy(surf_get_clock());
       }
@@ -174,10 +175,10 @@ void Action::resume()
 {
   XBT_IN("(%p)", this);
   if (suspended_ != SuspendStates::sleeping) {
-    getModel()->getMaxminSystem()->update_variable_weight(getVariable(), getPriority());
+    get_model()->getMaxminSystem()->update_variable_weight(getVariable(), get_priority());
     suspended_ = SuspendStates::not_suspended;
-    if (getModel()->getUpdateMechanism() == UM_LAZY)
-      heapRemove(getModel()->getActionHeap());
+    if (get_model()->getUpdateMechanism() == UM_LAZY)
+      heapRemove(get_model()->getActionHeap());
   }
   XBT_OUT();
 }
@@ -196,14 +197,14 @@ bool Action::isSuspended()
 void Action::heapInsert(heap_type& heap, double key, Action::Type hat)
 {
   type_       = hat;
-  heapHandle_ = heap.emplace(std::make_pair(key, this));
+  heap_handle_ = heap.emplace(std::make_pair(key, this));
 }
 
 void Action::heapRemove(heap_type& heap)
 {
   type_ = Action::Type::NOTSET;
-  if (heapHandle_) {
-    heap.erase(*heapHandle_);
+  if (heap_handle_) {
+    heap.erase(*heap_handle_);
     clearHeapHandle();
   }
 }
@@ -211,35 +212,35 @@ void Action::heapRemove(heap_type& heap)
 void Action::heapUpdate(heap_type& heap, double key, Action::Type hat)
 {
   type_ = hat;
-  if (heapHandle_) {
-    heap.update(*heapHandle_, std::make_pair(key, this));
+  if (heap_handle_) {
+    heap.update(*heap_handle_, std::make_pair(key, this));
   } else {
-    heapHandle_ = heap.emplace(std::make_pair(key, this));
+    heap_handle_ = heap.emplace(std::make_pair(key, this));
   }
 }
 
-double Action::getRemains()
+double Action::get_remains()
 {
   XBT_IN("(%p)", this);
   /* update remains before return it */
-  if (getModel()->getUpdateMechanism() == UM_LAZY) /* update remains before return it */
+  if (get_model()->getUpdateMechanism() == UM_LAZY) /* update remains before return it */
     updateRemainingLazy(surf_get_clock());
   XBT_OUT();
   return remains_;
 }
 
-void Action::updateMaxDuration(double delta)
+void Action::update_max_duration(double delta)
 {
-  double_update(&maxDuration_, delta, sg_surf_precision);
+  double_update(&max_duration_, delta, sg_surf_precision);
 }
-void Action::updateRemains(double delta)
+void Action::update_remains(double delta)
 {
   double_update(&remains_, delta, sg_maxmin_precision * sg_surf_precision);
 }
 
 void Action::refreshLastUpdate()
 {
-  lastUpdate_ = surf_get_clock();
+  last_update_ = surf_get_clock();
 }
 
 } // namespace surf