X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/2f32ccb82b474b69e3100f139e0b602d67ea5f63..58bb531bcf303874a5e1356c750423a8490617e9:/src/simix/ActorImpl.hpp diff --git a/src/simix/ActorImpl.hpp b/src/simix/ActorImpl.hpp index acb80de17d..684b322919 100644 --- a/src/simix/ActorImpl.hpp +++ b/src/simix/ActorImpl.hpp @@ -62,22 +62,22 @@ private: std::atomic_int_fast32_t refcount_{0}; public: - friend void intrusive_ptr_add_ref(ActorImpl* process) + friend void intrusive_ptr_add_ref(ActorImpl* actor) { // std::memory_order_relaxed ought to be enough here instead of std::memory_order_seq_cst // But then, we have a threading issue when an actor commits a suicide: // it seems that in this case, the worker thread kills the last occurrence of the actor // while usually, the maestro does so. FIXME: we should change how actors suicide - process->refcount_.fetch_add(1, std::memory_order_seq_cst); + actor->refcount_.fetch_add(1, std::memory_order_seq_cst); } - friend void intrusive_ptr_release(ActorImpl* process) + friend void intrusive_ptr_release(ActorImpl* actor) { // inspired from http://www.boost.org/doc/libs/1_55_0/doc/html/atomic/usage_examples.html - if (process->refcount_.fetch_sub(1, std::memory_order_release) == 1) { + if (actor->refcount_.fetch_sub(1, std::memory_order_release) == 1) { // Make sure that any changes done on other threads before their acquire are committed before our delete // http://stackoverflow.com/questions/27751025/why-is-an-acquire-barrier-needed-before-deleting-the-data-in-an-atomically-refer std::atomic_thread_fence(std::memory_order_acquire); - delete process; + delete actor; } } @@ -95,6 +95,8 @@ public: static ActorImplPtr create(std::string name, simix::ActorCode code, void* data, s4u::Host* host, std::unordered_map* properties, smx_actor_t parent_actor); void exit(); + void kill(smx_actor_t actor); + void kill_all(); void daemonize(); bool is_daemon() { return daemon_; } /** Whether this actor has been daemonized */ @@ -102,6 +104,7 @@ public: simgrid::s4u::Actor* restart(); smx_activity_t suspend(ActorImpl* issuer); void resume(); + smx_activity_t join(smx_actor_t actor, double timeout); smx_activity_t sleep(double duration); void set_user_data(void* data) { userdata_ = data; } void* get_user_data() { return userdata_; } @@ -160,8 +163,6 @@ XBT_PUBLIC void create_maestro(std::function code); typedef simgrid::kernel::actor::ActorImpl* smx_actor_t; XBT_PRIVATE void SIMIX_process_runall(); -XBT_PRIVATE void SIMIX_process_kill(smx_actor_t process, smx_actor_t issuer); -XBT_PRIVATE void SIMIX_process_killall(smx_actor_t issuer); XBT_PRIVATE void SIMIX_process_cleanup(smx_actor_t arg); XBT_PRIVATE void SIMIX_process_empty_trash(); XBT_PRIVATE void SIMIX_process_yield(smx_actor_t self); @@ -169,6 +170,5 @@ XBT_PRIVATE void SIMIX_process_yield(smx_actor_t self); extern void (*SMPI_switch_data_segment)(simgrid::s4u::ActorPtr actor); XBT_PRIVATE void SIMIX_process_sleep_destroy(smx_activity_t synchro); -XBT_PRIVATE smx_activity_t SIMIX_process_join(smx_actor_t issuer, smx_actor_t process, double timeout); #endif