X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/33adf3c6e189e468c9a55f1f7bc7d891b0700e1a..d89ca681772fdaafdd69049d4d66676a4e98de38:/src/kernel/actor/SimcallObserver.cpp diff --git a/src/kernel/actor/SimcallObserver.cpp b/src/kernel/actor/SimcallObserver.cpp index 8ecb3ee221..8d13441662 100644 --- a/src/kernel/actor/SimcallObserver.cpp +++ b/src/kernel/actor/SimcallObserver.cpp @@ -1,12 +1,14 @@ -/* Copyright (c) 2019-2021. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2019-2022. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ #include "src/kernel/actor/SimcallObserver.hpp" #include "simgrid/s4u/Host.hpp" +#include "src/kernel/activity/CommImpl.hpp" #include "src/kernel/activity/MutexImpl.hpp" #include "src/kernel/actor/ActorImpl.hpp" +#include "src/mc/mc_config.hpp" XBT_LOG_NEW_DEFAULT_SUBCATEGORY(mc_observer, mc, "Logging specific to MC simcall observation"); @@ -52,10 +54,10 @@ std::string SimcallObserver::to_string(int /*times_considered*/) const issuer_->get_cname()); } -std::string SimcallObserver::dot_label() const +std::string SimcallObserver::dot_label(int /*times_considered*/) const { if (issuer_->get_host()) - return xbt::string_printf("[(%ld)%s] ", issuer_->get_pid(), issuer_->get_cname()); + return xbt::string_printf("[(%ld)%s] ", issuer_->get_pid(), issuer_->get_host()->get_cname()); return xbt::string_printf("[(%ld)] ", issuer_->get_pid()); } @@ -64,9 +66,9 @@ std::string RandomSimcall::to_string(int times_considered) const return SimcallObserver::to_string(times_considered) + "MC_RANDOM(" + std::to_string(times_considered) + ")"; } -std::string RandomSimcall::dot_label() const +std::string RandomSimcall::dot_label(int times_considered) const { - return SimcallObserver::dot_label() + "MC_RANDOM(" + std::to_string(next_value_) + ")"; + return SimcallObserver::dot_label(times_considered) + "MC_RANDOM(" + std::to_string(next_value_) + ")"; } void RandomSimcall::prepare(int times_considered) @@ -85,9 +87,9 @@ std::string MutexUnlockSimcall::to_string(int times_considered) const return SimcallObserver::to_string(times_considered) + "Mutex UNLOCK"; } -std::string MutexUnlockSimcall::dot_label() const +std::string MutexUnlockSimcall::dot_label(int times_considered) const { - return SimcallObserver::dot_label() + "Mutex UNLOCK"; + return SimcallObserver::dot_label(times_considered) + "Mutex UNLOCK"; } std::string MutexLockSimcall::to_string(int times_considered) const @@ -100,9 +102,9 @@ std::string MutexLockSimcall::to_string(int times_considered) const return res; } -std::string MutexLockSimcall::dot_label() const +std::string MutexLockSimcall::dot_label(int times_considered) const { - return SimcallObserver::dot_label() + (blocking_ ? "Mutex LOCK" : "Mutex TRYLOCK"); + return SimcallObserver::dot_label(times_considered) + (blocking_ ? "Mutex LOCK" : "Mutex TRYLOCK"); } bool MutexLockSimcall::is_enabled() const @@ -117,9 +119,9 @@ std::string ConditionWaitSimcall::to_string(int times_considered) const return res; } -std::string ConditionWaitSimcall::dot_label() const +std::string ConditionWaitSimcall::dot_label(int times_considered) const { - return SimcallObserver::dot_label() + "Condition WAIT"; + return SimcallObserver::dot_label(times_considered) + "Condition WAIT"; } bool ConditionWaitSimcall::is_enabled() const @@ -139,9 +141,9 @@ std::string SemAcquireSimcall::to_string(int times_considered) const return res; } -std::string SemAcquireSimcall::dot_label() const +std::string SemAcquireSimcall::dot_label(int times_considered) const { - return SimcallObserver::dot_label() + "Sem ACQUIRE"; + return SimcallObserver::dot_label(times_considered) + "Sem ACQUIRE"; } bool SemAcquireSimcall::is_enabled() const @@ -154,28 +156,367 @@ bool SemAcquireSimcall::is_enabled() const return true; } -std::string ExecutionWaitanySimcall::to_string(int times_considered) const +int ActivityTestanySimcall::get_max_consider() const { - std::string res = SimcallObserver::to_string(times_considered) + "Execution WAITANY"; - res += "(" + (timeout_ == -1.0 ? "" : std::to_string(timeout_)) + ")"; + // Only Comms are of interest to MC for now. When all types of activities can be consider, this function can simply + // return the size of activities_. + int count = 0; + for (const auto& act : activities_) + if (dynamic_cast(act) != nullptr) + count++; + return count; +} + +void ActivityTestanySimcall::prepare(int times_considered) +{ + next_value_ = times_considered; +} + +std::string ActivityTestanySimcall::to_string(int times_considered) const +{ + std::string res = SimcallObserver::to_string(times_considered); + if (times_considered == -1) { + res += "TestAny FALSE(-)"; + } else { + res += "TestAny(" + xbt::string_printf("(%d of %zu)", times_considered + 1, activities_.size()); + } + return res; } -std::string ExecutionWaitanySimcall::dot_label() const +std::string ActivityTestanySimcall::dot_label(int times_considered) const { - return SimcallObserver::dot_label() + "Execution WAITANY"; + std::string res = SimcallObserver::dot_label(times_considered) + "TestAny "; + if (times_considered == -1) { + res += "FALSE"; + } else { + res += xbt::string_printf("TRUE [%d of %zu]", times_considered + 1, activities_.size()); + } + return res; } -std::string IoWaitanySimcall::to_string(int times_considered) const +bool ActivityTestSimcall::depends(SimcallObserver* other) { - std::string res = SimcallObserver::to_string(times_considered) + "I/O WAITANY"; - res += "(" + (timeout_ == -1.0 ? "" : std::to_string(timeout_)) + ")"; + if (get_issuer() == other->get_issuer()) + return false; + + if (dynamic_cast(other)) + return true; + + auto* comm1 = dynamic_cast(activity_); + if (comm1 == nullptr) + return false; + + if (dynamic_cast(other) != nullptr && + (comm1->src_actor_.get() == nullptr || comm1->dst_actor_.get() == nullptr)) + return false; + + if (comm1->src_buff_ == nullptr || comm1->dst_buff_ == nullptr) + return false; + + if (auto* test = dynamic_cast(other)) { + auto* comm2 = dynamic_cast(test->get_activity()); + if (comm2 == nullptr) + return false; + else if (comm2->src_buff_ == nullptr || comm2->dst_buff_ == nullptr) + return false; + } + + if (auto* wait = dynamic_cast(other)) { + auto* comm2 = dynamic_cast(wait->get_activity()); + if (comm2 == nullptr) + return false; + if (comm1->src_buff_ == comm2->src_buff_ && comm1->dst_buff_ == comm2->dst_buff_) + return false; + if (comm1->src_buff_ != nullptr && comm1->dst_buff_ != nullptr && comm2->src_buff_ != nullptr && + comm2->dst_buff_ != nullptr && comm1->dst_buff_ != comm2->src_buff_ && comm1->dst_buff_ != comm2->dst_buff_ && + comm2->dst_buff_ != comm1->src_buff_) + return false; + } + + return true; +} + +std::string ActivityTestSimcall::to_string(int times_considered) const +{ + std::string res = SimcallObserver::to_string(times_considered) + "Test "; + auto* comm = dynamic_cast(activity_); + if (comm) { + if (comm->src_actor_.get() == nullptr || comm->dst_actor_.get() == nullptr) { + res += "FALSE(comm="; + res += XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf("%p)", comm) + : "(verbose only))"; + } else { + res += "TRUE(comm="; + + auto src = comm->src_actor_; + auto dst = comm->dst_actor_; + res += + XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf("%p", comm) : "(verbose only) "; + res += xbt::string_printf("[(%ld)%s (%s) ", src->get_pid(), src->get_host()->get_cname(), src->get_cname()) + + "-> " + + xbt::string_printf("(%ld)%s (%s)])", dst->get_pid(), dst->get_host()->get_cname(), dst->get_cname()); + } + } else + xbt_die("Only Comms are supported here for now"); return res; } -std::string IoWaitanySimcall::dot_label() const +std::string ActivityTestSimcall::dot_label(int times_considered) const { - return SimcallObserver::dot_label() + "I/O WAITANY"; + std::string res = SimcallObserver::dot_label(times_considered) + "Test "; + auto* comm = dynamic_cast(activity_); + if (comm && (comm->src_actor_.get() == nullptr || comm->dst_actor_.get() == nullptr)) { + res += "FALSE"; + } else { + res += "TRUE"; + } + return res; +} + +bool ActivityWaitSimcall::is_enabled() const +{ + /* FIXME: check also that src and dst processes are not suspended */ + const auto* comm = dynamic_cast(activity_); + if (comm == nullptr) + xbt_die("Only Comms are supported here for now"); + + if (comm->src_timeout_ || comm->dst_timeout_) { + /* If it has a timeout it will be always be enabled (regardless of who declared the timeout), + * because even if the communication is not ready, it can timeout and won't block. */ + if (_sg_mc_timeout == 1) + return true; + } + /* On the other hand if it hasn't a timeout, check if the comm is ready.*/ + else if (comm->detached() && comm->src_actor_ == nullptr && comm->get_state() == activity::State::READY) + return (comm->dst_actor_ != nullptr); + return (comm->src_actor_ && comm->dst_actor_); +} + +bool ActivityWaitSimcall::depends(SimcallObserver* other) +{ + if (get_issuer() == other->get_issuer()) + return false; + + /* Timeouts in wait transitions are not considered by the independence theorem, thus assumed dependent */ + if (auto* wait = dynamic_cast(other)) { + if (timeout_ > 0 || wait->get_timeout() > 0) + return true; + auto* comm1 = dynamic_cast(activity_); + auto* comm2 = dynamic_cast(wait->get_activity()); + + if (comm1 == nullptr || comm2 == nullptr) // One wait at least in not on a Comm + return true; + + if (comm1->src_buff_ == comm2->src_buff_ && comm1->dst_buff_ == comm2->dst_buff_) + return false; + if (comm1->src_buff_ != nullptr && comm1->dst_buff_ != nullptr && comm2->src_buff_ != nullptr && + comm2->dst_buff_ != nullptr && comm1->dst_buff_ != comm2->src_buff_ && comm1->dst_buff_ != comm2->dst_buff_ && + comm2->dst_buff_ != comm1->src_buff_) + return false; + } + + return true; +} + +std::string ActivityWaitSimcall::to_string(int times_considered) const +{ + std::string res = SimcallObserver::to_string(times_considered); + auto* comm = dynamic_cast(activity_); + if (comm == nullptr) { + res += "ActivityWait on non-Comm (FIXME)"; // FIXME + return res; + } + + if (times_considered == -1) { + res += "WaitTimeout(comm=" + (XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) + ? xbt::string_printf("%p)", comm) + : "(verbose only))"); + } else { + res += "Wait(comm="; + + auto src = comm->src_actor_; + auto dst = comm->dst_actor_; + res += + XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf("%p", comm) : "(verbose only) "; + res += xbt::string_printf("[(%ld)%s (%s) ", src->get_pid(), src->get_host()->get_cname(), src->get_cname()) + + "-> " + xbt::string_printf("(%ld)%s (%s)])", dst->get_pid(), dst->get_host()->get_cname(), dst->get_cname()); + } + return res; +} + +std::string ActivityWaitSimcall::dot_label(int times_considered) const +{ + std::string res = SimcallObserver::dot_label(times_considered); + res += (times_considered == -1) ? "WaitTimeout " : "Wait "; + + auto* comm = dynamic_cast(activity_); + if (comm) { + auto src = comm->src_actor_; + auto dst = comm->dst_actor_; + res += " [(" + std::to_string(src ? src->get_pid() : 0) + ")"; + res += "->(" + std::to_string(dst ? dst->get_pid() : 0) + ")]"; + } else + xbt_die("Only Comms are supported here for now"); + return res; +} + +std::string ActivityWaitanySimcall::dot_label(int times_considered) const +{ + return SimcallObserver::dot_label(times_considered) + + xbt::string_printf("WaitAny [%d of %zu]", times_considered + 1, activities_.size()); +} + +bool ActivityWaitanySimcall::is_enabled() const +{ + // FIXME: deal with other kind of activities (Exec and I/Os) + // FIXME: Can be factored with ActivityWaitSimcall::is_enabled() + const auto* comm = dynamic_cast(activities_[next_value_]); + if (comm == nullptr) + xbt_die("Only Comms are supported here for now"); + if (comm->src_timeout_ || comm->dst_timeout_) { + /* If it has a timeout it will be always be enabled (regardless of who declared the timeout), + * because even if the communication is not ready, it can timeout and won't block. */ + if (_sg_mc_timeout == 1) + return true; + } + /* On the other hand if it hasn't a timeout, check if the comm is ready.*/ + else if (comm->detached() && comm->src_actor_ == nullptr && comm->get_state() == activity::State::READY) + return (comm->dst_actor_ != nullptr); + return (comm->src_actor_ && comm->dst_actor_); +} + +int ActivityWaitanySimcall::get_max_consider() const +{ + return static_cast(activities_.size()); +} + +void ActivityWaitanySimcall::prepare(int times_considered) +{ + next_value_ = times_considered; +} + +std::string ActivityWaitanySimcall::to_string(int times_considered) const +{ + std::string res = SimcallObserver::to_string(times_considered) + "WaitAny("; + size_t count = activities_.size(); + if (count > 0) { + if (auto* comm = dynamic_cast(activities_[times_considered])) + res += "comm=" + + (XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf("%p", comm) + : "(verbose only)") + + xbt::string_printf("(%d of %zu))", times_considered + 1, count); + else + xbt_die("Only Comms are supported here for now"); + } else + res += "comm at idx " + std::to_string(times_considered) + ")"; + return res; +} + +bool CommIsendSimcall::depends(SimcallObserver* other) +{ + if (get_issuer() == other->get_issuer()) + return false; + + if (auto* other_isend = dynamic_cast(other)) + return mbox_ == other_isend->get_mailbox(); + + // FIXME: Not in the former dependency check because of the ordering but seems logical to add it + if (dynamic_cast(other) != nullptr) + return false; + +#if SIMGRID_HAVE_MC // FIXME needed to access mbox_cpy + if (auto* wait = dynamic_cast(other)) { + if (auto* comm2 = dynamic_cast(wait->get_activity())) { // this is a Comm::wait_for + auto* mbox1 = mbox_; + auto* mbox2 = comm2->mbox_cpy; + + if (mbox1 != mbox2 && wait->get_timeout() <= 0) + return false; + + if ((get_issuer() != comm2->src_actor_.get()) && (get_issuer() != comm2->dst_actor_.get()) && + wait->get_timeout() <= 0) + return false; + + if (comm2->type_ == activity::CommImpl::Type::SEND && comm2->src_buff_ != src_buff_ && wait->get_timeout() <= 0) + return false; + } + } +#endif + /* FIXME: the following rule assumes that the result of the isend/irecv call is not stored in a buffer used in the + * test call. */ +#if 0 + if (dynamic_cast(other)) + return false; +#endif + + return true; +} + +std::string CommIsendSimcall::to_string(int times_considered) const +{ + std::string res = SimcallObserver::to_string(times_considered) + "iSend("; + res += xbt::string_printf("src=[(%ld)%s (%s)]", get_issuer()->get_pid(), get_issuer()->get_host()->get_cname(), + get_issuer()->get_cname()); + res += XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf(", buff=%p", src_buff_) + : "(verbose only)"; + res += ", size=" + + (XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? std::to_string(src_buff_size_) : "(verbose only)"); + res += ")"; + return res; +} + +bool CommIrecvSimcall::depends(SimcallObserver* other) +{ + if (get_issuer() == other->get_issuer()) + return false; + + if (auto* other_irecv = dynamic_cast(other)) + return mbox_ == other_irecv->get_mailbox(); + + if (dynamic_cast(other) != nullptr) + return false; + +#if SIMGRID_HAVE_MC // FIXME needed to access mbox_cpy + if (auto* wait = dynamic_cast(other)) { + if (auto* comm2 = dynamic_cast(wait->get_activity())) { // this is a Comm::wait_for + auto* mbox1 = mbox_; + auto* mbox2 = comm2->mbox_cpy; + + if (mbox1 != mbox2 && wait->get_timeout() <= 0) + return false; + + if ((get_issuer() != comm2->src_actor_.get()) && (get_issuer() != comm2->dst_actor_.get()) && + wait->get_timeout() <= 0) + return false; + + if (comm2->type_ == activity::CommImpl::Type::RECEIVE && comm2->dst_buff_ != dst_buff_ && + wait->get_timeout() <= 0) + return false; + } + } +#endif + /* FIXME: the following rule assumes that the result of the isend/irecv call is not stored in a buffer used in the + * test call. */ +#if 0 + if (dynamic_cast(other)) + return false; +#endif + + return true; +} + +std::string CommIrecvSimcall::to_string(int times_considered) const +{ + std::string res = SimcallObserver::to_string(times_considered) + "iRecv("; + res += xbt::string_printf("dst=[(%ld)%s (%s)]", get_issuer()->get_pid(), get_issuer()->get_host()->get_cname(), + get_issuer()->get_cname()); + res += XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? xbt::string_printf(", buff=%p", dst_buff_) + : "(verbose only)"; + res += ", size=" + (XBT_LOG_ISENABLED(mc_observer, xbt_log_priority_verbose) ? std::to_string(*dst_buff_size_) + : "(verbose only)"); + res += ")"; + return res; } } // namespace actor