X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/39f579ce40d3bd04d9f64a7914b07d1ec3334e4b..db5adf7439201fb67d1d697b86806d58ace9fe85:/src/surf/ptask_L07.cpp diff --git a/src/surf/ptask_L07.cpp b/src/surf/ptask_L07.cpp index 260757a588..7068377852 100644 --- a/src/surf/ptask_L07.cpp +++ b/src/surf/ptask_L07.cpp @@ -1,4 +1,4 @@ -/* Copyright (c) 2007-2019. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2007-2020. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ @@ -57,8 +57,10 @@ NetworkL07Model::NetworkL07Model(HostL07Model* hmodel, kernel::lmm::System* sys) : NetworkModel(Model::UpdateAlgo::FULL), hostModel_(hmodel) { set_maxmin_system(sys); - loopback_ = NetworkL07Model::create_link("__loopback__", std::vector{498000000}, 0.000015, - s4u::Link::SharingPolicy::FATPIPE); + loopback_ = NetworkL07Model::create_link("__loopback__", + std::vector{simgrid::config::get_value("network/loopback-bw")}, + simgrid::config::get_value("network/loopback-lat"), + s4u::Link::SharingPolicy::FATPIPE); } NetworkL07Model::~NetworkL07Model() @@ -70,9 +72,9 @@ double HostL07Model::next_occurring_event(double now) { double min = HostModel::next_occurring_event_full(now); for (kernel::resource::Action const& action : *get_started_action_set()) { - const L07Action& net_action = static_cast(action); - if (net_action.latency_ > 0 && (min < 0 || net_action.latency_ < min)) { - min = net_action.latency_; + const auto& net_action = static_cast(action); + if (net_action.get_latency() > 0 && (min < 0 || net_action.get_latency() < min)) { + min = net_action.get_latency(); XBT_DEBUG("Updating min with %p (start %f): %f", &net_action, net_action.get_start_time(), min); } } @@ -84,15 +86,15 @@ double HostL07Model::next_occurring_event(double now) void HostL07Model::update_actions_state(double /*now*/, double delta) { for (auto it = std::begin(*get_started_action_set()); it != std::end(*get_started_action_set());) { - L07Action& action = static_cast(*it); + auto& action = static_cast(*it); ++it; // increment iterator here since the following calls to action.finish() may invalidate it - if (action.latency_ > 0) { - if (action.latency_ > delta) { - double_update(&(action.latency_), delta, sg_surf_precision); + if (action.get_latency() > 0) { + if (action.get_latency() > delta) { + action.update_latency(delta, sg_surf_precision); } else { - action.latency_ = 0.0; + action.set_latency(0.0); } - if ((action.latency_ <= 0.0) && (action.is_suspended() == 0)) { + if ((action.get_latency() <= 0.0) && (action.is_suspended() == 0)) { action.updateBound(); get_maxmin_system()->update_variable_penalty(action.get_variable(), 1.0); action.set_last_update(); @@ -119,10 +121,10 @@ void HostL07Model::update_actions_state(double /*now*/, double delta) /* Need to check that none of the model has failed */ int i = 0; - kernel::lmm::Constraint* cnst = action.get_variable()->get_constraint(i); + const kernel::lmm::Constraint* cnst = action.get_variable()->get_constraint(i); while (cnst != nullptr) { i++; - kernel::resource::Resource* constraint_id = cnst->get_id(); + const kernel::resource::Resource* constraint_id = cnst->get_id(); if (not constraint_id->is_on()) { XBT_DEBUG("Action (%p) Failed!!", &action); action.finish(kernel::resource::Action::State::FAILED); @@ -142,7 +144,7 @@ kernel::resource::CpuAction* HostL07Model::execute_parallel(const std::vector& host_list, const double* flops_amount, const double* bytes_amount, double rate) - : CpuAction(model, 1, 0), computationAmount_(flops_amount), communicationAmount_(bytes_amount), rate_(rate) + : CpuAction(model, 1.0, false), computationAmount_(flops_amount), communicationAmount_(bytes_amount), rate_(rate) { size_t link_nb = 0; size_t used_host_nb = 0; /* Only the hosts with something to compute (>0 flops) are counted) */ @@ -210,8 +212,8 @@ L07Action::L07Action(kernel::resource::Model* model, const std::vector host_list = {src, dst}; - double* flops_amount = new double[2](); - double* bytes_amount = new double[4](); + const auto* flops_amount = new double[2](); + auto* bytes_amount = new double[4](); bytes_amount[1] = size; @@ -254,14 +256,14 @@ LinkL07::LinkL07(NetworkL07Model* model, const std::string& name, double bandwid if (policy == s4u::Link::SharingPolicy::FATPIPE) get_constraint()->unshare(); - s4u::Link::on_creation(this->piface_); + s4u::Link::on_creation(*get_iface()); } kernel::resource::CpuAction* CpuL07::execution_start(double size) { std::vector host_list = {get_host()}; - double* flops_amount = new double[host_list.size()](); + auto* flops_amount = new double[host_list.size()](); flops_amount[0] = size; kernel::resource::CpuAction* res = @@ -272,7 +274,7 @@ kernel::resource::CpuAction* CpuL07::execution_start(double size) kernel::resource::CpuAction* CpuL07::sleep(double duration) { - L07Action *action = static_cast(execution_start(1.0)); + auto* action = static_cast(execution_start(1.0)); action->set_max_duration(duration); action->set_suspend_state(kernel::resource::Action::SuspendStates::SLEEPING); get_model()->get_maxmin_system()->update_variable_penalty(action->get_variable(), 0.0); @@ -280,7 +282,7 @@ kernel::resource::CpuAction* CpuL07::sleep(double duration) return action; } -bool CpuL07::is_used() +bool CpuL07::is_used() const { return get_model()->get_maxmin_system()->constraint_used(get_constraint()); } @@ -288,12 +290,12 @@ bool CpuL07::is_used() /** @brief take into account changes of speed (either load or max) */ void CpuL07::on_speed_change() { - kernel::lmm::Variable* var = nullptr; + const kernel::lmm::Variable* var; const kernel::lmm::Element* elem = nullptr; get_model()->get_maxmin_system()->update_constraint_bound(get_constraint(), speed_.peak * speed_.scale); while ((var = get_constraint()->get_variable(&elem))) { - kernel::resource::Action* action = static_cast(var->get_id()); + const kernel::resource::Action* action = var->get_id(); get_model()->get_maxmin_system()->update_variable_bound(action->get_variable(), speed_.scale * speed_.peak); } @@ -301,7 +303,7 @@ void CpuL07::on_speed_change() Cpu::on_speed_change(); } -bool LinkL07::is_used() +bool LinkL07::is_used() const { return get_model()->get_maxmin_system()->constraint_used(get_constraint()); } @@ -317,7 +319,7 @@ void CpuL07::apply_event(kernel::profile::Event* triggered, double value) } else if (triggered == state_event_) { if (value > 0) { if (not is_on()) { - XBT_VERB("Restart processes on host %s", get_host()->get_cname()); + XBT_VERB("Restart actors on host %s", get_host()->get_cname()); get_host()->turn_on(); } } else @@ -362,7 +364,7 @@ void LinkL07::set_bandwidth(double value) void LinkL07::set_latency(double value) { - kernel::lmm::Variable* var = nullptr; + const kernel::lmm::Variable* var; L07Action *action; const kernel::lmm::Element* elem = nullptr; @@ -395,7 +397,6 @@ void L07Action::updateBound() if (communicationAmount_ != nullptr) { for (size_t i = 0; i < host_count; i++) { for (size_t j = 0; j < host_count; j++) { - if (communicationAmount_[i * host_count + j] > 0) { double lat = 0.0; std::vector route;