X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/3ebad857344d7658054328dabe709e006bff654a..ae62510f83c4cd6e7967aa00897bf66671a5923a:/src/mc/explo/DFSExplorer.cpp diff --git a/src/mc/explo/DFSExplorer.cpp b/src/mc/explo/DFSExplorer.cpp index 373d6e8a31..e8bb0b0979 100644 --- a/src/mc/explo/DFSExplorer.cpp +++ b/src/mc/explo/DFSExplorer.cpp @@ -1,4 +1,4 @@ -/* Copyright (c) 2016-2022. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2016-2023. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ @@ -13,6 +13,7 @@ #include "src/xbt/mmalloc/mmprivate.h" #include "xbt/log.h" +#include "xbt/string.hpp" #include "xbt/sysdep.h" #include @@ -49,7 +50,9 @@ void DFSExplorer::check_non_termination(const State* current_state) XBT_INFO("Counter-example execution trace:"); for (auto const& s : get_textual_trace()) XBT_INFO(" %s", s.c_str()); - XBT_INFO("Path = %s", get_record_trace().to_string().c_str()); + XBT_INFO("You can debug the problem (and see the whole details) by rerunning out of simgrid-mc with " + "--cfg=model-check/replay:'%s'", + get_record_trace().to_string().c_str()); log_state(); throw TerminationError(); @@ -95,7 +98,7 @@ void DFSExplorer::run() State* state = stack_.back().get(); XBT_DEBUG("**************************************************"); - XBT_DEBUG("Exploration depth=%zu (state:%ld; %zu interleaves)", stack_.size(), state->get_num(), + XBT_DEBUG("Exploration depth=%zu (state:#%ld; %zu interleaves todo)", stack_.size(), state->get_num(), state->count_todo()); mc_model_checker->inc_visited_states(); @@ -123,21 +126,30 @@ void DFSExplorer::run() } // Search for the next transition - int next = state->next_transition(); + aid_t next = state->next_transition(); if (next < 0) { // If there is no more transition in the current state, backtrack. XBT_DEBUG("There remains %lu actors, but none to interleave (depth %zu).", state->get_actor_count(), stack_.size() + 1); - + if (state->get_actor_count() == 0) { mc_model_checker->finalize_app(); XBT_VERB("Execution came to an end at %s (state: %ld, depth: %zu)", get_record_trace().to_string().c_str(), state->get_num(), stack_.size()); + } + this->backtrack(); continue; } + XBT_VERB("Sleep set actually containing:"); + for (auto & [aid, transition] : state->get_sleep_set()) { + + XBT_VERB(" <%ld,%s>", aid, transition.to_string().c_str()); + + } + /* Actually answer the request: let's execute the selected request (MCed does one step) */ state->execute_next(next); on_transition_execute_signal(state->get_transition(), get_remote_app()); @@ -148,9 +160,18 @@ void DFSExplorer::run() state->get_transition()->to_string().c_str(), stack_.size(), state->get_num(), state->count_todo()); /* Create the new expanded state (copy the state of MCed into our MCer data) */ - auto next_state = std::make_unique(get_remote_app()); + std::__detail::__unique_ptr_t next_state; + + /* If we want sleep set reduction, pass the old state to the new state so it can + * both copy the sleep set and eventually removes things from it locally */ + if (sleep_set_reduction_) + next_state = std::make_unique(get_remote_app(), state); + else + next_state = std::make_unique(get_remote_app()); + on_state_creation_signal(next_state.get(), get_remote_app()); + if (_sg_mc_termination) this->check_non_termination(next_state.get()); @@ -162,7 +183,7 @@ void DFSExplorer::run() if (visited_state_ == nullptr) { /* Get an enabled process and insert it in the interleave set of the next state */ for (auto const& [aid, _] : next_state->get_actors_list()) { - if (next_state->is_actor_enabled(aid)) { + if (next_state->is_actor_enabled(aid) and not next_state->is_done(aid)) { next_state->mark_todo(aid); if (reduction_mode_ == ReductionMode::dpor) break; // With DPOR, we take the first enabled transition @@ -188,18 +209,29 @@ void DFSExplorer::backtrack() backtrack_count_++; XBT_VERB("Backtracking from %s", get_record_trace().to_string().c_str()); on_backtracking_signal(get_remote_app()); - stack_.pop_back(); get_remote_app().check_deadlock(); + /* We may backtrack from somewhere either because it's leaf, or because every enabled process are in done/sleep set. + * In the first case, we need to remove the last transition corresponding to the Finalize */ + if (stack_.back()->get_transition()->aid_ == 0) + stack_.pop_back(); + /* Traverse the stack backwards until a state with a non empty interleave set is found, deleting all the states that * have it empty in the way. For each deleted state, check if the request that has generated it (from its - * predecessor state), depends on any other previous request executed before it. If it does then add it to the - * interleave set of the state that executed that previous request. */ + * predecessor state) depends on any other previous request executed before it on another process. If there exists one, + * find the more recent, and add its process to the interleave set. If the process is not enabled at this point, + * then add every enabled process to the interleave */ bool found_backtracking_point = false; while (not stack_.empty() && not found_backtracking_point) { std::unique_ptr state = std::move(stack_.back()); + stack_.pop_back(); + + XBT_DEBUG("Marking Transition >>%s<< of process %ld done and adding it to the sleep set", state->get_transition()->to_string().c_str(), state->get_transition()->aid_); + state->mark_done(state->get_transition()->aid_); + state->add_sleep_set(state->get_transition()); + if (reduction_mode_ == ReductionMode::dpor) { aid_t issuer_id = state->get_transition()->aid_; for (auto i = stack_.rbegin(); i != stack_.rend(); ++i) { @@ -207,16 +239,21 @@ void DFSExplorer::backtrack() if (state->get_transition()->aid_ == prev_state->get_transition()->aid_) { XBT_DEBUG("Simcall >>%s<< and >>%s<< with same issuer %ld", state->get_transition()->to_string().c_str(), prev_state->get_transition()->to_string().c_str(), issuer_id); - break; + continue; } else if (prev_state->get_transition()->depends(state->get_transition())) { XBT_VERB("Dependent Transitions:"); XBT_VERB(" %s (state=%ld)", prev_state->get_transition()->to_string().c_str(), prev_state->get_num()); XBT_VERB(" %s (state=%ld)", state->get_transition()->to_string().c_str(), state->get_num()); - if (not prev_state->is_done(issuer_id)) - prev_state->mark_todo(issuer_id); - else - XBT_DEBUG("Actor %ld is in done set", issuer_id); + if (prev_state->is_actor_enabled(issuer_id)){ + if (not prev_state->is_done(issuer_id)) + prev_state->mark_todo(issuer_id); + else + XBT_DEBUG("Actor %ld is already in done set: no need to explore it again", issuer_id); + } else { + XBT_DEBUG("Actor %ld is not enabled: DPOR may be failing. To stay sound, we are marking every enabled transition as todo", issuer_id); + prev_state->mark_all_todo(); + } break; } else { XBT_VERB("INDEPENDENT Transitions:"); @@ -226,12 +263,12 @@ void DFSExplorer::backtrack() } } - if (state->count_todo() == 0) { // Empty interleaving set + if (state->count_todo() == 0) { // Empty interleaving set: exploration at this level is over XBT_DEBUG("Delete state %ld at depth %zu", state->get_num(), stack_.size() + 1); } else { - XBT_DEBUG("Back-tracking to state %ld at depth %zu", state->get_num(), stack_.size() + 1); - stack_.push_back(std::move(state)); // Put it back on the stack + XBT_DEBUG("Back-tracking to state %ld at depth %zu: %ld transitions left to be explored", state->get_num(), stack_.size() + 1, state->count_todo()); + stack_.push_back(std::move(state)); // Put it back on the stack so we can explore the next transition of the interleave found_backtracking_point = true; } } @@ -268,6 +305,8 @@ DFSExplorer::DFSExplorer(const std::vector& args, bool with_dpor) : Explo else reduction_mode_ = ReductionMode::none; + sleep_set_reduction_ = _sg_mc_sleep_set; + if (_sg_mc_termination) { if (with_dpor) { XBT_INFO("Check non progressive cycles (turning DPOR off)");