X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/43593083f5e507b563bddc7d8d9c6022a9d7fab4..130f51aeb55bd3bf2706c1f5b09ca59fa291c087:/include/xbt/random.hpp

diff --git a/include/xbt/random.hpp b/include/xbt/random.hpp
index 81572c78ff..a5c4c7906f 100644
--- a/include/xbt/random.hpp
+++ b/include/xbt/random.hpp
@@ -1,4 +1,4 @@
-/* Copyright (c) 2019-2020. The SimGrid Team. All rights reserved.               */
+/* Copyright (c) 2019-2023. The SimGrid Team. All rights reserved.               */
 
 /* This program is free software; you can redistribute it and/or modify it
  * under the terms of the license (GNU LGPL) which comes with this package. */
@@ -12,9 +12,7 @@
 #include <random>
 #include <string>
 
-namespace simgrid {
-namespace xbt {
-namespace random {
+namespace simgrid::xbt::random {
 
 /** A random number generator.
  *
@@ -40,12 +38,12 @@ public:
   /**
    * @brief Read the state of the Mersenne-Twister RNG from a file
    */
-  bool read_state(std::string filename);
+  bool read_state(const std::string& filename);
 
   /**
    * @brief Write the state of the Mersenne-Twister RNG to a file
    */
-  bool write_state(std::string filename);
+  bool write_state(const std::string& filename) const;
 
   /**
    * @brief Draws an integer number uniformly in range [min, max] (min and max included)
@@ -85,8 +83,7 @@ public:
  */
 class XBT_PUBLIC StdRandom : public Random {
 public:
-  StdRandom() = default;
-  explicit StdRandom(int seed) : Random(seed) {}
+  using Random::Random;
 
   int uniform_int(int min, int max) override;
   double uniform_real(double min, double max) override;
@@ -100,8 +97,7 @@ public:
  */
 class XBT_PUBLIC XbtRandom : public Random {
 public:
-  XbtRandom() = default;
-  explicit XbtRandom(int seed) : Random(seed) {}
+  using Random::Random;
 
   int uniform_int(int min, int max) override;
   double uniform_real(double min, double max) override;
@@ -127,12 +123,12 @@ void set_mersenne_seed(int);
 /**
  * @brief Read the state of the Mersenne-Twister RNG from a file.
  */
-bool read_mersenne_state(std::string filename);
+bool read_mersenne_state(const std::string& filename);
 
 /**
  * @brief Write the state of the Mersenne-Twister RNG to a file.
  */
-bool write_mersenne_state(std::string filename);
+bool write_mersenne_state(const std::string& filename);
 
 /**
  * @brief Draws an integer number uniformly in range [min, max] (min and max included)
@@ -164,8 +160,6 @@ double exponential(double lambda);
  * @param sd Standard deviation of the normal distribution
  */
 double normal(double mean, double sd);
-} // namespace random
-} // namespace xbt
-} // namespace simgrid
+} // namespace simgrid::xbt::random
 
 #endif