X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/63dae9fee48b67ed8302130aa84c8a54cd42241b..6bb41d92e3329c3be26c100026424ed3885d8554:/src/kernel/routing/NetZoneImpl.cpp?ds=sidebyside diff --git a/src/kernel/routing/NetZoneImpl.cpp b/src/kernel/routing/NetZoneImpl.cpp index d357d6af6c..95f9028156 100644 --- a/src/kernel/routing/NetZoneImpl.cpp +++ b/src/kernel/routing/NetZoneImpl.cpp @@ -1,26 +1,27 @@ -/* Copyright (c) 2006-2021. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2006-2022. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ -#include "simgrid/kernel/routing/NetZoneImpl.hpp" -#include "simgrid/kernel/routing/NetPoint.hpp" -#include "simgrid/s4u/Engine.hpp" -#include "simgrid/s4u/Host.hpp" +#include +#include +#include +#include +#include + #include "src/include/simgrid/sg_config.hpp" #include "src/kernel/EngineImpl.hpp" +#include "src/kernel/resource/CpuImpl.hpp" #include "src/kernel/resource/DiskImpl.hpp" +#include "src/kernel/resource/NetworkModel.hpp" +#include "src/kernel/resource/SplitDuplexLinkImpl.hpp" +#include "src/kernel/resource/StandardLinkImpl.hpp" +#include "src/kernel/resource/VirtualMachineImpl.hpp" #include "src/surf/HostImpl.hpp" -#include "src/surf/SplitDuplexLinkImpl.hpp" -#include "src/surf/cpu_interface.hpp" -#include "src/surf/network_interface.hpp" -#include "surf/surf.hpp" -XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(surf_route); +XBT_LOG_NEW_DEFAULT_SUBCATEGORY(ker_routing, kernel, "Kernel routing-related information"); -namespace simgrid { -namespace kernel { -namespace routing { +namespace simgrid::kernel::routing { /* Pick the right models for CPU, net and host, and call their model_init_preparse */ static void surf_config_models_setup() @@ -67,34 +68,35 @@ static void surf_config_models_setup() xbt::signal const& link_list)> + std::vector const& link_list)> NetZoneImpl::on_route_creation; NetZoneImpl::NetZoneImpl(const std::string& name) : piface_(this), name_(name) { + auto* engine = s4u::Engine::get_instance(); /* workaroud: first netzoneImpl will be the root netzone. * Without globals and with current surf_*_model_description init functions, we need * the root netzone to exist when creating the models. * This was usually done at sg_platf.cpp, during XML parsing */ - if (not s4u::Engine::get_instance()->get_netzone_root()) { - s4u::Engine::get_instance()->set_netzone_root(&piface_); + if (not engine->get_netzone_root()) { + engine->set_netzone_root(&piface_); /* root netzone set, initialize models */ simgrid::s4u::Engine::on_platform_creation(); /* Initialize the surf models. That must be done after we got all config, and before we need the models. - * That is, after the last tag, if any, and before the first of cluster|peer|zone|trace|trace_connect + * That is, after the last tag, if any, and before the first of cluster|peer|zone|trace|trace_cb * - * I'm not sure for and , there may be a bug here + * I'm not sure for and , there may be a bug here * (FIXME: check it out by creating a file beginning with one of these tags) * but cluster and peer come down to zone creations, so putting this verification here is correct. */ surf_config_models_setup(); } - xbt_assert(nullptr == s4u::Engine::get_instance()->netpoint_by_name_or_null(get_name()), + xbt_assert(nullptr == engine->netpoint_by_name_or_null(get_name()), "Refusing to create a second NetZone called '%s'.", get_cname()); netpoint_ = new NetPoint(name_, NetPoint::Type::NetZone); - XBT_DEBUG("NetZone '%s' created with the id '%u'", get_cname(), netpoint_->id()); + XBT_DEBUG("NetZone '%s' created with the id '%lu'", get_cname(), netpoint_->id()); _sg_cfg_init_status = 2; /* HACK: direct access to the global controlling the level of configuration to prevent * any further config now that we created some real content */ simgrid::s4u::NetZone::on_creation(piface_); // notify the signal @@ -105,16 +107,54 @@ NetZoneImpl::~NetZoneImpl() for (auto const& nz : children_) delete nz; - for (auto const& kv : bypass_routes_) - delete kv.second; + /* Since hosts_ and links_ are a std::map, the hosts are destroyed in the lexicographic order, which ensures that the + * output is reproducible. + */ + for (auto const& [_, host] : hosts_) { + host->destroy(); + } + hosts_.clear(); + for (auto const& [_, link] : links_) { + link->destroy(); + } + links_.clear(); + + for (auto const& [_, route] : bypass_routes_) + delete route; s4u::Engine::get_instance()->netpoint_unregister(netpoint_); } +xbt_node_t NetZoneImpl::new_xbt_graph_node(const s_xbt_graph_t* graph, const char* name, + std::map>* nodes) +{ + auto [elm, inserted] = nodes->try_emplace(name); + if (inserted) + elm->second = xbt_graph_new_node(graph, xbt_strdup(name)); + return elm->second; +} + +xbt_edge_t NetZoneImpl::new_xbt_graph_edge(const s_xbt_graph_t* graph, xbt_node_t src, xbt_node_t dst, + std::map>* edges) +{ + const auto* src_name = static_cast(xbt_graph_node_get_data(src)); + const auto* dst_name = static_cast(xbt_graph_node_get_data(dst)); + + auto elm = edges->find(std::string(src_name) + dst_name); + if (elm == edges->end()) { + bool inserted; + std::tie(elm, inserted) = edges->try_emplace(std::string(dst_name) + src_name); + if (inserted) + elm->second = xbt_graph_new_edge(graph, src, dst, nullptr); + } + + return elm->second; +} + void NetZoneImpl::add_child(NetZoneImpl* new_zone) { xbt_assert(not sealed_, "Cannot add a new child to the sealed zone %s", get_cname()); - /* set the father behavior */ + /* set the parent behavior */ hierarchy_ = RoutingMode::recursive; children_.push_back(new_zone); } @@ -126,23 +166,43 @@ void NetZoneImpl::add_child(NetZoneImpl* new_zone) */ std::vector NetZoneImpl::get_all_hosts() const { - std::vector res; - for (auto const& card : get_vertices()) { - s4u::Host* host = s4u::Host::by_name_or_null(card->get_name()); - if (host != nullptr) - res.push_back(host); + return s4u::Engine::get_instance()->get_filtered_hosts( + [this](const s4u::Host* host) { return host->get_impl()->get_englobing_zone() == this; }); +} +size_t NetZoneImpl::get_host_count() const +{ + return get_all_hosts().size(); +} + +std::vector NetZoneImpl::get_filtered_links(const std::function& filter) const +{ + std::vector filtered_list; + for (auto const& [_, link] : links_) { + s4u::Link* l = link->get_iface(); + if (filter(l)) + filtered_list.push_back(l); + } + + for (const auto* child : children_) { + auto child_links = child->get_filtered_links(filter); + filtered_list.insert(filtered_list.end(), std::make_move_iterator(child_links.begin()), + std::make_move_iterator(child_links.end())); } - return res; + return filtered_list; } -int NetZoneImpl::get_host_count() const + +std::vector NetZoneImpl::get_all_links() const { - int count = 0; - for (auto const& card : get_vertices()) { - const s4u::Host* host = s4u::Host::by_name_or_null(card->get_name()); - if (host != nullptr) - count++; + return get_filtered_links([](const s4u::Link*) { return true; }); +} + +size_t NetZoneImpl::get_link_count() const +{ + size_t total = links_.size(); + for (const auto* child : children_) { + total += child->get_link_count(); } - return count; + return total; } s4u::Host* NetZoneImpl::create_host(const std::string& name, const std::vector& speed_per_pstate) @@ -150,12 +210,19 @@ s4u::Host* NetZoneImpl::create_host(const std::string& name, const std::vectorget_iface(); - res->set_netpoint((new NetPoint(name, NetPoint::Type::Host))->set_englobing_zone(this)); + xbt_assert(not sealed_, "Impossible to create host: %s. NetZone %s already sealed", name.c_str(), get_cname()); + auto* host = (new resource::HostImpl(name))->set_englobing_zone(this); + hosts_[name] = host; + host->get_iface()->set_netpoint((new NetPoint(name, NetPoint::Type::Host))->set_englobing_zone(this)); - cpu_model_pm_->create_cpu(res, speed_per_pstate); + cpu_model_pm_->create_cpu(host->get_iface(), speed_per_pstate); - return res; + return host->get_iface(); +} + +resource::StandardLinkImpl* NetZoneImpl::do_create_link(const std::string& name, const std::vector& bandwidths) +{ + return network_model_->create_link(name, bandwidths); } s4u::Link* NetZoneImpl::create_link(const std::string& name, const std::vector& bandwidths) @@ -164,18 +231,24 @@ s4u::Link* NetZoneImpl::create_link(const std::string& name, const std::vectorcreate_link(name, bandwidths)->get_iface(); + xbt_assert(not sealed_, "Impossible to create link: %s. NetZone %s already sealed", name.c_str(), get_cname()); + links_[name] = do_create_link(name, bandwidths)->set_englobing_zone(this); + return links_[name]->get_iface(); } s4u::SplitDuplexLink* NetZoneImpl::create_split_duplex_link(const std::string& name, const std::vector& bandwidths) { - auto* link_up = network_model_->create_link(name + "_UP", bandwidths); - auto* link_down = network_model_->create_link(name + "_DOWN", bandwidths); - auto link = std::make_unique(name, link_up, link_down); - auto* link_iface = link->get_iface(); - EngineImpl::get_instance()->add_split_duplex_link(name, std::move(link)); - return link_iface; + xbt_assert( + network_model_, + "Impossible to create link: %s. Invalid network model: nullptr. Have you set the parent of this NetZone: %s?", + name.c_str(), get_cname()); + xbt_assert(not sealed_, "Impossible to create link: %s. NetZone %s already sealed", name.c_str(), get_cname()); + + auto* link_up = create_link(name + "_UP", bandwidths)->get_impl()->set_englobing_zone(this); + auto* link_down = create_link(name + "_DOWN", bandwidths)->get_impl()->set_englobing_zone(this); + split_duplex_links_[name] = std::make_unique(name, link_up, link_down); + return split_duplex_links_[name]->get_iface(); } s4u::Disk* NetZoneImpl::create_disk(const std::string& name, double read_bandwidth, double write_bandwidth) @@ -183,6 +256,7 @@ s4u::Disk* NetZoneImpl::create_disk(const std::string& name, double read_bandwid xbt_assert(disk_model_, "Impossible to create disk: %s. Invalid disk model: nullptr. Have you set the parent of this NetZone: %s?", name.c_str(), get_cname()); + xbt_assert(not sealed_, "Impossible to create disk: %s. NetZone %s already sealed", name.c_str(), get_cname()); auto* l = disk_model_->create_disk(name, read_bandwidth, write_bandwidth); return l->get_iface(); @@ -192,52 +266,123 @@ NetPoint* NetZoneImpl::create_router(const std::string& name) { xbt_assert(nullptr == s4u::Engine::get_instance()->netpoint_by_name_or_null(name), "Refusing to create a router named '%s': this name already describes a node.", name.c_str()); + xbt_assert(not sealed_, "Impossible to create router: %s. NetZone %s already sealed", name.c_str(), get_cname()); return (new NetPoint(name, NetPoint::Type::Router))->set_englobing_zone(this); } -int NetZoneImpl::add_component(NetPoint* elm) + +unsigned long NetZoneImpl::add_component(NetPoint* elm) { vertices_.push_back(elm); return vertices_.size() - 1; // The rank of the newly created object } -std::vector NetZoneImpl::get_link_list_impl(const std::vector& link_list, - bool backroute) const +std::vector NetZoneImpl::get_link_list_impl(const std::vector& link_list, + bool backroute) const { - std::vector links; + std::vector links; for (const auto& link : link_list) { - resource::LinkImpl* link_impl; - if (link.get_link()->get_sharing_policy() == s4u::Link::SharingPolicy::SPLITDUPLEX) { - const auto* sd_link = dynamic_cast(link.get_link()); - xbt_assert(sd_link, - "Add_route: cast to SpliDuplexLink impossible. This should not happen, please contact SimGrid team"); - switch (link.get_direction()) { - case s4u::LinkInRoute::Direction::UP: - if (backroute) - link_impl = sd_link->get_link_down()->get_impl(); - else - link_impl = sd_link->get_link_up()->get_impl(); - break; - case s4u::LinkInRoute::Direction::DOWN: - if (backroute) - link_impl = sd_link->get_link_up()->get_impl(); - else - link_impl = sd_link->get_link_down()->get_impl(); - break; - case s4u::LinkInRoute::Direction::NONE: - default: - throw std::invalid_argument("Invalid add_route. Split-Duplex link without a direction: " + - link.get_link()->get_name()); - } - } else { - link_impl = link.get_link()->get_impl(); + if (link.get_link()->get_sharing_policy() != s4u::Link::SharingPolicy::SPLITDUPLEX) { + links.push_back(link.get_link()->get_impl()); + continue; + } + // split-duplex links + const auto* sd_link = dynamic_cast(link.get_link()); + xbt_assert(sd_link, + "Add_route: cast to SpliDuplexLink impossible. This should not happen, please contact SimGrid team"); + resource::StandardLinkImpl* link_impl; + switch (link.get_direction()) { + case s4u::LinkInRoute::Direction::UP: + if (backroute) + link_impl = sd_link->get_link_down()->get_impl(); + else + link_impl = sd_link->get_link_up()->get_impl(); + break; + case s4u::LinkInRoute::Direction::DOWN: + if (backroute) + link_impl = sd_link->get_link_up()->get_impl(); + else + link_impl = sd_link->get_link_down()->get_impl(); + break; + default: + throw std::invalid_argument("Invalid add_route. Split-Duplex link without a direction: " + + link.get_link()->get_name()); } links.push_back(link_impl); } return links; } +resource::StandardLinkImpl* NetZoneImpl::get_link_by_name_or_null(const std::string& name) const +{ + if (auto link_it = links_.find(name); link_it != links_.end()) + return link_it->second; + + for (const auto* child : children_) { + if (auto* link = child->get_link_by_name_or_null(name)) + return link; + } + + return nullptr; +} + +resource::SplitDuplexLinkImpl* NetZoneImpl::get_split_duplex_link_by_name_or_null(const std::string& name) const +{ + if (auto link_it = split_duplex_links_.find(name); link_it != split_duplex_links_.end()) + return link_it->second.get(); + + for (const auto* child : children_) { + if (auto* link = child->get_split_duplex_link_by_name_or_null(name)) + return link; + } + + return nullptr; +} + +resource::HostImpl* NetZoneImpl::get_host_by_name_or_null(const std::string& name) const +{ + for (auto const& [_, host] : hosts_) { + if (host->get_name() == name) + return host; + /* keep old behavior where host and VMs were saved together on EngineImpl::hosts_ + * get hosts returns VMs too */ + auto* vm = host->get_vm_by_name_or_null(name); + if (vm) + return vm; + } + + for (const auto* child : children_) { + auto* host = child->get_host_by_name_or_null(name); + if (host) + return host; + } + + return nullptr; +} + +std::vector NetZoneImpl::get_filtered_hosts(const std::function& filter) const +{ + std::vector filtered_list; + for (auto const& [_, host] : hosts_) { + s4u::Host* h = host->get_iface(); + if (filter(h)) + filtered_list.push_back(h); + /* Engine::get_hosts returns the VMs too */ + for (auto* vm : h->get_impl()->get_vms()) { + if (filter(vm)) + filtered_list.push_back(vm); + } + } + + for (const auto* child : children_) { + auto child_links = child->get_filtered_hosts(filter); + filtered_list.insert(filtered_list.end(), std::make_move_iterator(child_links.begin()), + std::make_move_iterator(child_links.end())); + } + return filtered_list; +} + void NetZoneImpl::add_route(NetPoint* /*src*/, NetPoint* /*dst*/, NetPoint* /*gw_src*/, NetPoint* /*gw_dst*/, const std::vector& /*link_list_*/, bool /*symmetrical*/) { @@ -270,7 +415,7 @@ void NetZoneImpl::add_bypass_route(NetPoint* src, NetPoint* dst, NetPoint* gw_sr newRoute->links.insert(newRoute->links.end(), begin(converted_list), end(converted_list)); /* Store it */ - bypass_routes_.insert({{src, dst}, newRoute}); + bypass_routes_.try_emplace({src, dst}, newRoute); } /** @brief Get the common ancestor and its first children in each line leading to src and dst @@ -358,33 +503,33 @@ static void find_common_ancestors(const NetPoint* src, const NetPoint* dst, current = current->get_parent(); } - /* (3) find the common father. + /* (3) find the common parent. * Before that, index_src and index_dst may be different, they both point to nullptr in path_src/path_dst * So we move them down simultaneously as long as they point to the same content. * * This works because all SimGrid platform have a unique root element (that is the last element of both paths). */ - NetZoneImpl* father = nullptr; // the netzone we dropped on the previous loop iteration + NetZoneImpl* parent = nullptr; // the netzone we dropped on the previous loop iteration while (path_src.size() > 1 && path_dst.size() > 1 && path_src.back() == path_dst.back()) { - father = path_src.back(); + parent = path_src.back(); path_src.pop_back(); path_dst.pop_back(); } /* (4) we found the difference at least. Finalize the returned values */ - *src_ancestor = path_src.back(); /* the first different father of src */ - *dst_ancestor = path_dst.back(); /* the first different father of dst */ + *src_ancestor = path_src.back(); /* the first different parent of src */ + *dst_ancestor = path_dst.back(); /* the first different parent of dst */ if (*src_ancestor == *dst_ancestor) { // src is the ancestor of dst, or the contrary *common_ancestor = *src_ancestor; } else { - xbt_assert(father != nullptr); - *common_ancestor = father; + xbt_assert(parent != nullptr); + *common_ancestor = parent; } } /* PRECONDITION: this is the common ancestor of src and dst */ bool NetZoneImpl::get_bypass_route(const NetPoint* src, const NetPoint* dst, - /* OUT */ std::vector& links, double* latency, + /* OUT */ std::vector& links, double* latency, std::unordered_set& netzones) { // If never set a bypass route return nullptr without any further computations @@ -420,7 +565,7 @@ bool NetZoneImpl::get_bypass_route(const NetPoint* src, const NetPoint* dst, current = current->parent_; } - /* (2) find the common father */ + /* (2) find the common parent */ while (path_src.size() > 1 && path_dst.size() > 1 && path_src.back() == path_dst.back()) { path_src.pop_back(); path_dst.pop_back(); @@ -468,15 +613,15 @@ bool NetZoneImpl::get_bypass_route(const NetPoint* src, const NetPoint* dst, } void NetZoneImpl::get_global_route(const NetPoint* src, const NetPoint* dst, - /* OUT */ std::vector& links, double* latency) + /* OUT */ std::vector& links, double* latency) { std::unordered_set netzones; get_global_route_with_netzones(src, dst, links, latency, netzones); } void NetZoneImpl::get_global_route_with_netzones(const NetPoint* src, const NetPoint* dst, - /* OUT */ std::vector& links, double* latency, - std::unordered_set& netzones) + /* OUT */ std::vector& links, + double* latency, std::unordered_set& netzones) { Route route; @@ -487,8 +632,8 @@ void NetZoneImpl::get_global_route_with_netzones(const NetPoint* src, const NetP NetZoneImpl* src_ancestor; NetZoneImpl* dst_ancestor; find_common_ancestors(src, dst, &common_ancestor, &src_ancestor, &dst_ancestor); - XBT_DEBUG("elements_father: common ancestor '%s' src ancestor '%s' dst ancestor '%s'", common_ancestor->get_cname(), - src_ancestor->get_cname(), dst_ancestor->get_cname()); + XBT_DEBUG("find_common_ancestors: common ancestor '%s' src ancestor '%s' dst ancestor '%s'", + common_ancestor->get_cname(), src_ancestor->get_cname(), dst_ancestor->get_cname()); netzones.insert(src->get_englobing_zone()); netzones.insert(dst->get_englobing_zone()); @@ -531,6 +676,11 @@ void NetZoneImpl::seal() for (auto* host : get_all_hosts()) { host->seal(); } + + /* sealing links */ + for (auto const& [_, link] : links_) + link->get_iface()->seal(); + for (auto* sub_net : get_children()) { sub_net->seal(); } @@ -579,7 +729,7 @@ void NetZoneImpl::set_disk_model(std::shared_ptr disk_model disk_model_ = std::move(disk_model); } -void NetZoneImpl::set_host_model(std::shared_ptr host_model) +void NetZoneImpl::set_host_model(std::shared_ptr host_model) { xbt_assert(not sealed_, "Impossible to set host model to an already sealed NetZone(%s)", this->get_cname()); host_model_ = std::move(host_model); @@ -611,6 +761,4 @@ bool NetZoneImpl::is_component_recursive(const NetPoint* netpoint) const return std::any_of(begin(children_), end(children_), [netpoint](const auto* child) { return child->is_component_recursive(netpoint); }); } -} // namespace routing -} // namespace kernel -} // namespace simgrid +} // namespace simgrid::kernel::routing