X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/93797e97a5cd7517c65e1c22c208816a784f4c61..3368ca8f8b3fb922a94a217f0afc3243ae18c8f5:/include/simgrid/s4u/Comm.hpp diff --git a/include/simgrid/s4u/Comm.hpp b/include/simgrid/s4u/Comm.hpp index 40f6a01394..2032de7403 100644 --- a/include/simgrid/s4u/Comm.hpp +++ b/include/simgrid/s4u/Comm.hpp @@ -10,7 +10,11 @@ #include #include +#include // DEPRECATED 3.17 #include + +#include + namespace simgrid { namespace s4u { /** @brief Communication async @@ -23,78 +27,71 @@ XBT_PUBLIC_CLASS Comm : public Activity public: friend void intrusive_ptr_release(simgrid::s4u::Comm * c); friend void intrusive_ptr_add_ref(simgrid::s4u::Comm * c); + friend Mailbox; // Factory of comms virtual ~Comm(); - /*! take a range of s4u::Comm* (last excluded) and return when one of them is finished. The return value is an + /*! take a range of s4u::CommPtr (last excluded) and return when one of them is finished. The return value is an * iterator on the finished Comms. */ - template static I wait_any(I first, I last) + static int wait_any(std::vector * comms) { return wait_any_for(comms, -1); } + /*! Same as wait_any, but with a timeout. If the timeout occurs, parameter last is returned.*/ + static int wait_any_for(std::vector * comms_in, double timeout) { // Map to dynar: xbt_dynar_t comms = xbt_dynar_new(sizeof(simgrid::kernel::activity::ActivityImpl*), [](void*ptr){ - intrusive_ptr_release((simgrid::kernel::activity::ActivityImpl*)ptr); + intrusive_ptr_release(*(simgrid::kernel::activity::ActivityImpl**)ptr); }); - for (I iter = first; iter != last; iter++) { - Comm& comm = **iter; - if (comm.state_ == inited) - comm.start(); - xbt_assert(comm.state_ == started); - intrusive_ptr_add_ref(comm.pimpl_.get()); - xbt_dynar_push_as(comms, simgrid::kernel::activity::ActivityImpl*, comm.pimpl_.get()); + for (auto comm : *comms_in) { + if (comm->state_ == inited) + comm->start(); + xbt_assert(comm->state_ == started); + simgrid::kernel::activity::ActivityImpl* ptr = comm->pimpl_.get(); + intrusive_ptr_add_ref(ptr); + xbt_dynar_push_as(comms, simgrid::kernel::activity::ActivityImpl*, ptr); } // Call the underlying simcall: - int idx = simcall_comm_waitany(comms, -1); + int idx = simcall_comm_waitany(comms, timeout); xbt_dynar_free(&comms); - // Not found: - if (idx == -1) - return last; - // Lift the index to the corresponding iterator: - auto res = std::next(first, idx); - (*res)->state_ = finished; - return res; + return idx; } - /*! Same as wait_any, but with a timeout. If wait_any_for return because of the timeout last is returned.*/ - template static I wait_any_for(I first, I last, double timeout) + /** Creates (but don't start) an async send to the mailbox @p dest */ + static CommPtr XBT_ATTRIB_DEPRECATED("please use Mailbox::send_init") // 3.17 + send_init(MailboxPtr dest) { - // Map to dynar: - xbt_dynar_t comms = xbt_dynar_new(sizeof(simgrid::kernel::activity::ActivityImpl*), [](void*ptr){ - intrusive_ptr_release((simgrid::kernel::activity::ActivityImpl*)ptr); - }); - for (I iter = first; iter != last; iter++) { - Comm& comm = **iter; - if (comm.state_ == inited) - comm.start(); - xbt_assert(comm.state_ == started); - intrusive_ptr_add_ref(comm.pimpl_.get()); - xbt_dynar_push_as(comms, simgrid::kernel::activity::ActivityImpl*, comm.pimpl_.get()); - } - // Call the underlying simcall: - int idx = simcall_comm_waitany(comms, timeout); - xbt_dynar_free(&comms); - // Not found: - if (idx == -1) - return last; - // Lift the index to the corresponding iterator: - auto res = std::next(first, idx); - (*res)->state_ = finished; - return res; + return dest->send_init(); } /** Creates (but don't start) an async send to the mailbox @p dest */ - static CommPtr send_init(MailboxPtr dest); + static CommPtr XBT_ATTRIB_DEPRECATED("please use Mailbox::send_init") // 3.17 + send_init(MailboxPtr dest, void* data, int simulatedByteAmount) + { + return dest->send_init(data, simulatedByteAmount); + } /** Creates and start an async send to the mailbox @p dest */ - static CommPtr send_async(MailboxPtr dest, void* data, int simulatedByteAmount); + static CommPtr XBT_ATTRIB_DEPRECATED("please use Mailbox::send_async") // 3.17 + send_async(MailboxPtr dest, void* data, int simulatedByteAmount) + { + return dest->send_async(data, simulatedByteAmount); + } /** Creates (but don't start) an async recv onto the mailbox @p from */ - static CommPtr recv_init(MailboxPtr from); + static CommPtr XBT_ATTRIB_DEPRECATED("please use Mailbox::recv_init") // 3.17 + recv_init(MailboxPtr from) + { + return from->recv_init(); + } /** Creates and start an async recv to the mailbox @p from */ - static CommPtr recv_async(MailboxPtr from, void** data); - /** Creates and start a detached send to the mailbox @p dest - * TODO: make it possible to detach an already created comm */ - static void send_detached(MailboxPtr dest, void* data, int simulatedSize); + static CommPtr XBT_ATTRIB_DEPRECATED("please use Mailbox::recv_async") // 3.17 + recv_async(MailboxPtr from, void** data) + { + return from->recv_async(data); + } void start() override; void wait() override; void wait(double timeout) override; + /** Start the comm, and ignore its result. It can be completely forgotten after that. */ + void detach(); + /** Sets the maximal communication rate (in byte/sec). Must be done before start */ void setRate(double rate); @@ -124,7 +121,7 @@ private: /* FIXME: expose these elements in the API */ int detached_ = 0; - int (*matchFunction_)(void*, void*, smx_activity_t) = nullptr; + int (*matchFunction_)(void*, void*, simgrid::kernel::activity::CommImpl*) = nullptr; void (*cleanFunction_)(void*) = nullptr; void (*copyDataFunction_)(smx_activity_t, void*, size_t) = nullptr;