X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/96cedde3cdbc0b8ffc3f096a1b65d021b0226f99..1067edf07adcaa046abb976e7d92174d608b2d91:/src/s4u/s4u_ConditionVariable.cpp diff --git a/src/s4u/s4u_ConditionVariable.cpp b/src/s4u/s4u_ConditionVariable.cpp index 9908b0c991..74ae59b881 100644 --- a/src/s4u/s4u_ConditionVariable.cpp +++ b/src/s4u/s4u_ConditionVariable.cpp @@ -1,23 +1,25 @@ -/* Copyright (c) 2006-2019. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2006-2023. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ -#include "simgrid/s4u/ConditionVariable.hpp" -#include "simgrid/simix.h" +#include +#include +#include + +#include "src/kernel/activity/ActivityImpl.hpp" #include "src/kernel/activity/ConditionVariableImpl.hpp" -#include "xbt/log.hpp" +#include "src/kernel/actor/SynchroObserver.hpp" -#include #include -namespace simgrid { -namespace s4u { +namespace simgrid::s4u { ConditionVariablePtr ConditionVariable::create() { - smx_cond_t cond = simcall_cond_init(); - return ConditionVariablePtr(&cond->cond_, false); + kernel::activity::ConditionVariableImpl* cond = + kernel::actor::simcall_answered([] { return new kernel::activity::ConditionVariableImpl(); }); + return ConditionVariablePtr(cond->get_iface(), false); } /** @@ -25,21 +27,32 @@ ConditionVariablePtr ConditionVariable::create() */ void ConditionVariable::wait(MutexPtr lock) { - simcall_cond_wait(cond_, lock->pimpl_); + kernel::actor::ActorImpl* issuer = kernel::actor::ActorImpl::self(); + kernel::actor::ConditionVariableObserver observer{issuer, pimpl_, lock->pimpl_}; + kernel::actor::simcall_blocking( + [&observer] { observer.get_cond()->wait(observer.get_mutex(), -1.0, observer.get_issuer()); }, &observer); } -void ConditionVariable::wait(std::unique_lock& lock) +void ConditionVariable::wait(const std::unique_lock& lock) { - simcall_cond_wait(cond_, lock.mutex()->pimpl_); + kernel::actor::ActorImpl* issuer = kernel::actor::ActorImpl::self(); + kernel::actor::ConditionVariableObserver observer{issuer, pimpl_, lock.mutex()->pimpl_}; + kernel::actor::simcall_blocking( + [&observer] { observer.get_cond()->wait(observer.get_mutex(), -1.0, observer.get_issuer()); }, &observer); } -std::cv_status s4u::ConditionVariable::wait_for(std::unique_lock& lock, double timeout) +std::cv_status s4u::ConditionVariable::wait_for(const std::unique_lock& lock, double timeout) { // The simcall uses -1 for "any timeout" but we don't want this: if (timeout < 0) timeout = 0.0; - if (simcall_cond_wait_timeout(cond_, lock.mutex()->pimpl_, timeout)) { + kernel::actor::ActorImpl* issuer = kernel::actor::ActorImpl::self(); + kernel::actor::ConditionVariableObserver observer{issuer, pimpl_, lock.mutex()->pimpl_, timeout}; + bool timed_out = kernel::actor::simcall_blocking( + [&observer] { observer.get_cond()->wait(observer.get_mutex(), observer.get_timeout(), observer.get_issuer()); }, + &observer); + if (timed_out) { // If we reached the timeout, we have to take the lock again: lock.mutex()->lock(); return std::cv_status::timeout; @@ -48,9 +61,9 @@ std::cv_status s4u::ConditionVariable::wait_for(std::unique_lock& lock, d } } -std::cv_status ConditionVariable::wait_until(std::unique_lock& lock, double timeout_time) +std::cv_status ConditionVariable::wait_until(const std::unique_lock& lock, double timeout_time) { - double now = SIMIX_get_clock(); + double now = Engine::get_clock(); double timeout; if (timeout_time < now) timeout = 0.0; @@ -64,23 +77,54 @@ std::cv_status ConditionVariable::wait_until(std::unique_lock& lock, doub */ void ConditionVariable::notify_one() { - simgrid::simix::simcall([this]() { cond_->signal(); }); + simgrid::kernel::actor::simcall_answered([this]() { pimpl_->signal(); }); } void ConditionVariable::notify_all() { - simgrid::simix::simcall([this]() { cond_->broadcast(); }); + simgrid::kernel::actor::simcall_answered([this]() { pimpl_->broadcast(); }); +} + +void intrusive_ptr_add_ref(const ConditionVariable* cond) +{ + intrusive_ptr_add_ref(cond->pimpl_); +} + +void intrusive_ptr_release(const ConditionVariable* cond) +{ + intrusive_ptr_release(cond->pimpl_); } -void intrusive_ptr_add_ref(ConditionVariable* cond) +} // namespace simgrid::s4u + +/* **************************** Public C interface *************************** */ +sg_cond_t sg_cond_init() { - intrusive_ptr_add_ref(cond->cond_); + return simgrid::s4u::ConditionVariable::create().detach(); } -void intrusive_ptr_release(ConditionVariable* cond) +void sg_cond_wait(sg_cond_t cond, sg_mutex_t mutex) { - intrusive_ptr_release(cond->cond_); + cond->wait(mutex); } -} // namespace s4u -} // namespace simgrid +int sg_cond_wait_for(sg_cond_t cond, sg_mutex_t mutex, double delay) +{ + std::unique_lock lock(*mutex); + return cond->wait_for(lock, delay) == std::cv_status::timeout; +} + +void sg_cond_notify_one(sg_cond_t cond) +{ + cond->notify_one(); +} + +void sg_cond_notify_all(sg_cond_t cond) +{ + cond->notify_all(); +} + +void sg_cond_destroy(const_sg_cond_t cond) +{ + intrusive_ptr_release(cond); +}