X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/d9275f747ba3c37e33a3f301dc70dbbb7e9bae38..7f626fa7e7d9a7d28fdc994ae197f82f0a0c6e52:/src/surf/ptask_L07.cpp diff --git a/src/surf/ptask_L07.cpp b/src/surf/ptask_L07.cpp index bd0f778b49..357dd10ddc 100644 --- a/src/surf/ptask_L07.cpp +++ b/src/surf/ptask_L07.cpp @@ -1,4 +1,4 @@ -/* Copyright (c) 2007-2021. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2007-2022. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ @@ -7,7 +7,11 @@ #include #include +#include "simgrid/config.h" #include "src/kernel/EngineImpl.hpp" +#if SIMGRID_HAVE_EIGEN3 +#include "src/kernel/lmm/bmf.hpp" +#endif #include "src/kernel/resource/profile/Event.hpp" #include "src/surf/ptask_L07.hpp" @@ -16,34 +20,41 @@ XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(res_host); XBT_LOG_EXTERNAL_CATEGORY(xbt_cfg); +/*********** + * Options * + ***********/ +static simgrid::config::Flag cfg_ptask_solver("host/solver", + "Set linear equations solver used by ptask model", + "fairbottleneck", + &simgrid::kernel::lmm::System::validate_solver); + /**************************************/ /*** Resource Creation & Destruction **/ /**************************************/ void surf_host_model_init_ptask_L07() { XBT_CINFO(xbt_cfg, "Switching to the L07 model to handle parallel tasks."); + xbt_assert(cfg_ptask_solver != "maxmin", "Invalid configuration. Cannot use maxmin solver with parallel tasks."); - auto host_model = std::make_shared("Host_Ptask"); + auto* system = simgrid::kernel::lmm::System::build(cfg_ptask_solver, true /* selective update */); + auto host_model = std::make_shared("Host_Ptask", system); auto* engine = simgrid::kernel::EngineImpl::get_instance(); engine->add_model(host_model); engine->get_netzone_root()->set_host_model(host_model); } -namespace simgrid { -namespace kernel { -namespace resource { +namespace simgrid::kernel::resource { -HostL07Model::HostL07Model(const std::string& name) : HostModel(name) +HostL07Model::HostL07Model(const std::string& name, lmm::System* sys) : HostModel(name) { - auto* maxmin_system = new lmm::FairBottleneck(true /* selective update */); - set_maxmin_system(maxmin_system); + set_maxmin_system(sys); - auto net_model = std::make_shared("Network_Ptask", this, maxmin_system); + auto net_model = std::make_shared("Network_Ptask", this, sys); auto engine = EngineImpl::get_instance(); engine->add_model(net_model); engine->get_netzone_root()->set_network_model(net_model); - auto cpu_model = std::make_shared("Cpu_Ptask", this, maxmin_system); + auto cpu_model = std::make_shared("Cpu_Ptask", this, sys); engine->add_model(cpu_model); engine->get_netzone_root()->set_cpu_pm_model(cpu_model); } @@ -63,10 +74,10 @@ NetworkL07Model::NetworkL07Model(const std::string& name, HostL07Model* hmodel, : NetworkModel(name), hostModel_(hmodel) { set_maxmin_system(sys); - loopback_ = create_link("__loopback__", {simgrid::config::get_value("network/loopback-bw")}); + loopback_.reset(create_link("__loopback__", {simgrid::config::get_value("network/loopback-bw")})); loopback_->set_sharing_policy(s4u::Link::SharingPolicy::FATPIPE, {}); loopback_->set_latency(simgrid::config::get_value("network/loopback-lat")); - loopback_->seal(); + loopback_->get_iface()->seal(); } NetworkL07Model::~NetworkL07Model() @@ -101,7 +112,7 @@ void HostL07Model::update_actions_state(double /*now*/, double delta) action.set_latency(0.0); } if ((action.get_latency() <= 0.0) && (action.is_suspended() == 0)) { - action.updateBound(); + action.update_bound(); get_maxmin_system()->update_variable_penalty(action.get_variable(), 1.0); action.set_last_update(); } @@ -129,8 +140,7 @@ void HostL07Model::update_actions_state(double /*now*/, double delta) const lmm::Constraint* cnst = action.get_variable()->get_constraint(i); while (cnst != nullptr) { i++; - const Resource* constraint_id = cnst->get_id(); - if (not constraint_id->is_on()) { + if (not cnst->get_id()->is_on()) { XBT_DEBUG("Action (%p) Failed!!", &action); action.finish(Action::State::FAILED); break; @@ -148,29 +158,32 @@ CpuAction* HostL07Model::execute_parallel(const std::vector& host_li L07Action::L07Action(Model* model, const std::vector& host_list, const double* flops_amount, const double* bytes_amount, double rate) - : CpuAction(model, 1.0, false), computationAmount_(flops_amount), communicationAmount_(bytes_amount), rate_(rate) + : CpuAction(model, 1.0, false) + , host_list_(host_list) + , computation_amount_(flops_amount) + , communication_amount_(bytes_amount) + , rate_(rate) { - size_t link_nb = 0; - size_t used_host_nb = 0; /* Only the hosts with something to compute (>0 flops) are counted) */ - double latency = 0.0; + size_t link_nb = 0; + const size_t host_nb = host_list_.size(); + size_t used_host_nb = 0; /* Only the hosts with something to compute (>0 flops) are counted) */ + double latency = 0.0; this->set_last_update(); - hostList_.insert(hostList_.end(), host_list.begin(), host_list.end()); - if (flops_amount != nullptr) - used_host_nb += std::count_if(flops_amount, flops_amount + host_list.size(), [](double x) { return x > 0.0; }); + used_host_nb += std::count_if(flops_amount, flops_amount + host_nb, [](double x) { return x > 0.0; }); /* Compute the number of affected resources... */ if (bytes_amount != nullptr) { std::unordered_set affected_links; - for (size_t k = 0; k < host_list.size() * host_list.size(); k++) { + for (size_t k = 0; k < host_nb * host_nb; k++) { if (bytes_amount[k] <= 0) continue; double lat = 0.0; - std::vector route; - hostList_[k / host_list.size()]->route_to(hostList_[k % host_list.size()], route, &lat); + std::vector route; + host_list_[k / host_nb]->route_to(host_list_[k % host_nb], route, &lat); latency = std::max(latency, lat); for (auto const& link : route) @@ -180,37 +193,30 @@ L07Action::L07Action(Model* model, const std::vector& host_list, con link_nb = affected_links.size(); } - XBT_DEBUG("Creating a parallel task (%p) with %zu hosts and %zu unique links.", this, host_list.size(), link_nb); + XBT_DEBUG("Creating a parallel task (%p) with %zu hosts and %zu unique links.", this, host_nb, link_nb); latency_ = latency; - set_variable( - model->get_maxmin_system()->variable_new(this, 1.0, (rate > 0 ? rate : -1.0), host_list.size() + link_nb)); + set_variable(model->get_maxmin_system()->variable_new(this, 1.0, (rate > 0 ? rate : -1.0), host_nb + link_nb)); if (latency_ > 0) model->get_maxmin_system()->update_variable_penalty(get_variable(), 0.0); /* Expand it for the CPUs even if there is nothing to compute, to make sure that it gets expended even if there is no * communication either */ - double bound = std::numeric_limits::max(); - for (size_t i = 0; i < host_list.size(); i++) { + for (size_t i = 0; i < host_nb; i++) { model->get_maxmin_system()->expand(host_list[i]->get_cpu()->get_constraint(), get_variable(), - (flops_amount == nullptr ? 0.0 : flops_amount[i])); - if (flops_amount && flops_amount[i] > 0) - bound = std::min(bound, host_list[i]->get_cpu()->get_speed(1.0) * host_list[i]->get_cpu()->get_speed_ratio() / - flops_amount[i]); + (flops_amount == nullptr ? 0.0 : flops_amount[i]), true); } - if (bound < std::numeric_limits::max()) - model->get_maxmin_system()->update_variable_bound(get_variable(), bound); if (bytes_amount != nullptr) { - for (size_t k = 0; k < host_list.size() * host_list.size(); k++) { + for (size_t k = 0; k < host_nb * host_nb; k++) { if (bytes_amount[k] <= 0.0) continue; - std::vector route; - hostList_[k / host_list.size()]->route_to(hostList_[k % host_list.size()], route, nullptr); + std::vector route; + host_list_[k / host_nb]->route_to(host_list_[k % host_nb], route, nullptr); for (auto const& link : route) - model->get_maxmin_system()->expand_add(link->get_constraint(), this->get_variable(), bytes_amount[k]); + model->get_maxmin_system()->expand(link->get_constraint(), this->get_variable(), bytes_amount[k]); } } @@ -218,6 +224,8 @@ L07Action::L07Action(Model* model, const std::vector& host_list, con this->set_cost(1.0); this->set_remains(0.0); } + /* finally calculate the initial bound value */ + update_bound(); } Action* NetworkL07Model::communicate(s4u::Host* src, s4u::Host* dst, double size, double rate) @@ -238,7 +246,7 @@ CpuImpl* CpuL07Model::create_cpu(s4u::Host* host, const std::vector& spe return (new CpuL07(host, speed_per_pstate))->set_model(this); } -LinkImpl* NetworkL07Model::create_link(const std::string& name, const std::vector& bandwidths) +StandardLinkImpl* NetworkL07Model::create_link(const std::string& name, const std::vector& bandwidths) { xbt_assert(bandwidths.size() == 1, "Non WIFI link must have only 1 bandwidth."); auto link = new LinkL07(name, bandwidths[0], get_maxmin_system()); @@ -246,7 +254,7 @@ LinkImpl* NetworkL07Model::create_link(const std::string& name, const std::vecto return link; } -LinkImpl* NetworkL07Model::create_wifi_link(const std::string& name, const std::vector& bandwidths) +StandardLinkImpl* NetworkL07Model::create_wifi_link(const std::string& name, const std::vector& bandwidths) { THROW_UNIMPLEMENTED; } @@ -284,17 +292,17 @@ void CpuL07::on_speed_change() { const lmm::Element* elem = nullptr; - get_model()->get_maxmin_system()->update_constraint_bound(get_constraint(), speed_.peak * speed_.scale); - while (const auto* var = get_constraint()->get_variable(&elem)) { - const Action* action = var->get_id(); + get_model()->get_maxmin_system()->update_constraint_bound(get_constraint(), get_core_count() * speed_.peak * speed_.scale); - get_model()->get_maxmin_system()->update_variable_bound(action->get_variable(), speed_.scale * speed_.peak); + while (const auto* var = get_constraint()->get_variable(&elem)) { + const auto* action = static_cast(var->get_id()); + action->update_bound(); } CpuImpl::on_speed_change(); } -LinkL07::LinkL07(const std::string& name, double bandwidth, lmm::System* system) : LinkImpl(name) +LinkL07::LinkL07(const std::string& name, double bandwidth, lmm::System* system) : StandardLinkImpl(name) { this->set_constraint(system->constraint_new(this, bandwidth)); bandwidth_.peak = bandwidth; @@ -348,7 +356,7 @@ void LinkL07::apply_event(profile::Event* triggered, double value) void LinkL07::set_bandwidth(double value) { bandwidth_.peak = value; - LinkImpl::on_bandwidth_change(); + StandardLinkImpl::on_bandwidth_change(); get_model()->get_maxmin_system()->update_constraint_bound(get_constraint(), bandwidth_.peak * bandwidth_.scale); } @@ -360,8 +368,8 @@ void LinkL07::set_latency(double value) latency_.peak = value; while (const auto* var = get_constraint()->get_variable(&elem)) { - auto* action = static_cast(var->get_id()); - action->updateBound(); + const auto* action = static_cast(var->get_id()); + action->update_bound(); } } LinkL07::~LinkL07() = default; @@ -373,40 +381,69 @@ LinkL07::~LinkL07() = default; L07Action::~L07Action() { if (free_arrays_) { - delete[] computationAmount_; - delete[] communicationAmount_; + delete[] computation_amount_; + delete[] communication_amount_; } } -void L07Action::updateBound() +double L07Action::calculate_network_bound() const { double lat_current = 0.0; + double lat_bound = std::numeric_limits::max(); - size_t host_count = hostList_.size(); + size_t host_count = host_list_.size(); - if (communicationAmount_ != nullptr) { - for (size_t i = 0; i < host_count; i++) { - for (size_t j = 0; j < host_count; j++) { - if (communicationAmount_[i * host_count + j] > 0) { - double lat = 0.0; - std::vector route; - hostList_.at(i)->route_to(hostList_.at(j), route, &lat); + if (communication_amount_ == nullptr) { + return lat_bound; + } - lat_current = std::max(lat_current, lat * communicationAmount_[i * host_count + j]); - } + for (size_t i = 0; i < host_count; i++) { + for (size_t j = 0; j < host_count; j++) { + if (communication_amount_[i * host_count + j] > 0) { + double lat = 0.0; + std::vector route; + host_list_.at(i)->route_to(host_list_.at(j), route, &lat); + + lat_current = std::max(lat_current, lat * communication_amount_[i * host_count + j]); } } } - double lat_bound = NetworkModel::cfg_tcp_gamma / (2.0 * lat_current); - XBT_DEBUG("action (%p) : lat_bound = %g", this, lat_bound); - if ((latency_ <= 0.0) && is_running()) { + if (lat_current > 0) { + lat_bound = NetworkModel::cfg_tcp_gamma / (2.0 * lat_current); + } + return lat_bound; +} + +double L07Action::calculate_cpu_bound() const +{ + double cpu_bound = std::numeric_limits::max(); + + if (computation_amount_ == nullptr) { + return cpu_bound; + } + + for (size_t i = 0; i < host_list_.size(); i++) { + if (computation_amount_[i] > 0) { + cpu_bound = std::min(cpu_bound, host_list_[i]->get_cpu()->get_speed(1.0) * + host_list_[i]->get_cpu()->get_speed_ratio() / computation_amount_[i]); + } + } + return cpu_bound; +} + +void L07Action::update_bound() const +{ + double bound = std::min(calculate_network_bound(), calculate_cpu_bound()); + + XBT_DEBUG("action (%p) : bound = %g", this, bound); + + /* latency has been paid (or no latency), we can set the appropriate bound for multicore or network limit */ + if ((bound < std::numeric_limits::max()) && (latency_ <= 0.0)) { if (rate_ < 0) - get_model()->get_maxmin_system()->update_variable_bound(get_variable(), lat_bound); + get_model()->get_maxmin_system()->update_variable_bound(get_variable(), bound); else - get_model()->get_maxmin_system()->update_variable_bound(get_variable(), std::min(rate_, lat_bound)); + get_model()->get_maxmin_system()->update_variable_bound(get_variable(), std::min(rate_, bound)); } } -} // namespace resource -} // namespace kernel -} // namespace simgrid +} // namespace simgrid::kernel::resource