X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/dc9b8feaddd53842f6204f4f24409b2382393fa9..555ebd52dcc6199fdca1cb9d9876d8da2357a80f:/src/instr/instr_paje_types.cpp diff --git a/src/instr/instr_paje_types.cpp b/src/instr/instr_paje_types.cpp index 3df94374a7..ff0c4b5b72 100644 --- a/src/instr/instr_paje_types.cpp +++ b/src/instr/instr_paje_types.cpp @@ -22,7 +22,7 @@ Type::Type(const std::string& name, const std::string& alias, const std::string& THROWF(tracing_error, 0, "can't create a new type with no name or alias"); if (father != nullptr){ - father->children_.insert({alias, this}); + father->children_[alias].reset(this); XBT_DEBUG("new type %s, child of %s", get_cname(), father->get_cname()); } if (trace_format == simgrid::instr::TraceFormat::Paje) { @@ -30,18 +30,6 @@ Type::Type(const std::string& name, const std::string& alias, const std::string& } } -Type::~Type() -{ - for (auto elm : children_) - delete elm.second; -} - -ValueType::~ValueType() -{ - for (auto elm : values_) - delete elm.second; -} - ContainerType::ContainerType(const std::string& name, Type* father) : Type(name, name, "", father) { XBT_DEBUG("ContainerType %s(%lld), child of %s(%lld)", get_cname(), get_id(), father->get_cname(), father->get_id()); @@ -60,11 +48,6 @@ StateType::StateType(const std::string& name, Type* father) : ValueType(name, fa log_definition(PAJE_DefineStateType); } -StateType::~StateType() -{ - events_.clear(); -} - void StateType::set_event(const std::string& value_name) { events_.push_back(new StateEvent(issuer_, this, PAJE_SetState, get_entity_value(value_name), nullptr)); @@ -97,11 +80,6 @@ VariableType::VariableType(const std::string& name, const std::string& color, Ty log_definition(PAJE_DefineVariableType); } -VariableType::~VariableType() -{ - events_.clear(); -} - void VariableType::instr_event(double now, double delta, const char* resource, double value) { /* To trace resource utilization, we use AddEvent and SubEvent only. This implies to add a SetEvent first to set the @@ -181,12 +159,12 @@ void Type::log_definition(simgrid::instr::Type* source, simgrid::instr::Type* de Type* Type::by_name(const std::string& name) { Type* ret = nullptr; - for (auto elm : children_) { + for (auto const& elm : children_) { if (elm.second->name_ == name) { if (ret != nullptr) { THROWF (tracing_error, 0, "there are two children types with the same name?"); } else { - ret = elm.second; + ret = elm.second.get(); } } } @@ -207,10 +185,9 @@ void ValueType::add_entity_value(const std::string& name, const std::string& col auto it = values_.find(name); if (it == values_.end()) { - EntityValue* new_val = new EntityValue(name, color, this); - values_.insert({name, new_val}); + auto res = values_.emplace(name, EntityValue(name, color, this)); XBT_DEBUG("new value %s, child of %s", name.c_str(), get_cname()); - new_val->print(); + res.first->second.print(); } } @@ -220,14 +197,15 @@ EntityValue* ValueType::get_entity_value(const std::string& name) if (ret == values_.end()) { THROWF(tracing_error, 2, "value with name (%s) not found in father type (%s)", name.c_str(), get_cname()); } - return ret->second; + return &ret->second; } VariableType* Type::by_name_or_create(const std::string& name, const std::string& color) { auto cont = children_.find(name); std::string mycolor = color.empty() ? "1 1 1" : color; - return cont == children_.end() ? new VariableType(name, mycolor, this) : static_cast(cont->second); + return cont == children_.end() ? new VariableType(name, mycolor, this) + : static_cast(cont->second.get()); } LinkType* Type::by_name_or_create(const std::string& name, Type* source, Type* dest) @@ -241,7 +219,7 @@ LinkType* Type::by_name_or_create(const std::string& name, Type* source, Type* d ret->log_definition(source, dest); return ret; } else - return static_cast(it->second); + return static_cast(it->second.get()); } } }