X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/ea74f5d95928a521a588737e81f1de94eef25d19..c4c82977e0a105cdf7b04010ddd21bbf15dced4d:/src/plugins/host_dvfs.cpp diff --git a/src/plugins/host_dvfs.cpp b/src/plugins/host_dvfs.cpp index 8d3ef16902..138cdaee1b 100644 --- a/src/plugins/host_dvfs.cpp +++ b/src/plugins/host_dvfs.cpp @@ -1,4 +1,4 @@ -/* Copyright (c) 2010-2022. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2010-2023. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ @@ -13,13 +13,15 @@ #include "src/internal_config.h" // HAVE_SMPI #include "src/kernel/activity/CommImpl.hpp" -#include "src/kernel/resource/StandardLinkImpl.hpp" +#include "src/kernel/resource/NetworkModel.hpp" +#include "src/simgrid/module.hpp" #if HAVE_SMPI #include "src/smpi/include/smpi_request.hpp" #include "src/smpi/plugins/ampi/ampi.hpp" #endif #include +#include SIMGRID_REGISTER_PLUGIN(host_dvfs, "Dvfs support", &sg_host_dvfs_plugin_init) @@ -43,7 +45,7 @@ static simgrid::config::Flag cfg_governor("plugin/dvfs/governor", {"performance", "TODO: Doc"}, {"powersave", "TODO: Doc"}, }), - [](const std::string& val) { + [](std::string_view val) { if (val != "performance") sg_host_dvfs_plugin_init(); }); @@ -52,23 +54,14 @@ static simgrid::config::Flag cfg_min_pstate("plugin/dvfs/min-pstate", "Which pstate is the minimum (and hence fastest) pstate for this governor?", 0); -static const int max_pstate_not_limited = -1; +static constexpr int MAX_PSTATE_NOT_LIMITED = -1; static simgrid::config::Flag cfg_max_pstate("plugin/dvfs/max-pstate", - "Which pstate is the maximum (and hence slowest) pstate for this governor?", max_pstate_not_limited); + "Which pstate is the maximum (and hence slowest) pstate for this governor?", MAX_PSTATE_NOT_LIMITED); -/** @addtogroup SURF_plugin_load +XBT_LOG_NEW_DEFAULT_SUBCATEGORY(host_dvfs, kernel, "Logging specific to the HostDvfs plugin"); - This plugin makes it very simple for users to obtain the current load for each host. - -*/ - -XBT_LOG_NEW_DEFAULT_SUBCATEGORY(surf_plugin_dvfs, surf, "Logging specific to the SURF HostDvfs plugin"); - -namespace simgrid { -namespace plugin { - -namespace dvfs { +namespace simgrid::plugin::dvfs { /** * Add this to your host tag: @@ -98,7 +91,7 @@ public: explicit Governor(simgrid::s4u::Host* ptr) : host_(ptr) { - if (cfg_max_pstate == max_pstate_not_limited) + if (cfg_max_pstate == MAX_PSTATE_NOT_LIMITED) max_pstate = host_->get_pstate_count() - 1; init(); } @@ -110,19 +103,16 @@ public: void init() { - const char* local_sampling_rate_config = host_->get_property(cfg_sampling_rate.get_name()); - if (local_sampling_rate_config != nullptr) { + if (const char* local_sampling_rate_config = host_->get_property(cfg_sampling_rate.get_name())) { sampling_rate_ = std::stod(local_sampling_rate_config); } else { sampling_rate_ = cfg_sampling_rate; } - const char* local_min_pstate_config = host_->get_property(cfg_min_pstate.get_name()); - if (local_min_pstate_config != nullptr) { + if (const char* local_min_pstate_config = host_->get_property(cfg_min_pstate.get_name())) { min_pstate = std::stoul(local_min_pstate_config); } - const char* local_max_pstate_config = host_->get_property(cfg_max_pstate.get_name()); - if (local_max_pstate_config != nullptr) { + if (const char* local_max_pstate_config = host_->get_property(cfg_max_pstate.get_name())) { max_pstate = std::stoul(local_max_pstate_config); } xbt_assert(max_pstate <= host_->get_pstate_count() - 1, "Value for max_pstate too large!"); @@ -299,21 +289,18 @@ public: if (activity.get_host() == get_host()) pre_task(); }); - simgrid::s4u::Activity::on_completion_cb([this](simgrid::s4u::Activity& activity) { - const auto* exec = dynamic_cast(&activity); - if (exec == nullptr) // Only Execs are concerned here - return; + simgrid::s4u::Exec::on_completion_cb([this](simgrid::s4u::Exec const& exec) { // For more than one host (not yet supported), we can access the host via // simcalls_.front()->issuer->get_iface()->get_host() - if (exec->get_host() == get_host() && iteration_running) { - comp_timer += exec->get_finish_time() - exec->get_start_time(); + if (exec.get_host() == get_host() && iteration_running) { + comp_timer += exec.get_finish_time() - exec.get_start_time(); } }); // FIXME I think that this fires at the same time for all hosts, so when the src sends something, // the dst will be notified even though it didn't even arrive at the recv yet - kernel::activity::CommImpl::on_start.connect([this](const kernel::activity::CommImpl& comm) { - const auto* act = static_cast(comm.surf_action_); - if ((get_host() == &act->get_src() || get_host() == &act->get_dst()) && iteration_running) { + simgrid::s4u::Comm::on_start_cb([this](const s4u::Comm& comm) { + if ((get_host() == comm.get_sender()->get_host() || get_host() == comm.get_receiver()->get_host()) && + iteration_running) { post_task(); } }); @@ -363,9 +350,7 @@ public: void update() override {} }; #endif -} // namespace dvfs -} // namespace plugin -} // namespace simgrid +} // namespace simgrid::plugin::dvfs /* **************************** events callback *************************** */ static void on_host_added(simgrid::s4u::Host& host) @@ -373,7 +358,7 @@ static void on_host_added(simgrid::s4u::Host& host) if (dynamic_cast(&host)) // Ignore virtual machines return; - std::string name = std::string("dvfs-daemon-") + host.get_cname(); + std::string name = "dvfs-daemon-" + host.get_name(); simgrid::s4u::ActorPtr daemon = simgrid::s4u::Actor::create(name.c_str(), &host, []() { /** * This lambda function is the function the actor (daemon) will execute @@ -385,9 +370,8 @@ static void on_host_added(simgrid::s4u::Host& host) XBT_DEBUG("DVFS process on %s is a daemon: %d", daemon_proc->get_host()->get_cname(), daemon_proc->is_daemon()); std::string dvfs_governor; - const char* host_conf = daemon_proc->get_host()->get_property("plugin/dvfs/governor"); - if (host_conf != nullptr) { - dvfs_governor = std::string(host_conf); + if (const char* host_conf = daemon_proc->get_host()->get_property("plugin/dvfs/governor")) { + dvfs_governor = host_conf; boost::algorithm::to_lower(dvfs_governor); } else { dvfs_governor = cfg_governor;