X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/blobdiff_plain/fc646b32904fce0465f564d149a830c8e7aeffe4..b3e6487cbebfaada40d407ac8d98daf9e370153c:/src/surf/cpu_ti.cpp diff --git a/src/surf/cpu_ti.cpp b/src/surf/cpu_ti.cpp index 89cc142f4a..6f1121be7f 100644 --- a/src/surf/cpu_ti.cpp +++ b/src/surf/cpu_ti.cpp @@ -1,13 +1,16 @@ -/* Copyright (c) 2013-2021. The SimGrid Team. All rights reserved. */ +/* Copyright (c) 2013-2022. The SimGrid Team. All rights reserved. */ /* This program is free software; you can redistribute it and/or modify it * under the terms of the license (GNU LGPL) which comes with this package. */ #include "cpu_ti.hpp" +#include "simgrid/kernel/routing/NetZoneImpl.hpp" +#include "simgrid/s4u/Engine.hpp" +#include "xbt/asserts.h" +#include "src/kernel/EngineImpl.hpp" #include "src/kernel/resource/profile/Event.hpp" #include "src/kernel/resource/profile/Profile.hpp" #include "src/surf/surf_interface.hpp" -#include "surf/surf.hpp" #include #include @@ -16,9 +19,7 @@ constexpr double EPSILON = 0.000000001; XBT_LOG_NEW_DEFAULT_SUBCATEGORY(cpu_ti, res_cpu, "CPU resource, Trace Integration model"); -namespace simgrid { -namespace kernel { -namespace resource { +namespace simgrid::kernel::resource { /********* * Trace * @@ -26,17 +27,28 @@ namespace resource { CpuTiProfile::CpuTiProfile(const profile::Profile* profile) { - double integral = 0; - double time = 0; - unsigned nb_points = profile->event_list.size() + 1; + double integral = 0; + double time = 0; + double prev_value = 1; + const std::vector& events=profile->get_event_list(); + xbt_assert(not events.empty()); + unsigned long nb_points = events.size() + 1; time_points_.reserve(nb_points); integral_.reserve(nb_points); - for (auto const& val : profile->event_list) { + for (auto const& val : events) { + time += val.date_; + integral += val.date_ * prev_value; time_points_.push_back(time); integral_.push_back(integral); - time += val.date_; - integral += val.date_ * val.value_; + prev_value = val.value_; } + + double delay=profile->get_repeat_delay()+ events.at(0).date_; + + xbt_assert( events.back().value_==prev_value,"Profiles need to end as they start"); + time += delay; + integral += delay*prev_value; + time_points_.push_back(time); integral_.push_back(integral); } @@ -53,10 +65,10 @@ CpuTiProfile::CpuTiProfile(const profile::Profile* profile) */ double CpuTiTmgr::integrate(double a, double b) const { - if ((a < 0.0) || (a > b)) { - xbt_die("Error, invalid integration interval [%.2f,%.2f]. " - "You probably have a task executing with negative computation amount. Check your code.", a, b); - } + xbt_assert(a >= 0.0 && a <= b, + "Error, invalid integration interval [%.2f,%.2f]. You probably have a task executing with negative " + "computation amount. Check your code.", + a, b); if (fabs(a - b) < EPSILON) return 0.0; @@ -71,7 +83,7 @@ double CpuTiTmgr::integrate(double a, double b) const a_index = ceil(a / last_time_); double b_index = floor(b / last_time_); - if (a_index > b_index) { /* Same chunk */ + if (a_index > b_index) { /* Same chunk */ return profile_->integrate_simple(a - (a_index - 1) * last_time_, b - b_index * last_time_); } @@ -102,11 +114,11 @@ double CpuTiProfile::integrate_simple(double a, double b) const double CpuTiProfile::integrate_simple_point(double a) const { double integral = 0; - double a_aux = a; - int ind = binary_search(time_points_, a); + double a_aux = a; + long ind = binary_search(time_points_, a); integral += integral_[ind]; - XBT_DEBUG("a %f ind %d integral %f ind + 1 %f ind %f time +1 %f time %f", a, ind, integral, integral_[ind + 1], + XBT_DEBUG("a %f ind %ld integral %f ind + 1 %f ind %f time +1 %f time %f", a, ind, integral, integral_[ind + 1], integral_[ind], time_points_[ind + 1], time_points_[ind]); double_update(&a_aux, time_points_[ind], sg_maxmin_precision * sg_surf_precision); if (a_aux > 0) @@ -137,11 +149,10 @@ double CpuTiTmgr::solve(double a, double amount) const } /* Sanity checks */ - if ((a < 0.0) || (amount < 0.0)) { - XBT_CRITICAL ("Error, invalid parameters [a = %.2f, amount = %.2f]. " - "You probably have a task executing with negative computation amount. Check your code.", a, amount); - xbt_abort(); - } + xbt_assert(a >= 0.0 && amount >= 0.0, + "Error, invalid parameters [a = %.2f, amount = %.2f]. " + "You probably have a task executing with negative computation amount. Check your code.", + a, amount); /* At this point, a and amount are positive */ if (amount < EPSILON) @@ -155,21 +166,18 @@ double CpuTiTmgr::solve(double a, double amount) const XBT_DEBUG("amount %f total %f", amount, total_); /* Reduce the problem to one where amount <= trace_total */ double quotient = floor(amount / total_); - double reduced_amount = (total_) * ((amount / total_) - floor(amount / total_)); - double reduced_a = a - (last_time_) * static_cast(floor(a / last_time_)); + double reduced_amount = total_ * ((amount / total_) - floor(amount / total_)); + double reduced_a = a - last_time_ * static_cast(floor(a / last_time_)); XBT_DEBUG("Quotient: %g reduced_amount: %f reduced_a: %f", quotient, reduced_amount, reduced_a); /* Now solve for new_amount which is <= trace_total */ - double reduced_b; XBT_DEBUG("Solve integral: [%.2f, amount=%.2f]", reduced_a, reduced_amount); - double amount_till_end = integrate(reduced_a, last_time_); - if (amount_till_end > reduced_amount) { - reduced_b = profile_->solve_simple(reduced_a, reduced_amount); - } else { - reduced_b = last_time_ + profile_->solve_simple(0.0, reduced_amount - amount_till_end); - } + double amount_till_end = integrate(reduced_a, last_time_); + double reduced_b = amount_till_end > reduced_amount + ? profile_->solve_simple(reduced_a, reduced_amount) + : last_time_ + profile_->solve_simple(0.0, reduced_amount - amount_till_end); /* Re-map to the original b and amount */ return last_time_ * floor(a / last_time_) + (quotient * last_time_) + reduced_b; @@ -185,7 +193,7 @@ double CpuTiTmgr::solve(double a, double amount) const double CpuTiProfile::solve_simple(double a, double amount) const { double integral_a = integrate_simple_point(a); - int ind = binary_search(integral_, integral_a + amount); + long ind = binary_search(integral_, integral_a + amount); double time = time_points_[ind]; time += (integral_a + amount - integral_[ind]) / ((integral_[ind + 1] - integral_[ind]) / (time_points_[ind + 1] - time_points_[ind])); @@ -202,9 +210,9 @@ double CpuTiProfile::solve_simple(double a, double amount) const */ double CpuTiTmgr::get_power_scale(double a) const { - double reduced_a = a - floor(a / last_time_) * last_time_; - int point = CpuTiProfile::binary_search(profile_->time_points_, reduced_a); - kernel::profile::DatedValue val = speed_profile_->event_list.at(point); + double reduced_a = a - floor(a / last_time_) * last_time_; + long point = CpuTiProfile::binary_search(profile_->get_time_points(), reduced_a); + profile::DatedValue val = speed_profile_->get_event_list().at(point); return val.value_; } @@ -227,17 +235,20 @@ CpuTiTmgr::CpuTiTmgr(kernel::profile::Profile* speed_profile, double value) : sp return; } + xbt_assert(speed_profile->is_repeating()); + /* only one point available, fixed trace */ - if (speed_profile->event_list.size() == 1) { - value_ = speed_profile->event_list.front().value_; + if (speed_profile->get_event_list().size() == 1) { + value_ = speed_profile->get_event_list().front().value_; return; } type_ = Type::DYNAMIC; /* count the total time of trace file */ - for (auto const& val : speed_profile->event_list) + for (auto const& val : speed_profile->get_event_list()) total_time += val.date_; + total_time += speed_profile->get_repeat_delay(); profile_ = std::make_unique(speed_profile); last_time_ = total_time; @@ -253,7 +264,7 @@ CpuTiTmgr::CpuTiTmgr(kernel::profile::Profile* speed_profile, double value) : sp * @param a Value to search * @return Index of point */ -int CpuTiProfile::binary_search(const std::vector& array, double a) +long CpuTiProfile::binary_search(const std::vector& array, double a) { if (array[0] > a) return 0; @@ -265,26 +276,15 @@ int CpuTiProfile::binary_search(const std::vector& array, double a) * Model * *********/ -void CpuTiModel::create_pm_vm_models() -{ - xbt_assert(surf_cpu_model_pm == nullptr, "CPU model already initialized. This should not happen."); - xbt_assert(surf_cpu_model_vm == nullptr, "CPU model already initialized. This should not happen."); - - surf_cpu_model_pm = new CpuTiModel(); - surf_cpu_model_vm = new CpuTiModel(); -} - -CpuTiModel::CpuTiModel() : CpuModel(Model::UpdateAlgo::FULL) -{ - all_existing_models.push_back(this); -} - -CpuTiModel::~CpuTiModel() +void CpuTiModel::create_pm_models() { - surf_cpu_model_pm = nullptr; + auto cpu_model_pm = std::make_shared("Cpu_TI"); + auto* engine = EngineImpl::get_instance(); + engine->add_model(cpu_model_pm); + engine->get_netzone_root()->set_cpu_pm_model(cpu_model_pm); } -Cpu* CpuTiModel::create_cpu(s4u::Host* host, const std::vector& speed_per_pstate) +CpuImpl* CpuTiModel::create_cpu(s4u::Host* host, const std::vector& speed_per_pstate) { return (new CpuTi(host, speed_per_pstate))->set_model(this); } @@ -316,14 +316,14 @@ void CpuTiModel::update_actions_state(double now, double /*delta*/) XBT_DEBUG("Action %p: finish", action); action->finish(Action::State::FINISHED); /* update remaining amount of all actions */ - action->cpu_->update_remaining_amount(surf_get_clock()); + action->cpu_->update_remaining_amount(EngineImpl::get_clock()); } } /************ * Resource * ************/ -CpuTi::CpuTi(s4u::Host* host, const std::vector& speed_per_pstate) : Cpu(host, speed_per_pstate) +CpuTi::CpuTi(s4u::Host* host, const std::vector& speed_per_pstate) : CpuImpl(host, speed_per_pstate) { speed_.peak = speed_per_pstate.front(); XBT_DEBUG("CPU create: peak=%f", speed_.peak); @@ -337,19 +337,20 @@ CpuTi::~CpuTi() delete speed_integrated_trace_; } -void CpuTi::set_speed_profile(kernel::profile::Profile* profile) +CpuImpl* CpuTi::set_speed_profile(kernel::profile::Profile* profile) { delete speed_integrated_trace_; speed_integrated_trace_ = new CpuTiTmgr(profile, speed_.scale); /* add a fake trace event if periodicity == 0 */ - if (profile && profile->event_list.size() > 1) { - kernel::profile::DatedValue val = profile->event_list.back(); + if (profile && profile->get_event_list().size() > 1) { + kernel::profile::DatedValue val = profile->get_event_list().back(); if (val.date_ < 1e-12) { - auto* prof = new kernel::profile::Profile(); + auto* prof = profile::ProfileBuilder::from_void(); speed_.event = prof->schedule(&profile::future_evt_set, this); } } + return this; } void CpuTi::apply_event(kernel::profile::Event* event, double value) @@ -358,7 +359,7 @@ void CpuTi::apply_event(kernel::profile::Event* event, double value) XBT_DEBUG("Speed changed in trace! New fixed value: %f", value); /* update remaining of actions and put in modified cpu list */ - update_remaining_amount(surf_get_clock()); + update_remaining_amount(EngineImpl::get_clock()); set_modified(true); @@ -368,7 +369,7 @@ void CpuTi::apply_event(kernel::profile::Event* event, double value) speed_.scale = value; tmgr_trace_event_unref(&speed_.event); - } else if (event == state_event_) { + } else if (event == get_state_event()) { if (value > 0) { if (not is_on()) { XBT_VERB("Restart actors on host %s", get_iface()->get_cname()); @@ -376,7 +377,7 @@ void CpuTi::apply_event(kernel::profile::Event* event, double value) } } else { get_iface()->turn_off(); - double date = surf_get_clock(); + double date = EngineImpl::get_clock(); /* put all action running on cpu to failed */ for (CpuTiAction& action : action_set_) { @@ -388,7 +389,7 @@ void CpuTi::apply_event(kernel::profile::Event* event, double value) } } } - tmgr_trace_event_unref(&state_event_); + unref_state_event(); } else { xbt_die("Unknown event!\n"); @@ -405,7 +406,7 @@ void CpuTi::update_actions_finish_time(double now) sum_priority_ = 0.0; for (CpuTiAction const& action : action_set_) { /* action not running, skip it */ - if (action.get_state_set() != surf_cpu_model_pm->get_started_action_set()) + if (action.get_state_set() != get_model()->get_started_action_set()) continue; /* bogus priority, skip it */ @@ -420,9 +421,9 @@ void CpuTi::update_actions_finish_time(double now) } for (CpuTiAction& action : action_set_) { - double min_finish = -1; + double min_finish = NO_MAX_DURATION; /* action not running, skip it */ - if (action.get_state_set() != surf_cpu_model_pm->get_started_action_set()) + if (action.get_state_set() != get_model()->get_started_action_set()) continue; /* verify if the action is really running on cpu */ @@ -462,8 +463,8 @@ bool CpuTi::is_used() const double CpuTi::get_speed_ratio() { - speed_.scale = speed_integrated_trace_->get_power_scale(surf_get_clock()); - return Cpu::get_speed_ratio(); + speed_.scale = speed_integrated_trace_->get_power_scale(EngineImpl::get_clock()); + return CpuImpl::get_speed_ratio(); } /** @brief Update the remaining amount of actions */ @@ -504,9 +505,10 @@ void CpuTi::update_remaining_amount(double now) last_update_ = now; } -CpuAction* CpuTi::execution_start(double size) +CpuAction* CpuTi::execution_start(double size, double user_bound) { XBT_IN("(%s,%g)", get_cname(), size); + xbt_assert(user_bound <= 0, "Invalid user bound (%lf) in CPU TI model", user_bound); auto* action = new CpuTiAction(this, size); action_set_.push_back(*action); // Actually start the action @@ -599,26 +601,6 @@ void CpuTiAction::resume() XBT_OUT(); } -void CpuTiAction::set_max_duration(double duration) -{ - double min_finish; - - XBT_IN("(%p,%g)", this, duration); - - Action::set_max_duration(duration); - - if (duration >= 0) - min_finish = (get_start_time() + get_max_duration()) < get_finish_time() ? (get_start_time() + get_max_duration()) - : get_finish_time(); - else - min_finish = get_finish_time(); - - /* add in action heap */ - get_model()->get_action_heap().update(this, min_finish, ActionHeap::Type::unset); - - XBT_OUT(); -} - void CpuTiAction::set_sharing_penalty(double sharing_penalty) { XBT_IN("(%p,%g)", this, sharing_penalty); @@ -630,11 +612,9 @@ void CpuTiAction::set_sharing_penalty(double sharing_penalty) double CpuTiAction::get_remains() { XBT_IN("(%p)", this); - cpu_->update_remaining_amount(surf_get_clock()); + cpu_->update_remaining_amount(EngineImpl::get_clock()); XBT_OUT(); return get_remains_no_update(); } -} // namespace resource -} // namespace kernel -} // namespace simgrid +} // namespace simgrid::kernel::resource