From: Martin Quinson <martin.quinson@ens-rennes.fr>
Date: Fri, 11 Feb 2022 10:16:29 +0000 (+0100)
Subject: don't use char* for pointers that shall be serialized with >>
X-Git-Tag: v3.31~453
X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/06a4291371a1f3425628a6715242dfab4cdb010c

don't use char* for pointers that shall be serialized with >>
---

diff --git a/src/kernel/actor/SimcallObserver.cpp b/src/kernel/actor/SimcallObserver.cpp
index b977abcb6c..f7f77f4ab7 100644
--- a/src/kernel/actor/SimcallObserver.cpp
+++ b/src/kernel/actor/SimcallObserver.cpp
@@ -348,6 +348,7 @@ void CommIsendSimcall::serialize(Simcall& type, char* buffer)
   std::stringstream stream;
   stream << mbox_->get_id() << ' ' << (void*)src_buff_ << ' ' << src_buff_size_;
   strcpy(buffer, stream.str().c_str());
+  XBT_DEBUG("SendObserver mbox:%u buff:%p size:%zu", mbox_->get_id(), src_buff_, src_buff_size_);
 }
 
 void CommIrecvSimcall::serialize(Simcall& type, char* buffer)
diff --git a/src/mc/Transition.cpp b/src/mc/Transition.cpp
index a0c37f24e9..b08eb1853f 100644
--- a/src/mc/Transition.cpp
+++ b/src/mc/Transition.cpp
@@ -50,6 +50,8 @@ CommWaitTransition::CommWaitTransition(aid_t issuer, int times_considered, char*
 {
   std::stringstream stream(buffer);
   stream >> timeout_ >> comm_ >> sender_ >> receiver_ >> mbox_ >> src_buff_ >> dst_buff_ >> size_;
+  XBT_DEBUG("CommWaitTransition tout:%f comm:%p, sender:%ld receiver:%ld mbox:%u sbuff:%p rbuff:%p size:%zu", timeout_,
+            comm_, sender_, receiver_, mbox_, src_buff_, dst_buff_, size_);
 }
 std::string CommWaitTransition::to_string(bool verbose)
 {
@@ -143,6 +145,7 @@ CommSendTransition::CommSendTransition(aid_t issuer, int times_considered, char*
 {
   std::stringstream stream(buffer);
   stream >> mbox_ >> src_buff_ >> size_;
+  XBT_DEBUG("SendTransition mbox:%u buff:%p size:%zu", mbox_, src_buff_, size_);
 }
 std::string CommSendTransition::to_string(bool verbose = false)
 {
diff --git a/src/mc/Transition.hpp b/src/mc/Transition.hpp
index 88e7747905..8bf38a96df 100644
--- a/src/mc/Transition.hpp
+++ b/src/mc/Transition.hpp
@@ -70,12 +70,12 @@ class CommRecvTransition;
 
 class CommWaitTransition : public Transition {
   double timeout_;
-  uintptr_t comm_;
+  void* comm_;
   aid_t sender_;
   aid_t receiver_;
   unsigned mbox_;
-  unsigned char* src_buff_;
-  unsigned char* dst_buff_;
+  void* src_buff_;
+  void* dst_buff_;
   size_t size_;
   friend CommSendTransition;
   friend CommRecvTransition;