From: Martin Quinson <martin.quinson@ens-rennes.fr>
Date: Mon, 7 Mar 2022 08:09:59 +0000 (+0100)
Subject: sonar
X-Git-Tag: v3.31~207
X-Git-Url: http://bilbo.iut-bm.univ-fcomte.fr/pub/gitweb/simgrid.git/commitdiff_plain/9960565e03934f289c6fb41d34240ed27b6c76c2

sonar

- Ignore MBI scripts in the coverage
- unused local variable was indeed a bug
---

diff --git a/sonar-project.properties b/sonar-project.properties
index 4d9201fa1a..1742c3f472 100644
--- a/sonar-project.properties
+++ b/sonar-project.properties
@@ -199,7 +199,7 @@ sonar.cfamily.gcov.reportsPath=Testing/CoverageInfo
 #   - Python files used to generate either simcalls or deployment files
 #   - Any java source code (it's deprecated now)
 #   - MSG (deprecated too)
-sonar.coverage.exclusions=teshsuite/smpi/mpich3-test/**,examples/smpi/mc/**,**/*.xml,src/simix/simcalls.py,**/generate.py,**/*.java,src/bindings/java/**,src/msg/**,include/msg/**,examples/deprecated/**,teshsuite/msg/**
+sonar.coverage.exclusions=teshsuite/smpi/mpich3-test/**,teshsuite/smpi/MBI/**,examples/smpi/mc/**,**/*.xml,**/generate.py,**/*.java,src/bindings/java/**,src/msg/**,include/msg/**,examples/deprecated/**,teshsuite/msg/**
 
 # Encoding of the source files
 sonar.sourceEncoding=UTF-8
diff --git a/teshsuite/smpi/MBI/simgrid.py b/teshsuite/smpi/MBI/simgrid.py
index 1dc6befee6..b4f4158291 100644
--- a/teshsuite/smpi/MBI/simgrid.py
+++ b/teshsuite/smpi/MBI/simgrid.py
@@ -70,7 +70,7 @@ class Tool(AbstractTool):
 
     def parse(self, cachefile):
         if os.path.exists(f'{cachefile}.timeout') or os.path.exists(f'logs/simgrid/{cachefile}.timeout'):
-            outcome = 'timeout'
+            return 'timeout'
         if not (os.path.exists(f'{cachefile}.txt') or os.path.exists(f'logs/simgrid/{cachefile}.txt')):
             return 'failure'