Ehsan Azimi [Tue, 8 Dec 2020 16:48:48 +0000 (17:48 +0100)]
mc_api::get_automaton_transition_label() defined and called in run()
Ehsan Azimi [Tue, 8 Dec 2020 16:33:30 +0000 (17:33 +0100)]
mc_api::get_dynar_length() defined and called in run()
Ehsan Azimi [Tue, 8 Dec 2020 16:14:27 +0000 (17:14 +0100)]
mcapi::log_state() in run()
Ehsan Azimi [Tue, 8 Dec 2020 16:14:06 +0000 (17:14 +0100)]
mcapi::mc_wait_for_requests() in run()
Ehsan Azimi [Tue, 8 Dec 2020 16:13:41 +0000 (17:13 +0100)]
mcapi::handle_simcall() in run()
Ehsan Azimi [Tue, 8 Dec 2020 16:13:15 +0000 (17:13 +0100)]
mcapi::mc_inc_executed_trans() in run()
Ehsan Azimi [Tue, 8 Dec 2020 11:04:22 +0000 (12:04 +0100)]
request_to_string() implementation in mc_api class
Ehsan Azimi [Tue, 8 Dec 2020 10:41:59 +0000 (11:41 +0100)]
Pull from simgrid/master and a subsequent merge with origin/master
Ehsan Azimi [Tue, 8 Dec 2020 10:41:37 +0000 (11:41 +0100)]
request_get_dot_output() implementation in mc_api class
Ehsan Azimi [Tue, 8 Dec 2020 10:40:02 +0000 (11:40 +0100)]
mcapi::request_get_dot_output() called in run()
Arnaud Giersch [Mon, 7 Dec 2020 22:49:17 +0000 (23:49 +0100)]
Convert deprecated/msg/trace-masterworker to s4u/trace-masterworkers.
Ehsan Azimi [Tue, 8 Dec 2020 09:52:33 +0000 (10:52 +0100)]
mcapi::snapshot_equal() in insert_visited_pair()
Ehsan Azimi [Tue, 8 Dec 2020 09:52:02 +0000 (10:52 +0100)]
mcapi::automaton_state_compare() in insert_visited_pair()
Ehsan Azimi [Tue, 8 Dec 2020 09:37:36 +0000 (10:37 +0100)]
mcapi::snapshot_equal() called in insert_acceptance_pair()
Ehsan Azimi [Tue, 8 Dec 2020 09:37:12 +0000 (10:37 +0100)]
mc_api::automaton_state_compare() defined. It's called in insert_acceptance_pair()
Ehsan Azimi [Tue, 8 Dec 2020 09:23:32 +0000 (10:23 +0100)]
mcapi::compare_pair() in insert_acceptance_pair()
Ehsan Azimi [Tue, 8 Dec 2020 09:07:59 +0000 (10:07 +0100)]
mcapi::compare_pair() in addVisitedState()
Ehsan Azimi [Tue, 8 Dec 2020 08:52:28 +0000 (09:52 +0100)]
mc_api::compare_pair() defined, it's called in insert_visited_pair()
Ehsan Azimi [Tue, 8 Dec 2020 08:35:45 +0000 (09:35 +0100)]
A Pull from simgrid/master and a subsequent merge
Arnaud Giersch [Mon, 7 Dec 2020 22:22:40 +0000 (23:22 +0100)]
Spacing cosmetics.
Arnaud Giersch [Mon, 7 Dec 2020 21:47:20 +0000 (22:47 +0100)]
Fix misleading cmake message.
"Example mc-bugged1-liveness disabled, thus not compiled." while it's not true.
Arnaud Giersch [Mon, 7 Dec 2020 21:01:14 +0000 (22:01 +0100)]
Reduce scope for variables.
Arnaud Giersch [Mon, 7 Dec 2020 20:27:10 +0000 (21:27 +0100)]
Useless code.
Arnaud Giersch [Mon, 7 Dec 2020 20:17:27 +0000 (21:17 +0100)]
Fix type.
Arnaud Giersch [Mon, 7 Dec 2020 16:02:00 +0000 (17:02 +0100)]
Update MANIFEST.in.
Arnaud Giersch [Mon, 7 Dec 2020 15:04:37 +0000 (16:04 +0100)]
Convert deprecated/msg/trace-host-user-variables to s4u/trace-host-user-variables.
Arnaud Giersch [Mon, 7 Dec 2020 14:02:15 +0000 (15:02 +0100)]
Convert deprecated/msg/trace-link-user-variables to s4u/trace-link-user-variables.
Arnaud Giersch [Mon, 7 Dec 2020 12:48:23 +0000 (13:48 +0100)]
Convert deprecated/msg/trace-host-user-variables to s4u/trace-host-user-variables.
Arnaud Giersch [Mon, 7 Dec 2020 09:46:09 +0000 (10:46 +0100)]
Convert deprecated/msg/trace-categories to s4u/trace-categories.
Arnaud Giersch [Mon, 7 Dec 2020 10:55:39 +0000 (11:55 +0100)]
Chdir into example directory, and set srcdir.
Ehsan Azimi [Mon, 7 Dec 2020 10:09:41 +0000 (11:09 +0100)]
mc_api::set_property_automaton(), it is called in run()
Arnaud Giersch [Sat, 5 Dec 2020 13:34:53 +0000 (14:34 +0100)]
[sonar] Refactor to reduce nested blocks.
Arnaud Giersch [Sat, 5 Dec 2020 10:22:24 +0000 (11:22 +0100)]
[sonar] s/NULL/nullptr.
Ehsan Azimi [Fri, 4 Dec 2020 23:15:41 +0000 (00:15 +0100)]
pull from simgrid/master and a subsequent merge with origin/master
Arnaud Giersch [Fri, 4 Dec 2020 20:14:17 +0000 (21:14 +0100)]
Change timeout value to avoid a NetworkFailureException.
We don't want ctest to report a test failure.
Ehsan Azimi [Fri, 4 Dec 2020 18:23:54 +0000 (19:23 +0100)]
CodeFactor nags!
Ehsan Azimi [Fri, 4 Dec 2020 18:16:47 +0000 (19:16 +0100)]
mc_api::compare_automaton_exp_lable() defined. It's called in evaluate_label()
Ehsan Azimi [Fri, 4 Dec 2020 17:18:14 +0000 (18:18 +0100)]
mc_api::get_automaton_state() defined. It is called in LivenessChecker::run()
Ehsan Azimi [Fri, 4 Dec 2020 16:55:17 +0000 (17:55 +0100)]
code arrangement
Ehsan Azimi [Fri, 4 Dec 2020 16:48:53 +0000 (17:48 +0100)]
mcapi.actor_is_enabled() is called in LivenessChecker::create_pair()
Ehsan Azimi [Fri, 4 Dec 2020 16:48:13 +0000 (17:48 +0100)]
mcapi.get_actors() is called in LivenessChecker::create_pair()
Ehsan Azimi [Fri, 4 Dec 2020 16:19:47 +0000 (17:19 +0100)]
Pull simgrid/master and a subsequent merge
Arnaud Giersch [Fri, 4 Dec 2020 16:06:36 +0000 (17:06 +0100)]
Please cppcheck.
Arnaud Giersch [Fri, 4 Dec 2020 11:13:50 +0000 (12:13 +0100)]
Use type 'bool' for boolean.
Arnaud Giersch [Fri, 4 Dec 2020 11:04:10 +0000 (12:04 +0100)]
Drop xbt_str_split().
Arnaud Giersch [Fri, 4 Dec 2020 10:51:18 +0000 (11:51 +0100)]
[sonar] Reduce number of nested code blocks.
Best viewed with 'git show -b'
Arnaud Giersch [Fri, 4 Dec 2020 09:27:07 +0000 (10:27 +0100)]
Increase coverage.
Arnaud Giersch [Fri, 4 Dec 2020 09:13:09 +0000 (10:13 +0100)]
Drop unused smpi/plugins/load_balancer.
There's no example, and it seems that it's not used since nearly 2 years.
Arnaud Giersch [Fri, 4 Dec 2020 15:32:24 +0000 (16:32 +0100)]
Fix comment.
Ehsan Azimi [Fri, 4 Dec 2020 15:00:41 +0000 (16:00 +0100)]
mc_api::automaton_propositional_symbol_evaluate() is used in LivenessChecker::get_proposition_values()
Ehsan Azimi [Fri, 4 Dec 2020 14:50:32 +0000 (15:50 +0100)]
mc_api::s_initialize() renamed to mc_api::session_initialize()
Ehsan Azimi [Fri, 4 Dec 2020 14:47:00 +0000 (15:47 +0100)]
call to mcapi.s_initialize()
Ehsan Azimi [Fri, 4 Dec 2020 14:10:47 +0000 (15:10 +0100)]
mc_api::automaton_load() defined
Arnaud Giersch [Fri, 4 Dec 2020 07:48:27 +0000 (08:48 +0100)]
Fix comment : 2nd arg was never used.
Arnaud Giersch [Fri, 4 Dec 2020 07:46:35 +0000 (08:46 +0100)]
Add more tests for coverage.
Arnaud Giersch [Fri, 4 Dec 2020 07:36:49 +0000 (08:36 +0100)]
Cosmetics (uppercase).
Arnaud Giersch [Fri, 4 Dec 2020 07:25:17 +0000 (08:25 +0100)]
Change parameter to increase coverage.
Arnaud Giersch [Thu, 3 Dec 2020 22:35:48 +0000 (23:35 +0100)]
Exclude examples/smpi/mc from coverage analysis.
Arnaud Giersch [Thu, 3 Dec 2020 22:15:57 +0000 (23:15 +0100)]
Dry run MC examples for coverage.
Arnaud Giersch [Thu, 3 Dec 2020 22:13:50 +0000 (23:13 +0100)]
Allow to set a deadline for test.
Arnaud Giersch [Thu, 3 Dec 2020 20:40:50 +0000 (21:40 +0100)]
Unused argument.
Arnaud Giersch [Thu, 3 Dec 2020 20:11:24 +0000 (21:11 +0100)]
Revert "Silly workaround for coverage build with gcc-10."
This reverts commit
d345b5dad90a1ec9829011b9188185aaf4d3240a.
The problem with gcc was likely fixed with PR fortran/95847
(see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95847)
Arnaud Giersch [Tue, 1 Dec 2020 13:46:03 +0000 (14:46 +0100)]
Update .mailmap.
Arnaud Giersch [Sun, 29 Nov 2020 09:18:29 +0000 (10:18 +0100)]
Attribute 'const'.
Arnaud Giersch [Sun, 29 Nov 2020 09:10:50 +0000 (10:10 +0100)]
Attribute 'noreturn'.
Arnaud Giersch [Sun, 29 Nov 2020 08:51:54 +0000 (09:51 +0100)]
Use operator= to copy std::vector.
Arnaud Giersch [Sun, 29 Nov 2020 09:16:20 +0000 (10:16 +0100)]
MC_smx_get_maxpid returns an unsigned long.
Arnaud Giersch [Sat, 28 Nov 2020 13:31:19 +0000 (14:31 +0100)]
Fix build MC+NO_SMPI.
Arnaud Giersch [Thu, 26 Nov 2020 22:22:39 +0000 (23:22 +0100)]
[pvs] Don't let field uninitialized.
Arnaud Giersch [Thu, 26 Nov 2020 20:31:42 +0000 (21:31 +0100)]
Call the good function.
Caught by PVS-studio.
Arnaud Giersch [Tue, 1 Dec 2020 13:10:25 +0000 (14:10 +0100)]
Merge remote-tracking branch 'github/master'
Martin Quinson [Tue, 1 Dec 2020 13:01:01 +0000 (14:01 +0100)]
Merge pull request #369 from eazimi/master
Further work on the Facade API of Mc SimGrid.
Ehsan Azimi [Tue, 1 Dec 2020 12:46:10 +0000 (13:46 +0100)]
static function
Ehsan Azimi [Tue, 1 Dec 2020 07:52:43 +0000 (08:52 +0100)]
mcapi::get().request_to_string() called in LivenessChecker::replay() and LivenessChecker::run()
Ehsan Azimi [Tue, 1 Dec 2020 07:50:20 +0000 (08:50 +0100)]
LivenessChecker::get_textual_trace() calls a facade api
Ehsan Azimi [Tue, 1 Dec 2020 07:46:38 +0000 (08:46 +0100)]
mc_api::mc_dump_record_path() renamed to mc_api::dump_record_path()
Ehsan Azimi [Tue, 1 Dec 2020 07:44:59 +0000 (08:44 +0100)]
LivenessChecker::show_acceptance_cycle() call facade APIs
Ehsan Azimi [Tue, 1 Dec 2020 07:40:09 +0000 (08:40 +0100)]
LivenessChecker::log_state() calls a facade api
Ehsan Azimi [Tue, 1 Dec 2020 07:09:02 +0000 (08:09 +0100)]
copy_incomplete_comm_pattern() and copy_index_comm_pattern() moved from mc_api to mc_state class
Ehsan Azimi [Tue, 1 Dec 2020 07:06:49 +0000 (08:06 +0100)]
cleanup!
Ehsan Azimi [Mon, 30 Nov 2020 17:39:03 +0000 (18:39 +0100)]
MC_restore_communications_pattern() and MC_patterns_copy() moved to CommunicationDeterminismChecker.cpp,
mc_comm_pattern.cpp dissolved
Ehsan Azimi [Mon, 30 Nov 2020 17:10:55 +0000 (18:10 +0100)]
CommunicationDeterminismChecker class doesn't use RemotePtr, it passes paramaters
with CommImpl* type to APIs in mc_api (fasade layer). The mc_api calls RemotePtr and does
the required conversion.
Ehsan Azimi [Mon, 30 Nov 2020 16:35:00 +0000 (17:35 +0100)]
mc_api::comm_addr_equal() is used in CommunicationDeterminismChecker::complete_comm_pattern()
Ehsan Azimi [Mon, 30 Nov 2020 16:34:23 +0000 (17:34 +0100)]
handle_comm_pattern() defined in CommunicationDeterminismChecker class,
mc_api::get_comm_wait_raw_addr() and mc_api::get_comm_waitany_raw_addr()
are used in handle_comm_pattern()
Ehsan Azimi [Mon, 30 Nov 2020 16:23:22 +0000 (17:23 +0100)]
mc_api::comm_addr_equal() defined
Ehsan Azimi [Mon, 30 Nov 2020 16:22:49 +0000 (17:22 +0100)]
mc_api::get_comm_waitany_raw_addr() defined
Ehsan Azimi [Mon, 30 Nov 2020 16:22:12 +0000 (17:22 +0100)]
mc_api::get_comm_wait_raw_addr() defined
Ehsan Azimi [Mon, 30 Nov 2020 16:18:13 +0000 (17:18 +0100)]
mc_api::get_pattern_comm_addr() is renamed to mc_api::get_comm_isend_raw_addr()
Ehsan Azimi [Mon, 30 Nov 2020 10:43:27 +0000 (11:43 +0100)]
MC_state_copy_incomplete_communications_pattern() implemented in mc_api
Ehsan Azimi [Mon, 30 Nov 2020 10:31:44 +0000 (11:31 +0100)]
MC_state_copy_index_communications_pattern() implemented in mc_api
Ehsan Azimi [Mon, 30 Nov 2020 10:21:17 +0000 (11:21 +0100)]
more cleanups
Ehsan Azimi [Mon, 30 Nov 2020 09:02:41 +0000 (10:02 +0100)]
mcapi::s_restore_initial_state() renamed to mcapi::restore_initial_state()
Ehsan Azimi [Mon, 30 Nov 2020 08:56:18 +0000 (09:56 +0100)]
A little bit clean up, mc_api::s_log_state() renamed to mc_api::log_state()
Ehsan Azimi [Mon, 30 Nov 2020 08:39:17 +0000 (09:39 +0100)]
mcapi::get().get_actors() is called in CommunicationDeterminismChecker::real_run()
Ehsan Azimi [Mon, 30 Nov 2020 08:31:18 +0000 (09:31 +0100)]
mc_api::restore_state() is defined, it is used in SafetyChecker::restore_state() and CommunicationDeterminismChecker::restoreState()
Ehsan Azimi [Mon, 30 Nov 2020 07:55:32 +0000 (08:55 +0100)]
mc_api::get_actors_size() defined and it is used in VisitedState::VisitedState()
Ehsan Azimi [Mon, 30 Nov 2020 07:21:14 +0000 (08:21 +0100)]
mc_api (facade layer) is merged with mster branch in simgrid project
Arnaud Giersch [Sun, 29 Nov 2020 10:18:43 +0000 (11:18 +0100)]
Fix comment.
Ehsan Azimi [Fri, 27 Nov 2020 23:12:04 +0000 (00:12 +0100)]
Introduce mc::mc_api (pull request 1 -- #349)
* mc_api class introduced, SafetyChecher's constructor and main() in simgrid_mc.cpp call mc_api's functions
* SafetyChecker::restore_state() calls mc_api functions
* SafetyChecker::backtrack() calls mc_api functions
* SafetyChecker::log_state() calls APIs of mc_api
* SafetyChecker::get_textual_trace() uses mc_api
* SafetyChecker::check_non_termination() uses mc_api
* SafetyChecker::run() uses mc_api
* mc_assert() deleted
* get_maxpid() and take_snapshot() in mc_api
* copy_incomplete_comm_pattern() and copy_index_comm_pattern() in mc_api
* mc_api::mc_state_choose_request() updated
* In VisitedState class, get_remote_heap_bytes() from mc_api is called
* prepare() and run() call APIs of mc_api
* CommunicationDeterminismChecker::real_run() uses APIs of mc_api
* CommunicationDeterminismChecker::restoreState() uses APIs of mc_api
* CommunicationDeterminismChecker::log_state() uses APIs of mc_api
* mc_pattern.hpp created
* get_pattern_comm_rdv() defined in mc_api and used in CommDet checker
* mc_api::get_pattern_comm_rdv()
mc_api::get_pattern_comm_addr()
mc_api::get_pattern_comm_src_proc()
mc_api::get_pattern_comm_data()
mc_api::get_actor_host_name()
The above functions are defined in mc_api and being used in comm_dete checker
* conflict with simgrid/master resolved
* unused variable removed
* call APIs from facade layer
* mc_api::get_smpi_request_tag() defined and used in comm_deter checker
* mc_api::get_pattern_comm_dst_proc() defined and used in comm_deter checker
* mc_api::check_send_request_detached() defined and used in comm_deter checker
* CommunicationDeterminismChecker::deterministic_comm_pattern() uses APIs of mc_api
* mc_api clean up
* mc_api::get_src_actor() defined,
it used in update_comm_pattern() of comm. deter. checker
* mc_api::get_dst_actor() defined,
it used in update_comm_pattern() of comm. deter. checker
* mc_api::get_actor_host_name() used by update_comm_pattern() in comm. deter. checker
* mc_api::get_pattern_comm_data() defined,
it used by update_comm_pattern() in comm. deter. checker
Co-authored-by: Ehsan Azimi <eazimi@ehsan.irisa.fr>
Ehsan Azimi [Fri, 27 Nov 2020 20:37:47 +0000 (21:37 +0100)]
mc_api::get_pattern_comm_data() defined,
it used by update_comm_pattern() in comm. deter. checker