Arnaud Giersch [Tue, 1 Jun 2021 20:45:17 +0000 (22:45 +0200)]
Add missing calls to smpi_bench_begin() on error paths.
Bruno Donassolo [Tue, 1 Jun 2021 15:48:47 +0000 (17:48 +0200)]
Cannot set split-duplex through s4u intf.
This makes sense only in XML where it properly creates the
link-up/link-down.
Bruno Donassolo [Tue, 1 Jun 2021 15:48:18 +0000 (17:48 +0200)]
Add fg#71 to changelog [ci-skip]
Arnaud Giersch [Tue, 1 Jun 2021 13:51:01 +0000 (15:51 +0200)]
Missing include.
Arnaud Giersch [Tue, 1 Jun 2021 13:30:44 +0000 (15:30 +0200)]
Coding style: no global "using namespace".
Arnaud Giersch [Tue, 1 Jun 2021 13:26:10 +0000 (15:26 +0200)]
Prefer std algorithms.
Arnaud Giersch [Tue, 1 Jun 2021 12:53:37 +0000 (14:53 +0200)]
Invert tests to reduce depth of nesting.
Arnaud Giersch [Tue, 1 Jun 2021 12:50:07 +0000 (14:50 +0200)]
Useless tests for emptyness.
Arnaud Giersch [Tue, 1 Jun 2021 10:59:34 +0000 (12:59 +0200)]
Add attribute(printf) to xbt::string_printf.
Arnaud Giersch [Tue, 1 Jun 2021 07:38:57 +0000 (09:38 +0200)]
Pointer-to-const for Sonar.
Arnaud Giersch [Mon, 31 May 2021 21:20:24 +0000 (23:20 +0200)]
Set shared variable *before* mutex unlock.
Arnaud Giersch [Mon, 31 May 2021 21:01:42 +0000 (23:01 +0200)]
Die on unwanted function calls.
Arnaud Giersch [Mon, 31 May 2021 20:53:55 +0000 (22:53 +0200)]
Parameter 'assert' is a bit field.
Bruno Donassolo [Mon, 31 May 2021 17:22:28 +0000 (19:22 +0200)]
Fixes in UTs
Arnaud Giersch [Mon, 31 May 2021 13:40:40 +0000 (15:40 +0200)]
Handle case where different groups are given to MPI_Win_start and MPI_Win_post on a seame process.
Arnaud Giersch [Mon, 31 May 2021 13:14:10 +0000 (15:14 +0200)]
Handle duplicated datatypes within predefined MPI_Op.
Martin Quinson [Mon, 31 May 2021 10:33:06 +0000 (12:33 +0200)]
Docker: try to get apt update to run despite the cache
Arnaud Giersch [Mon, 31 May 2021 09:32:23 +0000 (11:32 +0200)]
A few more 'const'.
Arnaud Giersch [Mon, 31 May 2021 09:28:24 +0000 (11:28 +0200)]
Replace redundant type with 'auto'.
Arnaud Giersch [Mon, 31 May 2021 09:24:54 +0000 (11:24 +0200)]
Remove useless temporary shadowing outer variable.
Arnaud Giersch [Mon, 31 May 2021 08:22:02 +0000 (10:22 +0200)]
Add some 'const' qualifiers.
This started with NetPoint::get_englobing_zone() and propagated quickly...
Arnaud Giersch [Mon, 31 May 2021 07:44:22 +0000 (09:44 +0200)]
Unused exception parameter 'e'.
Arnaud Giersch [Mon, 31 May 2021 07:40:15 +0000 (09:40 +0200)]
Explicitly delete the copy constructor and copy assignment operator (enforce rule-of-five).
Arnaud Giersch [Sat, 29 May 2021 12:25:53 +0000 (14:25 +0200)]
No valgrind leak check for issue71.
Millian Poquet [Fri, 28 May 2021 21:03:01 +0000 (23:03 +0200)]
xbt_replay: rethrow exception instead of xbt_die
Bruno Donassolo [Fri, 28 May 2021 19:16:55 +0000 (21:16 +0200)]
Remove sg_bandwidth_factor from disks
No need for bw_factor here
Lucas M. Schnorr [Fri, 28 May 2021 19:10:50 +0000 (16:10 -0300)]
remove a space to force update
Bruno Donassolo [Fri, 28 May 2021 17:49:45 +0000 (19:49 +0200)]
Issue#71: add check in add_route for gw_src/gw_dst
When adding a NetZoneRoute, check if gw_src and gw_dst belongs to the
respective netzones.
We need to recursively search for the netpoint inside the netzone since
the netpoint can be from one of its children.
Arnaud Giersch [Fri, 28 May 2021 15:16:30 +0000 (17:16 +0200)]
Fix refcount for Datatype_contents.
Error seen with Petsc test: vec_is_sf_tutorials-ex3_basic_dupped.
Arnaud Giersch [Fri, 28 May 2021 09:52:30 +0000 (11:52 +0200)]
Allow null ranks for MPI_Group_incl when n == 0.
Lucas M. Schnorr [Fri, 28 May 2021 14:48:12 +0000 (11:48 -0300)]
update draw_gantt.R script to work with pajengr
todo
- need to test with a recent version of S4U trace
Lucas M. Schnorr [Fri, 28 May 2021 14:41:29 +0000 (11:41 -0300)]
update pajengr installation procedure in S4U tutorial
Lucas M. Schnorr [Fri, 28 May 2021 14:36:59 +0000 (11:36 -0300)]
replace r-cran-dplyr by r-cran-devtools
Lucas M. Schnorr [Fri, 28 May 2021 14:35:35 +0000 (11:35 -0300)]
update tuto-smpi Dockerfile to contain r-cran-tidyverse (replacing included R packages)
Lucas M. Schnorr [Fri, 28 May 2021 14:26:40 +0000 (11:26 -0300)]
add additional necessary packages for pajengr installation
Lucas M. Schnorr [Fri, 28 May 2021 13:56:14 +0000 (10:56 -0300)]
update pajengr R code and figure
details:
- note the addition of library(tidyverse)
Augustin Degomme [Thu, 27 May 2021 14:55:48 +0000 (16:55 +0200)]
use new option in random test.
Augustin Degomme [Thu, 27 May 2021 14:47:48 +0000 (16:47 +0200)]
document new option
Augustin Degomme [Thu, 27 May 2021 13:40:44 +0000 (15:40 +0200)]
Add flag to provide an optional barrier in MPI_Finalize.
This is meant to help for codes which can aggressively cleanup memory at finalization, while other processes still have to use it.
For example when attributes are attached to a local communicator, in SMPI this communicator may be cleaned up by another process in the end, and the attribute has to still be valid at this point.
This was an issue with PETSC, for example.
Arnaud Giersch [Thu, 27 May 2021 09:04:25 +0000 (11:04 +0200)]
Use std::string for xbt_parse_units.
Combine parameters 'entity_kind' and 'name'.
Also rename surf_parse_* to xbt_parse_*.
Arnaud Giersch [Thu, 27 May 2021 08:35:46 +0000 (10:35 +0200)]
Deprecate SIMIX_get_clock().
Use simgrid_get_clock() or Engine::get_clock().
Arnaud Giersch [Thu, 27 May 2021 07:52:59 +0000 (09:52 +0200)]
Keyval should always exist.
Also please sonar by reducing depth for nested blocks.
Augustin Degomme [Thu, 27 May 2021 09:13:29 +0000 (11:13 +0200)]
leaks analysis: when -analyze is given to smpirun, set value for list-leaks to 50.
Augustin Degomme [Thu, 27 May 2021 09:12:17 +0000 (11:12 +0200)]
leaks analysis : activate if list-leaks is asked manually (without smpi/display-allocs or -analyze)
SUTER Frederic [Wed, 26 May 2021 14:39:49 +0000 (16:39 +0200)]
make simix_global->maestro_ private
Augustin Degomme [Wed, 26 May 2021 14:49:56 +0000 (16:49 +0200)]
Check types matching in MPI communications.
should work with basic ones and duplicated ones.
todo: derived types matching, which is more tricky.
Augustin Degomme [Wed, 26 May 2021 14:48:09 +0000 (16:48 +0200)]
mark these as derived datatypes, and don't divide by 0 if possible
Augustin Degomme [Wed, 26 May 2021 14:47:22 +0000 (16:47 +0200)]
keep track of which datatype was duplicated, to be able to match with it later
Augustin Degomme [Wed, 26 May 2021 09:44:45 +0000 (11:44 +0200)]
nothing old here, just the type ..
SUTER Frederic [Wed, 26 May 2021 10:37:29 +0000 (12:37 +0200)]
prepare transition of context_factory: make it private
Bruno Donassolo [Wed, 26 May 2021 10:17:33 +0000 (12:17 +0200)]
Minor simplification in CM02::communicate
Don't need a function in NetworkModel for an "if" used only in CM02
Arnaud Giersch [Wed, 26 May 2021 07:30:23 +0000 (09:30 +0200)]
Fix potential mem leak seen by scan-build.
Note that ret should not normally be different than MPI_SUCCESS in the other case.
Arnaud Giersch [Tue, 25 May 2021 15:46:43 +0000 (17:46 +0200)]
Don't create mailbox before engine is turned on.
Arnaud Giersch [Tue, 25 May 2021 14:58:42 +0000 (16:58 +0200)]
Lookup only once on mailbox creation.
Arnaud Giersch [Tue, 25 May 2021 14:21:20 +0000 (16:21 +0200)]
Misc sonar smells.
Arnaud Giersch [Tue, 25 May 2021 14:17:20 +0000 (16:17 +0200)]
vector::back() is good enough + assert for scan_build.
Arnaud Giersch [Thu, 6 May 2021 18:21:59 +0000 (20:21 +0200)]
[cppcheck] Don't let fields uninitialized.
Arnaud Giersch [Thu, 6 May 2021 13:49:55 +0000 (15:49 +0200)]
[sonar] Extract assignments from expressions.
Arnaud Giersch [Sun, 23 May 2021 22:20:38 +0000 (00:20 +0200)]
Plug remaining leaks in mpich3-test/f77/attr.
Arnaud Giersch [Sun, 23 May 2021 20:40:39 +0000 (22:40 +0200)]
Plug memleaks with Fortran bindings.
Arnaud Giersch [Sun, 23 May 2021 20:26:58 +0000 (22:26 +0200)]
Review allocation of MPI attributes with Fortran bindings.
Arnaud Giersch [Tue, 25 May 2021 12:33:56 +0000 (14:33 +0200)]
Fix refcounting of MPI keyvals when keyval_free is called twice.
Arnaud Giersch [Tue, 25 May 2021 12:23:59 +0000 (14:23 +0200)]
Simplify a bit Keyval::attr_delete.
Arnaud Giersch [Sat, 22 May 2021 20:15:05 +0000 (22:15 +0200)]
Don't increase refcount when existing elem is overwritten.
Arnaud Giersch [Sat, 22 May 2021 19:25:00 +0000 (21:25 +0200)]
Save an indirection with smpi keyvals.
SUTER Frederic [Tue, 25 May 2021 14:50:11 +0000 (16:50 +0200)]
revalidate tesh
SUTER Frederic [Tue, 25 May 2021 14:28:56 +0000 (16:28 +0200)]
remove cruft [ci-skip]
SUTER Frederic [Tue, 25 May 2021 14:13:40 +0000 (16:13 +0200)]
Change way Mailboxes are create, stored, and destroyed
- keep the global map in EngineImpl (not as a static global in
MailboxImpl.cpp)
- Delete mailboxes in ~EngineImpl() and get rid of SIMIX_mailbox_exit
- replace MailboxImpl::by_name_or_null and
MailboxImpl::by_name_or_create by Engine::mailbox_by_name_or_create
+ better match with what is done for hosts, links, and actors
+ Mailbox::by_name cause two searchs in the map. One to check if
name already points to a mailbox (by_name_or_null) and if not
search again before creating a new mailbox. As there is no
Mailbox::by_name_or_null, just keep the latter.
- Revalidate a bunch of tests (message ordering mostly)
SUTER Frederic [Tue, 25 May 2021 13:17:58 +0000 (15:17 +0200)]
delete Timer when shutting down EngineImpl
SUTER Frederic [Tue, 25 May 2021 12:03:10 +0000 (14:03 +0200)]
Continue to migrate contents of simix_global to EngineImpl
thx @agiersch for unblocking this commit with the usual magic!
Arnaud Giersch [Sat, 22 May 2021 11:33:17 +0000 (13:33 +0200)]
Prefer using emplace() to insert() for smpi keyvals/attributes.
Arnaud Giersch [Sat, 22 May 2021 11:20:02 +0000 (13:20 +0200)]
Make smpi::Keyval::attribute() return a reference.
Arnaud Giersch [Sun, 23 May 2021 12:41:53 +0000 (14:41 +0200)]
No need to test for attributes()->empty().
Arnaud Giersch [Sun, 23 May 2021 20:40:22 +0000 (22:40 +0200)]
Fix parameter names.
Arnaud Giersch [Sat, 22 May 2021 16:22:43 +0000 (18:22 +0200)]
Coding style: ! -> 'not'.
Arnaud Giersch [Sun, 23 May 2021 22:39:33 +0000 (00:39 +0200)]
Update filter line for recent versions of Asan.
Arnaud Giersch [Thu, 20 May 2021 08:37:48 +0000 (10:37 +0200)]
Define variables outside of header file.
Arnaud Giersch [Thu, 20 May 2021 08:28:36 +0000 (10:28 +0200)]
[sonar] Unused parameter.
Arnaud Giersch [Thu, 20 May 2021 08:23:58 +0000 (10:23 +0200)]
[sonar] Const/explicit methods.
Bruno Donassolo [Tue, 25 May 2021 08:35:34 +0000 (10:35 +0200)]
Please sonar
Bruno Donassolo [Thu, 20 May 2021 15:13:59 +0000 (17:13 +0200)]
Adjust test timing
Minor changement in rounding up.
No real changement in timing (manually verified).
Bruno Donassolo [Thu, 20 May 2021 15:07:52 +0000 (17:07 +0200)]
Single get_bandwidth_constraint function.
Unify behavior of get_bandwidth_constraint function.
Note: Possible side-effect in SMPI communications with user defined
rate. Do not scale the user rate with bandwidth factor.
No impact on tests
Bruno Donassolo [Wed, 19 May 2021 18:55:39 +0000 (20:55 +0200)]
Refactor of NetworkCm02Model::communicate
Divide and conquer.
Reorganize code.
Cosmetics.
Bruno Donassolo [Mon, 17 May 2021 17:26:18 +0000 (19:26 +0200)]
Dynamic factors: implement and test
Fully implements the dynamic factors through the NetworkModelIntf API.
Added an example showing its usage.
Added UT and doc.
Bruno Donassolo [Fri, 26 Mar 2021 17:27:38 +0000 (18:27 +0100)]
NetworkModelIntf: Interface to dynamic factors
Adding API to set user callbacks for bandwidth and network factors.
Valid for CM02 models and its childrens (SMPI, IB, etc).
Not fully working yet.
Bruno Donassolo [Thu, 13 May 2021 16:41:26 +0000 (18:41 +0200)]
Get netzones traversed by a route
Preparing field to implement dynamic bandwidth and latency factors
SUTER Frederic [Fri, 21 May 2021 13:38:56 +0000 (15:38 +0200)]
migrate actors_to_run and actors_that_ran to EngineImpl
Augustin Degomme [Fri, 21 May 2021 10:37:39 +0000 (12:37 +0200)]
SMPI should not eat up all exceptions in wait/waitany simcalls silently
It only deals with cancel ones
Augustin Degomme [Fri, 21 May 2021 10:36:15 +0000 (12:36 +0200)]
typo --
SUTER Frederic [Fri, 21 May 2021 07:46:15 +0000 (09:46 +0200)]
process -> actor
Martin Quinson [Fri, 21 May 2021 08:12:08 +0000 (10:12 +0200)]
fix changelog [ci-skip]
Martin Quinson [Fri, 21 May 2021 08:03:19 +0000 (10:03 +0200)]
Add a word to the tutorial for older versions of SimGrid
Closes https://framagit.org/simgrid/simgrid/-/issues/69
SUTER Frederic [Thu, 20 May 2021 07:30:18 +0000 (09:30 +0200)]
[sonar] const
SUTER Frederic [Thu, 20 May 2021 07:21:37 +0000 (09:21 +0200)]
[sonar] Don't mix public and private data members
SUTER Frederic [Wed, 19 May 2021 16:27:18 +0000 (18:27 +0200)]
introduce a new plugin: stock implementation of a Producer-Consumer with a monitor
Arnaud Giersch [Wed, 19 May 2021 10:52:00 +0000 (12:52 +0200)]
Typos.
SUTER Frederic [Mon, 17 May 2021 18:05:49 +0000 (20:05 +0200)]
migrate daemons from simix::Global to kernel::EngineImpl
go from a public vector to a private set (order doesn't matter) in the
process.
SUTER Frederic [Mon, 17 May 2021 09:33:28 +0000 (11:33 +0200)]
migrate execute_tasks from simix::Global to kernel::EngineImpl
SUTER Frederic [Mon, 17 May 2021 08:33:14 +0000 (10:33 +0200)]
migrate wake_all_waiting_actors from simix::Global to kernel::EngineImpl
SUTER Frederic [Mon, 17 May 2021 08:23:13 +0000 (10:23 +0200)]
SIMIX_run becomes EngineImpl::run