Arnaud Giersch [Tue, 11 Jul 2023 16:26:47 +0000 (18:26 +0200)]
Disable real builds on jenkins/simgrid-qualif, hoping to avoid conflicts when both simgrid and simgrid-qualif are online.
Adrien Gougeon [Tue, 11 Jul 2023 10:50:10 +0000 (12:50 +0200)]
remove battery_platform.xml from DefinePackage
Adrien Gougeon [Tue, 11 Jul 2023 10:28:48 +0000 (12:28 +0200)]
remove unused battery parameters
Adrien Gougeon [Tue, 11 Jul 2023 09:36:04 +0000 (11:36 +0200)]
add new battery plugin doc
Adrien Gougeon [Wed, 28 Jun 2023 16:05:39 +0000 (18:05 +0200)]
try to fix initializer order
Adrien Gougeon [Wed, 28 Jun 2023 15:32:58 +0000 (17:32 +0200)]
Complete revamp of battery plugin
Arnaud Giersch [Tue, 11 Jul 2023 10:04:38 +0000 (12:04 +0200)]
Please Asan.
See commit
63225b9520042ef129adb975132fe68ec5710988
"Explicit instanciation of xbt::Extendable<> specializations." for details.
Arnaud Giersch [Tue, 11 Jul 2023 09:44:23 +0000 (11:44 +0200)]
Remove statement with no effect.
Arnaud Giersch [Tue, 11 Jul 2023 08:36:08 +0000 (10:36 +0200)]
Complete commit
afc02b7104 (Use std::string_view).
Fred Suter [Mon, 10 Jul 2023 14:38:46 +0000 (10:38 -0400)]
Merge remote-tracking branch 'origin/master' into jbod
Fred Suter [Mon, 3 Jul 2023 18:56:53 +0000 (14:56 -0400)]
adding a JBOD concept
Martin Quinson [Mon, 10 Jul 2023 13:11:42 +0000 (15:11 +0200)]
Merge branch 'master' of framagit.org:simgrid/simgrid
Martin Quinson [Mon, 10 Jul 2023 12:24:55 +0000 (14:24 +0200)]
New example: activityset-waitallfor
Adrien Gougeon [Mon, 10 Jul 2023 10:51:24 +0000 (12:51 +0200)]
update comm status BEFORE sending signals
Arnaud Giersch [Mon, 10 Jul 2023 09:44:21 +0000 (11:44 +0200)]
Missing includes (for gcc-14?)
Arnaud Giersch [Mon, 10 Jul 2023 09:32:53 +0000 (11:32 +0200)]
Cosmetics (codefactor.io).
Arnaud Giersch [Mon, 10 Jul 2023 08:59:27 +0000 (10:59 +0200)]
Use std::string_view.
Arnaud Giersch [Mon, 10 Jul 2023 08:56:18 +0000 (10:56 +0200)]
Make function "const", and void copy by returning a const reference.
Martin Quinson [Mon, 10 Jul 2023 00:17:05 +0000 (02:17 +0200)]
Convert an example to the new activity sets
Martin Quinson [Sun, 9 Jul 2023 23:49:19 +0000 (01:49 +0200)]
Drop some redundant examples
Martin Quinson [Sun, 9 Jul 2023 23:45:54 +0000 (01:45 +0200)]
Convert 2 examples from Activity::wait_any to ActivitySet
Martin Quinson [Sun, 9 Jul 2023 23:25:41 +0000 (01:25 +0200)]
Implement ActivitySet
Arnaud Giersch [Fri, 7 Jul 2023 13:04:02 +0000 (15:04 +0200)]
No clang-format for auto-generated files.
[ci-skip]
Martin Quinson [Sun, 2 Jul 2023 13:29:04 +0000 (15:29 +0200)]
Fix a MC serialization bug around WaitAny
The individual wait activities that are embeeded in a WaitAny or
TestAny do not have any call_location associated, as the call_location
is associated to the observer, not the activity. The previous code was
thus not serializing the call location of all those activities while
serializing them, but it's a pity because the Checker code deserialize
these call_location in any case. This was resulting in the beginning
of the next transition to be used as location, naturally breaking the
deserialization afterward.
Instead, the call location of the TestAny or WaitAny is now used for
each and every wait activities embedded in the *Any call. This may
challenge the MC implementation, but it sounds like a sensible idea:
In such case, the location of the embedded wait IS the one of the
englobing TestAny or WaitAny call.
In some sense, that's very close to how we handle the timeout that is
given by the englobing call, not the embedded ones, in such situation.
Martin Quinson [Sat, 1 Jul 2023 16:44:39 +0000 (18:44 +0200)]
Don't send sbuff and rbuff to the MC checker
They used to be included in the dependency computation, but that's a
very bad idea, as the same communication can land on the same address,
so the checker cannot get sure information from there.
This simplifies the MC-App protocol, as we have a bug somewhere.
Martin Quinson [Sat, 1 Jul 2023 16:24:18 +0000 (18:24 +0200)]
Don't break MC protocol if the user code has space in filenames
Martin Quinson [Sat, 1 Jul 2023 16:20:53 +0000 (18:20 +0200)]
More verbose error and debug messages
Martin Quinson [Thu, 29 Jun 2023 20:41:10 +0000 (22:41 +0200)]
Fix MC builds
Martin Quinson [Thu, 29 Jun 2023 20:31:05 +0000 (22:31 +0200)]
Show the user-level call in MC backtraces
Martin Quinson [Thu, 29 Jun 2023 13:33:09 +0000 (13:33 +0000)]
Merge branch 'master' into 'master'
Add trace call for MPI operations for checker side
See merge request simgrid/simgrid!164
mlaurent [Thu, 29 Jun 2023 11:14:05 +0000 (13:14 +0200)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid
Arnaud Giersch [Thu, 29 Jun 2023 08:26:31 +0000 (10:26 +0200)]
Make member variables "private" (Sonar).
Arnaud Giersch [Thu, 29 Jun 2023 08:02:46 +0000 (10:02 +0200)]
Unused parameters (Sonar).
Arnaud Giersch [Thu, 29 Jun 2023 07:50:04 +0000 (09:50 +0200)]
Shadowed variables (Sonar).
Arnaud Giersch [Thu, 29 Jun 2023 07:41:52 +0000 (09:41 +0200)]
Pass large objects by reference to const (Sonar).
Arnaud Giersch [Thu, 29 Jun 2023 07:32:33 +0000 (09:32 +0200)]
The result of "std::move" should not be passed as a const reference (Sonar).
Arnaud Giersch [Wed, 28 Jun 2023 20:57:00 +0000 (22:57 +0200)]
Plug memory leaks.
Capture by reference in order to break what I understand to be a circular dependency.
Arnaud Giersch [Wed, 28 Jun 2023 17:31:11 +0000 (19:31 +0200)]
Functions having rvalue reference arguments should "std::move" those arguments (Sonar).
Arnaud Giersch [Wed, 28 Jun 2023 17:11:01 +0000 (19:11 +0200)]
Fix: "std::move" should only be used where moving can happen (Sonar).
Arnaud Giersch [Wed, 28 Jun 2023 14:18:04 +0000 (16:18 +0200)]
Move signals "on_(this_)start" and methods "fire_on_*" into Activity_T.
Arnaud Giersch [Wed, 28 Jun 2023 07:37:55 +0000 (09:37 +0200)]
Replace redundant type with "auto" (Sonar).
Arnaud Giersch [Wed, 28 Jun 2023 07:01:09 +0000 (09:01 +0200)]
Remove nested code blocks (Sonar).
Best viewed with "git show -b"
Arnaud Giersch [Wed, 28 Jun 2023 06:41:32 +0000 (08:41 +0200)]
Further little simplifications around "if" statements.
Martin Quinson [Wed, 28 Jun 2023 13:13:04 +0000 (15:13 +0200)]
python: make it so that the host_load functions are only defined when the plugin is loaded
Martin Quinson [Wed, 28 Jun 2023 12:32:48 +0000 (14:32 +0200)]
Merge branch 'master' of framagit.org:simgrid/simgrid
Martin Quinson [Wed, 28 Jun 2023 12:32:38 +0000 (12:32 +0000)]
Merge branch 'python_bindings_host_load_plugin' into 'master'
add python bindings for plugin host load
See merge request simgrid/simgrid!162
Martin Quinson [Wed, 28 Jun 2023 12:32:27 +0000 (12:32 +0000)]
Merge branch 'master' into 'python_bindings_host_load_plugin'
# Conflicts:
# src/bindings/python/simgrid_python.cpp
Martin Quinson [Wed, 28 Jun 2023 11:26:54 +0000 (13:26 +0200)]
Typo found by lintian
Arnaud Giersch [Tue, 27 Jun 2023 14:54:11 +0000 (16:54 +0200)]
Use std::make_unique (Sonar).
Arnaud Giersch [Tue, 27 Jun 2023 13:14:48 +0000 (15:14 +0200)]
Respect coding style for boolean operators.
Arnaud Giersch [Tue, 27 Jun 2023 12:51:14 +0000 (14:51 +0200)]
Use the init-statement to reduce scope of local variables (Sonar).
Arnaud Giersch [Tue, 27 Jun 2023 12:04:37 +0000 (14:04 +0200)]
Use std::any_of(...).
Arnaud Giersch [Tue, 27 Jun 2023 11:46:43 +0000 (13:46 +0200)]
Misc. Sonar smells.
Martin Quinson [Tue, 27 Jun 2023 12:14:08 +0000 (14:14 +0200)]
MBI: use odpor by default, to speed things up
mlaurent [Tue, 27 Jun 2023 09:20:07 +0000 (11:20 +0200)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid
Arnaud Giersch [Tue, 27 Jun 2023 07:24:13 +0000 (09:24 +0200)]
Correct warning message, and update comments.
[ci-skip]
Arnaud Giersch [Tue, 27 Jun 2023 06:46:56 +0000 (08:46 +0200)]
Define macro XBT_ATTRIB_DEPRECATED_v339.
(to use during the dev of v3.35)
Arnaud Giersch [Tue, 27 Jun 2023 06:46:56 +0000 (08:46 +0200)]
Remove deprecated features for next release (3.35).
Arnaud Giersch [Mon, 26 Jun 2023 13:50:56 +0000 (15:50 +0200)]
Remove deprecated features for the new next release (3.34).
Martin Quinson [Mon, 26 Jun 2023 22:03:19 +0000 (00:03 +0200)]
Start a new development cycle
Fred Suter [Mon, 26 Jun 2023 16:35:39 +0000 (12:35 -0400)]
add missing copyright notes
Martin Quinson [Mon, 26 Jun 2023 15:13:10 +0000 (17:13 +0200)]
Add the release date to the ChangeLog (woops)
Martin Quinson [Mon, 26 Jun 2023 14:59:27 +0000 (16:59 +0200)]
Release 3.34
Martin Quinson [Mon, 26 Jun 2023 15:00:15 +0000 (17:00 +0200)]
Revert "Remove deprecated features for the new next release (3.34)" until after the release
Formally, this could be done, since we skipped the v3.33. But I prefer
to postpone these changes until after the release of v3.34 to release
today a code base that was throughoutly tested. Keeping these changes
would require to wait for the tests to be run again.
This reverts commit
66d0f6e192b8205fb6b7919ac1dc5475d3435d54.
Arnaud Giersch [Mon, 26 Jun 2023 14:24:19 +0000 (16:24 +0200)]
Whitespace cleanup (codefactor.io).
[ci-skip]
Arnaud Giersch [Mon, 26 Jun 2023 13:50:56 +0000 (15:50 +0200)]
Remove deprecated features for the new next release (3.34).
Arnaud Giersch [Mon, 26 Jun 2023 13:01:52 +0000 (15:01 +0200)]
Typos.
[ci-skip]
Martin Quinson [Mon, 26 Jun 2023 09:44:33 +0000 (11:44 +0200)]
Since we skip a release, use XBT_ATTRIB_DEPRECATED_v338 instead of v337
Martin Quinson [Mon, 26 Jun 2023 09:43:41 +0000 (11:43 +0200)]
Improve the documentation of this release, and introduce a release nick
Martin Quinson [Sat, 24 Jun 2023 17:13:48 +0000 (19:13 +0200)]
complete the release notes. They need more reviews
Martin Quinson [Sat, 24 Jun 2023 14:26:04 +0000 (16:26 +0200)]
sleep sets are not an option in MC. We always need them
It was useful to have it as an option when debugging.
Martin Quinson [Fri, 23 Jun 2023 22:41:33 +0000 (00:41 +0200)]
Extend the release notes with the work done until March 31.
Martin Quinson [Fri, 23 Jun 2023 10:25:31 +0000 (12:25 +0200)]
Reorg the MPI doc, and document SMPI_app_instance_start in release notes
Martin Quinson [Thu, 22 Jun 2023 07:21:41 +0000 (09:21 +0200)]
Fix MC builds
Martin Quinson [Thu, 22 Jun 2023 00:25:49 +0000 (02:25 +0200)]
Merge branch 'master' of framagit.org:simgrid/simgrid
Martin Quinson [Thu, 22 Jun 2023 00:24:47 +0000 (02:24 +0200)]
Improve the release notes for MC
Martin Quinson [Thu, 22 Jun 2023 00:13:04 +0000 (02:13 +0200)]
Document source-set and DPOR options
Martin Quinson [Thu, 22 Jun 2023 00:01:18 +0000 (02:01 +0200)]
model-check/sleep-set is now true by default
Martin Quinson [Wed, 21 Jun 2023 23:36:22 +0000 (01:36 +0200)]
Increase a bit an example which size got reduced when DPOR efficiency reduced, and test odpor+sdpor on it
Fred Suter [Wed, 21 Jun 2023 21:25:46 +0000 (17:25 -0400)]
[ci-skip] document s4u::Task
Fred Suter [Wed, 21 Jun 2023 18:54:17 +0000 (14:54 -0400)]
rename enqueue_execs into enqueue_firings
Fred Suter [Wed, 21 Jun 2023 18:25:39 +0000 (14:25 -0400)]
[Sonar] shadowed variable
Fred Suter [Wed, 21 Jun 2023 18:18:02 +0000 (14:18 -0400)]
[sonar] make signals private
Fred Suter [Wed, 21 Jun 2023 18:10:32 +0000 (14:10 -0400)]
[sonar] explicit capture
Fred Suter [Wed, 21 Jun 2023 16:57:36 +0000 (12:57 -0400)]
cleanups and refactoring in s4u::Task
Fred Suter [Tue, 20 Jun 2023 13:24:41 +0000 (09:24 -0400)]
Move Tasks from a plugin to s4u
Fred Suter [Tue, 20 Jun 2023 12:03:29 +0000 (12:03 +0000)]
Merge branch 'task-token' into 'master'
Task Token
See merge request simgrid/simgrid!163
Fred Suter [Tue, 20 Jun 2023 12:00:03 +0000 (12:00 +0000)]
Merge branch 'master' into 'task-token'
# Conflicts:
# docs/source/Installing_SimGrid.rst
# examples/cpp/mc-bugged2/s4u-mc-bugged2.tesh
# teshsuite/smpi/coll-allreduce-with-leaks/mc-coll-allreduce-with-leaks.tesh
Fred Suter [Mon, 19 Jun 2023 12:13:20 +0000 (08:13 -0400)]
more use of get_unique_data
Martin Quinson [Fri, 16 Jun 2023 16:14:51 +0000 (18:14 +0200)]
Fix indent in an example
Arnaud Giersch [Fri, 16 Jun 2023 14:16:49 +0000 (14:16 +0000)]
Merge branch 'fix-wakeup-tree-iterator' into 'master'
Fix `WakeupTreeIterator` bug comparing different iterators
See merge request simgrid/simgrid!165
Maxwell Pirtle [Fri, 16 Jun 2023 13:25:01 +0000 (15:25 +0200)]
Fix WakeupTreeIterator bug comparing diff iterators
Prior to this commit, the WakeupTreeIterator
compared iterators stemming from different
collections. This isn't defined behavior though :/.
The goal was to determine if a node should add its
children again when moving to the next node in the
iteration. Instead it suffices to keep track of which
nodes have already added their children after adding
them to the ordering.
mlaurent [Fri, 16 Jun 2023 09:57:42 +0000 (11:57 +0200)]
Stop using default mpi_call
mlaurent [Fri, 16 Jun 2023 08:37:21 +0000 (10:37 +0200)]
Merge branch 'master' of https://framagit.org/simgrid/simgrid
Martin Quinson [Thu, 15 Jun 2023 18:58:00 +0000 (20:58 +0200)]
fix the instructions on how to use local installs of python bindings
Martin Quinson [Thu, 15 Jun 2023 18:49:47 +0000 (20:49 +0200)]
Fix the liveness tests by ignoring the Comm ID memory that breaks the state equality detection
Martin Quinson [Thu, 15 Jun 2023 16:11:38 +0000 (18:11 +0200)]
Revalidate the tesh files after the recent MC depends change
Martin Quinson [Thu, 15 Jun 2023 16:10:59 +0000 (18:10 +0200)]
Do not consider the memory addresses in MC depends function
There is no use for that, and it makes depends system-dependent.
Martin Quinson [Thu, 15 Jun 2023 15:58:16 +0000 (17:58 +0200)]
MC: Give an ID to comms to not use their pointer value, that can be reused over time
Not doing so made the dependency architecture- and system- dependent:
if a pointer address got reused for another comm, that would have
impacted the depends() result on the MC side.
Adrien Gougeon [Thu, 15 Jun 2023 16:58:12 +0000 (18:58 +0200)]
use get_unique_data()