Augustin Degomme [Sun, 28 Mar 2021 15:55:04 +0000 (17:55 +0200)]
typo [noci]
Augustin Degomme [Sun, 28 Mar 2021 14:03:30 +0000 (16:03 +0200)]
cosmetics
Augustin Degomme [Sun, 28 Mar 2021 14:03:09 +0000 (16:03 +0200)]
add message when 0 bytes are allocated
Martin Quinson [Sun, 28 Mar 2021 10:11:44 +0000 (12:11 +0200)]
Proposition of a NEWS entry
Augustin Degomme [Sun, 28 Mar 2021 01:47:16 +0000 (03:47 +0200)]
cosmetics
Augustin Degomme [Sun, 28 Mar 2021 01:29:20 +0000 (03:29 +0200)]
also change option name in MC-flavored tesh
Augustin Degomme [Sun, 28 Mar 2021 00:59:56 +0000 (01:59 +0100)]
trim changelog
Augustin Degomme [Sun, 28 Mar 2021 00:59:46 +0000 (01:59 +0100)]
document new options
Augustin Degomme [Sun, 28 Mar 2021 00:57:18 +0000 (01:57 +0100)]
add -analyze to smpirun to activate both smpi/display-timing and smpi/display-allocs at once
Augustin Degomme [Sun, 28 Mar 2021 00:56:39 +0000 (01:56 +0100)]
rename option,
display-analysis was meant to display both timings and allocations, but it's just allocations.
Augustin Degomme [Sun, 28 Mar 2021 00:52:49 +0000 (01:52 +0100)]
typo
Arnaud Giersch [Sat, 27 Mar 2021 22:43:16 +0000 (23:43 +0100)]
Typos [noci]
Arnaud Giersch [Sat, 27 Mar 2021 22:38:19 +0000 (23:38 +0100)]
Add explaining comment.
Martin Quinson [Sat, 27 Mar 2021 21:20:53 +0000 (22:20 +0100)]
Changelog: this big fat warning is not mandated, as we don't have an example that fails [noci]
Arnaud Giersch [Sat, 27 Mar 2021 21:01:36 +0000 (22:01 +0100)]
Reduce scope for variables.
Arnaud Giersch [Sat, 27 Mar 2021 20:57:26 +0000 (21:57 +0100)]
Replace std::random with xbt::random.
Arnaud Giersch [Sat, 27 Mar 2021 20:54:44 +0000 (21:54 +0100)]
Fix XbtRandom::uniform_int() when used with large range.
Add more unit tests.
Arnaud Giersch [Sat, 27 Mar 2021 13:17:20 +0000 (14:17 +0100)]
[sonar] Useless parentheses.
Arnaud Giersch [Sat, 27 Mar 2021 09:18:21 +0000 (10:18 +0100)]
Use std::call_once instead of pthread_once.
Martin Quinson [Sat, 27 Mar 2021 21:06:47 +0000 (22:06 +0100)]
Changelog updates as a preparation to the next release [noci]
It's overdue already.
Augustin Degomme [Sat, 27 Mar 2021 20:25:18 +0000 (21:25 +0100)]
changelog update
Augustin Degomme [Sat, 27 Mar 2021 19:04:01 +0000 (19:04 +0000)]
Rename github action
It's the name of the badge, and it was too long
Augustin Degomme [Sat, 27 Mar 2021 13:18:44 +0000 (13:18 +0000)]
Merge branch 'master' into 'master'
add ctest output to gitlab ci
See merge request simgrid/simgrid!60
Augustin Degomme [Sat, 27 Mar 2021 13:18:44 +0000 (13:18 +0000)]
add ctest output to gitlab ci
Martin Quinson [Fri, 26 Mar 2021 23:02:04 +0000 (00:02 +0100)]
cosmetics, somewhat hinted by sonar
Martin Quinson [Fri, 26 Mar 2021 22:43:37 +0000 (23:43 +0100)]
Move SimcallObserver from simgrid::mc to simgrid::kernel::actor
Arnaud Giersch [Fri, 26 Mar 2021 22:01:11 +0000 (22:01 +0000)]
Merge branch 'simcall_blocking' into 'master'
Fix simcall_blocking returning a value.
See merge request simgrid/simgrid!59
Arnaud Giersch [Fri, 26 Mar 2021 13:55:46 +0000 (14:55 +0100)]
Move PoC blocking_simcall.hpp from public include/ to teshsuite/.
Arnaud Giersch [Fri, 26 Mar 2021 13:40:24 +0000 (14:40 +0100)]
Fix simcall_blocking returning a value.
Get the return value from observer->get_result().
Arnaud Giersch [Fri, 26 Mar 2021 14:05:10 +0000 (15:05 +0100)]
Kill empty file.
Augustin Degomme [Fri, 26 Mar 2021 00:57:18 +0000 (01:57 +0100)]
support MPI_CXX types.
As SMPI is in C++, that's basically free ..
Arnaud Giersch [Thu, 25 Mar 2021 20:43:17 +0000 (21:43 +0100)]
A few more ChangeLog updates.
Includes fixing trailing whitespaces.
Augustin Degomme [Thu, 25 Mar 2021 17:06:02 +0000 (18:06 +0100)]
Changelog update for SMPI
SUTER Frederic [Thu, 25 Mar 2021 15:37:32 +0000 (16:37 +0100)]
why do not implement this?
SUTER Frederic [Thu, 25 Mar 2021 15:37:11 +0000 (16:37 +0100)]
use simcalls for setters
Arnaud Giersch [Thu, 25 Mar 2021 13:19:55 +0000 (14:19 +0100)]
Use const& for std::string parameter (sonar, again).
Bruno Donassolo [Thu, 25 Mar 2021 13:56:12 +0000 (14:56 +0100)]
Fix test: java-app-bittorrent
Add a warning in Changelog, although no result has changed in our tests,
it's probably possible.
Simplify model management. As models must be added in order in the
engine, the list is already in the correct order respecting the
dependencies.
SUTER Frederic [Thu, 25 Mar 2021 09:48:51 +0000 (10:48 +0100)]
more chaining for CPUs too
SUTER Frederic [Thu, 25 Mar 2021 09:07:54 +0000 (10:07 +0100)]
as to zone
SUTER Frederic [Thu, 25 Mar 2021 08:42:37 +0000 (09:42 +0100)]
Cleaning and chaining around links
Arnaud Giersch [Thu, 25 Mar 2021 09:25:14 +0000 (10:25 +0100)]
Use a const reference for parameter.
Sonar warned that std::move is never called on this rvalue reference argument.
Arnaud Giersch [Thu, 25 Mar 2021 08:56:29 +0000 (09:56 +0100)]
Better fix for constness of argv in sg_actor_start/create.
Define two variants of the functions and allow to write the examples
without cast romving const qualifier.
Martin Quinson [Thu, 25 Mar 2021 01:37:24 +0000 (02:37 +0100)]
Make model name constant
Martin Quinson [Thu, 25 Mar 2021 00:59:00 +0000 (01:59 +0100)]
Use the models directly, not their names
Martin Quinson [Thu, 25 Mar 2021 00:41:04 +0000 (01:41 +0100)]
use default value when none better is to be given
Martin Quinson [Wed, 24 Mar 2021 22:19:06 +0000 (23:19 +0100)]
Remove more obsolete files from the old doc
Also remove the most obsolete parts of tools/cmake/Documentation.cmake
We should integrate docs/Build.sh into cmake, at some point.
Martin Quinson [Thu, 25 Mar 2021 00:11:09 +0000 (00:11 +0000)]
Merge branch 'models_type_rework_part2_try2' into 'master'
No more types for models.
See merge request simgrid/simgrid!58
Arnaud Giersch [Wed, 24 Mar 2021 21:12:47 +0000 (22:12 +0100)]
Remove a level of constness for argv parameter of sg_actor_start/create.
Aligns with the signature of main(), and allows to write without cast:
int main(int argc, char *argv[]) {
sg_actor_start(NULL, NULL, argc, argv);
...
The main drawback is that we have to add an explicit cast in our constrained
examples.
Arnaud Giersch [Wed, 24 Mar 2021 09:18:27 +0000 (10:18 +0100)]
Not sure if these files are still used, but keep them up-to-date.
Arnaud Giersch [Wed, 24 Mar 2021 08:45:15 +0000 (09:45 +0100)]
Restore xbt_dynar_to_array, which is still used by starpu.
But mark it as deprecated.
Arnaud Giersch [Tue, 23 Mar 2021 21:56:34 +0000 (22:56 +0100)]
Superfluous global variable.
Arnaud Giersch [Tue, 23 Mar 2021 15:22:24 +0000 (16:22 +0100)]
Kill now unused xbt_str_split_quoted(), xbt_str_split_quoted_in_place().
Arnaud Giersch [Tue, 23 Mar 2021 14:21:22 +0000 (15:21 +0100)]
Use boost::tokenizer.
It's already used in other parts of the code.
Arnaud Giersch [Tue, 23 Mar 2021 13:31:08 +0000 (14:31 +0100)]
Kill unused dynar functions.
Arnaud Giersch [Tue, 23 Mar 2021 13:11:00 +0000 (14:11 +0100)]
Use C++ functions to parse file.
Bruno Donassolo [Tue, 23 Mar 2021 18:04:35 +0000 (19:04 +0100)]
No more types for models.
Remove the concept of type for a model (CPU, VM, NETWORK, etc).
Explicitly declare the dependencies between models when adding them to
the engine.
Internally, they are organized in a ordered list, respecting the
dependencies described by the user.
Changes in APIs:
s4u_Engine.hpp:
- Delete get_model_list(simgrid::kernel::resource::Model::Type type)
- Modify add_model(std::shared_ptr<simgrid::kernel::resource::Model> model, std::vector<std::string>&& dep_models = {}): added list of dependencies
Model.hpp:
- set_name(), get_name(): add methods to associate a name to the model
Arnaud Giersch [Tue, 23 Mar 2021 12:39:05 +0000 (13:39 +0100)]
[sonar] Pass large object by reference to const.
Arnaud Giersch [Tue, 23 Mar 2021 12:36:57 +0000 (13:36 +0100)]
[sonar] Make parameter a pointer-to-const.
Arnaud Giersch [Tue, 23 Mar 2021 12:33:41 +0000 (13:33 +0100)]
[sonar] Inheriting constructors should be used.
Arnaud Giersch [Mon, 22 Mar 2021 19:47:13 +0000 (20:47 +0100)]
Blank lines.
Arnaud Giersch [Mon, 22 Mar 2021 19:46:33 +0000 (20:46 +0100)]
Kill "FIXME" comment.
Martin Quinson [Tue, 23 Mar 2021 00:47:04 +0000 (01:47 +0100)]
Humpf, time to sleep, obviously
Martin Quinson [Tue, 23 Mar 2021 00:41:23 +0000 (01:41 +0100)]
Forbid to modify a sealed netzone
Martin Quinson [Mon, 22 Mar 2021 23:32:56 +0000 (00:32 +0100)]
Fix make distcheck
Martin Quinson [Mon, 22 Mar 2021 22:48:16 +0000 (23:48 +0100)]
Sanitize how tracefiles are handled
In particular, SMPI was always providing a trace file per actor, even
when only one file was provided, with the content for all actors. That
was a waste of memory and processing.
But the worst was that the same file was opened N times, limiting this
solution to 1024 ranks on linux and 256 on Mac OSX. We could have
asked the users to increase the limit of file descriptors per process
to overcome this limitation.
Hopefuly with this change, the same file will be opened once only,
removing this limit all together.
Fixes https://framagit.org/simgrid/simgrid/-/issues/62
This cleanup also impacts S4U code, that cannot access the
simgrid::xbt::action_fs global anymore to open the shared file itself,
but must use xbt_replay_set_tracefile() for that.
SUTER Frederic [Mon, 22 Mar 2021 12:58:24 +0000 (13:58 +0100)]
NetZone: father to parent and more accessors
SUTER Frederic [Fri, 19 Mar 2021 10:04:26 +0000 (11:04 +0100)]
trimming zones
Arnaud Giersch [Mon, 22 Mar 2021 12:29:48 +0000 (13:29 +0100)]
Handle simcall result through mc::SimcallObserver.
Get rid of simix::(un)marshal.
Arnaud Giersch [Mon, 22 Mar 2021 10:08:56 +0000 (11:08 +0100)]
Reduce scope for variables.
Arnaud Giersch [Sat, 20 Mar 2021 20:28:40 +0000 (21:28 +0100)]
ActivityImpl::register_simcall does not need to be 'virtual'.
Arnaud Giersch [Sat, 20 Mar 2021 17:45:38 +0000 (18:45 +0100)]
Factor un-registration of simcall.
Arnaud Giersch [Fri, 19 Mar 2021 23:03:38 +0000 (00:03 +0100)]
Make SIMIX_comm_copy_data_callback a member of CommImpl.
Arnaud Giersch [Fri, 19 Mar 2021 23:00:58 +0000 (00:00 +0100)]
Make fields private.
Arnaud Giersch [Fri, 19 Mar 2021 22:58:27 +0000 (23:58 +0100)]
Cosmetics (redundant version number).
Augustin Degomme [Sun, 21 Mar 2021 00:22:27 +0000 (01:22 +0100)]
This is the index, we want the rank for the underlying iprobe.
Augustin Degomme [Sat, 20 Mar 2021 23:09:01 +0000 (00:09 +0100)]
extraneous chars
Augustin Degomme [Sat, 20 Mar 2021 23:08:22 +0000 (00:08 +0100)]
status can actually be MPI_STATUS_IGNORE
Martin Quinson [Sat, 20 Mar 2021 21:54:34 +0000 (22:54 +0100)]
Add ModelChecker::finalize_app(), but don't use it as it don't work yet
Martin Quinson [Sat, 20 Mar 2021 21:45:14 +0000 (22:45 +0100)]
some symbol renamings to make MC easier to understand (to me)
Arnaud Giersch [Fri, 19 Mar 2021 14:48:01 +0000 (15:48 +0100)]
.mailmap
Arnaud Giersch [Fri, 19 Mar 2021 14:03:24 +0000 (15:03 +0100)]
Make Time::date const; kill useless getter.
Arnaud Giersch [Fri, 19 Mar 2021 13:48:14 +0000 (14:48 +0100)]
Make fields private; define getters.
Arnaud Giersch [Fri, 19 Mar 2021 13:14:47 +0000 (14:14 +0100)]
Make Datatype::contents_ a private std::unique_ptr.
Arnaud Giersch [Fri, 19 Mar 2021 12:27:31 +0000 (13:27 +0100)]
Don't mix public and private fields (sonar).
Arnaud Giersch [Fri, 19 Mar 2021 10:35:38 +0000 (11:35 +0100)]
Factorize handling of asynchronous receives.
Apply the same changes to both the C and C++ examples.
Arnaud Giersch [Fri, 19 Mar 2021 10:08:35 +0000 (11:08 +0100)]
Unnecessary 'else'.
Arnaud Giersch [Fri, 19 Mar 2021 09:36:36 +0000 (10:36 +0100)]
Make cast explicit.
Arnaud Giersch [Fri, 19 Mar 2021 09:34:59 +0000 (10:34 +0100)]
Reduce scope for variables.
SUTER Frederic [Fri, 19 Mar 2021 08:48:27 +0000 (09:48 +0100)]
really set link latency for ns3
SUTER Frederic [Thu, 18 Mar 2021 18:26:03 +0000 (19:26 +0100)]
privatize fields of ClusterZone + more explicit methods
Augustin Degomme [Fri, 19 Mar 2021 00:35:36 +0000 (01:35 +0100)]
add tesh file to dist
Martin Quinson [Fri, 19 Mar 2021 00:08:04 +0000 (01:08 +0100)]
Fix clang builds
Martin Quinson [Thu, 18 Mar 2021 23:55:35 +0000 (00:55 +0100)]
Reorder the headers to ensure that ours are actually self-contained
Martin Quinson [Thu, 18 Mar 2021 13:13:08 +0000 (14:13 +0100)]
test with leaks: no printf, and run also in MC (that is currently wrong)
Currently, the MC test ensures that we still don't detect the leaks,
but I don't want to break the builds while I'm working on this.
Martin Quinson [Tue, 16 Mar 2021 01:10:43 +0000 (02:10 +0100)]
Fix non-MC builds
Martin Quinson [Tue, 16 Mar 2021 00:14:22 +0000 (01:14 +0100)]
simcall.py: this parameter is not a field, respect our coding conventions
Martin Quinson [Mon, 15 Mar 2021 22:29:30 +0000 (23:29 +0100)]
Add a tests-mc target to rebuild only what's needed to run the MC tests
Probably mostly useful to me, but hell, that's really useful :)
Arnaud Giersch [Thu, 18 Mar 2021 08:29:58 +0000 (09:29 +0100)]
Modernize simcall execution_waitany_for.
Arnaud Giersch [Wed, 17 Mar 2021 21:49:08 +0000 (22:49 +0100)]
Implement simcall_HANDLER_execution_waitany_for into ExecImpl::wait_any_for.
Arnaud Giersch [Wed, 17 Mar 2021 21:47:10 +0000 (22:47 +0100)]
Make simcall execution_waitany_for use a std::vector internally.