Arnaud Giersch [Sun, 9 May 2021 12:39:58 +0000 (14:39 +0200)]
[sonar] Prefer empty() to check for emptyness.
Arnaud Giersch [Sat, 8 May 2021 12:00:38 +0000 (14:00 +0200)]
[sonar] Minor simplifications.
Arnaud Giersch [Thu, 6 May 2021 13:44:22 +0000 (15:44 +0200)]
[cppcheck] Pass parameters by const reference.
Arnaud Giersch [Thu, 6 May 2021 13:38:43 +0000 (15:38 +0200)]
[codefactor] Cosmetics.
SUTER Frederic [Sun, 9 May 2021 14:41:39 +0000 (16:41 +0200)]
Rename kernel::resource:Cpu to CpuImpl
Augustin Degomme [Fri, 7 May 2021 21:49:48 +0000 (23:49 +0200)]
use .data() instead of &v[0] to avoid annoying analyzers.
Martin Quinson [Fri, 7 May 2021 22:16:11 +0000 (00:16 +0200)]
Revert "Try to activate -Wsugests-override in GNU compiler, as it may help if it works"
This fails for old versions of GCC, which could be worked around, but
also on ns-3 headers, which is harder to fix properly.
This reverts commit
694a2b171a6e03d42d5068bc6ba6c353cb0e34e3.
Martin Quinson [Fri, 7 May 2021 22:01:35 +0000 (00:01 +0200)]
Try to activate -Wsugests-override in GNU compiler, as it may help if it works
Martin Quinson [Wed, 5 May 2021 18:37:24 +0000 (20:37 +0200)]
Close those bugs in the Changelog [ci-skip]
Augustin Degomme [Fri, 7 May 2021 16:14:52 +0000 (18:14 +0200)]
non blocking collectives : array->vector
Augustin Degomme [Fri, 7 May 2021 13:45:16 +0000 (15:45 +0200)]
Fix previous fix.
It was turning test into wait for non blocking collectives, which is not what we wanted.
Arnaud Giersch [Fri, 7 May 2021 12:08:43 +0000 (14:08 +0200)]
Fix build with -Werror=undef.
Arnaud Giersch [Fri, 7 May 2021 11:39:11 +0000 (13:39 +0200)]
Allow an actor to destroy its own VM.
Fix https://github.com/simgrid/simgrid/issues/322
Arnaud Giersch [Fri, 7 May 2021 09:38:13 +0000 (11:38 +0200)]
Add test for VM (self) destruction.
Adapted from https://github.com/simgrid/simgrid/issues/322
Arnaud Giersch [Fri, 7 May 2021 11:28:40 +0000 (13:28 +0200)]
Distcheck.
Augustin Degomme [Fri, 7 May 2021 10:20:16 +0000 (12:20 +0200)]
activate the last nonblocking test in mpich3 suite, as now we should pass it.. probably.
Augustin Degomme [Fri, 7 May 2021 10:17:54 +0000 (12:17 +0200)]
Properly terminate non blocking collective requests in all cases (mpi_test/testall/testany/testsome/waitsome/waitany).
Also use flags to identify non blocking collectivre requests instead of the size of an array (which should be turned in a vector soon)
Fix one issue reported in #67
Bruno Donassolo [Fri, 7 May 2021 09:33:26 +0000 (11:33 +0200)]
Checks concerning StarZone and NS3
Arnaud Giersch [Thu, 6 May 2021 21:38:41 +0000 (23:38 +0200)]
Reduce scope for variable.
Arnaud Giersch [Thu, 6 May 2021 21:38:41 +0000 (23:38 +0200)]
Capitalize enum class.
Arnaud Giersch [Thu, 6 May 2021 12:29:52 +0000 (14:29 +0200)]
Cannot destroy iface before impl.
HostImpl::destroy() calls s4u::Host::on_destruction(*this->get_iface());
Move bogus XBT_DEBUG instead.
Arnaud Giersch [Thu, 6 May 2021 11:41:41 +0000 (13:41 +0200)]
Fix use-after-free with VirtualMachine::destroy().
Postpone destruction of VirtualMachineImpl, and do it in kernel mode.
Arnaud Giersch [Thu, 6 May 2021 11:24:00 +0000 (13:24 +0200)]
There is no need to have these functions 'virtual'.
Arnaud Giersch [Wed, 5 May 2021 08:22:46 +0000 (10:22 +0200)]
Fix rst.
SUTER Frederic [Thu, 6 May 2021 08:30:18 +0000 (10:30 +0200)]
[sonar] implicit casts
Martin Quinson [Wed, 5 May 2021 15:43:52 +0000 (17:43 +0200)]
Extend the description of the IB configuration
Martin Quinson [Wed, 5 May 2021 13:00:51 +0000 (15:00 +0200)]
A doc section that I don't know where to put: citations in several languages [ci-skip]
Martin Quinson [Tue, 4 May 2021 22:24:10 +0000 (00:24 +0200)]
MC: Start implementing the dependency functions on the AppSide (TBC)
(code committed to gather feedback: it's not used yet)
Instead of one big function handling the dependencies for every kind
of transition on the CheckerSide, we will split that logic between the
observer subclasses and execute it on the AppSide. This will induce
more latencies, but hopefully this will make the code more managable.
This commit introduces a MutexSimcall observer, as we want to group
MutexLock and MutexUnlock together when computing the dependencies.
But we cannot use it yet, as we need to have asynchronous locks for
the existing independence theorems to be usable.
Bruno Donassolo [Wed, 5 May 2021 09:02:07 +0000 (11:02 +0200)]
Some sonar stuff...
Arnaud Giersch [Tue, 4 May 2021 21:37:07 +0000 (23:37 +0200)]
Don't take default smpi compiler flags from the environment.
The user must explicitly define them through cmake parameters
SMPI_C_FLAGS, SMPI_CXX_FLAGS, or SMPI_Fortran_FLAGS.
Arnaud Giersch [Tue, 4 May 2021 20:37:59 +0000 (22:37 +0200)]
Cosmetics.
Arnaud Giersch [Tue, 4 May 2021 20:08:58 +0000 (22:08 +0200)]
Put stdout in line buffer mode for MCed apps.
The call to fflush before backtrack/exit is certainly superfluous now,
but it doesn't harm.
Martin Quinson [Tue, 4 May 2021 19:00:45 +0000 (21:00 +0200)]
fix my recent commit: build the binaries in the right directory
Martin Quinson [Tue, 4 May 2021 17:33:34 +0000 (19:33 +0200)]
distcheck, but in a new and shiny way with a lot of cmake stars in the sky
Martin Quinson [Tue, 4 May 2021 17:27:34 +0000 (19:27 +0200)]
factorize some code in examples/smpi/CMakeLists.txt
Because factorizing cmake code is what you need today.
Martin Quinson [Tue, 4 May 2021 15:51:40 +0000 (17:51 +0200)]
Warn the user if the sleep time is smaller than the numerical precision
Martin Quinson [Tue, 4 May 2021 08:27:05 +0000 (10:27 +0200)]
cmake: Ensure that the users don't activate minimal-bindings and model-checking together
Martin Quinson [Tue, 4 May 2021 08:22:55 +0000 (10:22 +0200)]
MC: add a clone() method to all Observers
This will be useful for the AppSide to maintain a vector of all
observers on the stack, to move the independency tracking to that side.
Martin Quinson [Tue, 4 May 2021 17:22:28 +0000 (19:22 +0200)]
Fix tesh file now that MC flushes the output on backtrack
That's weird, it seems that we don't flush it when the application
ends, as one of the outputs arrives after the end of MC. But I fail to
see in the code where that would come from.
Martin Quinson [Fri, 30 Apr 2021 22:56:52 +0000 (00:56 +0200)]
MC: also flush application's stdout on backtrack
Martin Quinson [Fri, 30 Apr 2021 22:32:37 +0000 (00:32 +0200)]
Document the fact that we have more documentation
Martin Quinson [Fri, 30 Apr 2021 21:20:46 +0000 (23:20 +0200)]
Work around a bug in vscode
Martin Quinson [Fri, 30 Apr 2021 15:46:33 +0000 (17:46 +0200)]
Tuto MC: Add a word about the missing pieces
Bruno Donassolo [Tue, 4 May 2021 15:34:08 +0000 (17:34 +0200)]
DragonflyZone: Add limiters for switches
Final change to make uniform the behavior of limiters in the clusters:
Fat-Tree, Torus and Dragonfly.
Changes in tests flatifier and cluster-multicpu
Bruno Donassolo [Tue, 4 May 2021 12:53:41 +0000 (14:53 +0200)]
FatTreeZone: Add limiters for switches
Users can set limiters for switches (elements whose level > 0) in Fat-Tree.
Coordinates in Fat-tree are now characterized by: <level, id>, level 0
elements are the leaves (processing nodes).
Uniform limiter behavior in routes: src, destination and middle nodes.
Changes in tests:
1) cluster-multicpu: adjust timing due to new limiters.
2) flatifier tests must be adapted for these reasons:
- Changed callback to create limiters from XML. Radicals in XML are valid for leaves in the tree. Use internal ID instead.
- Changed order of links in the route from get_local_route of Fat-trees.
Bruno Donassolo [Fri, 30 Apr 2021 12:53:19 +0000 (14:53 +0200)]
TorusZone: Add limiter for destination node
Uniform the behavior of limiters for clusters: Torus, Dragonfly and
Fat-tree.
Limiters are added in source, destination and middle nodes.
Example: Route from A to C, passing through B (A -> B -> C)
A-> limiter(A) -> link(A-B) -> limiter(B) -> link(B-C) -> limiter(C) ->
C
Adjust test timing because of the new limiter. Also, fix flatifier test,
adding new limiter link at destination.
Bruno Donassolo [Tue, 4 May 2021 15:57:36 +0000 (17:57 +0200)]
Fix leak on test.
Arnaud Giersch [Tue, 4 May 2021 14:54:47 +0000 (16:54 +0200)]
More files to cleanup (windows-wsl).
Arnaud Giersch [Tue, 4 May 2021 14:39:46 +0000 (16:39 +0200)]
Fix another Asan false alarm (with clang 12).
Arnaud Giersch [Tue, 4 May 2021 14:27:32 +0000 (16:27 +0200)]
Distcheck.
Arnaud Giersch [Tue, 4 May 2021 14:20:37 +0000 (16:20 +0200)]
Fix cmake 3.20 warning.
Policy CMP0115 is not set: Source file extensions must be explicit.
SUTER Frederic [Tue, 4 May 2021 14:02:34 +0000 (16:02 +0200)]
missing override
SUTER Frederic [Tue, 4 May 2021 13:33:17 +0000 (15:33 +0200)]
add Profile support for Disk
SUTER Frederic [Tue, 4 May 2021 06:43:42 +0000 (08:43 +0200)]
cosmetics and typos
SUTER Frederic [Mon, 3 May 2021 15:46:13 +0000 (17:46 +0200)]
do not store name in s4u::Disk
Arnaud Giersch [Tue, 4 May 2021 09:10:39 +0000 (11:10 +0200)]
Kill EngineWrapper hack and reduce code duplication.
Arnaud Giersch [Tue, 4 May 2021 08:57:09 +0000 (10:57 +0200)]
Define an Engine constructor taking only a name parameter.
It will by useful for unit tests.
Arnaud Giersch [Tue, 4 May 2021 09:24:05 +0000 (11:24 +0200)]
Kill unused parameters.
Arnaud Giersch [Tue, 4 May 2021 09:18:17 +0000 (11:18 +0200)]
Const pointer/reference.
Arnaud Giersch [Tue, 4 May 2021 12:14:54 +0000 (14:14 +0200)]
Hide Asan error.
Certainly a false positive seen with s4u-exec-ptask and swapped contexts:
==
3408837==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7fbcf3ffe0f0 at pc 0x7fbcf83efc32 bp 0x7fbcf3ffe040 sp 0x7fbcf3ffe038
WRITE of size 8 at 0x7fbcf3ffe0f0 thread T0
#0 0x7fbcf83efc31 in _M_init_functor ../src/s4u/s4u_Activity.cpp:63
#1 0x7fbcf83efc31 in _M_init_functor /usr/include/c++/10/bits/std_function.h:208
#2 0x7fbcf83efc31 in function<simgrid::kernel::actor::simcall<simgrid::s4u::Activity::cancel()::<lambda()> >::<lambda()> > /usr/include/c++/10/bits/std_function.h:609
#3 0x7fbcf83efc31 in simcall<simgrid::s4u::Activity::cancel()::<lambda()> > ../include/simgrid/simix.hpp:60
#4 0x7fbcf83efc31 in simgrid::s4u::Activity::cancel() ../src/s4u/s4u_Activity.cpp:63
#5 0x55e051d23c53 in simgrid::s4u::Activity_T<simgrid::s4u::Exec>::cancel() ../include/simgrid/s4u/Activity.hpp:223
#6 0x55e051d23c53 in runner ../examples/cpp/exec-ptask/s4u-exec-ptask.cpp:61
#7 0x7fbcf84d9d51 in std::function<void ()>::operator()() const /usr/include/c++/10/bits/std_function.h:622
#8 0x7fbcf84d9d51 in simgrid::kernel::context::Context::operator()() const ../src/kernel/context/Context.hpp:65
#9 0x7fbcf84d9d51 in smx_ctx_wrapper ../src/kernel/context/ContextSwapped.cpp:51
Arnaud Giersch [Tue, 4 May 2021 07:19:13 +0000 (09:19 +0200)]
Workaround false alarm stack-use-after-scope from Asan with operator<<.
Seen with tesh-s4u-activity-lifecycle:
==
3411378==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7fd4787b5f60 at pc 0x7fd4869e2acb bp 0x7fd4787b5530 sp 0x7fd4787b4ce0
READ of size 5 at 0x7fd4787b5f60 thread T0
#0 0x7fd4869e2aca in printf_common ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors_format.inc:490
#1 0x7fd4869e4115 in __interceptor_vsnprintf ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:1647
#2 0x7fd4858f932e (/usr/lib/x86_64-linux-gnu/libstdc++.so.6+0xea32e)
#3 0x7fd4859272eb in std::ostreambuf_iterator<char, std::char_traits<char> > std::num_put<char, std::ostreambuf_iterator<char, std::char_traits<char> > >::_M_insert_float<double>(std::ostreambuf_iterator<char, std::char_traits<char> >, std::ios_base&, char, char, double) const (/usr/lib/x86_64-linux-gnu/libstdc++.so.6+0x1182eb)
#4 0x7fd4859347b9 in std::ostream& std::ostream::_M_insert<double>(double) (/usr/lib/x86_64-linux-gnu/libstdc++.so.6+0x1257b9)
#5 0x55a66a474e0a in std::ostream::operator<<(double) /usr/include/c++/10/ostream:221
#6 0x55a66a474e0a in Catch::ReusableStringStream& Catch::ReusableStringStream::operator<< <double>(double const&) ../src/include/catch.hpp:1449
#7 0x55a66a474e0a in Catch::MessageBuilder& Catch::MessageBuilder::operator<< <double>(double const&) ../src/include/catch.hpp:2632
#8 0x55a66a474e0a in bool tester_wait<0, boost::intrusive_ptr<simgrid::s4u::Exec> >(boost::intrusive_ptr<simgrid::s4u::Exec> const&) ../teshsuite/s4u/activity-lifecycle/testing_test-wait.cpp:44
#9 0x55a66a63f0af in operator() ../teshsuite/s4u/activity-lifecycle/testing_test-wait.cpp:129
#10 0x7fd485d7bd51 in std::function<void ()>::operator()() const /usr/include/c++/10/bits/std_function.h:622
#11 0x7fd485d7bd51 in simgrid::kernel::context::Context::operator()() const ../src/kernel/context/Context.hpp:65
#12 0x7fd485d7bd51 in smx_ctx_wrapper ../src/kernel/context/ContextSwapped.cpp:51
#13 0x7fd485e09e48 in simgrid::kernel::context::BoostContext::wrapper(boost::context::detail::transfer_t) ../src/kernel/context/ContextBoost.cpp:49
#14 0x7fd4854be19e in make_fcontext (/usr/lib/x86_64-linux-gnu/libboost_context.so.1.74.0+0x119e)
Bruno Donassolo [Tue, 4 May 2021 08:07:44 +0000 (10:07 +0200)]
Mix create_host and add_route during platf creation.
Allow creating hosts and adding CPUs during platform description.
With the C++ interface, it's easy to mix the creation of hosts and
routes in the same for loop. However, the old code had the assumption
that all hosts were created when we added new routes. This info was used
to initialize the routing_table.
Change code to resize the routing table when necessary (number of
elements in the zone has changed).
Zones with the error: Full and Floyd
Added UTs for this case.
Arnaud Giersch [Mon, 3 May 2021 22:32:38 +0000 (00:32 +0200)]
Make sonar green again.
Arnaud Giersch [Mon, 3 May 2021 22:10:31 +0000 (00:10 +0200)]
Fix test tesh-s4u-trace-integration.
Overriding CpuTiAction::set_max_duration() was wrongly inserting an action with min_finish = -1.0.
Simply use the parent Action::set_max_duration() instead.
The action will be inserted in action_heap by update_action_finish_time() when needed.
Arnaud Giersch [Mon, 3 May 2021 20:09:40 +0000 (22:09 +0200)]
NO_MAX_DURATION is a double.
Arnaud Giersch [Mon, 3 May 2021 13:54:45 +0000 (15:54 +0200)]
Keep execution alive after timeout in sg_exec_wait_for.
Arnaud Giersch [Mon, 3 May 2021 10:46:44 +0000 (12:46 +0200)]
Fixed tests in activity-lifecycle/testing_test-wait.
Close simgrid/simgrid#47
Arnaud Giersch [Sat, 1 May 2021 22:20:20 +0000 (00:20 +0200)]
Fix test s4u-exec-ptask: task needs to be canceled after timeout.
Arnaud Giersch [Tue, 27 Apr 2021 12:44:10 +0000 (14:44 +0200)]
Fix ActivityImpl::wait_for to not cancel the activity on timeout.
This should improve issue simgrid/simgrid#47.
Some tests are broken by this commit, and should be fixed soon.
Arnaud Giersch [Tue, 27 Apr 2021 12:19:25 +0000 (14:19 +0200)]
Kill dead code.
It's never used, and I doubt that it's entirely correct.
Arnaud Giersch [Wed, 21 Apr 2021 11:01:16 +0000 (13:01 +0200)]
Use observer ActivityWaitSimcall in s4u::Activity::wait_for().
Arnaud Giersch [Wed, 21 Apr 2021 10:54:23 +0000 (12:54 +0200)]
Define observer ActivityWaitSimcall.
Arnaud Giersch [Mon, 3 May 2021 13:51:38 +0000 (15:51 +0200)]
Reduce code duplication.
Arnaud Giersch [Mon, 3 May 2021 13:37:08 +0000 (15:37 +0200)]
Cancel any activity on actor exit.
Arnaud Giersch [Mon, 3 May 2021 12:30:53 +0000 (14:30 +0200)]
Move fields from Exec to ExecImpl.
The Exec may be released before the end of the execution, bringing a
null dereference when finish_time is set.
Arnaud Giersch [Tue, 27 Apr 2021 13:17:44 +0000 (15:17 +0200)]
Improve messages: timeout is for the 'wait', not for the execution.
Arnaud Giersch [Mon, 3 May 2021 09:37:55 +0000 (11:37 +0200)]
Fix tesh file.
Measured energy consumption has changed. The new value seems more correct (2s on host2 at 4W gives 8J).
Arnaud Giersch [Mon, 3 May 2021 09:34:02 +0000 (11:34 +0200)]
Suspend all the associated activities on actor suspend.
Arnaud Giersch [Sat, 1 May 2021 21:37:46 +0000 (23:37 +0200)]
Migrate all the associated exec activities on actor migration.
SUTER Frederic [Mon, 3 May 2021 14:36:57 +0000 (16:36 +0200)]
yet another revision of the disk internals
SUTER Frederic [Mon, 3 May 2021 13:28:51 +0000 (15:28 +0200)]
cosmetics (before move to src/kernel/resource ??)
SUTER Frederic [Mon, 3 May 2021 12:11:31 +0000 (14:11 +0200)]
not needed anymore
SUTER Frederic [Mon, 3 May 2021 10:49:56 +0000 (12:49 +0200)]
do not use RouteCreationArgs outside of XML parsing
Arnaud Giersch [Fri, 30 Apr 2021 13:30:28 +0000 (15:30 +0200)]
Resize(0) is redundant.
Arnaud Giersch [Fri, 30 Apr 2021 13:27:28 +0000 (15:27 +0200)]
Missing includes.
Arnaud Giersch [Fri, 30 Apr 2021 09:56:10 +0000 (11:56 +0200)]
Cleanup some unused and/or useless build config variables.
SUTER Frederic [Fri, 30 Apr 2021 10:59:22 +0000 (12:59 +0200)]
do not need ClusterCreationArgs anymore
SUTER Frederic [Fri, 30 Apr 2021 09:51:45 +0000 (11:51 +0200)]
refactor link characteristics management across Clustered Zones
Bruno Donassolo [Fri, 30 Apr 2021 09:50:29 +0000 (11:50 +0200)]
Torus/Fat-Tree/Dragonfly: Aggregate callbacks
Put set callbacks in an object.
Less (or encapsulated) arguments for create_zones.
Remove create_cluster_zone (create_star_zone does its job for C++
interfaces).
Arnaud Giersch [Fri, 30 Apr 2021 09:03:12 +0000 (11:03 +0200)]
Asan sometimes chokes on RUNNING_ON_VALGRIND. Workaround by changing the test.
Arnaud Giersch [Fri, 30 Apr 2021 08:08:28 +0000 (10:08 +0200)]
Libunwind is useless for non-MC builds.
Moreover its presence causes unwanted false-positives with Asan.
Bruno Donassolo [Thu, 29 Apr 2021 17:23:32 +0000 (19:23 +0200)]
Fix 32 bits now...
Bruno Donassolo [Thu, 29 Apr 2021 16:49:58 +0000 (18:49 +0200)]
Ooops.. Fix CmakeFiles and MANIFEST
Bruno Donassolo [Thu, 29 Apr 2021 14:41:14 +0000 (16:41 +0200)]
Cluster: use radicals from XML when creating resources
Use radicals from XML when creating hosts in sg_platf.xml.
Fix bug with limiter.
Add test.
SUTER Frederic [Thu, 29 Apr 2021 14:01:36 +0000 (16:01 +0200)]
do not throw signal from sg_platf
Bruno Donassolo [Thu, 29 Apr 2021 10:49:12 +0000 (12:49 +0200)]
Use new API to create Torus/Dragonfly/Fat-Tree clusters from XML.
Get rid of ClusterCreationArgs in Torus/Dragonfly/Fat-tree.
NOTE: Routers aren't created anymore for Torus/Dragonfly/Fat-tree zones.
- This router was lost in the middle of topology connected through empty
routes (no links)
- In the past, the sg_platf created a router automatically for these
netzones since they shared the same sg_platf_new_cluster function.
- Impact on flatfier test: cluster_torus.xml.
Bruno Donassolo [Wed, 28 Apr 2021 16:39:11 +0000 (18:39 +0200)]
FatTreeZone: Do the checks earlier
Bruno Donassolo [Wed, 28 Apr 2021 13:38:28 +0000 (15:38 +0200)]
New: s4u::create_dragonfly_zone
Implements the builder method for Dragonfly zones.
New example: Dragonfly cluster of multi-cpu hosts(Star Zones)
Bruno Donassolo [Wed, 28 Apr 2021 09:24:54 +0000 (11:24 +0200)]
Cosmetics
Martin Quinson [Wed, 28 Apr 2021 08:24:37 +0000 (10:24 +0200)]
MC tuto: Review by Emma