Logo AND Algorithmique Numérique Distribuée

Public GIT Repository
simgrid.git
18 months agocomplexify the test a bit further
Fred Suter [Thu, 3 Nov 2022 21:29:23 +0000 (17:29 -0400)]
complexify the test a bit further

18 months agoReuse existing variable, and shorten conditional.
Arnaud Giersch [Thu, 3 Nov 2022 09:05:57 +0000 (10:05 +0100)]
Reuse existing variable, and shorten conditional.

18 months agoDon't call function with side effect twice in the same expression.
Arnaud Giersch [Wed, 2 Nov 2022 22:33:20 +0000 (23:33 +0100)]
Don't call function with side effect twice in the same expression.

The evaluation order is undecided and may give different results (e.g. using clang vs. gcc).

18 months agoUpdate random-bug-nocrash.tesh after last changes.
Arnaud Giersch [Wed, 2 Nov 2022 22:12:50 +0000 (23:12 +0100)]
Update random-bug-nocrash.tesh after last changes.

18 months agoVariable is declared in xbt/asserts.h.
Arnaud Giersch [Wed, 2 Nov 2022 19:52:05 +0000 (20:52 +0100)]
Variable is declared in xbt/asserts.h.

18 months agoSpurious #include.
Arnaud Giersch [Wed, 2 Nov 2022 19:51:13 +0000 (20:51 +0100)]
Spurious #include.

18 months agoMerge branch 'master' of framagit.org:simgrid/simgrid
Martin Quinson [Tue, 1 Nov 2022 22:55:04 +0000 (23:55 +0100)]
Merge branch 'master' of framagit.org:simgrid/simgrid

18 months agoDisplay the mailbox name when showing a deadlocking situation
Martin Quinson [Tue, 1 Nov 2022 22:54:56 +0000 (23:54 +0100)]
Display the mailbox name when showing a deadlocking situation

18 months agoMC: display the status of all actors in case of deadlock
Martin Quinson [Tue, 1 Nov 2022 21:29:27 +0000 (22:29 +0100)]
MC: display the status of all actors in case of deadlock

18 months agoMC: tell the user about how to use the replay path in case of problem
Martin Quinson [Tue, 1 Nov 2022 21:16:35 +0000 (22:16 +0100)]
MC: tell the user about how to use the replay path in case of problem

18 months agoDisplay the stack of each actor during a MC replay (unless --log=no_log for the tests)
Martin Quinson [Tue, 1 Nov 2022 18:39:55 +0000 (19:39 +0100)]
Display the stack of each actor during a MC replay (unless --log=no_log for the tests)

18 months agoMerge branch 'fluidio' into 'master'
Fred Suter [Tue, 1 Nov 2022 13:15:57 +0000 (13:15 +0000)]
Merge branch 'fluidio' into 'master'

Fluidio

See merge request simgrid/simgrid!121

18 months agofix issues spotted by agriersch
Fred Suter [Tue, 1 Nov 2022 13:04:18 +0000 (09:04 -0400)]
fix issues spotted by agriersch

18 months agoMC replay: check whether there is a deadlock after running the trace
Martin Quinson [Mon, 31 Oct 2022 23:35:54 +0000 (00:35 +0100)]
MC replay: check whether there  is a deadlock after running the trace

18 months agoAlign the behavior of MC and MC_replay in SMPI, so that replay actually works
Martin Quinson [Mon, 31 Oct 2022 23:25:43 +0000 (00:25 +0100)]
Align the behavior of MC and MC_replay in SMPI, so that replay actually works

+ improved debug messages

18 months agoBe more verbose on the blocking transition when displaying the actor state on Ctrl-C
Martin Quinson [Mon, 31 Oct 2022 21:41:10 +0000 (22:41 +0100)]
Be more verbose on the blocking transition when displaying the actor state on Ctrl-C

18 months agoextend test
Fred Suter [Mon, 31 Oct 2022 14:34:58 +0000 (10:34 -0400)]
extend test

18 months agoplug leak and more consistency with other models
Fred Suter [Mon, 31 Oct 2022 14:33:21 +0000 (10:33 -0400)]
plug leak and more consistency with other models

18 months agoMC_replay: Ensure that times_considered is always set
Martin Quinson [Sun, 30 Oct 2022 23:27:14 +0000 (00:27 +0100)]
MC_replay: Ensure that times_considered is always set

+ small cosmetics while reading again that code

18 months agoMBI: display the expected diagnostic on error
Martin Quinson [Tue, 25 Oct 2022 22:28:43 +0000 (00:28 +0200)]
MBI: display the expected diagnostic on error

18 months agocheck that disk has been given as argument before accessing its pimpl
Fred Suter [Fri, 28 Oct 2022 18:51:20 +0000 (14:51 -0400)]
check that disk has been given as argument before accessing its pimpl

18 months agoadd a transfer bottleneck case
Fred Suter [Fri, 28 Oct 2022 15:23:12 +0000 (11:23 -0400)]
add a transfer bottleneck case

18 months agorevalidate tesh
Fred Suter [Fri, 28 Oct 2022 11:48:13 +0000 (07:48 -0400)]
revalidate tesh

18 months agoupdate
Fred Suter [Fri, 28 Oct 2022 11:39:12 +0000 (07:39 -0400)]
update

18 months agoadd example
Fred Suter [Fri, 28 Oct 2022 11:38:47 +0000 (07:38 -0400)]
add example

18 months agointroduce s4u::Io::streamto
Fred Suter [Fri, 28 Oct 2022 11:36:22 +0000 (07:36 -0400)]
introduce s4u::Io::streamto

18 months agofixes
Fred Suter [Fri, 28 Oct 2022 11:36:11 +0000 (07:36 -0400)]
fixes

18 months agoeasier to store and use DiskImpl at kernel level
Fred Suter [Thu, 27 Oct 2022 12:59:09 +0000 (08:59 -0400)]
easier to store and use DiskImpl at kernel level

18 months agotypo spotted by Henri during a call
Fred Suter [Thu, 27 Oct 2022 12:31:05 +0000 (08:31 -0400)]
typo spotted by Henri during a call

18 months agoadd io_stream as a HostModel pure method
Fred Suter [Thu, 27 Oct 2022 12:29:45 +0000 (08:29 -0400)]
add io_stream as a HostModel pure method

18 months agofirst attempt to fluid comm/IO model
Fred Suter [Tue, 25 Oct 2022 13:16:34 +0000 (09:16 -0400)]
first attempt to fluid comm/IO model

18 months agomove update_remains_lazy to the pimpl (as for CPUs)
Fred Suter [Fri, 21 Oct 2022 18:17:48 +0000 (14:17 -0400)]
move update_remains_lazy to the pimpl (as for CPUs)

18 months agosimplify the way I/O actions are created (CPU style)
Fred Suter [Wed, 19 Oct 2022 16:20:10 +0000 (12:20 -0400)]
simplify the way I/O actions are created (CPU style)

18 months agoHave the disk model be part of the host models
Fred Suter [Tue, 18 Oct 2022 12:50:28 +0000 (08:50 -0400)]
Have the disk model be part of the host models

18 months agomention disk model in host model descriptions
Fred Suter [Tue, 18 Oct 2022 12:34:39 +0000 (08:34 -0400)]
mention disk model in host model descriptions

18 months agorename disk model init function: default is S19
Fred Suter [Tue, 18 Oct 2022 12:29:54 +0000 (08:29 -0400)]
rename disk model init function: default is S19

18 months agoMore functions declared "const" (Sonar).
Arnaud Giersch [Fri, 28 Oct 2022 09:09:15 +0000 (11:09 +0200)]
More functions declared "const" (Sonar).

18 months agoDeclare functions "const" (Sonar).
Arnaud Giersch [Thu, 27 Oct 2022 11:57:41 +0000 (13:57 +0200)]
Declare functions "const" (Sonar).

18 months agoFix infinite recursion.
Arnaud Giersch [Thu, 27 Oct 2022 11:50:11 +0000 (13:50 +0200)]
Fix infinite recursion.

18 months agoUse true/false for boolean variable (Sonar).
Arnaud Giersch [Thu, 27 Oct 2022 11:40:12 +0000 (13:40 +0200)]
Use true/false for boolean variable (Sonar).

18 months agoRemove redundant cast (Sonar).
Arnaud Giersch [Thu, 27 Oct 2022 11:23:40 +0000 (13:23 +0200)]
Remove redundant cast (Sonar).

18 months agoFix stack-use-after-scope (ASan).
Arnaud Giersch [Thu, 27 Oct 2022 11:22:31 +0000 (13:22 +0200)]
Fix stack-use-after-scope (ASan).

18 months agoCosmetics.
Arnaud Giersch [Thu, 27 Oct 2022 11:21:32 +0000 (13:21 +0200)]
Cosmetics.

18 months ago [ci-skip] end of the pass
Fred Suter [Wed, 26 Oct 2022 18:54:34 +0000 (14:54 -0400)]
 [ci-skip] end of the pass

18 months agostart a pass on that part of the doc
Fred Suter [Tue, 25 Oct 2022 16:04:09 +0000 (12:04 -0400)]
start a pass on that part of the doc

18 months agoMore x -> varrho in the doc
Martin Quinson [Tue, 25 Oct 2022 13:21:23 +0000 (15:21 +0200)]
More x -> varrho in the doc

18 months agoTry to make the abort() inconditionnal in failed xbt_assert, to please the checkers
Martin Quinson [Tue, 25 Oct 2022 13:05:49 +0000 (15:05 +0200)]
Try to make the abort() inconditionnal in failed xbt_assert, to please the checkers

18 months agoAdd a ref to the disk paper
Martin Quinson [Tue, 25 Oct 2022 13:04:27 +0000 (15:04 +0200)]
Add a ref to the disk paper

18 months agoArnaud prefers ϱ to x (+depict the simulated platform)
Martin Quinson [Tue, 25 Oct 2022 12:53:55 +0000 (14:53 +0200)]
Arnaud prefers ϱ to x (+depict the simulated platform)

18 months agoMerge branch 'master' of framagit.org:simgrid/simgrid
Martin Quinson [Tue, 25 Oct 2022 12:03:19 +0000 (14:03 +0200)]
Merge branch 'master' of framagit.org:simgrid/simgrid

18 months agoDraft a first version of the Models chapter in the doc
Martin Quinson [Tue, 25 Oct 2022 12:01:49 +0000 (14:01 +0200)]
Draft a first version of the Models chapter in the doc

18 months agoCosmetics
Arnaud Legrand [Tue, 25 Oct 2022 06:16:39 +0000 (08:16 +0200)]
Cosmetics

18 months agodoc: link to some more existing examples
Martin Quinson [Mon, 24 Oct 2022 07:01:22 +0000 (09:01 +0200)]
doc: link to some more existing examples

18 months agoMinor rewording
Arnaud Legrand [Mon, 24 Oct 2022 11:19:15 +0000 (13:19 +0200)]
Minor rewording

18 months agoFix non-smpi builds
Martin Quinson [Mon, 24 Oct 2022 06:35:44 +0000 (08:35 +0200)]
Fix non-smpi builds

18 months agoMake the factor callbacks private in NetworkModelFactors
Martin Quinson [Sun, 23 Oct 2022 22:53:48 +0000 (00:53 +0200)]
Make the factor callbacks private in NetworkModelFactors

18 months agoMove get_{bandwidth,latency}_factor to the NetworkModelFactors trait
Martin Quinson [Sun, 23 Oct 2022 22:23:27 +0000 (00:23 +0200)]
Move get_{bandwidth,latency}_factor to the NetworkModelFactors trait

18 months agoCleanups. Kill useless code
Martin Quinson [Sun, 23 Oct 2022 22:12:01 +0000 (00:12 +0200)]
Cleanups. Kill useless code

- Kill check_lat_factor_cb() and check_bw_factor_cb(): Now cleanly in NetworkModelFactors
- Kill the NetworkSmpiModel type: useless and empty
- Kill files network_smpi.[ch]pp: empty

18 months agoRename NetworkModelIntf into NetworkModelFactors
Martin Quinson [Sun, 23 Oct 2022 21:55:51 +0000 (23:55 +0200)]
Rename NetworkModelIntf into NetworkModelFactors

18 months agoMove set_lat_factor_cb and friends to NetworkModelFactors
Martin Quinson [Sun, 23 Oct 2022 20:40:57 +0000 (22:40 +0200)]
Move set_lat_factor_cb and friends to NetworkModelFactors

18 months agoChange public NetworkModelIntf.hpp into private NetworkModelFactors.hpp
Martin Quinson [Sun, 23 Oct 2022 20:08:48 +0000 (22:08 +0200)]
Change public NetworkModelIntf.hpp into private NetworkModelFactors.hpp

- This will soon become a Trait dedicated to the handling of factors

18 months agoAllow to set the network factors callback from userland w/o relying on NetworkModelIntf
Martin Quinson [Sun, 23 Oct 2022 19:57:59 +0000 (21:57 +0200)]
Allow to set the network factors callback from userland w/o relying on NetworkModelIntf

- this file is soon private, as the other kernel headers
- this was missing a simcall anyway

18 months agoMove FactorSet from smpi::utils to kernel::resource
Martin Quinson [Sun, 23 Oct 2022 14:46:56 +0000 (16:46 +0200)]
Move FactorSet from smpi::utils to kernel::resource

This fixes non-SMPI builds.

Also fix clang builds on the way (initializer_list must be given explicitly)

18 months agoRewrite the doc of the bw and latency factors
Martin Quinson [Sun, 23 Oct 2022 14:02:09 +0000 (16:02 +0200)]
Rewrite the doc of the bw and latency factors

19 months agoMerge network/bandwidth-factor and smpi/bw-factor (and same for latency)
Martin Quinson [Sun, 23 Oct 2022 09:28:33 +0000 (11:28 +0200)]
Merge network/bandwidth-factor and smpi/bw-factor (and same for latency)

19 months agoHide cfg_latency_factor and bw, and change them into smpi::utils::FactorSet
Martin Quinson [Sat, 22 Oct 2022 21:36:36 +0000 (23:36 +0200)]
Hide cfg_latency_factor and bw, and change them into smpi::utils::FactorSet

19 months agoParameters 'network/latency-factor' and bandwidth-factor are now strings parsed manually
Martin Quinson [Sat, 22 Oct 2022 20:31:08 +0000 (22:31 +0200)]
Parameters 'network/latency-factor' and bandwidth-factor are now strings parsed manually

This will allow to merge them with their smpi counterparts.

19 months agoAlso cleanup the network/weight-S parameter
Martin Quinson [Sat, 22 Oct 2022 20:05:48 +0000 (22:05 +0200)]
Also cleanup the network/weight-S parameter

19 months agoCleanups around network/latency-factor. Default latency of Cste model is 1 again
Martin Quinson [Sat, 22 Oct 2022 19:56:37 +0000 (21:56 +0200)]
Cleanups around network/latency-factor. Default latency of Cste model is 1 again

Default latency was accidentally the latency factor of LV_08

19 months agoInline the parse_factor function now that FactorSet is in place
Martin Quinson [Sat, 22 Oct 2022 19:15:43 +0000 (21:15 +0200)]
Inline the parse_factor function now that FactorSet is in place

19 months agoReduce the exposition of s_smpi_factor_t
Martin Quinson [Sat, 22 Oct 2022 19:10:50 +0000 (21:10 +0200)]
Reduce the exposition of s_smpi_factor_t

19 months agofurther refacto smpi_factors to reduce dupplication
Martin Quinson [Sat, 22 Oct 2022 18:00:12 +0000 (20:00 +0200)]
further refacto smpi_factors to reduce dupplication

19 months agoIntroduce class simgrid::smpi::utils::FactorSet to reduce code dupplication
Martin Quinson [Sat, 22 Oct 2022 16:59:39 +0000 (18:59 +0200)]
Introduce class simgrid::smpi::utils::FactorSet to reduce code dupplication

19 months agoReduce dupplication around smpi factors
Martin Quinson [Sat, 22 Oct 2022 09:34:32 +0000 (11:34 +0200)]
Reduce dupplication around smpi factors

19 months agoKill an unused declaration
Martin Quinson [Fri, 21 Oct 2022 19:10:15 +0000 (21:10 +0200)]
Kill an unused declaration

19 months agofix the parameter of a strncpy call
Martin Quinson [Fri, 21 Oct 2022 12:51:59 +0000 (14:51 +0200)]
fix the parameter of a strncpy call

19 months agoDoc: link another python example (+ typo)
Martin Quinson [Fri, 21 Oct 2022 12:51:02 +0000 (14:51 +0200)]
Doc: link another python example  (+ typo)

19 months agoin MC mode, failed xbt_assert() are reported as MC_assert()s
Martin Quinson [Mon, 17 Oct 2022 23:36:14 +0000 (01:36 +0200)]
in MC mode, failed xbt_assert() are reported as MC_assert()s

19 months agoRemove temporary file [ci-skip]
Arnaud Giersch [Sun, 16 Oct 2022 16:19:13 +0000 (18:19 +0200)]
Remove temporary file [ci-skip]

19 months agoFix non-MC builds that don't have libevent-dev installed
Martin Quinson [Mon, 17 Oct 2022 20:50:48 +0000 (22:50 +0200)]
Fix non-MC builds that don't have libevent-dev installed

Appveyor and Mac OSx are such systems

19 months agoKill redundent sanity checks
Martin Quinson [Sun, 16 Oct 2022 22:27:01 +0000 (00:27 +0200)]
Kill redundent sanity checks

19 months agoDon't include simgrid/config.h from simgrid/modelchecker.h so that the later is cheap...
Martin Quinson [Sun, 16 Oct 2022 21:59:01 +0000 (23:59 +0200)]
Don't include simgrid/config.h from simgrid/modelchecker.h so that the later is cheap to load

The functions are now generated in any case, and only do something
when SIMGRID_HAVE_MC is compiled in.

Also:
 - kill MC_automaton_new_propositional_symbol() that was never implemented
 - kill MC_visited_reduction() that was not used (anymore?)
 - Convert _sg_do_model_check to simgrid::mc::cfg_do_model_check

19 months agoDeal with PTHREAD_STATIC_INITIALIZER if it behave as in glibc
Martin Quinson [Sun, 16 Oct 2022 14:53:27 +0000 (16:53 +0200)]
Deal with PTHREAD_STATIC_INITIALIZER if it behave as in glibc

19 months agoAdd a sthread+MC example that deadlocks
Martin Quinson [Sun, 16 Oct 2022 10:57:20 +0000 (12:57 +0200)]
Add a sthread+MC example that deadlocks

+ fix make distcheck

19 months agoRename the transitions so that asynchronous ones clearly appear so
Martin Quinson [Sun, 16 Oct 2022 10:42:24 +0000 (12:42 +0200)]
Rename the transitions so that asynchronous ones clearly appear so

19 months agoAdd a sthread example that works (no deadlock)
Martin Quinson [Sun, 16 Oct 2022 10:11:47 +0000 (12:11 +0200)]
Add a sthread example that works (no deadlock)

19 months agoImplement pthread_join in MC mode for sthread
Martin Quinson [Sun, 16 Oct 2022 09:54:03 +0000 (11:54 +0200)]
Implement pthread_join in MC mode for sthread

19 months agoRestore the previous observable behavior.
Arnaud Giersch [Fri, 14 Oct 2022 12:05:09 +0000 (14:05 +0200)]
Restore the previous observable behavior.

The value -1 was in fact never returned.

19 months agoFix crash with debug logs.
Arnaud Giersch [Fri, 14 Oct 2022 09:35:21 +0000 (11:35 +0200)]
Fix crash with debug logs.

19 months agoCosmetics.
Arnaud Giersch [Thu, 13 Oct 2022 13:01:15 +0000 (15:01 +0200)]
Cosmetics.

19 months agoRemove redundant guard.
Arnaud Giersch [Wed, 12 Oct 2022 16:40:25 +0000 (18:40 +0200)]
Remove redundant guard.

AppSide::ignore_heap() already returns early when not MC_is_active().

19 months agoFix distcheck.
Arnaud Giersch [Tue, 11 Oct 2022 13:10:58 +0000 (15:10 +0200)]
Fix distcheck.

19 months agoEnable simple sthread example.
Arnaud Giersch [Tue, 11 Oct 2022 13:06:29 +0000 (15:06 +0200)]
Enable simple sthread example.

19 months agoActor::create already does init->start.
Arnaud Giersch [Tue, 11 Oct 2022 12:50:14 +0000 (14:50 +0200)]
Actor::create already does init->start.

19 months agoFix dead store (fbinfer).
Arnaud Giersch [Fri, 7 Oct 2022 12:54:10 +0000 (14:54 +0200)]
Fix dead store (fbinfer).

19 months agoMBI: don't even run the concurrency tests. Save white bears as we know these tests...
Martin Quinson [Mon, 10 Oct 2022 21:25:57 +0000 (23:25 +0200)]
MBI: don't even run the concurrency tests. Save white bears as we know these tests fail

19 months agoMBI: use file globbing to make sure that we don't forget any generator
Martin Quinson [Mon, 10 Oct 2022 21:07:57 +0000 (23:07 +0200)]
MBI: use file globbing to make sure that we don't forget any generator

19 months agoMBI: Properly integrate the Epoch lifecycle tests into our infra
Martin Quinson [Mon, 10 Oct 2022 20:59:09 +0000 (22:59 +0200)]
MBI: Properly integrate the Epoch lifecycle tests into our infra

19 months agoOnly add a barrier to 8 collectives. The other ones don't seem to need it
Martin Quinson [Mon, 10 Oct 2022 20:49:19 +0000 (22:49 +0200)]
Only add a barrier to 8 collectives. The other ones don't seem to need it

19 months agoFix windows build by not declaring XBT_PUBLIC an inline function
Martin Quinson [Mon, 10 Oct 2022 20:13:57 +0000 (22:13 +0200)]
Fix windows build by not declaring XBT_PUBLIC an inline function