Arnaud Giersch [Tue, 13 Jul 2021 10:33:03 +0000 (12:33 +0200)]
Simplify, and avoid nested SmpiBenchGuard when rastro_resolution is called by rastro_timestamp.
Arnaud Giersch [Mon, 12 Jul 2021 14:04:59 +0000 (16:04 +0200)]
[sonar] Less implicit conversions.
Bruno Donassolo [Sat, 10 Jul 2021 16:49:48 +0000 (18:49 +0200)]
Add network factors in changelog
Martin Quinson [Fri, 9 Jul 2021 23:38:13 +0000 (01:38 +0200)]
doc: fix an issue spotted by find-missing.py
Martin Quinson [Fri, 9 Jul 2021 23:26:52 +0000 (01:26 +0200)]
docs: properly report typedefs that are missing in the doc
Martin Quinson [Fri, 9 Jul 2021 23:13:38 +0000 (01:13 +0200)]
Adapt docs/find-missing to breathe now that autodoxy is gone
Arnaud Giersch [Fri, 9 Jul 2021 16:32:49 +0000 (18:32 +0200)]
Fix another bunch of warnings in doc generation.
Arnaud Giersch [Fri, 9 Jul 2021 11:33:15 +0000 (13:33 +0200)]
Use 'console' syntax highlighting for shell typescripts.
Arnaud Giersch [Fri, 9 Jul 2021 08:51:25 +0000 (10:51 +0200)]
Various corrections in docs.
Arnaud Giersch [Thu, 8 Jul 2021 22:22:27 +0000 (00:22 +0200)]
Missing const.
Arnaud Giersch [Thu, 8 Jul 2021 22:16:58 +0000 (00:16 +0200)]
Fix debug message better [ci-skip]
Arnaud Giersch [Thu, 8 Jul 2021 21:16:58 +0000 (23:16 +0200)]
Remove dead entries in 'docs/find-missing.ignore'.
Kill unused file 'ignored_symbols'.
Arnaud Giersch [Thu, 8 Jul 2021 19:54:44 +0000 (21:54 +0200)]
Instr: for consistency, rename 'father' to 'parent' here too.
Arnaud Giersch [Thu, 8 Jul 2021 19:53:05 +0000 (21:53 +0200)]
NetZone: rename the remaining occurrence of 'father' to 'parent'.
Arnaud Giersch [Thu, 8 Jul 2021 19:23:25 +0000 (21:23 +0200)]
Cosmetics around deprecated functions.
Arnaud Giersch [Thu, 8 Jul 2021 12:00:48 +0000 (14:00 +0200)]
Kill deprecated private field ActorImpl::userdata_ (use Actor::get/set_data instead).
This is on the *Impl side, and does not need to wait for the deprecation quarantine.
Arnaud Giersch [Thu, 8 Jul 2021 09:38:32 +0000 (11:38 +0200)]
Make comment match the declaration in Engine.hpp.
Arnaud Giersch [Wed, 7 Jul 2021 13:46:34 +0000 (15:46 +0200)]
Vector::at() is good enough to check bounds.
Arnaud Giersch [Wed, 7 Jul 2021 12:39:50 +0000 (14:39 +0200)]
Reduce number of unnecessary copies of 'args'.
Arnaud Giersch [Tue, 6 Jul 2021 20:55:03 +0000 (22:55 +0200)]
Make EngineImpl::tasksTemp a local variable.
Arnaud Giersch [Tue, 6 Jul 2021 20:27:20 +0000 (22:27 +0200)]
Simplify function calls (avoid explicit std::vector<double>).
Either use the variant taking a scalar, or use an initialization list.
Arnaud Giersch [Tue, 6 Jul 2021 15:24:15 +0000 (17:24 +0200)]
Make single argument constructor LinkInRoute::LinkInRoute(const Link*) explicit.
Arnaud Giersch [Tue, 6 Jul 2021 14:29:53 +0000 (16:29 +0200)]
Fix empty #ifndef..#endif. Annotate helper function as deprecated.
Arnaud Giersch [Tue, 6 Jul 2021 08:54:27 +0000 (10:54 +0200)]
SplitDuplexLinkImpl always have SharingPolicy::SPLITDUPLEX. Use a sdingle assert in Link::get_impl().
Martin Quinson [Mon, 5 Jul 2021 22:51:53 +0000 (00:51 +0200)]
doc: autodoxy is gone, so remove a workaround for it
Martin Quinson [Mon, 5 Jul 2021 22:51:18 +0000 (00:51 +0200)]
Cosmetics in ChangeLog (mostly reorder and rewrap)
Martin Quinson [Mon, 5 Jul 2021 22:50:35 +0000 (00:50 +0200)]
small doc improvement
Arnaud Giersch [Mon, 5 Jul 2021 13:17:29 +0000 (15:17 +0200)]
Use reference to const for large input parameters.
Arnaud Giersch [Mon, 5 Jul 2021 13:17:29 +0000 (15:17 +0200)]
Add 'const' for sonar.
Arnaud Giersch [Mon, 5 Jul 2021 13:17:29 +0000 (15:17 +0200)]
Add informative comment near implementation for deprecated functions.
Arnaud Giersch [Mon, 5 Jul 2021 13:17:29 +0000 (15:17 +0200)]
Attribute 'virtual' is redundant with 'override'.
Arnaud Giersch [Mon, 5 Jul 2021 13:17:29 +0000 (15:17 +0200)]
It's an internal error if get_impl returns null. Add an assert to be sure.
(and hope to please fbinfer)
Bruno Donassolo [Thu, 1 Jul 2021 12:51:44 +0000 (14:51 +0200)]
Changelog: C++ interface
Bruno Donassolo [Thu, 1 Jul 2021 12:19:49 +0000 (14:19 +0200)]
Sonar variety
Bruno Donassolo [Wed, 30 Jun 2021 17:59:24 +0000 (19:59 +0200)]
Try to fix opensuse, gcc 11.0.0 build
Bruno Donassolo [Wed, 30 Jun 2021 16:00:02 +0000 (16:00 +0000)]
Merge branch 'split_link_impl' into 'master'
Split-Duplex: s4u support
See merge request simgrid/simgrid!66
Bruno Donassolo [Fri, 18 Jun 2021 13:11:57 +0000 (15:11 +0200)]
Split-Duplex: new management
1. Huge commit to add support to Split-Duplex in S4U.
- New interface: s4u::SplitDuplexLink
2. Allows its creation through the C++ interface without manually creating
the link UP and DOWN.
- NetZone::create_split_duplex_link
3. Changes in NetZone::add_route to allow the description of the
direction in C++ interface
- LinkInRoute: wrap around Link* to indicate the direction
(UP/DOWN/NONE) for the link.
- UP/DOWN are used to split-duplex links
- NONE for other types (shared, wifi, fat-pipe)
4. Fix use of split-duplex links in symmetric routes in XML too.
<route src="alice" dst="bob" symmetrical="YES">
<link_ctn id="link1" direction="UP"/>
</route>
Now this code works, it will add the link1_DOWN as route to
bob->alice. In the past, it would add link1_UP for bob->alice too.
Bruno Donassolo [Thu, 17 Jun 2021 14:51:01 +0000 (16:51 +0200)]
Don't mix LMM sharing policy with S4U.
Add another enum for maxmin sharing policy
In the maxmin system, only FATPIPE and SHARED make sense.
Arnaud Giersch [Sat, 26 Jun 2021 19:30:26 +0000 (21:30 +0200)]
Don't mix C with C++ API here.
This is in the Tutorial section and should be kept simple.
Arnaud Giersch [Fri, 25 Jun 2021 21:47:17 +0000 (23:47 +0200)]
Fix another bunch of dead links in docs.
Arnaud Giersch [Fri, 25 Jun 2021 11:05:17 +0000 (13:05 +0200)]
More trivial fixes for docs.
Remove reference to Mutex/Semaphore ctor and dtor, since they are not public.
Arnaud Giersch [Fri, 25 Jun 2021 09:35:40 +0000 (11:35 +0200)]
Increase requirements for breathe.
Arnaud Giersch [Fri, 25 Jun 2021 09:02:17 +0000 (11:02 +0200)]
Disallow sphinx>=4.0 for now: it's breaking on CI
Exception occurred:
File /usr/lib/python3/dist-packages/docutils/nodes.py, line 625, in __getitem__
return self.attributes[key]
KeyError: 'domain'
Arnaud Giersch [Fri, 25 Jun 2021 08:34:44 +0000 (10:34 +0200)]
Try to increase sphinx requirements.
Match version currently available in Debian testing and unstable.
Arnaud Giersch [Fri, 25 Jun 2021 08:03:59 +0000 (10:03 +0200)]
Minor fixes in doc.
Arnaud Giersch [Fri, 25 Jun 2021 06:51:36 +0000 (08:51 +0200)]
Two more const methods spotted by sonar.
Arnaud Giersch [Fri, 25 Jun 2021 06:50:15 +0000 (08:50 +0200)]
More int -> unsigned long.
Arnaud Giersch [Fri, 25 Jun 2021 06:34:50 +0000 (08:34 +0200)]
Don't fail when there's no error!
Arnaud Giersch [Thu, 24 Jun 2021 18:26:20 +0000 (20:26 +0200)]
Fix a few warnings when building doc (mostly related to doxygen).
Arnaud Giersch [Thu, 24 Jun 2021 20:25:04 +0000 (22:25 +0200)]
Correctly remove generated files.
The added "rm" command for s4u-exec-ptasks prevents use of ADD_TESH_FACTORIES
(it chokes on "--cfg=contexts/factory:...").
Bruno Donassolo [Thu, 24 Jun 2021 14:13:53 +0000 (16:13 +0200)]
Get back |br| in XML doc
Fix my previous mistake removing them
Arnaud Giersch [Thu, 24 Jun 2021 12:33:07 +0000 (14:33 +0200)]
This is an unsigned integer.
Arnaud Giersch [Thu, 24 Jun 2021 12:23:01 +0000 (14:23 +0200)]
GraphNodeData::graph_id_ is an unsigned long.
Arnaud Giersch [Thu, 24 Jun 2021 12:10:52 +0000 (14:10 +0200)]
Type consistency.
Arnaud Giersch [Thu, 24 Jun 2021 12:09:27 +0000 (14:09 +0200)]
This is a test for emptiness.
Arnaud Giersch [Thu, 24 Jun 2021 11:43:30 +0000 (13:43 +0200)]
[sonar] Avoid C-style array.
Arnaud Giersch [Thu, 24 Jun 2021 09:10:06 +0000 (11:10 +0200)]
Parameter 'fd' is always -1 for xbt_mheap_new. Kill dead code.
Bruno Donassolo [Thu, 24 Jun 2021 13:27:52 +0000 (15:27 +0200)]
Several improvements in doc [ci-skip]
Arnaud Giersch [Thu, 24 Jun 2021 08:03:30 +0000 (10:03 +0200)]
Declare method const.
Arnaud Giersch [Thu, 24 Jun 2021 08:01:10 +0000 (10:01 +0200)]
Fix type for variable.
Arnaud Giersch [Thu, 24 Jun 2021 07:48:15 +0000 (09:48 +0200)]
Use std::unique_ptr and remove explicit destructor.
Arnaud Giersch [Thu, 24 Jun 2021 07:39:48 +0000 (09:39 +0200)]
Pass the real pointer to the englobing MC class for the event callback.
(avoid accidental upcast)
Arnaud Giersch [Wed, 23 Jun 2021 09:11:13 +0000 (11:11 +0200)]
Use ssize_t for Exec::wait_any and Io::wait_any too.
Arnaud Giersch [Wed, 23 Jun 2021 08:56:43 +0000 (10:56 +0200)]
Use ssize_t as return type for Comm::wait_any.
Arnaud Giersch [Wed, 23 Jun 2021 08:23:09 +0000 (10:23 +0200)]
Use ssize_t as return type for Comm::test_any.
Arnaud Giersch [Tue, 22 Jun 2021 22:22:16 +0000 (00:22 +0200)]
Update .mailmap.
Arnaud Giersch [Tue, 22 Jun 2021 21:50:16 +0000 (23:50 +0200)]
Two more s/pointer/reference/ for std::vector parameter.
Arnaud Giersch [Tue, 22 Jun 2021 20:37:17 +0000 (22:37 +0200)]
Prefer a reference for first parameter of {test,wait}_{all,any}.
Arnaud Giersch [Tue, 22 Jun 2021 09:48:41 +0000 (11:48 +0200)]
Add a test in teshsuite for Comm::wait_all_for.
Arnaud Giersch [Mon, 21 Jun 2021 15:04:20 +0000 (17:04 +0200)]
Implement Comm::wait_all_for (wait_all with a timeout).
Arnaud Giersch [Mon, 21 Jun 2021 14:57:20 +0000 (16:57 +0200)]
Reduce code duplication.
Arnaud Giersch [Mon, 21 Jun 2021 14:13:58 +0000 (16:13 +0200)]
Make field 'mc::ActorState::times_considered' private.
Arnaud Giersch [Mon, 21 Jun 2021 13:31:10 +0000 (15:31 +0200)]
Make field 's4u::Host::pimpl_cpu' private.
Arnaud Giersch [Tue, 22 Jun 2021 15:17:24 +0000 (17:17 +0200)]
Add missing copyright notices.
Augustin Degomme [Tue, 22 Jun 2021 10:18:46 +0000 (12:18 +0200)]
help latest fedora with mc
Augustin Degomme [Tue, 22 Jun 2021 08:42:20 +0000 (10:42 +0200)]
be a bit more safe here
Augustin Degomme [Tue, 22 Jun 2021 08:41:17 +0000 (10:41 +0200)]
changelog update for SMPI
Augustin Degomme [Tue, 22 Jun 2021 08:09:33 +0000 (10:09 +0200)]
document _TAG versions of sampling macros
Bruno Donassolo [Mon, 21 Jun 2021 19:05:57 +0000 (21:05 +0200)]
Fix distcheck
Bruno Donassolo [Mon, 21 Jun 2021 18:59:32 +0000 (20:59 +0200)]
Link::set_concurrency_limit
Allow setting a limit for concurrent flows on platforms links.
Add a simple example limiting the number of flows to 2 in the single
platform link.
Bruno Donassolo [Thu, 17 Jun 2021 12:39:53 +0000 (14:39 +0200)]
Small entry about dynamic network factors [doc]
Bruno Donassolo [Thu, 17 Jun 2021 11:38:10 +0000 (13:38 +0200)]
StarZone documentation [doc]
Explain Star Zone and its special route declaration.
Bruno Donassolo [Tue, 15 Jun 2021 14:36:32 +0000 (16:36 +0200)]
Fix some links in graphical toc [doc]
Bruno Donassolo [Tue, 15 Jun 2021 10:52:27 +0000 (12:52 +0200)]
Adding some packages missing packages [doc]
Packages needed to run ./Build.sh script
Bruno Donassolo [Tue, 15 Jun 2021 10:52:12 +0000 (12:52 +0200)]
Adding C++ platform documentation [doc]
- Point to the examples.
- Rewrite routing part to explain how we calculate the routes between
different zones.
Augustin Degomme [Wed, 16 Jun 2021 22:24:24 +0000 (00:24 +0200)]
Add a SMPI_SAMPLE_LOCAL_TAG and SMPI_SAMPLE_GLOBAL_TAG macro for sampling, to provide unique parameters to separate various calls to sampling.
This can be used when a kernel is called with various distinct sets of parameters.
Tag is a string of max size 128.
Augustin Degomme [Wed, 16 Jun 2021 20:26:25 +0000 (22:26 +0200)]
Try to be more coherent, fix misleading message, and fix test.
It was asking 0 iterations max, let's say that this means "exit after the first".
Augustin Degomme [Wed, 16 Jun 2021 19:00:57 +0000 (21:00 +0200)]
fix bug in sampling, it was ignoring max number of iterations
Augustin Degomme [Mon, 14 Jun 2021 12:10:19 +0000 (14:10 +0200)]
set this error added in
9d5b713b1 as a pedantic one, to allow ignoring it.
Rationale : we don't really know if it's actually an error, and read2shmem code triggers it in proxy apps.
Augustin Degomme [Mon, 14 Jun 2021 12:08:23 +0000 (14:08 +0200)]
Add smpi/pedantic flag to avoiding reporting controversial errors that may or may not be important.
Augustin Degomme [Mon, 14 Jun 2021 12:07:41 +0000 (14:07 +0200)]
Add option smpi/errors-are-fatal to allow users to bypass MPI errors returned by SMPI.
This basically sets the default errhandler to MPI_ERRORS_RETURN if set to false.
Arnaud Giersch [Sun, 13 Jun 2021 19:48:26 +0000 (21:48 +0200)]
Cleanup in .gitignore files; delete obsolete tesh file. [ci-skip]
Arnaud Giersch [Sun, 13 Jun 2021 13:45:25 +0000 (15:45 +0200)]
[sonar] Replace redundant type with 'auto'.
Arnaud Giersch [Sat, 12 Jun 2021 13:01:42 +0000 (15:01 +0200)]
Remove misleading comment: there is no simcall between the two assignments.
Arnaud Giersch [Sat, 12 Jun 2021 13:00:49 +0000 (15:00 +0200)]
Add more optimizations for MC builds.
Arnaud Giersch [Fri, 11 Jun 2021 11:52:17 +0000 (13:52 +0200)]
Factorize common code to assemble vector<LinkImpl*> and update latency.
Arnaud Giersch [Fri, 11 Jun 2021 09:33:14 +0000 (11:33 +0200)]
Fix loop: iterator is invalid after insertion.
Arnaud Giersch [Fri, 11 Jun 2021 08:20:04 +0000 (10:20 +0200)]
Use 'std::vector' instead of a C-style array.
Arnaud Giersch [Fri, 11 Jun 2021 07:57:38 +0000 (09:57 +0200)]
For sonar.
Arnaud Giersch [Thu, 10 Jun 2021 14:35:37 +0000 (16:35 +0200)]
Cosmetics: snake_case.