Martin Quinson [Tue, 25 Oct 2022 12:01:49 +0000 (14:01 +0200)]
Draft a first version of the Models chapter in the doc
Martin Quinson [Mon, 24 Oct 2022 07:01:22 +0000 (09:01 +0200)]
doc: link to some more existing examples
Arnaud Legrand [Mon, 24 Oct 2022 11:19:15 +0000 (13:19 +0200)]
Minor rewording
Martin Quinson [Mon, 24 Oct 2022 06:35:44 +0000 (08:35 +0200)]
Fix non-smpi builds
Martin Quinson [Sun, 23 Oct 2022 22:53:48 +0000 (00:53 +0200)]
Make the factor callbacks private in NetworkModelFactors
Martin Quinson [Sun, 23 Oct 2022 22:23:27 +0000 (00:23 +0200)]
Move get_{bandwidth,latency}_factor to the NetworkModelFactors trait
Martin Quinson [Sun, 23 Oct 2022 22:12:01 +0000 (00:12 +0200)]
Cleanups. Kill useless code
- Kill check_lat_factor_cb() and check_bw_factor_cb(): Now cleanly in NetworkModelFactors
- Kill the NetworkSmpiModel type: useless and empty
- Kill files network_smpi.[ch]pp: empty
Martin Quinson [Sun, 23 Oct 2022 21:55:51 +0000 (23:55 +0200)]
Rename NetworkModelIntf into NetworkModelFactors
Martin Quinson [Sun, 23 Oct 2022 20:40:57 +0000 (22:40 +0200)]
Move set_lat_factor_cb and friends to NetworkModelFactors
Martin Quinson [Sun, 23 Oct 2022 20:08:48 +0000 (22:08 +0200)]
Change public NetworkModelIntf.hpp into private NetworkModelFactors.hpp
- This will soon become a Trait dedicated to the handling of factors
Martin Quinson [Sun, 23 Oct 2022 19:57:59 +0000 (21:57 +0200)]
Allow to set the network factors callback from userland w/o relying on NetworkModelIntf
- this file is soon private, as the other kernel headers
- this was missing a simcall anyway
Martin Quinson [Sun, 23 Oct 2022 14:46:56 +0000 (16:46 +0200)]
Move FactorSet from smpi::utils to kernel::resource
This fixes non-SMPI builds.
Also fix clang builds on the way (initializer_list must be given explicitly)
Martin Quinson [Sun, 23 Oct 2022 14:02:09 +0000 (16:02 +0200)]
Rewrite the doc of the bw and latency factors
Martin Quinson [Sun, 23 Oct 2022 09:28:33 +0000 (11:28 +0200)]
Merge network/bandwidth-factor and smpi/bw-factor (and same for latency)
Martin Quinson [Sat, 22 Oct 2022 21:36:36 +0000 (23:36 +0200)]
Hide cfg_latency_factor and bw, and change them into smpi::utils::FactorSet
Martin Quinson [Sat, 22 Oct 2022 20:31:08 +0000 (22:31 +0200)]
Parameters 'network/latency-factor' and bandwidth-factor are now strings parsed manually
This will allow to merge them with their smpi counterparts.
Martin Quinson [Sat, 22 Oct 2022 20:05:48 +0000 (22:05 +0200)]
Also cleanup the network/weight-S parameter
Martin Quinson [Sat, 22 Oct 2022 19:56:37 +0000 (21:56 +0200)]
Cleanups around network/latency-factor. Default latency of Cste model is 1 again
Default latency was accidentally the latency factor of LV_08
Martin Quinson [Sat, 22 Oct 2022 19:15:43 +0000 (21:15 +0200)]
Inline the parse_factor function now that FactorSet is in place
Martin Quinson [Sat, 22 Oct 2022 19:10:50 +0000 (21:10 +0200)]
Reduce the exposition of s_smpi_factor_t
Martin Quinson [Sat, 22 Oct 2022 18:00:12 +0000 (20:00 +0200)]
further refacto smpi_factors to reduce dupplication
Martin Quinson [Sat, 22 Oct 2022 16:59:39 +0000 (18:59 +0200)]
Introduce class simgrid::smpi::utils::FactorSet to reduce code dupplication
Martin Quinson [Sat, 22 Oct 2022 09:34:32 +0000 (11:34 +0200)]
Reduce dupplication around smpi factors
Martin Quinson [Fri, 21 Oct 2022 19:10:15 +0000 (21:10 +0200)]
Kill an unused declaration
Martin Quinson [Fri, 21 Oct 2022 12:51:59 +0000 (14:51 +0200)]
fix the parameter of a strncpy call
Martin Quinson [Fri, 21 Oct 2022 12:51:02 +0000 (14:51 +0200)]
Doc: link another python example (+ typo)
Martin Quinson [Mon, 17 Oct 2022 23:36:14 +0000 (01:36 +0200)]
in MC mode, failed xbt_assert() are reported as MC_assert()s
Arnaud Giersch [Sun, 16 Oct 2022 16:19:13 +0000 (18:19 +0200)]
Remove temporary file [ci-skip]
Martin Quinson [Mon, 17 Oct 2022 20:50:48 +0000 (22:50 +0200)]
Fix non-MC builds that don't have libevent-dev installed
Appveyor and Mac OSx are such systems
Martin Quinson [Sun, 16 Oct 2022 22:27:01 +0000 (00:27 +0200)]
Kill redundent sanity checks
Martin Quinson [Sun, 16 Oct 2022 21:59:01 +0000 (23:59 +0200)]
Don't include simgrid/config.h from simgrid/modelchecker.h so that the later is cheap to load
The functions are now generated in any case, and only do something
when SIMGRID_HAVE_MC is compiled in.
Also:
- kill MC_automaton_new_propositional_symbol() that was never implemented
- kill MC_visited_reduction() that was not used (anymore?)
- Convert _sg_do_model_check to simgrid::mc::cfg_do_model_check
Martin Quinson [Sun, 16 Oct 2022 14:53:27 +0000 (16:53 +0200)]
Deal with PTHREAD_STATIC_INITIALIZER if it behave as in glibc
Martin Quinson [Sun, 16 Oct 2022 10:57:20 +0000 (12:57 +0200)]
Add a sthread+MC example that deadlocks
+ fix make distcheck
Martin Quinson [Sun, 16 Oct 2022 10:42:24 +0000 (12:42 +0200)]
Rename the transitions so that asynchronous ones clearly appear so
Martin Quinson [Sun, 16 Oct 2022 10:11:47 +0000 (12:11 +0200)]
Add a sthread example that works (no deadlock)
Martin Quinson [Sun, 16 Oct 2022 09:54:03 +0000 (11:54 +0200)]
Implement pthread_join in MC mode for sthread
Arnaud Giersch [Fri, 14 Oct 2022 12:05:09 +0000 (14:05 +0200)]
Restore the previous observable behavior.
The value -1 was in fact never returned.
Arnaud Giersch [Fri, 14 Oct 2022 09:35:21 +0000 (11:35 +0200)]
Fix crash with debug logs.
Arnaud Giersch [Thu, 13 Oct 2022 13:01:15 +0000 (15:01 +0200)]
Cosmetics.
Arnaud Giersch [Wed, 12 Oct 2022 16:40:25 +0000 (18:40 +0200)]
Remove redundant guard.
AppSide::ignore_heap() already returns early when not MC_is_active().
Arnaud Giersch [Tue, 11 Oct 2022 13:10:58 +0000 (15:10 +0200)]
Fix distcheck.
Arnaud Giersch [Tue, 11 Oct 2022 13:06:29 +0000 (15:06 +0200)]
Enable simple sthread example.
Arnaud Giersch [Tue, 11 Oct 2022 12:50:14 +0000 (14:50 +0200)]
Actor::create already does init->start.
Arnaud Giersch [Fri, 7 Oct 2022 12:54:10 +0000 (14:54 +0200)]
Fix dead store (fbinfer).
Martin Quinson [Mon, 10 Oct 2022 21:25:57 +0000 (23:25 +0200)]
MBI: don't even run the concurrency tests. Save white bears as we know these tests fail
Martin Quinson [Mon, 10 Oct 2022 21:07:57 +0000 (23:07 +0200)]
MBI: use file globbing to make sure that we don't forget any generator
Martin Quinson [Mon, 10 Oct 2022 20:59:09 +0000 (22:59 +0200)]
MBI: Properly integrate the Epoch lifecycle tests into our infra
Martin Quinson [Mon, 10 Oct 2022 20:49:19 +0000 (22:49 +0200)]
Only add a barrier to 8 collectives. The other ones don't seem to need it
Martin Quinson [Mon, 10 Oct 2022 20:13:57 +0000 (22:13 +0200)]
Fix windows build by not declaring XBT_PUBLIC an inline function
Martin Quinson [Mon, 10 Oct 2022 19:23:25 +0000 (21:23 +0200)]
MBI.py: More informative error message on failure
Martin Quinson [Mon, 10 Oct 2022 19:19:04 +0000 (21:19 +0200)]
New option to detect dangerous code mixing collectives and P2P in a deadlocking way
Martin Quinson [Mon, 10 Oct 2022 18:54:59 +0000 (20:54 +0200)]
Allow to pass aliases to declare_flag
Martin Quinson [Fri, 7 Oct 2022 09:08:24 +0000 (11:08 +0200)]
MBI: re-mark as WILL_FAIL some tests that require to intercept memory accesses
Arnaud Giersch [Fri, 7 Oct 2022 12:47:17 +0000 (12:47 +0000)]
Merge branch 'wifi_clean' into 'master'
removed unused variable
See merge request simgrid/simgrid!120
Clément Courageux-Sudan [Fri, 7 Oct 2022 10:13:25 +0000 (12:13 +0200)]
removed unused variable
Arnaud Giersch [Fri, 7 Oct 2022 07:38:25 +0000 (09:38 +0200)]
Misc sonar and codefactor.io issues.
Arnaud Giersch [Fri, 7 Oct 2022 07:36:49 +0000 (09:36 +0200)]
List last merged MR.
Augustin Degomme [Thu, 6 Oct 2022 22:27:27 +0000 (22:27 +0000)]
Merge branch 'adegomme-master-patch-91657' into 'master'
SMPI: add option to inject a barrier before every collective call, to allow...
See merge request simgrid/simgrid!119
Augustin Degomme [Thu, 6 Oct 2022 22:18:04 +0000 (22:18 +0000)]
SMPI: add option to inject a barrier before every collective call, to allow better detection of dangerous patterns in MPI codes, triggering deadlocks more consistently. Activate it in -analyze mode, or with --cfg=smpi/colls-inject-barrier:true
Martin Quinson [Thu, 6 Oct 2022 21:58:39 +0000 (23:58 +0200)]
Document the recent https://framagit.org/simgrid/simgrid/-/merge_requests/118
Martin Quinson [Thu, 6 Oct 2022 12:50:37 +0000 (14:50 +0200)]
typo in the tutorial
Martin Quinson [Tue, 4 Oct 2022 22:35:41 +0000 (00:35 +0200)]
Let the latest MBI tests compile with our paranoid compil flags
Pierre-Antoine Rouby [Mon, 11 Jul 2022 13:11:58 +0000 (15:11 +0200)]
teshsuite: smpi: MBI: Merge change form MBI.
Martin Quinson [Tue, 4 Oct 2022 20:44:07 +0000 (22:44 +0200)]
We don't use doxygen to build the docs anymore
This integrates another debian patch
Martin Quinson [Tue, 4 Oct 2022 20:35:59 +0000 (22:35 +0200)]
Integrate the patch javadoc-openjdk17 from Debian
Arnaud Giersch [Thu, 6 Oct 2022 19:07:17 +0000 (19:07 +0000)]
Merge branch 'wifi_clean' into 'master'
Wi-Fi callback mechanism
See merge request simgrid/simgrid!118
Clément Courageux-Sudan [Thu, 6 Oct 2022 15:10:00 +0000 (17:10 +0200)]
syntax issues
Clément Courageux-Sudan [Thu, 6 Oct 2022 15:09:15 +0000 (17:09 +0200)]
fix make distcheck
Arnaud Giersch [Thu, 6 Oct 2022 12:16:55 +0000 (14:16 +0200)]
Do not expose Activity::set_remaining publicly.
Prevents confusion with Comm::set_payload_size.
Arnaud Giersch [Thu, 6 Oct 2022 12:16:37 +0000 (14:16 +0200)]
s/set_/get_/ in doc
Arnaud Giersch [Tue, 4 Oct 2022 13:27:24 +0000 (15:27 +0200)]
Coding style: prefer keyword "not" to "!".
Martin Quinson [Tue, 4 Oct 2022 12:54:57 +0000 (14:54 +0200)]
docker-stable gh action: push all tags; display the pushed version
Arnaud Giersch [Tue, 4 Oct 2022 06:54:20 +0000 (08:54 +0200)]
Define macro XBT_ATTRIB_DEPRECATED_v337.
Arnaud Giersch [Tue, 4 Oct 2022 06:54:20 +0000 (08:54 +0200)]
Remove deprecated features for next release (3.33).
Martin Quinson [Mon, 3 Oct 2022 23:21:16 +0000 (01:21 +0200)]
Start the next dev cycle
Augustin Degomme [Mon, 3 Oct 2022 21:38:20 +0000 (21:38 +0000)]
Don't crash simulation if size is 0 in sendrecv_replace, as it is legal.
Martin Quinson [Mon, 3 Oct 2022 18:38:53 +0000 (20:38 +0200)]
Release v3.32: The Wiedervereinigung release
Martin Quinson [Mon, 3 Oct 2022 17:14:56 +0000 (19:14 +0200)]
Fix an error message
Augustin Degomme [Mon, 3 Oct 2022 16:43:51 +0000 (16:43 +0000)]
MPI_Win: set to MPI_WIN_NULL after deletion to avoid possibility of calling it multiple times
Arnaud Giersch [Mon, 3 Oct 2022 12:25:18 +0000 (14:25 +0200)]
Minor polishing.
[ci-skip]
Fred Suter [Mon, 3 Oct 2022 12:17:22 +0000 (08:17 -0400)]
[noci] check v3.32 notes
Fred Suter [Tue, 19 Jul 2022 13:50:21 +0000 (09:50 -0400)]
docs/source/Release_Notes.rst
[noci] check v3.32 notes
Martin Quinson [Sun, 2 Oct 2022 23:45:24 +0000 (01:45 +0200)]
Draft of release notes
Martin Quinson [Sun, 2 Oct 2022 21:53:37 +0000 (23:53 +0200)]
Tentative NEWS file for the 3.32 release
Martin Quinson [Sun, 2 Oct 2022 21:39:59 +0000 (23:39 +0200)]
docs: tiny improvement about cmake+SMPI in user code
Martin Quinson [Sun, 2 Oct 2022 21:28:25 +0000 (23:28 +0200)]
More helpful error message when someone needs --cfg=model-check/setenv
Martin Quinson [Sun, 2 Oct 2022 19:35:32 +0000 (21:35 +0200)]
Cosmetics in the ChangeLog
Martin Quinson [Sun, 2 Oct 2022 15:05:37 +0000 (17:05 +0200)]
Document all commits since 3.31. The changelog may be reordered for clarity
Martin Quinson [Sun, 2 Oct 2022 14:37:20 +0000 (16:37 +0200)]
Hint the users about how to avoid dwarf5 errors around MC
Arnaud Giersch [Thu, 29 Sep 2022 15:29:41 +0000 (17:29 +0200)]
Use std::fill instead of memset.
It's a bit more C++'ish, and it seems to help to workaround what looks like an
optimization bug in IntelLLVM 2022.2.0 (xbt::dict unit tests are failing).
Arnaud Giersch [Thu, 29 Sep 2022 14:03:20 +0000 (16:03 +0200)]
Useless cast.
Arnaud Giersch [Thu, 29 Sep 2022 08:42:43 +0000 (10:42 +0200)]
Reduce code duplication.
Arnaud Giersch [Thu, 29 Sep 2022 08:41:43 +0000 (10:41 +0200)]
Cosmetics: parameter is obviously not empty.
Arnaud Giersch [Wed, 28 Sep 2022 20:34:48 +0000 (22:34 +0200)]
Update .mailmap.
Lucas Nesi [Wed, 28 Sep 2022 15:47:51 +0000 (17:47 +0200)]
Remove old fPIC placement
Lucas Nesi [Wed, 28 Sep 2022 14:26:26 +0000 (16:26 +0200)]
Ensure a fPIC in case CMDARGS has a fPIE
Arnaud Giersch [Wed, 21 Sep 2022 14:02:21 +0000 (16:02 +0200)]
Lambdas should not have too many lines (sonar).
Arnaud Giersch [Wed, 21 Sep 2022 12:45:27 +0000 (14:45 +0200)]
Kill obsolete FIXME.
Arnaud Giersch [Fri, 16 Sep 2022 15:04:39 +0000 (17:04 +0200)]
Initialize all members (PVS V730).
Arnaud Giersch [Fri, 16 Sep 2022 14:55:45 +0000 (16:55 +0200)]
Useless assignment (PVS V1048).