From 14395882a33613da82251cc43bce52f55f66c617 Mon Sep 17 00:00:00 2001
From: Fred Suter <suterf@ornl.gov>
Date: Tue, 23 May 2023 04:17:57 -0400
Subject: [PATCH] another try to please clang

---
 include/simgrid/s4u/Activity.hpp | 2 +-
 src/s4u/s4u_Activity.cpp         | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/simgrid/s4u/Activity.hpp b/include/simgrid/s4u/Activity.hpp
index cbedfaaaf4..4879ad3ea1 100644
--- a/include/simgrid/s4u/Activity.hpp
+++ b/include/simgrid/s4u/Activity.hpp
@@ -239,7 +239,7 @@ template <class AnyActivity> class Activity_T : public Activity {
   std::string tracing_category_ = "";
 
 public:
-  static xbt::signal<void(AnyActivity const&)> on_completion;
+  inline static xbt::signal<void(AnyActivity const&)> on_completion;
   /*! Add a callback fired when the activity completes (either normally, cancelled or failed) */
   static void on_completion_cb(const std::function<void(AnyActivity const&)>& cb) { on_completion.connect(cb); }
 
diff --git a/src/s4u/s4u_Activity.cpp b/src/s4u/s4u_Activity.cpp
index d9c236accd..4b593876ec 100644
--- a/src/s4u/s4u_Activity.cpp
+++ b/src/s4u/s4u_Activity.cpp
@@ -27,7 +27,6 @@ namespace s4u {
 xbt::signal<void(Activity&)> Activity::on_veto;
 xbt::signal<void(Activity const&)> Activity::on_suspended;
 xbt::signal<void(Activity const&)> Activity::on_resumed;
-template<class AnyActivity> extern xbt::signal<void(AnyActivity const&)> Activity_T<AnyActivity>::on_completion;
 
 std::set<Activity*>* Activity::vetoed_activities_ = nullptr;
 
-- 
2.20.1