From 184f0e36afb128db3cc35349d699b86f977c2820 Mon Sep 17 00:00:00 2001
From: Fred Suter <suterf@ornl.gov>
Date: Mon, 22 May 2023 15:21:41 -0400
Subject: [PATCH 1/1] add missing override

---
 include/simgrid/s4u/Comm.hpp | 2 +-
 include/simgrid/s4u/Exec.hpp | 2 +-
 include/simgrid/s4u/Io.hpp   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/simgrid/s4u/Comm.hpp b/include/simgrid/s4u/Comm.hpp
index 391b126c30..366d38babf 100644
--- a/include/simgrid/s4u/Comm.hpp
+++ b/include/simgrid/s4u/Comm.hpp
@@ -51,7 +51,7 @@ public:
   static void on_send_cb(const std::function<void(Comm const&)>& cb) { on_send.connect(cb); }
   static void on_recv_cb(const std::function<void(Comm const&)>& cb) { on_recv.connect(cb); }
   static void on_start_cb(const std::function<void(Comm const&)>& cb) { on_start.connect(cb); }
-  void fire_this_completion() const { on_completion(*this); }
+  void fire_this_completion() const override { on_completion(*this); }
   /* More callbacks */
   CommPtr set_copy_data_callback(const std::function<void(kernel::activity::CommImpl*, void*, size_t)>& callback);
   XBT_ATTRIB_DEPRECATED_v337("Please manifest if you actually need this function") static void copy_buffer_callback(
diff --git a/include/simgrid/s4u/Exec.hpp b/include/simgrid/s4u/Exec.hpp
index bf5898df56..d37b2c63c5 100644
--- a/include/simgrid/s4u/Exec.hpp
+++ b/include/simgrid/s4u/Exec.hpp
@@ -52,7 +52,7 @@ public:
 #endif
   /*! Signal fired each time that an execution actually starts (no veto) */
   static void on_start_cb(const std::function<void(Exec const&)>& cb) { on_start.connect(cb); }
-  void fire_this_completion() const { on_completion(*this); }
+  void fire_this_completion() const override { on_completion(*this); }
 
   static ExecPtr init();
 
diff --git a/include/simgrid/s4u/Io.hpp b/include/simgrid/s4u/Io.hpp
index 3cca8a7991..a2babc981d 100644
--- a/include/simgrid/s4u/Io.hpp
+++ b/include/simgrid/s4u/Io.hpp
@@ -35,7 +35,7 @@ public:
   enum class OpType { READ, WRITE };
 
   static void on_start_cb(const std::function<void(Io const&)>& cb) { on_start.connect(cb); }
-  void fire_this_completion() const { on_completion(*this); }
+  void fire_this_completion() const override{ on_completion(*this); }
 
   static IoPtr init();
   /*! take a vector of s4u::IoPtr and return when one of them is finished.
-- 
2.20.1