From 5dac6a62a7898887c48c6dd5197ca219580cdd08 Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Wed, 7 Apr 2021 14:54:52 +0200 Subject: [PATCH] Const/override for member functions. --- src/smpi/include/smpi_actor.hpp | 2 +- src/smpi/include/smpi_f2c.hpp | 4 ++-- src/smpi/include/smpi_request.hpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/smpi/include/smpi_actor.hpp b/src/smpi/include/smpi_actor.hpp index 1b43f2cabc..dd1519d900 100644 --- a/src/smpi/include/smpi_actor.hpp +++ b/src/smpi/include/smpi_actor.hpp @@ -75,7 +75,7 @@ public: void simulated_start(); double simulated_elapsed() const; MPI_Comm comm_world() const; - bool comm_self_is_set() {return (comm_self_ != MPI_COMM_NULL);}; + bool comm_self_is_set() const { return (comm_self_ != MPI_COMM_NULL); }; MPI_Comm comm_self(); MPI_Comm comm_intra(); void set_comm_intra(MPI_Comm comm); diff --git a/src/smpi/include/smpi_f2c.hpp b/src/smpi/include/smpi_f2c.hpp index 856525bc14..1f70e9b2b2 100644 --- a/src/smpi/include/smpi_f2c.hpp +++ b/src/smpi/include/smpi_f2c.hpp @@ -35,7 +35,7 @@ protected: if (not f2c_lookup_) f2c_lookup_ = std::make_unique(); } - int f2c_id() { return my_f2c_id_; } + int f2c_id() const { return my_f2c_id_; } static int global_f2c_id() { return f2c_id_; } static void f2c_id_increment() { f2c_id_++; } @@ -56,7 +56,7 @@ public: static F2C* f2c(int id); static void finish_initialization() { num_default_handles_ = f2c_lookup_->size(); } static f2c_lookup_type::size_type get_num_default_handles() { return num_default_handles_; } - std::string call_location(){ return call_location_; } + const std::string& call_location() const { return call_location_; } }; } diff --git a/src/smpi/include/smpi_request.hpp b/src/smpi/include/smpi_request.hpp index 9f2f86410f..939248b868 100644 --- a/src/smpi/include/smpi_request.hpp +++ b/src/smpi/include/smpi_request.hpp @@ -64,7 +64,7 @@ public: int tag() const { return tag_; } int flags() const { return flags_; } bool detached() const { return detached_; } - std::string name() const {return std::string("MPI_Request");} + std::string name() const override { return std::string("MPI_Request"); } MPI_Datatype type() const { return old_type_; } void print_request(const char* message) const; void start(); -- 2.20.1