From 72055aaf2beec9ff1d8f3317ca41094596ffebf8 Mon Sep 17 00:00:00 2001 From: Arnaud Giersch Date: Sat, 3 Apr 2021 23:59:15 +0200 Subject: [PATCH] Make virtual functions called from constructor "final". Sonar S1699: Constructors and destructors should only use defined methods and fields --- src/surf/network_cm02.hpp | 2 +- src/surf/ptask_L07.hpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/surf/network_cm02.hpp b/src/surf/network_cm02.hpp index da0d5cd9ff..dfa4e8ea69 100644 --- a/src/surf/network_cm02.hpp +++ b/src/surf/network_cm02.hpp @@ -31,7 +31,7 @@ class XBT_PRIVATE NetworkSmpiModel; class NetworkCm02Model : public NetworkModel { public: explicit NetworkCm02Model(const std::string& name); - LinkImpl* create_link(const std::string& name, const std::vector& bandwidths) override; + LinkImpl* create_link(const std::string& name, const std::vector& bandwidths) final; LinkImpl* create_wifi_link(const std::string& name, const std::vector& bandwidths) override; void update_actions_state_lazy(double now, double delta) override; void update_actions_state_full(double now, double delta) override; diff --git a/src/surf/ptask_L07.hpp b/src/surf/ptask_L07.hpp index 6c7db7a1af..4e6bf2b392 100644 --- a/src/surf/ptask_L07.hpp +++ b/src/surf/ptask_L07.hpp @@ -67,7 +67,7 @@ public: NetworkL07Model(const NetworkL07Model&) = delete; NetworkL07Model& operator=(const NetworkL07Model&) = delete; ~NetworkL07Model() override; - kernel::resource::LinkImpl* create_link(const std::string& name, const std::vector& bandwidths) override; + kernel::resource::LinkImpl* create_link(const std::string& name, const std::vector& bandwidths) final; kernel::resource::LinkImpl* create_wifi_link(const std::string& name, const std::vector& bandwidths) override; kernel::resource::Action* communicate(s4u::Host* src, s4u::Host* dst, double size, double rate) override; -- 2.20.1