From 9960565e03934f289c6fb41d34240ed27b6c76c2 Mon Sep 17 00:00:00 2001 From: Martin Quinson Date: Mon, 7 Mar 2022 09:09:59 +0100 Subject: [PATCH] sonar - Ignore MBI scripts in the coverage - unused local variable was indeed a bug --- sonar-project.properties | 2 +- teshsuite/smpi/MBI/simgrid.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sonar-project.properties b/sonar-project.properties index 4d9201fa1a..1742c3f472 100644 --- a/sonar-project.properties +++ b/sonar-project.properties @@ -199,7 +199,7 @@ sonar.cfamily.gcov.reportsPath=Testing/CoverageInfo # - Python files used to generate either simcalls or deployment files # - Any java source code (it's deprecated now) # - MSG (deprecated too) -sonar.coverage.exclusions=teshsuite/smpi/mpich3-test/**,examples/smpi/mc/**,**/*.xml,src/simix/simcalls.py,**/generate.py,**/*.java,src/bindings/java/**,src/msg/**,include/msg/**,examples/deprecated/**,teshsuite/msg/** +sonar.coverage.exclusions=teshsuite/smpi/mpich3-test/**,teshsuite/smpi/MBI/**,examples/smpi/mc/**,**/*.xml,**/generate.py,**/*.java,src/bindings/java/**,src/msg/**,include/msg/**,examples/deprecated/**,teshsuite/msg/** # Encoding of the source files sonar.sourceEncoding=UTF-8 diff --git a/teshsuite/smpi/MBI/simgrid.py b/teshsuite/smpi/MBI/simgrid.py index 1dc6befee6..b4f4158291 100644 --- a/teshsuite/smpi/MBI/simgrid.py +++ b/teshsuite/smpi/MBI/simgrid.py @@ -70,7 +70,7 @@ class Tool(AbstractTool): def parse(self, cachefile): if os.path.exists(f'{cachefile}.timeout') or os.path.exists(f'logs/simgrid/{cachefile}.timeout'): - outcome = 'timeout' + return 'timeout' if not (os.path.exists(f'{cachefile}.txt') or os.path.exists(f'logs/simgrid/{cachefile}.txt')): return 'failure' -- 2.20.1