From de6f03f2a89a0e4810740ef55689e82cede38e31 Mon Sep 17 00:00:00 2001
From: Arnaud Giersch <arnaud.giersch@univ-fcomte.fr>
Date: Tue, 2 May 2023 16:32:11 +0200
Subject: [PATCH] Kill useless empty function.

---
 include/simgrid/plugins/operation.hpp | 4 ++--
 src/plugins/operation.cpp             | 9 ++++++---
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/include/simgrid/plugins/operation.hpp b/include/simgrid/plugins/operation.hpp
index acd7dddba1..0f2f0e664f 100644
--- a/include/simgrid/plugins/operation.hpp
+++ b/include/simgrid/plugins/operation.hpp
@@ -44,8 +44,8 @@ protected:
   int count_        = 0;
   bool working_     = false;
   simgrid::s4u::ActivityPtr current_activity_;
-  std::function<void(Operation*)> end_func_   = [](Operation*) {};
-  std::function<void(Operation*)> start_func_ = [](Operation*) {};
+  std::function<void(Operation*)> end_func_;
+  std::function<void(Operation*)> start_func_;
   Operation(const std::string& name);
   virtual ~Operation()   = default;
   virtual void execute() = 0;
diff --git a/src/plugins/operation.cpp b/src/plugins/operation.cpp
index f9f8f1c105..06290650db 100644
--- a/src/plugins/operation.cpp
+++ b/src/plugins/operation.cpp
@@ -105,7 +105,8 @@ void Operation::complete()
     working_ = false;
     count_++;
   });
-  end_func_(this);
+  if (end_func_)
+    end_func_(this);
   Operation::on_end(this);
   for (auto const& op : successors_)
     op->receive(this);
@@ -234,7 +235,8 @@ ExecOpPtr ExecOp::init(const std::string& name, double flops, simgrid::s4u::Host
  */
 void ExecOp::execute()
 {
-  start_func_(this);
+  if (start_func_)
+    start_func_(this);
   Operation::on_start(this);
   simgrid::kernel::actor::simcall_answered([this] {
     working_      = true;
@@ -301,7 +303,8 @@ CommOpPtr CommOp::init(const std::string& name, double bytes, simgrid::s4u::Host
  */
 void CommOp::execute()
 {
-  start_func_(this);
+  if (start_func_)
+    start_func_(this);
   Operation::on_start(this);
   simgrid::kernel::actor::simcall_answered([this] {
     working_      = true;
-- 
2.20.1