From fd9816a49af1ad3ce81c8a51744fdd517135cb39 Mon Sep 17 00:00:00 2001 From: SUTER Frederic Date: Tue, 11 Jan 2022 10:57:14 +0100 Subject: [PATCH 1/1] =?utf8?q?[sonar]=C2=A0const?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit --- .../s4u-trace-host-user-variables.cpp | 6 +++--- .../s4u-trace-link-user-variables.cpp | 4 ++-- .../cpp/trace-masterworkers/s4u-trace-masterworkers.cpp | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/cpp/trace-host-user-variables/s4u-trace-host-user-variables.cpp b/examples/cpp/trace-host-user-variables/s4u-trace-host-user-variables.cpp index 00e4d6ef4c..d650f55734 100644 --- a/examples/cpp/trace-host-user-variables/s4u-trace-host-user-variables.cpp +++ b/examples/cpp/trace-host-user-variables/s4u-trace-host-user-variables.cpp @@ -15,7 +15,7 @@ XBT_LOG_NEW_DEFAULT_CATEGORY(s4u_test, "Messages specific for this s4u example") static void trace_fun() { - auto* host = simgrid::s4u::this_actor::get_host(); + const auto* host = simgrid::s4u::this_actor::get_host(); // the hostname has an empty HDD with a capacity of 100000 (bytes) simgrid::instr::set_host_variable(host, "HDD_capacity", 100000); @@ -54,13 +54,13 @@ int main(int argc, char* argv[]) e.run(); // get user declared variables - auto host_variables = simgrid::instr::get_host_variables(); + const auto& host_variables = simgrid::instr::get_host_variables(); if (not host_variables.empty()) { XBT_INFO("Declared host variables:"); for (const auto& var : host_variables) XBT_INFO("%s", var.c_str()); } - auto link_variables = simgrid::instr::get_link_variables(); + const auto& link_variables = simgrid::instr::get_link_variables(); xbt_assert(link_variables.empty(), "Should not have any declared link variable!"); return 0; diff --git a/examples/cpp/trace-link-user-variables/s4u-trace-link-user-variables.cpp b/examples/cpp/trace-link-user-variables/s4u-trace-link-user-variables.cpp index 59de93da22..48c1d9a660 100644 --- a/examples/cpp/trace-link-user-variables/s4u-trace-link-user-variables.cpp +++ b/examples/cpp/trace-link-user-variables/s4u-trace-link-user-variables.cpp @@ -15,8 +15,8 @@ static void trace_fun() { // set initial values for the link user variables this example only shows for links identified by "6" and "3" in the // platform file - auto* link_3 = simgrid::s4u::Link::by_name("3"); - auto* link_6 = simgrid::s4u::Link::by_name("6"); + const auto* link_3 = simgrid::s4u::Link::by_name("3"); + const auto* link_6 = simgrid::s4u::Link::by_name("6"); // Set the Link_Capacity variable simgrid::instr::set_link_variable(link_6, "Link_Capacity", 12.34); simgrid::instr::set_link_variable(link_3, "Link_Capacity", 56.78); diff --git a/examples/cpp/trace-masterworkers/s4u-trace-masterworkers.cpp b/examples/cpp/trace-masterworkers/s4u-trace-masterworkers.cpp index e3c3703dd0..2e130e05ea 100644 --- a/examples/cpp/trace-masterworkers/s4u-trace-masterworkers.cpp +++ b/examples/cpp/trace-masterworkers/s4u-trace-masterworkers.cpp @@ -22,7 +22,7 @@ static void master(std::vector args) double compute_cost = std::stod(args[2]); long communication_cost = std::stol(args[3]); size_t workers_count = args.size() - 4; - auto* my_host = simgrid::s4u::this_actor::get_host(); + const auto* my_host = simgrid::s4u::this_actor::get_host(); auto mailbox = simgrid::s4u::Mailbox::by_name("master_mailbox"); XBT_DEBUG("Got %zu workers and %ld tasks to process", workers_count, tasks_count); @@ -107,14 +107,14 @@ int main(int argc, char* argv[]) XBT_DEBUG("Simulation is over"); - auto categories = simgrid::instr::get_tracing_categories(); + const auto& categories = simgrid::instr::get_tracing_categories(); if (not categories.empty()) { XBT_INFO("Declared tracing categories:"); for (const auto& category : categories) XBT_INFO("%s", category.c_str()); } - auto marks = simgrid::instr::get_marks(); + const auto& marks = simgrid::instr::get_marks(); if (not marks.empty()) { XBT_INFO("Declared marks:"); for (const auto& mark : marks) -- 2.30.2