Use bool for return type of parse_args().

[loba.git] / options.cpp

diff --git a/options.cpp b/options.cpp
index cf9d7b70bcfdbc6cd14bf08559981fb9d86768d3..142056600f93c83bfe2ec94e1c16cefe496191f0 100644 (file)
--- a/options.cpp
+++ b/options.cpp
@@ -13,6 +13,12 @@ XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(main);
 
 namespace opt {
 
+    // Constants
+
+    // A sum of loads if considered null if it is less than
+    // load_ratio_threshold percent of the sum of loads at init.
+    const double load_ratio_threshold = 1e-4;
+
     // Global options
     std::string program_name;
     int help_requested = 0;
@@ -69,9 +75,9 @@ namespace opt {
 
 } // namespace opt
 
-int opt::parse_args(int* argc, char* argv[])
+bool opt::parse_args(int* argc, char* argv[])
 {
-    int result = 1;
+    bool result = true;
 
     opt::program_name = argv[0];
     opt::program_name.erase(0, 1 + opt::program_name.find_last_of('/'));
@@ -85,7 +91,7 @@ int opt::parse_args(int* argc, char* argv[])
             if (!opt::loba_algorithms.exists(opt::loba_algo)) {
                 ERROR1("unknownw load balancing algorithm -- %s",
                        opt::loba_algo.c_str());
-                result = 0;
+                result = false;
             }
             break;
         case 'b':
@@ -120,7 +126,7 @@ int opt::parse_args(int* argc, char* argv[])
             if (!opt::topologies.exists(opt::auto_depl::topology)) {
                 ERROR1("unknownw topology -- %s",
                        opt::auto_depl::topology.c_str());
-                result = 0;
+                result = false;
             }
             break;
         case 'v':
@@ -132,7 +138,7 @@ int opt::parse_args(int* argc, char* argv[])
             break;
         case '?':
             ERROR1("invalid option -- '%c'", optopt);
-            result = 0;
+            result = false;
             break;
         }
     }
@@ -144,7 +150,7 @@ int opt::parse_args(int* argc, char* argv[])
         opt::platform_file = argv[optind++];
     } else {
         ERROR0("missing parameter -- <plaform_file>");
-        result = 0;
+        result = false;
     }
     if (optind < *argc) {
         opt::deployment_file = argv[optind++];
@@ -153,7 +159,7 @@ int opt::parse_args(int* argc, char* argv[])
 
     while (optind < *argc) {
         ERROR1("unused parameter -- \"%s\"", argv[optind++]);
-        result = 0;
+        result = false;
     }
 
     return result;