Fix typos.

[loba.git] / process.cpp

diff --git a/process.cpp b/process.cpp
index b0d702644de509e4cc2e12c53212847e924a07ac..214b9d05a785d80edeb436f14466a6d8140545d9 100644 (file)
--- a/process.cpp
+++ b/process.cpp
@@ -1,5 +1,3 @@
-#include "process.h"
-

 #include <algorithm>
 #include <tr1/functional>
 #include <iterator>
 #include <algorithm>
 #include <tr1/functional>
 #include <iterator>


@@ -8,10 +6,16 @@
 #include <sstream>
 #include <xbt/log.h>
 #include <xbt/time.h>
 #include <sstream>
 #include <xbt/log.h>
 #include <xbt/time.h>

+
+XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(proc);
+

 #include "misc.h"
 #include "options.h"
 
 #include "misc.h"
 #include "options.h"
 

-XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(proc);
+#include "process.h"
+
+double process::total_load_init = 0.0;
+double process::total_load_exit = 0.0;

 
 process::process(int argc, char* argv[])
 {
 
 process::process(int argc, char* argv[])
 {


@@ -29,6 +33,7 @@ process::process(int argc, char* argv[])
     }
 
     expected_load = load;
     }
 
     expected_load = load;

+    total_load_init += load;

 
     ctrl_close_pending = data_close_pending = neigh.size();
     if (neigh.size() == 1) {
 
     ctrl_close_pending = data_close_pending = neigh.size();
     if (neigh.size() == 1) {


@@ -51,24 +56,25 @@ process::process(int argc, char* argv[])
         oss << neigh.back().get_name();
     }
     LOG1(logp, "Got %s.", oss.str().c_str());
         oss << neigh.back().get_name();
     }
     LOG1(logp, "Got %s.", oss.str().c_str());

-    print_loads(logp);
+    print_loads(true, logp);

 }
 
 process::~process()
 {
 }
 
 process::~process()
 {

+    total_load_exit += load;

 }
 
 int process::run()
 {
 }
 
 int process::run()
 {

-    bool one_more = true;
-

     INFO1("Initial load: %g", load);
     VERB0("Starting...");
     // first send() to inform neighbors about our load (force it)
     INFO1("Initial load: %g", load);
     VERB0("Starting...");
     // first send() to inform neighbors about our load (force it)

-    prev_load_broadcast = !(opt::bookkeeping? expected_load: load);
-    send();
+    prev_load_broadcast = -1;

     iter = 0;
     iter = 0;

-    while (one_more) {
+    bool one_more = true;
+    do {
+        ++iter;
+

         if (opt::log_rate && iter % opt::log_rate == 0) {
             if (opt::bookkeeping)
                 INFO3("(%u) current load: %g ; expected: %g",
         if (opt::log_rate && iter % opt::log_rate == 0) {
             if (opt::bookkeeping)
                 INFO3("(%u) current load: %g ; expected: %g",


@@ -77,15 +83,7 @@ int process::run()
                 INFO2("(%u) current load: %g",
                       iter, load);
         }
                 INFO2("(%u) current load: %g",
                       iter, load);
         }

-        print_loads(xbt_log_priority_debug);
-
-        bool do_compute = load > 0.0;
-        if (do_compute) {
-            compute();
-            ++iter;
-        }
-
-        bool close_received = !receive(do_compute? NO_WAIT: WAIT);
+        print_loads(true, xbt_log_priority_debug);

 
         if (opt::bookkeeping)
             expected_load -= load_balance(expected_load);
 
         if (opt::bookkeeping)
             expected_load -= load_balance(expected_load);


@@ -93,12 +91,31 @@ int process::run()
             load -= load_balance(load);
 
         send();
             load -= load_balance(load);
 
         send();

+        compute();

 
 

-        if (opt::exit_on_close && close_received)
-            one_more = false;
-        if (opt::maxiter && iter >= opt::maxiter)
-            one_more = false;
-    }
+// NDS for Need To Send
+#define NDS ((opt::bookkeeping ? expected_load : load) != prev_load_broadcast)
+        bool can_recv;
+        do {
+            // General idea: do not iterate if there is nothing to
+            // compute, nor to send.
+
+            // fixme: review this chunk, and remove this NDS macro!
+
+            bool recv_wait = (load == 0 && !NDS);
+            bool close_received = !receive(recv_wait? WAIT: NO_WAIT);
+
+            if (opt::exit_on_close && close_received)
+                one_more = false;
+            else if (opt::maxiter && iter >= opt::maxiter)
+                one_more = false;
+            
+            can_recv = (ctrl_close_pending || data_close_pending);
+
+        } while (one_more && can_recv && load == 0 && !NDS);
+#undef NDS
+
+    } while (one_more);

     VERB0("Going to finalize...");
     finalize();
 
     VERB0("Going to finalize...");
     finalize();
 


@@ -109,11 +126,9 @@ int process::run()
      */
 
     VERB0("Done.");
      */
 
     VERB0("Done.");

+    INFO3("Final load after %d iteration%s: %g", iter, ESSE(iter), load);

     if (opt::bookkeeping)
     if (opt::bookkeeping)

-        INFO4("Final load after %d iteration%s: %g ; expected: %g",
-              iter, ESSE(iter), load, expected_load);
-    else
-        INFO3("Final load after %d iteration%s: %g", iter, ESSE(iter), load);
+        INFO1("Expected load: %g", expected_load);

     return 0;
 }
 
     return 0;
 }
 


@@ -136,11 +151,15 @@ double process::load_balance(double /*my_load*/)
 
 void process::compute()
 {
 
 void process::compute()
 {

-    double duration = opt::comp_cost(load);
-    m_task_t task = MSG_task_create("computation", duration, 0.0, NULL);
-    DEBUG2("compute %g flop%s.", duration, ESSE(duration));
-    MSG_task_execute(task);
-    MSG_task_destroy(task);
+    if (load > 0.0) {
+        double duration = opt::comp_cost(load);
+        m_task_t task = MSG_task_create("computation", duration, 0.0, NULL);
+        DEBUG2("compute %g flop%s.", duration, ESSE(duration));
+        MSG_task_execute(task);
+        MSG_task_destroy(task);
+    } else {
+        DEBUG0("nothing to compute !");
+    }

 }
 
 void process::send1_no_bookkeeping(neighbor& nb)
 }
 
 void process::send1_no_bookkeeping(neighbor& nb)


@@ -201,6 +220,8 @@ void process::send()
 
 bool process::receive(recv_wait_mode wait)
 {
 
 bool process::receive(recv_wait_mode wait)
 {

+    // DEBUG1("go for receive(%s)",
+    //        "NO_WAIT\0WAIT\0\0\0\0WAIT_FOR_CLOSE" + 8 * wait);

     bool result = true;
     message* msg;
     m_host_t from;
     bool result = true;
     message* msg;
     m_host_t from;


@@ -261,23 +282,31 @@ void process::finalize()
     comm.flush(true);
 }
 
     comm.flush(true);
 }
 

-void process::print_loads(e_xbt_log_priority_t logp)
+#define print_loads_generic(vec, verbose, logp, cat)                    \
+    if (_XBT_LOG_ISENABLEDV((*cat), logp)) {                            \
+        using namespace std::tr1;                                       \
+        using namespace std::tr1::placeholders;                         \
+        XCLOG0(cat, logp, "Neighbor loads:");                           \
+        std::for_each(vec.begin(), vec.end(),                           \
+                      bind(&neighbor::print, _1, verbose, logp, cat));  \
+    } else ((void)0)
+
+void process::print_loads(bool verbose,
+                          e_xbt_log_priority_t logp,
+                          xbt_log_category_t cat) const

 {
 {

-    if (!LOG_ISENABLED(logp))
-        return;
+    print_loads_generic(neigh, verbose, logp, cat);
+}

 
 

-    std::ostringstream oss;
-    if (neigh.empty()) {
-        oss << "no neighbor!";
-    } else {
-        std::transform(neigh.begin(), neigh.end() - 1,
-                       std::ostream_iterator<double>(oss, ", "),
-                       std::tr1::mem_fn(&neighbor::get_load));
-        oss << neigh.back().get_load();
-    }
-    LOG1(logp, "Neighbor loads: %s", oss.str().c_str());
+void process::print_loads_p(bool verbose,
+                            e_xbt_log_priority_t logp,
+                            xbt_log_category_t cat) const
+{
+    print_loads_generic(pneigh, verbose, logp, cat);

 }
 
 }
 

+#undef print_loads_generic
+

 // Local variables:
 // mode: c++
 // End:
 // Local variables:
 // mode: c++
 // End: