Be consistent and hold mutex in any case when returning from condition_t::timedwait().

[loba.git] / hostdata.cpp

diff --git a/hostdata.cpp b/hostdata.cpp
index c15c0eefa325f963b83ea7b9eacfb5b341540113..88ca6fde2f197305879f8dea66e86521b9a74d5a 100644 (file)
--- a/hostdata.cpp
+++ b/hostdata.cpp
@@ -1,42 +1,43 @@
-#include "hostdata.h"
-
-#include <cstring>
 #include <algorithm>
+#include <cstring>
+#include <functional>
 #include <stdexcept>
 #include <xbt/log.h>
 #include <xbt/sysdep.h>
-#include "misc.h"
 
 XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(main);
 
-std::vector<hostdata> hostdata::hosts;
+#include "misc.h"
+#include "options.h"
 
-// used to compare m_host_t's by name
-struct hostdata::m_host_less {
-    bool operator()(const m_host_t& a, const m_host_t& b)
-    {
-        const char* na = MSG_host_get_name(a);
-        const char* nb = MSG_host_get_name(b);
-        return strcmp(na, nb) < 0;
-    }
-};
+#include "hostdata.h"
+
+std::vector<hostdata> hostdata::hosts;
 
 void hostdata::create()
 {
-    int nhosts = MSG_get_host_number();
-    m_host_t* host_list = MSG_get_host_table();
-    // fixme: only sort hosts for automatically created deployment
-    // fixme: add an option to disable sorting
-    std::sort(host_list, host_list + nhosts, m_host_less());
+    using std::placeholders::_1;
+    using std::placeholders::_2;
+
+    xbt_dynar_t host_dynar = MSG_hosts_as_dynar();
+    int nhosts = xbt_dynar_length(host_dynar);
+    msg_host_t* host_list = static_cast<msg_host_t*>(xbt_dynar_to_array(host_dynar));
+    // only sort hosts for automatically created deployment
+    if (opt::auto_depl::enabled)
+        std::sort(host_list, host_list + nhosts,
+                  std::bind(std::less<int>(),
+                            std::bind(strcmp,
+                                      std::bind(MSG_host_get_name, _1),
+                                      std::bind(MSG_host_get_name, _2)), 0));
     hosts.assign(host_list, host_list + nhosts);
     xbt_free(host_list);
 
     e_xbt_log_priority_t logp = xbt_log_priority_verbose;
     if (!LOG_ISENABLED(logp))
         return;
-    LOG1(logp, "Got %lu hosts.", (unsigned long)hosts.size());
+    XBT_LOG(logp, "Got %zu hosts.", hosts.size());
     for (int i = 0; i < nhosts; i++) {
-        LOG2(logp, "Host #%d named \"%s\".", i, hosts[i].get_name());
+        XBT_LOG(logp, "Host #%d named \"%s\".", i, hosts[i].get_name());
     }
 }
 
@@ -45,7 +46,7 @@ void hostdata::destroy()
     // hosts are automatically destroyed...
 }
 
-hostdata::hostdata(m_host_t host)
+hostdata::hostdata(msg_host_t host)
     : name(MSG_host_get_name(host))
     , ctrl_mbox(std::string(name) + "_ctrl")
     , data_mbox(std::string(name) + "_data")