Bug fix: only send to a lesser loaded neighbor!

[loba.git] / loba_fairstrategy.cpp

diff --git a/loba_fairstrategy.cpp b/loba_fairstrategy.cpp
index 81de9e100a7e0941fbe0974e35d9c56e949cb7f3..9942fac1b1847616a9518788df811ceb2d38cb0e 100644 (file)
--- a/loba_fairstrategy.cpp
+++ b/loba_fairstrategy.cpp
@@ -1,61 +1,46 @@
-#include "loba_fairstrategy.h"

 #include <algorithm>
 #include <xbt/log.h>
 
 XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(loba);
 
 #include <algorithm>
 #include <xbt/log.h>
 
 XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(loba);
 

+#include "loba_fairstrategy.h"
+

 /* simple version:
  *   load balance with a least-loaded neighbor,
  *   without breaking the ping-pong condition
  */
 
 class compare {
 /* simple version:
  *   load balance with a least-loaded neighbor,
  *   without breaking the ping-pong condition
  */
 
 class compare {

-public : 
-       bool operator()(const neighbor*a, const neighbor*b)     {
-               return a->get_load()>b->get_load();
-       }
+public:
+    bool operator()(const neighbor*a, const neighbor*b) {
+        return a->get_load() > b->get_load();
+    }

 };
 
 double loba_fairstrategy::load_balance(double my_load)
 {
 };
 
 double loba_fairstrategy::load_balance(double my_load)
 {

-    int imin = -1;
-    int imax = -1;
-    double min = my_load;
-    double max = -1.0;
-
-               std::sort(pneigh.begin(),pneigh.end(),compare());
-
-               //print_loads();
-
-               INFO0("list voisins");
-               for(unsigned i=0;i< pneigh.size() ; ++i) {
-                       INFO2("%s %f ", pneigh[i]->get_name(), pneigh[i]->get_load());
-               }
-
-               double sum_sent=0;
-               bool found=true;
-
-               while(found) {
-                       found=false;
-                       for (unsigned i = 0 ; i < pneigh.size() ; ++i) {
-        double l = pneigh[i]->get_load();
-        if (l >= my_load)
-                                       continue;
-                               if(l<my_load+2) {
-                                       found=true;
-                                       pneigh[i]->set_load(l+1);
-                                       pneigh[i]->add_to_send(1);
-                                       INFO1("sent to %s",pneigh[i]->get_name());
-                                       my_load--;
-                                       sum_sent++;
-                               }
-                       }
-               }
-
-
-               
-               return sum_sent;
-    
+    std::sort(pneigh.begin(), pneigh.end(), compare());
+
+    print_loads_p();
+
+    double sum_sent = 0;
+    bool found = true;
+
+    while (found) {
+        found = false;
+        for (unsigned i = 0 ; i < pneigh.size() ; ++i) {
+            if (pneigh[i]->get_load() <= my_load - 2) {
+                found = true;
+                pneigh[i]->add_load(1);
+                pneigh[i]->add_to_send(1);
+                INFO1("sent to %s", pneigh[i]->get_name());
+                my_load--;
+                sum_sent++;
+            }
+        }
+    }
+
+    return sum_sent;

 }
 
 // Local variables:
 }
 
 // Local variables: