Cleanup, no functional change (no bug fixed too).

[loba.git] / process.cpp

diff --git a/process.cpp b/process.cpp
index e9e234864dfbe733623aeb3ad9edb128a8658e52..a24d6ebcbfb5eae01f098611a3373a00f06a872f 100644 (file)
--- a/process.cpp
+++ b/process.cpp
@@ -1,29 +1,55 @@
 #include <algorithm>
 #include <tr1/functional>
 #include <iterator>
 #include <algorithm>
 #include <tr1/functional>
 #include <iterator>

+#include <numeric>

 #include <stdexcept>
 #include <sstream>
 #include <xbt/log.h>
 #include <xbt/time.h>
 #include <stdexcept>
 #include <sstream>
 #include <xbt/log.h>
 #include <xbt/time.h>

+
+XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(proc);
+

 #include "misc.h"
 #include "options.h"
 #include "misc.h"
 #include "options.h"

+

 #include "process.h"
 
 #include "process.h"
 

-XBT_LOG_EXTERNAL_DEFAULT_CATEGORY(simu);
+double process::total_load_init = 0.0;
+double process::total_load_exit = 0.0;

 
 process::process(int argc, char* argv[])
 {
     if (argc < 2 || !(std::istringstream(argv[1]) >> load))
 
 process::process(int argc, char* argv[])
 {
     if (argc < 2 || !(std::istringstream(argv[1]) >> load))

-        throw std::invalid_argument("bad or missing initial load");
+        throw std::invalid_argument("bad or missing initial load parameter");

 
     neigh.assign(argv + 2, argv + argc);
 
     neigh.assign(argv + 2, argv + argc);

+
+    pneigh.reserve(neigh.size());
+    for (unsigned i = 0 ; i < neigh.size() ; i++) {
+        neighbor* ptr = &neigh[i];
+        m_host_t host = MSG_get_host_by_name(ptr->get_name());
+        pneigh.push_back(ptr);
+        rev_neigh.insert(std::make_pair(host, ptr));
+    }
+
+    prev_load_broadcast = -1;   // force sending of load on first send()

     expected_load = load;
     expected_load = load;

+    total_load_init += load;
+

     ctrl_close_pending = data_close_pending = neigh.size();
     ctrl_close_pending = data_close_pending = neigh.size();

+    if (neigh.size() == 1) {
+        comm.next_close_on_ctrl_is_last();
+        comm.next_close_on_data_is_last();
+    }
+    close_received = false;
+    may_receive =  (neigh.size() > 0); // the same as (ctrl_close_pending ||
+                                       //              data_close_pending)
+    if (may_receive)
+        comm.listen();

 
     e_xbt_log_priority_t logp = xbt_log_priority_verbose;
     if (!LOG_ISENABLED(logp))
         return;
 
     e_xbt_log_priority_t logp = xbt_log_priority_verbose;
     if (!LOG_ISENABLED(logp))
         return;

-    LOG1(logp, "My initial load is: %g", load);

     std::ostringstream oss;
     oss << neigh.size() << " neighbor";
     if (!neigh.empty()) {
     std::ostringstream oss;
     oss << neigh.size() << " neighbor";
     if (!neigh.empty()) {


@@ -34,41 +60,67 @@ process::process(int argc, char* argv[])
         oss << neigh.back().get_name();
     }
     LOG1(logp, "Got %s.", oss.str().c_str());
         oss << neigh.back().get_name();
     }
     LOG1(logp, "Got %s.", oss.str().c_str());

-    print_loads(logp);
+    print_loads(true, logp);
+}
+
+process::~process()
+{
+    total_load_exit += load;

 }
 
 int process::run()
 {
 }
 
 int process::run()
 {

-    INFO0("Coucou !");
+    INFO1("Initial load: %g", load);
+    VERB0("Starting...");
+    iter = 0;
+    bool one_more = true;
+    do {
+        ++iter;
+
+        if (opt::log_rate && iter % opt::log_rate == 0) {
+            if (opt::bookkeeping)
+                INFO3("(%u) current load: %g ; expected: %g",
+                      iter, load, expected_load);
+            else
+                INFO2("(%u) current load: %g",
+                      iter, load);
+        }
+        print_loads(true, xbt_log_priority_debug);

 
 

-    int n = 100;
-    while (n--) {

         if (opt::bookkeeping)
         if (opt::bookkeeping)

-            INFO2("current load: %g ; expected: %g", load, expected_load);
+            expected_load -= load_balance(expected_load);

         else
         else

-            INFO1("current load: %g", load);
+            load -= load_balance(load);

 
 

-        if (load > 0)
-            compute();
-        else
-            xbt_sleep(100);        // fixme
-        if (!receive(false))
-            n = 0;
-    }
-    DEBUG0("going to finalize.");
-    finalize();
+        send();
+        compute();

 
 

-    //    MSG_process_sleep(100.0);   // xxx
-    /* xxx:
-     * while (there is something to do) {
-     *    compute some task;
-     *    get received tasks;
-     *    compute load balancing;
-     *    send tasks to neighbors;
-     * }
-     * finalize;
-     * wait for pending messages;
-     */
+// NDS for Need To Send
+#define NDS ((opt::bookkeeping ? expected_load : load) != prev_load_broadcast)
+        do {
+            // General idea: block on receiving unless there is
+            // something to compute, or to send, or we must exit.
+
+            // fixme: review this chunk, and remove this NDS macro!
+
+            // FIXME: HAD A DEADLOCK HERE...
+
+            bool recv_wait = (load == 0 && !NDS);
+            DEBUG1("CALL RECEIVE(%s)", recv_wait? "WAIT": "NO_WAIT");
+            receive(recv_wait? WAIT: NO_WAIT);
+
+            if (opt::exit_on_close && close_received)
+                one_more = false;
+            else if (opt::maxiter && iter >= opt::maxiter)
+                one_more = false;
+            
+        } while (one_more && may_receive && load == 0 && !NDS);
+        DEBUG0("RECEIVE LOOP ENDED");
+#undef NDS
+
+    } while (one_more);
+    VERB0("Going to finalize...");
+    finalize();

 
     /* Open Questions :
      * - definition of load on heterogeneous hosts ?
 
     /* Open Questions :
      * - definition of load on heterogeneous hosts ?


@@ -76,92 +128,186 @@ int process::run()
      * - how to manage link failures ?
      */
 
      * - how to manage link failures ?
      */
 

-    DEBUG0("done.");
+    VERB0("Done.");
+    INFO3("Final load after %d iteration%s: %g", iter, ESSE(iter), load);
+    if (opt::bookkeeping)
+        INFO1("Expected load: %g", expected_load);

     return 0;
 }
 
     return 0;
 }
 

+double process::sum_of_to_send() const
+{
+    using namespace std::tr1;
+    using namespace std::tr1::placeholders;
+
+    return std::accumulate(neigh.begin(), neigh.end(), 0.0,
+                           bind(std::plus<double>(),
+                                _1, bind(&neighbor::get_to_send, _2)));
+}
+
+double process::load_balance(double /*my_load*/)
+{
+    if (iter == 1)
+        WARN0("process::load_balance is a no-op!");
+    return 0.0;
+}
+

 void process::compute()
 {
 void process::compute()
 {

-    double duration = opt::comp_cost(load);
-    m_task_t task = MSG_task_create("computation", duration, 0.0, NULL);
-    DEBUG2("compute %g flop%s.", duration, ESSE(duration));
-    MSG_task_execute(task);
-    MSG_task_destroy(task);
+    if (load > 0.0) {
+        double duration = opt::comp_cost(load);
+        m_task_t task = MSG_task_create("computation", duration, 0.0, NULL);
+        DEBUG2("compute %g flop%s.", duration, ESSE(duration));
+        MSG_task_execute(task);
+        MSG_task_destroy(task);
+    } else {
+        DEBUG0("nothing to compute !");
+    }

 }
 
 }
 

-bool process::receive(bool wait_for_close)
+void process::send1_no_bookkeeping(neighbor& nb)

 {
 {

-    bool result = true;
+    if (load != prev_load_broadcast)
+        comm.send(nb.get_ctrl_mbox(), new message(message::INFO, load));
+    double load_to_send = nb.get_to_send();
+    if (load_to_send > 0.0) {
+        comm.send(nb.get_data_mbox(), new message(message::LOAD, load_to_send));
+        nb.set_to_send(0.0);
+    }
+}
+
+void process::send1_bookkeeping(neighbor& nb)
+{
+    if (expected_load != prev_load_broadcast)
+        comm.send(nb.get_ctrl_mbox(),
+                  new message(message::INFO, expected_load));
+    double load_to_send;
+    double new_debt;
+    double debt_to_send = nb.get_to_send();
+    if (debt_to_send > 0.0) {
+        comm.send(nb.get_ctrl_mbox(),
+                  new message(message::CREDIT, debt_to_send));
+        nb.set_to_send(0.0);
+        new_debt = nb.get_debt() + debt_to_send;
+    } else {
+        new_debt = nb.get_debt();
+    }
+    if (load <= new_debt) {
+        load_to_send = load;
+        nb.set_debt(new_debt - load_to_send);
+        load = 0.0;
+    } else {
+        load_to_send = new_debt;
+        nb.set_debt(0.0);
+        load -= load_to_send;
+    }
+    if (load_to_send > 0.0)
+        comm.send(nb.get_data_mbox(), new message(message::LOAD, load_to_send));
+}
+
+void process::send()
+{
+    using namespace std::tr1;
+    using namespace std::tr1::placeholders;
+
+    if (opt::bookkeeping) {
+        std::for_each(neigh.begin(), neigh.end(),
+                      bind(&process::send1_bookkeeping, this, _1));
+        prev_load_broadcast = expected_load;
+    } else {
+        std::for_each(neigh.begin(), neigh.end(),
+                      bind(&process::send1_no_bookkeeping, this, _1));
+        prev_load_broadcast = load;
+    }
+}
+
+void process::receive(recv_wait_mode wait)
+{
+    // DEBUG1("go for receive(%s)",
+    //        "NO_WAIT\0WAIT\0\0\0\0WAIT_FOR_CLOSE" + 8 * wait);

     message* msg;
     m_host_t from;
     message* msg;
     m_host_t from;

-    while ((ctrl_close_pending ||
-            data_close_pending) && comm.recv(msg, from, wait_for_close)) {
+    bool do_loop = may_receive;
+    while (do_loop && comm.recv(msg, from, wait)) {

         switch (msg->get_type()) {
         switch (msg->get_type()) {

-        case message::INFO:
-            DEBUG0("received INFO");
-            // fixme: update neighbor
-            // need a map m_host_t -> neighbor&
+        case message::INFO: {
+            neighbor* n = rev_neigh[from];
+            n->set_load(msg->get_amount());

             break;
             break;

+        }

         case message::CREDIT:
         case message::CREDIT:

-            DEBUG0("received CREDIT");

             expected_load += msg->get_amount();
             break;
         case message::LOAD:
             expected_load += msg->get_amount();
             break;
         case message::LOAD:

-            DEBUG0("received LOAD");

             load += msg->get_amount();
             break;
         case message::CTRL_CLOSE:
             load += msg->get_amount();
             break;
         case message::CTRL_CLOSE:

-            DEBUG0("received CTRL_CLOSE");

             if (--ctrl_close_pending == 1)
                 comm.next_close_on_ctrl_is_last();
             if (--ctrl_close_pending == 1)
                 comm.next_close_on_ctrl_is_last();

-            result = false;
+            // DEBUG1("ctrl_close_pending = %d", ctrl_close_pending);
+            close_received = true;

             break;
         case message::DATA_CLOSE:
             break;
         case message::DATA_CLOSE:

-            DEBUG0("received DATA_CLOSE");

             if (--data_close_pending == 1)
                 comm.next_close_on_data_is_last();
             if (--data_close_pending == 1)
                 comm.next_close_on_data_is_last();

-            result = false;
+            // DEBUG1("data_close_pending = %d", data_close_pending);
+            close_received = true;

             break;
         }
         delete msg;
             break;
         }
         delete msg;

+        may_receive = (ctrl_close_pending || data_close_pending);
+        do_loop = (wait == WAIT_FOR_CLOSE) && may_receive;

     }
     }

-    return result;
+}
+
+void process::finalize1(neighbor& nb)
+{
+    comm.send(nb.get_ctrl_mbox(), new message(message::CTRL_CLOSE, 0.0));
+    comm.send(nb.get_data_mbox(), new message(message::DATA_CLOSE, 0.0));    

 }
 
 void process::finalize()
 {
 }
 
 void process::finalize()
 {

+    using namespace std::tr1;
+    using namespace std::tr1::placeholders;
+

     DEBUG2("send CLOSE to %d neighbor%s.",
            (int )neigh.size(), ESSE(neigh.size()));
     DEBUG2("send CLOSE to %d neighbor%s.",
            (int )neigh.size(), ESSE(neigh.size()));

-    std::vector<neighbor>::iterator n;
-    for (n = neigh.begin() ; n != neigh.end() ; ++n) {
-        comm.send(n->get_ctrl_mbox(), new message(message::CTRL_CLOSE, 0.0));
-        comm.send(n->get_data_mbox(), new message(message::DATA_CLOSE, 0.0));
-    }
+    std::for_each(neigh.begin(), neigh.end(),
+                  bind(&process::finalize1, this, _1));

 
     DEBUG2("wait for CLOSE from %d neighbor%s.",
            (int )neigh.size(), ESSE(neigh.size()));
 
     DEBUG2("wait for CLOSE from %d neighbor%s.",
            (int )neigh.size(), ESSE(neigh.size()));

-    receive(true);
+    receive(WAIT_FOR_CLOSE);

 
 

-    comm.wait_for_sent();
+    comm.flush(true);

 }
 
 }
 

-void process::print_loads(e_xbt_log_priority_t logp)
+#define print_loads_generic(vec, verbose, logp, cat)                    \
+    if (_XBT_LOG_ISENABLEDV((*cat), logp)) {                            \
+        using namespace std::tr1;                                       \
+        using namespace std::tr1::placeholders;                         \
+        XCLOG0(cat, logp, "Neighbor loads:");                           \
+        std::for_each(vec.begin(), vec.end(),                           \
+                      bind(&neighbor::print, _1, verbose, logp, cat));  \
+    } else ((void)0)
+
+void process::print_loads(bool verbose,
+                          e_xbt_log_priority_t logp,
+                          xbt_log_category_t cat) const

 {
 {

-    if (!LOG_ISENABLED(logp))
-        return;
+    print_loads_generic(neigh, verbose, logp, cat);
+}

 
 

-    std::ostringstream oss;
-    if (neigh.empty()) {
-        oss << "no neighbor!";
-    } else {
-        std::transform(neigh.begin(), neigh.end() - 1,
-                       std::ostream_iterator<double>(oss, ", "),
-                       std::tr1::mem_fn(&neighbor::get_load));
-        oss << neigh.back().get_load();
-    }
-    LOG1(logp, "Neighbor loads: %s", oss.str().c_str());
+void process::print_loads_p(bool verbose,
+                            e_xbt_log_priority_t logp,
+                            xbt_log_category_t cat) const
+{
+    print_loads_generic(pneigh, verbose, logp, cat);

 }
 
 }
 

+#undef print_loads_generic
+

 // Local variables:
 // mode: c++
 // End:
 // Local variables:
 // mode: c++
 // End: