X-Git-Url: https://bilbo.iut-bm.univ-fcomte.fr/and/gitweb/loba.git/blobdiff_plain/8da825f95900484f657c27e30eafe4aacbba3af5..9f21b5351f943feb1099f387d385c95bdacf6e62:/options.cpp?ds=inline diff --git a/options.cpp b/options.cpp index f3e2be3..9ea0a72 100644 --- a/options.cpp +++ b/options.cpp @@ -47,13 +47,14 @@ namespace opt { // Load balancing algorithm std::string loba_algo("simple"); bool bookkeeping = false; + double min_lb_iter_duration = 1.0; // fixme: find better defaults // Application parameters - // fixme: find better defaults - cost_func comp_cost("1e9, 0"); - cost_func comm_cost("1e6, 0"); - double min_lb_iter_duration = 1.0; - double min_comp_iter_duration = 1.0; + cost_func comp_cost("1e9, 0"); // fixme: find better defaults + cost_func comm_cost("1e6, 0"); // fixme: find better defaults + double min_comp_iter_duration = 1.0; // fixme: find better defaults + unsigned comp_iter_delay = 0; // fixme: find better defaults + double comp_time_delay = 0.0; // fixme: find better defaults // Parameters for the end of the simulation unsigned lb_maxiter = 0; @@ -93,6 +94,8 @@ namespace { // local helper class class opt_helper { public: + template + static bool parse_arg(char opt, const char *arg, T& val); static const char* on_off(bool b); const char* descr(const char* str); template @@ -109,6 +112,16 @@ namespace { } // namespace +template +bool opt_helper::parse_arg(char opt, const char *arg, T& val) +{ + std::istringstream str(arg); + bool result = (str >> val) && str.eof(); + if (!result) + XBT_ERROR("invalid argument for option '-%c' -- \"%s\"", opt, arg); + return result; +} + const char* opt_helper::on_off(bool b) { return b ? "on" : "off"; @@ -178,10 +191,13 @@ bool opt::parse_args(int* argc, char* argv[]) opt::program_name = argv[0]; opt::program_name.erase(0, 1 + opt::program_name.find_last_of('/')); + +#define PARSE_ARG(x) result = opt_helper::parse_arg(c, optarg, (x)) && result int c; opterr = 0; - while ((c = getopt(*argc, argv, "a:bc:C:ehi:I:l:L:N:s:S:t:T:vV")) != -1) { + while ((c = getopt(*argc, argv, + "a:bc:C:d:D:ehi:I:l:L:N:s:S:t:T:vV")) != -1) { switch (c) { case 'a': opt::loba_algo = optarg; @@ -200,34 +216,50 @@ bool opt::parse_args(int* argc, char* argv[]) opt::help_requested++; break; case 'c': - opt::comp_cost = cost_func(optarg); + try { + opt::comp_cost = cost_func(optarg); + } catch (...) { + XBT_ERROR("invalid argument for option '-%c' -- \"%s\"", c, optarg); + result = false; + } break; case 'C': - opt::comm_cost = cost_func(optarg); + try { + opt::comm_cost = cost_func(optarg); + } catch (...) { + XBT_ERROR("invalid argument for option '-%c' -- \"%s\"", c, optarg); + result = false; + } + break; + case 'd': + PARSE_ARG(opt::comp_iter_delay); + break; + case 'D': + PARSE_ARG(opt::comp_time_delay); break; case 'i': - std::istringstream(optarg) >> opt::lb_maxiter; + PARSE_ARG(opt::lb_maxiter); break; case 'I': - std::istringstream(optarg) >> opt::comp_maxiter; + PARSE_ARG(opt::comp_maxiter); break; case 'l': - std::istringstream(optarg) >> opt::log_rate; + PARSE_ARG(opt::log_rate); break; case 'L': - std::istringstream(optarg) >> opt::auto_depl::load; + PARSE_ARG(opt::auto_depl::load); break; case 'N': - std::istringstream(optarg) >> opt::auto_depl::nhosts; + PARSE_ARG(opt::auto_depl::nhosts); break; case 's': - std::istringstream(optarg) >> opt::min_lb_iter_duration; + PARSE_ARG(opt::min_lb_iter_duration); break; case 'S': - std::istringstream(optarg) >> opt::min_comp_iter_duration; + PARSE_ARG(opt::min_comp_iter_duration); break; case 't': - std::istringstream(optarg) >> opt::time_limit; + PARSE_ARG(opt::time_limit); break; case 'T': opt::auto_depl::topology = optarg; @@ -249,6 +281,8 @@ bool opt::parse_args(int* argc, char* argv[]) } } +#undef PARSE_ARG + if (opt::version_requested || opt::help_requested) return 1; @@ -293,12 +327,12 @@ void opt::print() } DESCR("load balancing algorithm", "%s", loba_algo.c_str()); DESCR("bookkeeping", "%s", h.on_off(bookkeeping)); + DESCR("minimum duration between lb. iterations", "%g", min_lb_iter_duration); DESCR("computation cost factors", "[%s]", comp_cost.to_string().c_str()); DESCR("communication cost factors", "[%s]", comm_cost.to_string().c_str()); - DESCR("minimum duration between lb. iterations", "%g", - min_lb_iter_duration); - DESCR("minimum duration between comp. iterations", "%g", - min_comp_iter_duration); + DESCR("minimum duration between comp. iterations", "%g", min_comp_iter_duration); + DESCR("computations start after lb. iter", "%u", comp_iter_delay); + DESCR("computations start after time", "%g", comp_time_delay); DESCR("maximum number of lb. iterations", "%s", h.val_or_string(lb_maxiter, "infinity")); DESCR("maximum number of comp. iterations", "%s", @@ -365,6 +399,9 @@ void opt::usage() so_list(opt::loba_algorithms); std::clog << o("-b") << "toggle bookkeeping (\"virtual load\")" << " [" << opt_helper::on_off(opt::bookkeeping) << "]\n"; + std::clog << o("-s value") + << "minimum duration between lb. iterations" + << " [" << opt::min_lb_iter_duration << "]\n"; std::clog << "\nApplication parameters\n"; std::clog << o("-c [aN,...]a0") @@ -373,12 +410,15 @@ void opt::usage() std::clog << o("-C [aN,...]a0") << "polynomial factors for communication cost" << " [" << opt::comm_cost.to_string() << "]\n"; - std::clog << o("-s value") - << "minimum duration between lb. iterations" - << " [" << opt::min_lb_iter_duration << "]\n"; std::clog << o("-S value") << "minimum duration between comp. iterations" << " [" << opt::min_comp_iter_duration << "]\n"; + std::clog << o("-d value") + << "start computations after given number of lb iterations" + << " [" << opt::comp_iter_delay << "]\n"; + std::clog << o("-D value") + << "start computations after given time" + << " [" << opt::comp_time_delay << "]\n"; std::clog << "\nParameters for the end of the simulation\n"; std::clog << o("-i value")